diff mbox series

[2/3] lib/test_vmalloc.c: drop empty exit function

Message ID 20240226191159.39509-3-martin@kaiser.cx
State New
Headers
Series lib/test_vmalloc.c: three trivial fixes |

Commit Message

Martin Kaiser Feb. 26, 2024, 7:11 p.m. UTC 
  The module is never loaded successfully. Therefore, it'll never be
unloaded and we can remove the exit function.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
 lib/test_vmalloc.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Uladzislau Rezki Feb. 27, 2024, 6:59 a.m. UTC | #1 
On Mon, Feb 26, 2024 at 08:11:58PM +0100, Martin Kaiser wrote:
> The module is never loaded successfully. Therefore, it'll never be
> unloaded and we can remove the exit function.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  lib/test_vmalloc.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
> index 191b6bd5dff9..d0c0cbe1913d 100644
> --- a/lib/test_vmalloc.c
> +++ b/lib/test_vmalloc.c
> @@ -600,12 +600,7 @@ static int vmalloc_test_init(void)
>  	return -EAGAIN; /* Fail will directly unload the module */
>  }
>  
> -static void vmalloc_test_exit(void)
> -{
> -}
> -
>  module_init(vmalloc_test_init)
> -module_exit(vmalloc_test_exit)
>  
>  MODULE_LICENSE("GPL");
>  MODULE_AUTHOR("Uladzislau Rezki");
> -- 
> 2.39.2
> 
Reviewed-by: Uladzislau Rezki (Sony) <urezki@gmail.com>

--
Uladzislau Rezki
diff mbox series

Patch

diff --git a/lib/test_vmalloc.c b/lib/test_vmalloc.c
index 191b6bd5dff9..d0c0cbe1913d 100644
--- a/lib/test_vmalloc.c
+++ b/lib/test_vmalloc.c
@@ -600,12 +600,7 @@  static int vmalloc_test_init(void)
 	return -EAGAIN; /* Fail will directly unload the module */
 }
 
-static void vmalloc_test_exit(void)
-{
-}
-
 module_init(vmalloc_test_init)
-module_exit(vmalloc_test_exit)
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Uladzislau Rezki");