Message ID | 20240112035039.833974-1-maobibo@loongson.cn |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-24276-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:2411:b0:101:2151:f287 with SMTP id m17csp1887722dyi; Thu, 11 Jan 2024 19:51:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IERKxUtIu99UItsfNB9CkUkbkKuTLPQM+NcUHJp3rRhsq3mjalbqJ5EtgsBVl3vBuqGtBQy X-Received: by 2002:a05:6358:f1c:b0:175:643d:75ef with SMTP id b28-20020a0563580f1c00b00175643d75efmr769737rwj.4.1705031480443; Thu, 11 Jan 2024 19:51:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1705031480; cv=none; d=google.com; s=arc-20160816; b=foiTxyIBW9JZWSdLzcn1iccs1HJbzacHvJmgAjAWAunJod1ABSMxxYCVRUMizNkrVz WgZSKSN0nOXti1EvxvwWZjasbcSoVy909PJPQK2E8+Yh8qhGUDOV2vUzNVxhTtED54cE pK4kGs6n2bu1rc5oz8k1JJ7X0lECy60jWIW29YaeUQJ9Ak96z6fF3aLSprzJ5YuA8tbR wW2PQ1L8YvNZaz3PovWLqsOlva4KGCwQLNao8L5ykGyl0v69sYJOQp8ZGpJbPCkm1E4+ 3z9/sw5K06hHV2oDNKXkwnEqROzCO8AjnXMxJ+BpbFC5dcVEFgbbuT9En7MNB6Ly6550 5Ckg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from; bh=3EmbgR0cSCDEuQMTqRbPjfoGWySRoFqZgTs0CXtkLcg=; fh=x/Bt1aIM1r3EQAi+gC/DzSsKR75c0gIQCHo4YyJmMCE=; b=R/F2VSzik12SngoGVuo93VaC1ZF1OvdvZpRx+DwFNL/8kFgOosijWol5NLZeESCrr/ BGdMY3Bu9fjJ5CBWzD7Xfg83Dd8ibVdG5YJxHHJEyyuhjD0LhsdfBIyzBlhOFWHhADYR kVgLQdwyb2j9ZKfFvYwk7jzvhR/vfgSn07mLTtYLQ34MrCoiBkXBigmE7pfa8A1SxATh TCmaZrQIrpCoBgG7YeN4t3WoYux//GHCsr4CEhCUkhcpEa14HVGQGYPEr3/sZ9Dwteuh 3fzcAiXjjrgR0AWCvTJh3CV9CFj4pvlQACAIQlaCxq4pa16Wlk2nCvgXV0j/WgRfWlcx 8zxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-24276-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24276-ouuuleilei=gmail.com@vger.kernel.org" Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id o11-20020a17090a744b00b0028c5375ed45si5075359pjk.35.2024.01.11.19.51.20 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jan 2024 19:51:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-24276-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel+bounces-24276-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-24276-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 38A54283A82 for <ouuuleilei@gmail.com>; Fri, 12 Jan 2024 03:51:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3F81C1EB37; Fri, 12 Jan 2024 03:50:52 +0000 (UTC) Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D43EC43AB4; Fri, 12 Jan 2024 03:50:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=loongson.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=loongson.cn Received: from loongson.cn (unknown [10.2.5.213]) by gateway (Coremail) with SMTP id _____8AxCuoPt6BlOXEEAA--.9033S3; Fri, 12 Jan 2024 11:50:40 +0800 (CST) Received: from localhost.localdomain (unknown [10.2.5.213]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Axqt0Pt6BlAsMSAA--.49445S2; Fri, 12 Jan 2024 11:50:39 +0800 (CST) From: Bibo Mao <maobibo@loongson.cn> To: Tianrui Zhao <zhaotianrui@loongson.cn>, Huacai Chen <chenhuacai@kernel.org> Cc: kvm@vger.kernel.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] LoongArch: KVM: Remove unnecessary CSR register saving during enter guest Date: Fri, 12 Jan 2024 11:50:39 +0800 Message-Id: <20240112035039.833974-1-maobibo@loongson.cn> X-Mailer: git-send-email 2.39.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: AQAAf8Axqt0Pt6BlAsMSAA--.49445S2 X-CM-SenderInfo: xpdruxter6z05rqj20fqof0/ X-Coremail-Antispam: 1Uk129KBj9xXoWrKFyxGw1fuFy3Kr45Ww4ftFc_yoWfAFX_XF 1xtw4Durn3Janruw1Fvas5Xw1jga1kGwsY9F18uryxJa4FqrZ8Zr4Iya1DAr13KFWUZrWf ZrWxGrZ3ur1IyosvyTuYvTs0mTUanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjqI5I8CrVACY4xI64kE6c02F40Ex7xfYxn0WfASr-VFAUDa7-sFnT9fnUUI cSsGvfJTRUUUb7kYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20x vaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxS w2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxV WUJVW8JwA2z4x0Y4vEx4A2jsIE14v26F4j6r4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_ Gr1j6F4UJwAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc 02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUXVWUAwAv7VC2z280aVAF wI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcxkI7VAKI48JMxAIw28IcxkI7V AKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCj r7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI42IY6x IIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42IY6xAI w20EY4v20xvaj40_Jr0_JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x 0267AKxVWUJVW8JbIYCTnIWIevJa73UjIFyTuYvjxUwmhFDUUUU X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1787855089598890227 X-GMAIL-MSGID: 1787855089598890227 |
Series |
LoongArch: KVM: Remove unnecessary CSR register saving during enter guest
|
|
Commit Message
maobibo
Jan. 12, 2024, 3:50 a.m. UTC
Some CSR registers like CRMD/PRMD are saved during enter VM mode. However
they are not restored for actual use, saving for these CSR registers
can be removed.
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
---
arch/loongarch/kvm/switch.S | 6 ------
1 file changed, 6 deletions(-)
base-commit: de927f6c0b07d9e698416c5b287c521b07694cac
Comments
slightly ping :) On 2024/1/12 上午11:50, Bibo Mao wrote: > Some CSR registers like CRMD/PRMD are saved during enter VM mode. However > they are not restored for actual use, saving for these CSR registers > can be removed. > > Signed-off-by: Bibo Mao <maobibo@loongson.cn> > --- > arch/loongarch/kvm/switch.S | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/arch/loongarch/kvm/switch.S b/arch/loongarch/kvm/switch.S > index 0ed9040307b7..905b90de50e8 100644 > --- a/arch/loongarch/kvm/switch.S > +++ b/arch/loongarch/kvm/switch.S > @@ -213,12 +213,6 @@ SYM_FUNC_START(kvm_enter_guest) > /* Save host GPRs */ > kvm_save_host_gpr a2 > > - /* Save host CRMD, PRMD to stack */ > - csrrd a3, LOONGARCH_CSR_CRMD > - st.d a3, a2, PT_CRMD > - csrrd a3, LOONGARCH_CSR_PRMD > - st.d a3, a2, PT_PRMD > - > addi.d a2, a1, KVM_VCPU_ARCH > st.d sp, a2, KVM_ARCH_HSP > st.d tp, a2, KVM_ARCH_HTP > > base-commit: de927f6c0b07d9e698416c5b287c521b07694cac >
Reviewed-by: Tianrui Zhao <zhaotianrui@loongson.cn> 在 2024/1/31 上午11:48, maobibo 写道: > slightly ping :) > > On 2024/1/12 上午11:50, Bibo Mao wrote: >> Some CSR registers like CRMD/PRMD are saved during enter VM mode. However >> they are not restored for actual use, saving for these CSR registers >> can be removed. >> >> Signed-off-by: Bibo Mao <maobibo@loongson.cn> >> --- >> arch/loongarch/kvm/switch.S | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/arch/loongarch/kvm/switch.S b/arch/loongarch/kvm/switch.S >> index 0ed9040307b7..905b90de50e8 100644 >> --- a/arch/loongarch/kvm/switch.S >> +++ b/arch/loongarch/kvm/switch.S >> @@ -213,12 +213,6 @@ SYM_FUNC_START(kvm_enter_guest) >> /* Save host GPRs */ >> kvm_save_host_gpr a2 >> - /* Save host CRMD, PRMD to stack */ >> - csrrd a3, LOONGARCH_CSR_CRMD >> - st.d a3, a2, PT_CRMD >> - csrrd a3, LOONGARCH_CSR_PRMD >> - st.d a3, a2, PT_PRMD >> - >> addi.d a2, a1, KVM_VCPU_ARCH >> st.d sp, a2, KVM_ARCH_HSP >> st.d tp, a2, KVM_ARCH_HTP >> >> base-commit: de927f6c0b07d9e698416c5b287c521b07694cac >>
LGTM, queued for loongarch-kvm. Huacai On Thu, Feb 1, 2024 at 11:30 AM zhaotianrui <zhaotianrui@loongson.cn> wrote: > > Reviewed-by: Tianrui Zhao <zhaotianrui@loongson.cn> > > 在 2024/1/31 上午11:48, maobibo 写道: > > slightly ping :) > > > > On 2024/1/12 上午11:50, Bibo Mao wrote: > >> Some CSR registers like CRMD/PRMD are saved during enter VM mode. However > >> they are not restored for actual use, saving for these CSR registers > >> can be removed. > >> > >> Signed-off-by: Bibo Mao <maobibo@loongson.cn> > >> --- > >> arch/loongarch/kvm/switch.S | 6 ------ > >> 1 file changed, 6 deletions(-) > >> > >> diff --git a/arch/loongarch/kvm/switch.S b/arch/loongarch/kvm/switch.S > >> index 0ed9040307b7..905b90de50e8 100644 > >> --- a/arch/loongarch/kvm/switch.S > >> +++ b/arch/loongarch/kvm/switch.S > >> @@ -213,12 +213,6 @@ SYM_FUNC_START(kvm_enter_guest) > >> /* Save host GPRs */ > >> kvm_save_host_gpr a2 > >> - /* Save host CRMD, PRMD to stack */ > >> - csrrd a3, LOONGARCH_CSR_CRMD > >> - st.d a3, a2, PT_CRMD > >> - csrrd a3, LOONGARCH_CSR_PRMD > >> - st.d a3, a2, PT_PRMD > >> - > >> addi.d a2, a1, KVM_VCPU_ARCH > >> st.d sp, a2, KVM_ARCH_HSP > >> st.d tp, a2, KVM_ARCH_HTP > >> > >> base-commit: de927f6c0b07d9e698416c5b287c521b07694cac > >> > >
diff --git a/arch/loongarch/kvm/switch.S b/arch/loongarch/kvm/switch.S index 0ed9040307b7..905b90de50e8 100644 --- a/arch/loongarch/kvm/switch.S +++ b/arch/loongarch/kvm/switch.S @@ -213,12 +213,6 @@ SYM_FUNC_START(kvm_enter_guest) /* Save host GPRs */ kvm_save_host_gpr a2 - /* Save host CRMD, PRMD to stack */ - csrrd a3, LOONGARCH_CSR_CRMD - st.d a3, a2, PT_CRMD - csrrd a3, LOONGARCH_CSR_PRMD - st.d a3, a2, PT_PRMD - addi.d a2, a1, KVM_VCPU_ARCH st.d sp, a2, KVM_ARCH_HSP st.d tp, a2, KVM_ARCH_HTP