Message ID | 20240223091122.2430037-1-wenst@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-77982-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp467216dyb; Fri, 23 Feb 2024 01:12:10 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCU7eIiW/wIoM60vh3u/7vvo1r79XN5DXbfRaJ6e2UJ3Lp1xcRkTHRdf+4r9874WkitqFSKlxsczzhPVoVMOBYe5p82QtA== X-Google-Smtp-Source: AGHT+IGlrx2k87YRBBw6o2hsjHtlJE1Q3gLyywoFeURwmV4Kv9dKpJddvxU61NAcmvkQLRQWY+Z8 X-Received: by 2002:a05:622a:1450:b0:42b:eb89:87c4 with SMTP id v16-20020a05622a145000b0042beb8987c4mr1902528qtx.33.1708679529813; Fri, 23 Feb 2024 01:12:09 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708679529; cv=pass; d=google.com; s=arc-20160816; b=I9rHrzkkWN7FdxsxDB2ECfRWx/8XYI9qv6MsCYY1rVS7x5l4CAjQacnByynWlke+bE qz3PCCE1UTMmtbGCfZJUkvAzFtnZFM4cotDBKPuJd0Cf1dyL2LaTtnp9FAB8vU2viCZW +kCvXI+zWEFOonflGf46Htpnbpe6ydXM05oR4dgMYCJbZSHWxB15U1sFiAUXihUZMEbT HAoyZYDhRsmAFSul7yah2HMngBm2AVcqpTa+VDXgx/ZAn0kHklGi/C29pDPD33G2GSsc VOv4S8/7/pI/6F14gdrCUMnyJ6CG5+vOS9ikeluIYlfgcj8bUfMXsmOV0g5FGKdBYEhx vg0g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=DXXgc5ooBuiJ0rd83JBNXgx7wSQOERYhBcUIH8zsNHg=; fh=f+b3jzez9XOp/+079jbRktvCKRkwXgp0jc40Kmg9LY0=; b=KbpF0WMG1zw++UA4EXUyUUdQL0fPfp2+37aJWg5Nc0mskNu39O0cKcpMm/3mXcBtm5 QYZ/W36DlQXXYasKzaIbeM1MrESaivDphTywYRaxLQqAjXUvwDndkocmxkHngeP7MMDD AWPVE1to6eKn5JAlZTAV2gt3Z8QitERadn85xDZdkjj1DXguoLh5TXm3AMQKeDvkQR5f lGOir4/08U5kCHU2iFDoDG+41P8Aq3GV/yFhOFc31VXmyNY6/ghsegSn48vse8vzZ5Aj mfIglh9XNmAW9iT36lGsi8SSMsiYHXqJAsy5ciakmQ4bZJ2yAeuu2Y9g0RZrI6fEHgIn ELgA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ahvgVy80; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77982-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77982-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id z25-20020ac84559000000b0042e5e285433si1236456qtn.585.2024.02.23.01.12.09 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 01:12:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77982-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=ahvgVy80; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77982-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77982-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 180711C216F3 for <ouuuleilei@gmail.com>; Fri, 23 Feb 2024 09:12:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id ABFC12941C; Fri, 23 Feb 2024 09:11:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="ahvgVy80" Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FC121B95F for <linux-kernel@vger.kernel.org>; Fri, 23 Feb 2024 09:11:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708679490; cv=none; b=U9wdoL8zOYrnSCJ/ikLWPObI+PJUt27opaAgjLMrlwtNM6hqaCEu2jPBL5T85UTUgCrtInoGF41ZDifIkSoyh9g6m7pcS5JnRt2cCfU7DR0Zy6CNtbSfwrax1B0qvjJkUZ1WZYKgIRsXrBoOcjiNfMSSo0R9ERxh9lLMucfW3wI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708679490; c=relaxed/simple; bh=IpkfMNeyeLubIoGLauI2jl0iOwiP1kjt0u3vJSlNrZ0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A4UvJUOFrNKRQLUG7Hd2DHWVE3OuUrR4aHtSJPp4xUYzxqJc9xzX8FSJdfRRWp9/M8+X5wXilUX5t1vpCPD7H5U4jATer7YwvX1HP9Hppyox2uQLs5Rk6DYHgVPbpzDsUfdFhQlpoPqP3f8P83YrNi5CoZm8zc1ZjbHR5yW0J6Y= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=ahvgVy80; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-5d81b08d6f2so567657a12.0 for <linux-kernel@vger.kernel.org>; Fri, 23 Feb 2024 01:11:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708679486; x=1709284286; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DXXgc5ooBuiJ0rd83JBNXgx7wSQOERYhBcUIH8zsNHg=; b=ahvgVy80FzqZM2b1pxq+iPu1krgJidruwPGDCV00aAOXT2SSm4fWttjq9Q8ixCX4NQ jZqBKZPwVmQIXKrcodzEanZCLHjftFUyBsUPaMQZVIJ/w3wYvwyOZLECzsEHNccW4+wk MD7Xu2ggsfJZK3w8VwR3Cyh4mq8yP+N3mxMCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708679486; x=1709284286; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DXXgc5ooBuiJ0rd83JBNXgx7wSQOERYhBcUIH8zsNHg=; b=pwSyEm+al2EXi60A/cX/kibnk3ECm0ZZFiXHfjluoJACqN2fHUEWFJVuzX56VPwJfM 41m+4Xh3EAVLuYmibzWBF8ZCr9jjFwTpv07uJklLuoSWva0wz0ZqrMHF5+vpujICtVUx aE3o5oxpG2KL8u0DvdvbYoRRpS7RWRIhfmIpWjzsTtDwR0YypF6LlfnkRNsW/CwV/9pK R6exxXv3WMH0hGy+W1lujj8rbgQH1q4w2h7pHMDglIYsfh6p+RMG7UQOnarRBFrvHfKN J8E9xIyvtUjosV2lO/w23DEByXKx/8HNhmLiDsorln1JUJSP4tc4hpOha4aT1SoQnazL iuFA== X-Forwarded-Encrypted: i=1; AJvYcCWX8oL67qfhIm88fBD/xo2kihOe5Pg37gacjp9qog1+moF7Dv0uY/fOm5xx9CYJV2HIK7FwlPORHVXjLf7xjKl73D6AHMGojzcDpfAn X-Gm-Message-State: AOJu0YzaO1khDS7vSqiJ1ExQ/vJwngMcWguiCbLv6sWq8qB4QUUUngbK h6hK1p6Pd0WhLeNWfpto8XGzIR5uGmEoC0iFXcUzPxOcIQaJ87qiEeRkyoix+A== X-Received: by 2002:a05:6a20:244e:b0:19b:673d:824d with SMTP id t14-20020a056a20244e00b0019b673d824dmr1490319pzc.46.1708679486692; Fri, 23 Feb 2024 01:11:26 -0800 (PST) Received: from wenstp920.tpe.corp.google.com ([2401:fa00:1:10:e0c9:81eb:a87f:e8e7]) by smtp.gmail.com with ESMTPSA id y15-20020a170902b48f00b001dc05535632sm7800365plr.170.2024.02.23.01.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 01:11:26 -0800 (PST) From: Chen-Yu Tsai <wenst@chromium.org> To: Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Cc: Ikjoon Jang <ikjn@chromium.org>, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Weiyi Lu <weiyi.lu@mediatek.com>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Chen-Yu Tsai <wenst@chromium.org> Subject: [PATCH] arm64: dts: mediatek: mt8183: Add power-domains properity to mfgcfg Date: Fri, 23 Feb 2024 17:11:21 +0800 Message-ID: <20240223091122.2430037-1-wenst@chromium.org> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791680346670167672 X-GMAIL-MSGID: 1791680346670167672 |
Series |
arm64: dts: mediatek: mt8183: Add power-domains properity to mfgcfg
|
|
Commit Message
Chen-Yu Tsai
Feb. 23, 2024, 9:11 a.m. UTC
From: Ikjoon Jang <ikjn@chromium.org> mfgcfg clock is under MFG_ASYNC power domain. Fixes: e526c9bc11f8 ("arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile") Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller") Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> Signed-off-by: Ikjoon Jang <ikjn@chromium.org> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- This patch is long overdue. Could we merge it for fixes for this or the next release? Changes since v2: - Rebased onto current tree - Added Fixes tags - Fix up subject prefix arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + 1 file changed, 1 insertion(+)
Comments
Il 23/02/24 10:11, Chen-Yu Tsai ha scritto: > From: Ikjoon Jang <ikjn@chromium.org> > > mfgcfg clock is under MFG_ASYNC power domain. > > Fixes: e526c9bc11f8 ("arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile") > Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller") > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> > Signed-off-by: Ikjoon Jang <ikjn@chromium.org> > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > This patch is long overdue. Could we merge it for fixes for this or the > next release? > A clock controller that needs a power domain? Can you please describe the issue that you're trying to solve with this? It's not very uncommon but I'm not entirely convinced that this is right, because the MFG_BG3D is a gate - and it's *not* outputting a clock rate on its own: the mfgcfg is entirely GPU related and if there is no GPU support this clock is not even ever needed. MediaTek, can you please clarify if (and why) this gate clock needs a MTCMOS to be ungated? Thanks, Angelo > Changes since v2: > - Rebased onto current tree > - Added Fixes tags > - Fix up subject prefix > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 93dfbf130231..774ae5d9143f 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -1637,6 +1637,7 @@ mfgcfg: syscon@13000000 { > compatible = "mediatek,mt8183-mfgcfg", "syscon"; > reg = <0 0x13000000 0 0x1000>; > #clock-cells = <1>; > + power-domains = <&spm MT8183_POWER_DOMAIN_MFG_ASYNC>; > }; > > gpu: gpu@13040000 {
On Mon, Feb 26, 2024 at 4:54 PM AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 23/02/24 10:11, Chen-Yu Tsai ha scritto: > > From: Ikjoon Jang <ikjn@chromium.org> > > > > mfgcfg clock is under MFG_ASYNC power domain. > > > > Fixes: e526c9bc11f8 ("arm64: dts: Add Mediatek SoC MT8183 and evaluation board dts and Makefile") > > Fixes: 37fb78b9aeb7 ("arm64: dts: mediatek: Add mt8183 power domains controller") > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> > > Signed-off-by: Ikjoon Jang <ikjn@chromium.org> > > Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > This patch is long overdue. Could we merge it for fixes for this or the > > next release? > > > > A clock controller that needs a power domain? Can you please describe the issue > that you're trying to solve with this? Our issue tracker doesn't have much on this. But this was part of the initial submission for MT8183, but somehow got left out. The clk driver patch to enable runtime PM was even merged, but was effectively reverted following the clk driver rework. > It's not very uncommon but I'm not entirely convinced that this is right, because > the MFG_BG3D is a gate - and it's *not* outputting a clock rate on its own: the > mfgcfg is entirely GPU related and if there is no GPU support this clock is not > even ever needed. It could be just a gate, or could be a buffer. Either way, the registers to control said device could be in a power domain that is not always on. I don't think this can be ruled out. And if the registers are in a powered down domain, then either the readout would be bogus (if access isolation is implemented) or just hang the system. ChenYu > MediaTek, can you please clarify if (and why) this gate clock needs a MTCMOS to > be ungated? > > Thanks, > Angelo > > > Changes since v2: > > - Rebased onto current tree > > - Added Fixes tags > > - Fix up subject prefix > > > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > index 93dfbf130231..774ae5d9143f 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > > @@ -1637,6 +1637,7 @@ mfgcfg: syscon@13000000 { > > compatible = "mediatek,mt8183-mfgcfg", "syscon"; > > reg = <0 0x13000000 0 0x1000>; > > #clock-cells = <1>; > > + power-domains = <&spm MT8183_POWER_DOMAIN_MFG_ASYNC>; > > }; > > > > gpu: gpu@13040000 { > >
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 93dfbf130231..774ae5d9143f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -1637,6 +1637,7 @@ mfgcfg: syscon@13000000 { compatible = "mediatek,mt8183-mfgcfg", "syscon"; reg = <0 0x13000000 0 0x1000>; #clock-cells = <1>; + power-domains = <&spm MT8183_POWER_DOMAIN_MFG_ASYNC>; }; gpu: gpu@13040000 {