Message ID | 20240223015219.3618111-2-megi@xff.cz |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-77652-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp331144dyb; Thu, 22 Feb 2024 17:53:24 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXCpVZdySF2k1AZwRjFwdIJI8F6yqIOaon2ICdIF92a7aF6dYB7KxXLqirUz3DwMzAFqEn9eQYeh84cI6xuQgkrAb/b+g== X-Google-Smtp-Source: AGHT+IGFeB1nEwPaR7XtvQ5WR0H2ZUzZuLsfax4Zp3nJC6sGTd9Ek2Gshwpo/av0tZHlEpvpS75b X-Received: by 2002:a05:6a20:6f88:b0:19e:cbe9:64b with SMTP id gv8-20020a056a206f8800b0019ecbe9064bmr653595pzb.50.1708653204310; Thu, 22 Feb 2024 17:53:24 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708653204; cv=pass; d=google.com; s=arc-20160816; b=S9+vn24MSpvXZLYu5eRZ7OCruF77jGq2VsqQqErQD91KLyk4x3zRgBKTsXckZZKRIc +L4KXzLbX1gf6xPiU/DHB9EKpdqskYBUrm1pwobVvoSGe0Rxwcd83QkgrHr4Juo2aZig L80NaHMphfN3pfzEWeqKbwNl4R5lUyf4tERzT/kfaL0BYQ2JzkaD3kK6gYgy870H9/07 feo+tKwJ1PwqJzWMCRGO+DF2EDTiMdZ8WjCkvTUA7/1lV6asKHM5OvmFT2QjDdbamWp7 jjw1jDOi3IkA/hZVdu+sxh9ik6JPb1tq31LPmA1KFpV6rAjIusLzs37HfrHbdGk3lS2J 2/8g== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=DBRqqF7A2APxIOQ3hlOaI6UC69pgVvO3cwuWdEHkmZM=; fh=LyOUUyERizBut43yg2bQgiL8MyPFN7nnSRizOKM8oK8=; b=CQSwG/HgmXXphnwMiIlQu8bP1GWGKiP1nPUll9pk1dKimPRADe6hEqvpuVceVx5JNI sSkFDOIMkuG8DHK3k6PzvY1G/p2NTAK2XUabgafyLBWkl7CYfmBHWGe7NVPH8KkXZy7r QrgzmPCns34BfHi9mB/Jqm0dQVbZ0sZMMGEkUPlFjwC1z6Ctm6yHfkD20WSEUtKYpbNT c2oBq0C57dYmVgyqLiweslTpyT2dArMe/YSR9HLdwl7Arl1hMkxCNu05SjIOgeEvwO5S sFJuNupvx6iGAgOQIWgV2pw7HyZxdhdi0bdeJvmkWolrYLwmHHE8v1glPyUK35WXPRCe qb9w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=hDfWFMaD; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-77652-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77652-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id g14-20020a17090a128e00b00299ef592509si269795pja.106.2024.02.22.17.53.23 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 17:53:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77652-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@xff.cz header.s=mail header.b=hDfWFMaD; arc=pass (i=1 spf=pass spfdomain=xff.cz dkim=pass dkdomain=xff.cz dmarc=pass fromdomain=xff.cz); spf=pass (google.com: domain of linux-kernel+bounces-77652-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77652-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=xff.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 57D68B226A4 for <ouuuleilei@gmail.com>; Fri, 23 Feb 2024 01:53:23 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3DA6110A1B; Fri, 23 Feb 2024 01:52:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b="hDfWFMaD" Received: from vps.xff.cz (vps.xff.cz [195.181.215.36]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B2BAB64C; Fri, 23 Feb 2024 01:52:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.181.215.36 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708653151; cv=none; b=rcMnpH1EBFkNh21SZYTJ4/VQ3CicHVNorPD1aRLA+KRTPduQOhxUvUeEEvpooCmT6ahOnYMxy7qiVpRCw1VbhYeL2G1oZx4SaHYpRoUhv293xYmQcaIWX8tmELcSa+Qd4crzpGBvLlyXGYfZmQhVHHIYXIQ0/EcOGCFWseYqQyk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708653151; c=relaxed/simple; bh=6sk56gVI0A8n0qFpYuh7aNKcgFgXVN6+8f765I+Eq54=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=n9L1K/0MqyOgndb4vlO0w3FZLpoardoZvJJowbc4bbhMtrXSpXlAlKNdhi42AQRo4Cnh5cMy8HclIHO83UMMkXLGTZOA/UoQ/ZRfBA6KlCv4j3a2+Cz544PfobrGvd7evOmQ04PeyOn9rSrgYHOb+wiiLF8V9Qb6hRBu8dvAifs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz; spf=pass smtp.mailfrom=xff.cz; dkim=pass (1024-bit key) header.d=xff.cz header.i=@xff.cz header.b=hDfWFMaD; arc=none smtp.client-ip=195.181.215.36 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=xff.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xff.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xff.cz; s=mail; t=1708653141; bh=6sk56gVI0A8n0qFpYuh7aNKcgFgXVN6+8f765I+Eq54=; h=From:To:Cc:Subject:Date:References:From; b=hDfWFMaDLa++M0quMYHdkRxCRJlCxKh5BaSwKUm23H97hHGG/ReKWrWqL5Hu/5pGI ACb4sJ8tnsO6c67fGmF9CmfIFWF4Xzry6EwwV49c1ZMDa4SyN+lXRBsaAwhY4/ToIi Kw8TMVIJMRibVj7kE+P6l18pRTbNfGp7BHFAVc1k= From: =?utf-8?q?Ond=C5=99ej_Jirman?= <megi@xff.cz> To: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> Cc: Ondrej Jirman <megi@xff.cz>, Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Arnaud Ferraris <arnaud.ferraris@collabora.com>, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: [PATCH v2 1/5] dt-bindings: sound: Add jack-type property to sun8i-a33-codec Date: Fri, 23 Feb 2024 02:52:11 +0100 Message-ID: <20240223015219.3618111-2-megi@xff.cz> In-Reply-To: <20240223015219.3618111-1-megi@xff.cz> References: <20240223015219.3618111-1-megi@xff.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791652742164950356 X-GMAIL-MSGID: 1791652742164950356 |
Series |
Add support for jack detection to codec present in A64 SoC
|
|
Commit Message
Ondřej Jirman
Feb. 23, 2024, 1:52 a.m. UTC
From: Ondrej Jirman <megi@xff.cz> The codec driver needs to know what jack connector is connected to on the board. Add proprty to describe the type of connector. Signed-off-by: Ondrej Jirman <megi@xff.cz> --- .../bindings/sound/allwinner,sun8i-a33-codec.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)
Comments
On 23/02/2024 02:52, Ondřej Jirman wrote: > From: Ondrej Jirman <megi@xff.cz> > > The codec driver needs to know what jack connector is connected to > on the board. Add proprty to describe the type of connector. > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > --- Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time, thus I will skip this patch entirely till you follow the process allowing the patch to be tested. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On Sat, Feb 24, 2024 at 11:31:07AM +0100, Krzysztof Kozlowski wrote: > On 23/02/2024 02:52, Ondřej Jirman wrote: > > From: Ondrej Jirman <megi@xff.cz> > > > > The codec driver needs to know what jack connector is connected to > > on the board. Add proprty to describe the type of connector. > > > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > > --- > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time, thus I will skip this patch entirely till you follow > the process allowing the patch to be tested. > > Please kindly resend and include all necessary To/Cc entries. Yeah, I did run the script on v3 where this patch was not present, and forgot to re-run it on the new version. I'll resend. In any case I did run DT tests on the patch. kind regards, o. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml index 63eadc4200ac..399fc00ad3f4 100644 --- a/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml +++ b/Documentation/devicetree/bindings/sound/allwinner,sun8i-a33-codec.yaml @@ -44,6 +44,15 @@ properties: - const: bus - const: mod + jack-type: + enum: + - headset + - headphone + description: + Type of jack connector connected to the codec. This can be either + a 3-pin headphone connector or 4-pin headset connector. If not + specified, jack detection is disabled. + required: - "#sound-dai-cells" - compatible