diff mbox series

exec: Remove unnecessary ‘NULL’ values from vma

Message ID 20240220051830.61099-1-zeming@nfschina.com
State New
Headers
Series exec: Remove unnecessary ‘NULL’ values from vma |

Commit Message

Li zeming Feb. 20, 2024, 5:18 a.m. UTC 
  vma is assigned first, so it does not need to initialize the
assignment.

Signed-off-by: Li zeming <zeming@nfschina.com>
---
 fs/exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kees Cook Feb. 24, 2024, 1:04 a.m. UTC | #1 
On Tue, Feb 20, 2024 at 01:18:30PM +0800, Li zeming wrote:
> vma is assigned first, so it does not need to initialize the
> assignment.

I don't really like removing explicit initializations. They don't cause
any problems and the compiler will remove redundant stores, so there's
no benefit in dropping them.
diff mbox series

Patch

diff --git a/fs/exec.c b/fs/exec.c
index af4fbb61cd53e..7be0527f5ff25 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -254,7 +254,7 @@  static void flush_arg_page(struct linux_binprm *bprm, unsigned long pos,
 static int __bprm_mm_init(struct linux_binprm *bprm)
 {
 	int err;
-	struct vm_area_struct *vma = NULL;
+	struct vm_area_struct *vma;
 	struct mm_struct *mm = bprm->mm;
 
 	bprm->vma = vma = vm_area_alloc(mm);