Message ID | 20240223-player-buckskin-01405c5889c4@spud |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-78717-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:a81b:b0:108:e6aa:91d0 with SMTP id bq27csp692485dyb; Fri, 23 Feb 2024 08:24:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWslPxtczl95s5TivQJUHoRiaAuv6pADHUwwhxo5ENDuWI5h9NDYg4cx7A608TcdYUS7LVZ2hoALKYGFB7mpqLdhmzUNQ== X-Google-Smtp-Source: AGHT+IFnkfhERxwxewDkfCyd6/Xw3L6BXMQ/y5y2wrepnfI9JLrZxpzeMWSfh62HUhb0QkZDRisw X-Received: by 2002:a17:906:1310:b0:a3d:a63f:2db0 with SMTP id w16-20020a170906131000b00a3da63f2db0mr231415ejb.28.1708705470300; Fri, 23 Feb 2024 08:24:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708705470; cv=pass; d=google.com; s=arc-20160816; b=SC1hanq3sjs4kglc9I2qMc/vF+yG3WjBjGrz9fal2VlqjtxsQabqhaPKMSepuCZuJe qwEOkiuPl+QFpaGpuFigiHkJDmlSe0Ap4TZ+KXvok7OzL6KuK8eucypmJKK//QvEGySM /HT0jbFi/7e67N+TRzn0itdhTOJ1i3U7w6guluTeVIdIzcxJhHqCUFfrqX95+4wgFzgC t25lGlc4esh7crfRwgjuysXKWwC2YXW5b6R4vMx7Y1T3kCFIQXcNirQ7fy1AVyJBEuf0 UZVvIX9wcWjfTLbAa5OLY7KBSeoUR+TF0vEX0lNkCrdUMug6Cb/9mMu6w0d3nnolqD7V WTJA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HfDdP3Bmn0II9UZYIe+loD2p1pk90upOrXHbdfrJ+/o=; fh=x7BZgx5LKkWFLAFoe9p/O54YK0XTo1QETE/K7fPNxJ0=; b=CAeGhhU3N/OcDFRuOpF7KKkjLXnzftIl1IAetwkuUIDgNPsgDI3JKL2nHyLxKR8bO+ 4nTZlIv89OL/FhbrILnWdoCCqH9NPWayM7pJ7h4gU9Jv3cCPxCE8SyWgF215TpxhbXUq Ch0KIZ1TYMYCC2NF2nyBx/k5Oi1rMrhlzx9xZtIeZGEnnPrw7GEAT362MmPygegjy0MV hiXOiwJAOfnB1HHqoehR4j+1RiaCLij6Yk5EDuP6OPGCS89Fuesmj2tNcs0Xufsx41yd 8dk0uSiDR4Op+hOMX+LZIahV4Ns+FVQmDippy020wK4qTfkPdVRpL3WFRDVGxPYitfAv TpZQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dTIvL9xA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78717-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78717-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id k16-20020a17090627d000b00a3e5de68f28si5376442ejc.855.2024.02.23.08.24.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 08:24:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-78717-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dTIvL9xA; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-78717-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-78717-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id DFF931F21CE0 for <ouuuleilei@gmail.com>; Fri, 23 Feb 2024 16:24:29 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0C69134CD9; Fri, 23 Feb 2024 16:21:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dTIvL9xA" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 249C912E1FC; Fri, 23 Feb 2024 16:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708705310; cv=none; b=kCaT2ZCeSis/XTV+BY0810a3lTlWR706gABmv3RAj+No9p9LYfd9WQXqtoc/Q3OxxkWGFssHlwiNiqWb/6AJWyCwtw2Nl2SgrLc4XWjpNBILHimX+prgO1EQqKfpS93lywYOd8XMZM8GMPnRgkkYtg/RK67NDcDmuNo6d2GB2lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708705310; c=relaxed/simple; bh=jbwiQKAcTZW+OF+UocDdv05N53uW5wLX6hkKOMBTcOM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jUzpBxmEe0bfPxFMpVdyH7pSLDtKzzHxaYpMHFq/IUtgZ+2BuBIMprOwnKU4a6YmQLBDere7dIoQDwrGk8PDGwDJOQm0FT0sgJtfxvckhGkc8ozPCRsRct/RFGyrT8sgVuE87Bjq0lnGCMQm3EZfDZIEGzF//ZyQPs3FMSqhOxk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dTIvL9xA; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65F04C43390; Fri, 23 Feb 2024 16:21:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708705309; bh=jbwiQKAcTZW+OF+UocDdv05N53uW5wLX6hkKOMBTcOM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dTIvL9xAKYzJdtJJl+Ix/2HOVcMOsQU7G28axnq7a+CL65sIgFuZsJIlluGUeIkWM ZtpLCZJbcaMFmJgHNX3Whbu6pnP/3ophsAP2Y/82Mcnt6LfGUO7tcizXvVp4c2R5gA OQ2DryRFGSfsQWLZfJJ/DtQKHuc/aQmswPsTnlwOac/5/fNaModp2T8DBy7QXgmmQ5 o/c4YRSGshfFBRoUHJh4MymSHJy1A4+qKa4d/h6E+RBTcJAyvPMEGlgfyVQS+PGq6A 4Auiq06PqG9UpocQ69cVdr1gKGBo/IKIrCs87IPysVAFEPURO14EbuIeSpAHz7yN4D i7BtcwpSEjo4w== From: Conor Dooley <conor@kernel.org> To: linux@roeck-us.net Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>, Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Zev Weiss <zev@bewilderbeest.net>, Patrick Rudolph <patrick.rudolph@9elements.com>, Peter Yin <peteryin.openbmc@gmail.com>, Alexander Stein <alexander.stein@ew.tq-group.com>, linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Naresh Solanki <naresh.solanki@9elements.com> Subject: [PATCH v2 4/5] hwmon: (pmbus/lm25066) Use PMBUS_REGULATOR_ONE to declare regulator Date: Fri, 23 Feb 2024 16:21:08 +0000 Message-ID: <20240223-player-buckskin-01405c5889c4@spud> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240223-moonrise-feminist-de59b9e1b3ba@spud> References: <20240223-moonrise-feminist-de59b9e1b3ba@spud> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=989; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=pvEzR+gA96CLf2ByeujTgLZ57PfkfC8+QPdFFNSWXgs=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDKk3jv7gz06I0cheuEdus3LXUs8VHOcbHY3E2+fbzz/8K MS5rnxSRykLgxgHg6yYIkvi7b4WqfV/XHY497yFmcPKBDKEgYtTACbCrMnI0DVRsNCUvTao7sf2 mos/klY288iwVgWHCPJfMjqwP1jtDMN/p2exUl/Z/R38lhRLrjlzI32jzbo/33cnSvKnz2Kom9H PAwA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791707546887579983 X-GMAIL-MSGID: 1791707546887579983 |
Series |
PMBUS Regulator cleanups
|
|
Commit Message
Conor Dooley
Feb. 23, 2024, 4:21 p.m. UTC
From: Guenter Roeck <linux@roeck-us.net> If a chip only provides a single regulator, it should be named 'vout' and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make that happen. Cc: Conor Dooley <conor@kernel.org> Cc: Naresh Solanki <naresh.solanki@9elements.com> Cc: Zev Weiss <zev@bewilderbeest.net> Signed-off-by: Guenter Roeck <linux@roeck-us.net> Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- drivers/hwmon/pmbus/lm25066.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote: >From: Guenter Roeck <linux@roeck-us.net> > >If a chip only provides a single regulator, it should be named 'vout' >and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make >that happen. > As mentioned on Guenter's v1, this change necessitates a corresponding update to arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts, which has a dependency on the name of the regulator. Given (AFAICT) the lack of any combined dts & driver patches anywhere in the kernel git history I guess maybe doing both atomically in a single commit might not be considered kosher, but could it at least be included in the same patch series? Thanks, Zev
On Fri, Feb 23, 2024 at 03:16:28PM PST, Zev Weiss wrote: >On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote: >>From: Guenter Roeck <linux@roeck-us.net> >> >>If a chip only provides a single regulator, it should be named 'vout' >>and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make >>that happen. >> > >Given (AFAICT) the >lack of any combined dts & driver patches anywhere >in the kernel git history I guess maybe doing both atomically in a >single commit might not be considered kosher, but could it at least be >included in the same patch series? > Ah, except I realize now I neglected to pass '--full-diff' to 'git log' when checking that, and after fixing that I see there is in fact some precedent for commits changing device-trees and driver code together, so ideally that would be my preference here too. Thanks, Zev
On 2/23/24 15:26, Zev Weiss wrote: > On Fri, Feb 23, 2024 at 03:16:28PM PST, Zev Weiss wrote: >> On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote: >>> From: Guenter Roeck <linux@roeck-us.net> >>> >>> If a chip only provides a single regulator, it should be named 'vout' >>> and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make >>> that happen. >>> > > >> >> Given (AFAICT) the >lack of any combined dts & driver patches anywhere in the kernel git history I guess maybe doing both atomically in a single commit might not be considered kosher, but could it at least be included in the same patch series? >> > > Ah, except I realize now I neglected to pass '--full-diff' to 'git log' when checking that, and after fixing that I see there is in fact some precedent for commits changing device-trees and driver code together, so ideally that would be my preference here too. > That is not going to happen in the hwmon subsystem unless something slips by. In a large project like the Linux kernel you'll find precedents for everything, so citing one is not a valid argument. As a general rule, I don't apply patches in .dts[i] files through the hwmon branch at all, not even as part of a patch series. Architecture maintainers tend to strongly oppose that idea, for the simple reason that it creates the risk of merge conflicts and thus of bugs during commit windows. Guenter
On Fri, Feb 23, 2024 at 03:16:26PM -0800, Zev Weiss wrote: > On Fri, Feb 23, 2024 at 08:21:08AM PST, Conor Dooley wrote: > > From: Guenter Roeck <linux@roeck-us.net> > > > > If a chip only provides a single regulator, it should be named 'vout' > > and not 'vout0'. Declare regulator using PMBUS_REGULATOR_ONE() to make > > that happen. > > > > As mentioned on Guenter's v1, this change necessitates a corresponding > update to arch/arm/boot/dts/aspeed/aspeed-bmc-delta-ahe50dc.dts, which has a > dependency on the name of the regulator. Given (AFAICT) the lack of any > combined dts & driver patches anywhere in the kernel git history I guess > maybe doing both atomically in a single commit might not be considered > kosher, but could it at least be included in the same patch series? I was gonna do it in isolation if this went ahead, but I see you went and did it yourself - thanks. As Guenter pointed out later in the thread, any patch that combines dts changes with drivers or bindings is something that likely snuck in or was some sort of extenuating circumstance. Cheers, Conor.
diff --git a/drivers/hwmon/pmbus/lm25066.c b/drivers/hwmon/pmbus/lm25066.c index 3a20df5a43ec..cfffa4cdc0df 100644 --- a/drivers/hwmon/pmbus/lm25066.c +++ b/drivers/hwmon/pmbus/lm25066.c @@ -437,7 +437,7 @@ static int lm25066_write_word_data(struct i2c_client *client, int page, int reg, #if IS_ENABLED(CONFIG_SENSORS_LM25066_REGULATOR) static const struct regulator_desc lm25066_reg_desc[] = { - PMBUS_REGULATOR("vout", 0), + PMBUS_REGULATOR_ONE("vout"), }; #endif