Message ID | 20240213-verse-clinic-e6de06e1f18d@spud |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-64220-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp784567dyb; Tue, 13 Feb 2024 12:14:14 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVp9kmMvx0KxTdTFNpF/w7blG+0V/TRFM6ImH+aOjTT2Xjuv7E4At7x7TJqBXD7CIPzElanOKXJDs+eTKKIuk/wcYoIow== X-Google-Smtp-Source: AGHT+IFWgqacwDmXcDjiFENUnh7IR2rqW7HlWbK+xaExrtveoOXoy+XDnLz24PTY+e83uyIg4WTX X-Received: by 2002:a05:620a:b06:b0:787:238a:13c0 with SMTP id t6-20020a05620a0b0600b00787238a13c0mr527611qkg.15.1707855254256; Tue, 13 Feb 2024 12:14:14 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707855254; cv=pass; d=google.com; s=arc-20160816; b=tRuMkO9HTqoRvKUNun37S0hRji/WR05kVEuit7ENGJGrwLztXK92YIVPhNjCOFxFmQ eqWAV86QRo1ESbXWW9T32NfxMzeijkUXz9Ly74uEc43UBdjiagE01UNyi2A1GvlM43Xd EC+vL5GRZCCqYgYki9ThlcAZ0KJxx7iWE/V8y0xt0uIlo2LWvFk6ARlrrH0c3gzYKvMC 3XDMR+FFksojQ6FJYYwVA8OVItWp85JExNLQ6UTijIuq5qe6T7mD7XBMs0PBMMSJRX5G BXOdzMF9ZhnoZzJZ1ml/UHzrI+1JAPj1GiiiivyvkbJgWEt151fpmhgsXxglkrwOrZTB Pi+w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=+SKhiSY/iXMGHA2D+psYu06aco7/XgvxMEa1D3rTa7U=; fh=kK6FXXGSDs1N4XoJS282bvK4LLDtfzQFmfrOkoLWh0E=; b=D7USAkWuVqRYnVd+zLWQRr0AqgH9DXZwN7Ev3WTzVwYN7bu/GFl12nOwid3RNpFRva hYmY70Fti3wbCDopXn0hmmRY8MMTEASveabdBkdjcXFObUfKiMrnCIgVfk+YZwQx78zV FUVON9g7UpaFN/5oNlKDqFkYhBgs2Hfv5p9NRi/v0KGcTTDtuVrCYY47elyhoxq1RHFy bNOt12ZUcHkZtieT2hmhpj6ZSR3nTd+/7wzF41rVjDD8k1dw3kUvor7/C1SjN2s/FGPv JDR0PXwDl4t0Fu6H9RjI1fon3Zd7MCO7x5PXe5s/M+gtjbrS8kVy4A0pd47MbuVPrxlw aQuw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rsySa6xI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64220-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64220-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUjF99ymRV0E10+pUd+xPa69c4rrlsSDvLorffC2+oW1dWfLumZiw2EWk7iDdHPmkJ12fLYwTV6hb6Muc2ryrxtFnayaQ== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id d2-20020a05620a136200b00785d95ddd99si4463729qkl.65.2024.02.13.12.14.14 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 12:14:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-64220-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=rsySa6xI; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-64220-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-64220-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 10B141C24702 for <ouuuleilei@gmail.com>; Tue, 13 Feb 2024 20:14:14 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2257160BA8; Tue, 13 Feb 2024 20:14:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rsySa6xI" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 821C160EC3; Tue, 13 Feb 2024 20:14:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707855240; cv=none; b=p6n8bwb+bY8SIabZmUZo2afRJzas1K8WHfl3JlmwmzMkQij5DWYY7PlT+Wj12nv1yb6JRwdKUxW06+0pUDcmv9UKwk1FDj9knR1i9/LJH7aL1yreiMVFXsY6lwu06vunfEVR+WHhL4IRUYsrTQBGs8p9EIjLtPtzRBdytB5ZOxc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707855240; c=relaxed/simple; bh=oJqi+TkCFTQfeAF3TAmEu+UcwKS0++cFDBDB9TAcdDA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=jEIpx/mpZuBP32DJcJmskZ9uQ8tGtJzuYKH50NE99NdgETtQnOBGaER3bIG51EwkVxMtu5StetpzvbS4cFescrxcJ1eWmO7Qf6TK3ye+haYJzrTUw8gNwGP4huXHh74Y/cG2R+w3RVbibO1xE4f+5iF8Ltf/rCfmBghiwtm2uoU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rsySa6xI; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DAF2C433C7; Tue, 13 Feb 2024 20:13:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707855240; bh=oJqi+TkCFTQfeAF3TAmEu+UcwKS0++cFDBDB9TAcdDA=; h=From:To:Cc:Subject:Date:From; b=rsySa6xIVALy8A8vdXWYBEIVuHAhI9HBVDZNQLg+JtlYjWUVfiVVJSG63o7py12SH jMCKONPxC1IaLaxVnQmfhbucetwhFWPSpUYWHenWfaj412Q5G53e016I7CP4Q3mZMF wYxSD4TlnfRKCa+3f2Yr4bMdrNNWQAQ2YKaZ4jljvHWeq1WEbvCBJlt4VK4/KCPsZX 2glaNKmDJIuasE/s9o0XtMsVjZ7uEKaVqHZaHIXig6q+J1q9F4ZCFgf+bYVGQ/YR1w yUX4nhhRdlIw7BTSJ3iaJBLV+E6PU4mLbh8LOODVCb0IZsRKdVUjkUJGd4ltHzoT4q Hh64pW+l2EzRw== From: Conor Dooley <conor@kernel.org> To: Lee Jones <lee@kernel.org> Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>, Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Sven Schwermer <sven.schwermer@disruptive-technologies.com>, Christian Marangi <ansuelsmth@gmail.com>, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low Date: Tue, 13 Feb 2024 20:13:41 +0000 Message-ID: <20240213-verse-clinic-e6de06e1f18d@spud> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1565; i=conor.dooley@microchip.com; h=from:subject:message-id; bh=EBDvz2f7L83vswny9H9PgyID1DoSZ6oLH7Vj9u17jOE=; b=owGbwMvMwCFWscWwfUFT0iXG02pJDKmnz5ZKr2S5F3UlL+9BSMDiAx6plTP+ibWVRv5IWz/JZ Jld4umwjlIWBjEOBlkxRZbE230tUuv/uOxw7nkLM4eVCWQIAxenAEzkyGOGf0oc25gmJJauXLQ4 aLNKEvPUXyahsYz3RHq73eU8Jxz10GP4X8bZfdtzyZ9flk1bjIrsVptFn57Tkxvv8vtdQPPtqnm a7AA= X-Developer-Key: i=conor.dooley@microchip.com; a=openpgp; fpr=F9ECA03CF54F12CD01F1655722E2C55B37CF380C Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790816031089560804 X-GMAIL-MSGID: 1790816031089560804 |
Series |
dt-bindings: leds: pwm-multicolour: re-allow active-low
|
|
Commit Message
Conor Dooley
Feb. 13, 2024, 8:13 p.m. UTC
From: Conor Dooley <conor.dooley@microchip.com> active-low was lifted to the common schema for leds, but it went unnoticed that the leds-multicolour binding had "additionalProperties: false" where the other users had "unevaluatedProperties: false", thereby disallowing active-low for multicolour leds. Explicitly permit it again. Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") Signed-off-by: Conor Dooley <conor.dooley@microchip.com> --- I'm just assuming this is intentionally restrictive, if its not, we could easily just change this to uneval: false. CC: Pavel Machek <pavel@ucw.cz> CC: Lee Jones <lee@kernel.org> CC: Rob Herring <robh@kernel.org> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> CC: Conor Dooley <conor+dt@kernel.org> CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com> CC: Christian Marangi <ansuelsmth@gmail.com> CC: linux-leds@vger.kernel.org CC: devicetree@vger.kernel.org CC: linux-kernel@vger.kernel.org --- Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++ 1 file changed, 2 insertions(+)
Comments
On Tue, 13 Feb 2024 20:13:41 +0000, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > active-low was lifted to the common schema for leds, but it went > unnoticed that the leds-multicolour binding had "additionalProperties: > false" where the other users had "unevaluatedProperties: false", thereby > disallowing active-low for multicolour leds. Explicitly permit it again. > > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > > I'm just assuming this is intentionally restrictive, if its not, we > could easily just change this to uneval: false. > > CC: Pavel Machek <pavel@ucw.cz> > CC: Lee Jones <lee@kernel.org> > CC: Rob Herring <robh@kernel.org> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > CC: Conor Dooley <conor+dt@kernel.org> > CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > CC: Christian Marangi <ansuelsmth@gmail.com> > CC: linux-leds@vger.kernel.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Acked-by: Rob Herring <robh@kernel.org>
On Tue, 13 Feb 2024, Conor Dooley wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > active-low was lifted to the common schema for leds, but it went > unnoticed that the leds-multicolour binding had "additionalProperties: > false" where the other users had "unevaluatedProperties: false", thereby > disallowing active-low for multicolour leds. Explicitly permit it again. > > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > > I'm just assuming this is intentionally restrictive, if its not, we > could easily just change this to uneval: false. > > CC: Pavel Machek <pavel@ucw.cz> > CC: Lee Jones <lee@kernel.org> > CC: Rob Herring <robh@kernel.org> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > CC: Conor Dooley <conor+dt@kernel.org> > CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > CC: Christian Marangi <ansuelsmth@gmail.com> > CC: linux-leds@vger.kernel.org > CC: devicetree@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > index 5edfbe347341..a31a202afe5c 100644 > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > @@ -41,6 +41,8 @@ properties: > > pwm-names: true > > + active-low: true > + > color: true > > required: > -- > 2.43.0 Neither checkpatch.pl or Git appear to be happy with this: ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 0 warnings, 0 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. "[PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low" has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. WARNING: Missing commit description - Add an appropriate one ERROR: Missing Signed-off-by: line(s) total: 1 errors, 1 warnings, 8 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. Your patch has style problems, please review. NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Check the results (hit return to continue or Ctrl+c to exit) Applying patch(es) Applying: dt-bindings: leds: pwm-multicolour: re-allow active-low Using index info to reconstruct a base tree... M Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml /home/joneslee/projects/linux/kernel/.git/worktrees/for-led-next/rebase-apply/patch:28: indent with spaces. active-low: true Checking patch Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml... Applied patch Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml cleanly. warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... error: Your local changes to the following files would be overwritten by merge: Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml Please commit your changes or stash them before you merge. Aborting error: Failed to merge in the changes. Patch failed at 0001 dt-bindings: leds: pwm-multicolour: re-allow active-low hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort".
On Fri, Feb 23, 2024 at 03:43:04PM +0000, Lee Jones wrote: > On Tue, 13 Feb 2024, Conor Dooley wrote: > > > From: Conor Dooley <conor.dooley@microchip.com> > > > > active-low was lifted to the common schema for leds, but it went > > unnoticed that the leds-multicolour binding had "additionalProperties: > > false" where the other users had "unevaluatedProperties: false", thereby > > disallowing active-low for multicolour leds. Explicitly permit it again. > > > > Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common") > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > > --- > > > > I'm just assuming this is intentionally restrictive, if its not, we > > could easily just change this to uneval: false. > > > > CC: Pavel Machek <pavel@ucw.cz> > > CC: Lee Jones <lee@kernel.org> > > CC: Rob Herring <robh@kernel.org> > > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > > CC: Conor Dooley <conor+dt@kernel.org> > > CC: Sven Schwermer <sven.schwermer@disruptive-technologies.com> > > CC: Christian Marangi <ansuelsmth@gmail.com> > > CC: linux-leds@vger.kernel.org > > CC: devicetree@vger.kernel.org > > CC: linux-kernel@vger.kernel.org > > --- > > Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > > index 5edfbe347341..a31a202afe5c 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml > > @@ -41,6 +41,8 @@ properties: > > > > pwm-names: true > > > > + active-low: true > > + > > color: true > > > > required: > > -- > > 2.43.0 > > Neither checkpatch.pl or Git appear to be happy with this: 18:15:26 conor /stuff/linux$ shazam 20240213-verse-clinic-e6de06e1f18d@spud Grabbing thread from lore.kernel.org/all/20240213-verse-clinic-e6de06e1f18d@spud/t.mbox.gz Checking for newer revisions Grabbing search results from lore.kernel.org Analyzing 3 messages in the thread Looking for additional code-review trailers on lore.kernel.org Checking attestation on all messages, may take a moment... Retrieving CI status, may take a moment... --- ✓ [PATCH] dt-bindings: leds: pwm-multicolour: re-allow active-low + Acked-by: Rob Herring <robh@kernel.org> (✓ DKIM/kernel.org) --- ✓ Signed: openpgp/conor.dooley@microchip.com (From: conor@kernel.org) ✓ Signed: DKIM/kernel.org --- Total patches: 1 --- Applying: dt-bindings: leds: pwm-multicolour: re-allow active-low 18:15:39 conor /stuff/linux$ git show HEAD~1 commit 2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e (tag: next-20240220, korg-next/master) What do you use to apply patches? b4 seems to have no trouble. Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml index 5edfbe347341..a31a202afe5c 100644 --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml @@ -41,6 +41,8 @@ properties: pwm-names: true + active-low: true + color: true required: