Message ID | 20240221145846.1611627-4-xu.yang_2@nxp.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-74169-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp870754dyc; Tue, 20 Feb 2024 22:52:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX0lvZUNHDhYCQy6YuTAhSyB0DenwubiwsKWsW7jRqPtrN0O5S9z5TTHrG6Sb3uWXzrZO3F/sE6eKsMWur7Ost/oGFjNQ== X-Google-Smtp-Source: AGHT+IERIAaGyLL/vKqBqWpFzi/tTrFJmj+zsRbhLZbjAA1hecxVhNlN7Kz2kMUGZIeD8SKcscQK X-Received: by 2002:a05:6a21:6315:b0:1a0:785c:58c2 with SMTP id wu21-20020a056a21631500b001a0785c58c2mr14012288pzb.61.1708498369628; Tue, 20 Feb 2024 22:52:49 -0800 (PST) Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id mw18-20020a17090b4d1200b00299785035dcsi5968187pjb.107.2024.02.20.22.52.49 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Feb 2024 22:52:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74169-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector2 header.b=BzRQpNhq; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-74169-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74169-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5503328309D for <ouuuleilei@gmail.com>; Wed, 21 Feb 2024 06:52:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AE8C43A27B; Wed, 21 Feb 2024 06:51:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="BzRQpNhq" Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2042.outbound.protection.outlook.com [40.107.6.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D474E3AC25; Wed, 21 Feb 2024 06:51:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.6.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708498315; cv=fail; b=XqVaXFuYnDkPO9383SAhzsgEEBQQWAgJB1hPY+67Iub10O7Ff2c1f1erWwGXJldu6K6rvM6pSF5OCmSkN5uKvtLjDzYl+xtJ0Y147jPn2yc6fjcaeFFiMsEp8DQGpacb8CodNsO1jwPENWbdG15kdzU3T4YZYQGz7fvZLXrZuUo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708498315; c=relaxed/simple; bh=zoB1G40HMGMaUnbvkdET6FupLf9uQGhM6mAxm/eXZeI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=pCdAJ9pCiQymPN5vGDsSnCFLy8oVit0kBHV8GnUa1mWmqC1bnR0QxsZaGE1s0y+88l6hHoEPUZ+0CxmbgIK5jx2IhmgNkxjs/7h6H99NSzqRNX2w5gsNvYLkEGlGeXBbHE13+6tYbshbsgeweVpKiDX3QRnQ+4YdRzItjhp9qCA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=BzRQpNhq; arc=fail smtp.client-ip=40.107.6.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=izT7RGscfNrSXZ8Se6DW9Mb9tVbbmOEN9C1n8E3ghGFQ04RH7zCIXWNo9KOmeHHLZvYcU7TKX78lAigcGaTBuKQp9ASAr7QugtwSZXD8Mkj3mVEqAOZw6KSzEBwLEbDeM+UjalPssFRcOoGYFzqYaMdtw4QuSN08LDuYd6ISYWA5qqmsfab20NeRUW7ZOOAfACHgFyg1BFb9TRla9d26qIHw5uGA3U/PSHSmG/gnE1FXx5uMOgOkO/KxvVdP/9603Lkcm1NhgGDHaikP6gp2WHCP6DLcaK8oe+ZlXbIOEQsvHxvNPjwv77zKajWRmTljIQqoou9CNfREGWfmHom1yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Efo77SPUftdc6VSRPIBJO/of8Og+4gFvmQDRGFG4FDE=; b=SbpeD1674dcfMBr1u8h21v/0rUeX6cJBV0qXiz09UEPijBr9CdssXC5FQyWoIX0qUyKuaVGDCrlVcdeGCHI2c/wzRNDHi5AUqvJtAC0m5CfXsui82unatDZNBVJ++Y9mXWa6vyD5pb1fejxtg1IzxaJLzHnluZmKtjn/ZoNOltT5beokY56LMtSWJFy2gW2IiVUVgcTv9OoU/nOJ0dT4rd8yHCPTXKycpu+TauuJ3YofFP+CJGArs1kx4/XGSoX1Vyi25tYfDg6MIg2Mtx+yy3wUF2i+8PpOAfdvdP3lFQ6JDXNzXJqclT1FEdkSWQKO6b8mmdNwhrBA3weW6NTzNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Efo77SPUftdc6VSRPIBJO/of8Og+4gFvmQDRGFG4FDE=; b=BzRQpNhqKDhJKjCZwemAyoKK0w2J5raCPc/DeNC5la/hszV47b6qEUFMib60hzbK2tjjCKiQAcrRKOPrZJw6bnXYa1gqs9gg3f4q8jfSY0H0xh22/QiKL9HvRqC5jGQnaKhQkDA3aPTKJQkhgtcNvNExNZWMwsbxgnRJNDUi8SI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) by PAXPR04MB9304.eurprd04.prod.outlook.com (2603:10a6:102:2b6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.39; Wed, 21 Feb 2024 06:51:50 +0000 Received: from DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::d45f:4483:c11:68b0]) by DU2PR04MB8822.eurprd04.prod.outlook.com ([fe80::d45f:4483:c11:68b0%7]) with mapi id 15.20.7292.029; Wed, 21 Feb 2024 06:51:50 +0000 From: Xu Yang <xu.yang_2@nxp.com> To: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, conor+dt@kernel.org Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, peter.chen@kernel.org, xu.yang_2@nxp.com, jun.li@nxp.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/9] dt-bindings: usb: add NXP ChipIdea USB2 Controller schema Date: Wed, 21 Feb 2024 22:58:41 +0800 Message-Id: <20240221145846.1611627-4-xu.yang_2@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240221145846.1611627-1-xu.yang_2@nxp.com> References: <20240221145846.1611627-1-xu.yang_2@nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2P153CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096:4:140::6) To DU2PR04MB8822.eurprd04.prod.outlook.com (2603:10a6:10:2e1::11) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB8822:EE_|PAXPR04MB9304:EE_ X-MS-Office365-Filtering-Correlation-Id: 7ea61284-dede-4a24-4131-08dc32a99446 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J5L8OSup3E+InYyi6MQtWnK6Kmw8uVL5Bmm8zOA1J5fUa7YUkwHXvLBQncovokpOFdhlMchl3ByPaVzigaJS8Lht57qngLTWZkCZB+Z52uk5QzpKojmS7ILuFPwzAPUN+GbII4wMqGpAj4wuySZlqjpJ0pmAaD23tbdNnmXpX9sY52DGyaF8iwy5glx/SLAVP0JM4ZRXMnc6Ki5xJYkQ8B+1nI2u30AvStziNbK7BrPdsePd4CPKFlQyLP/3QKTCVzjeVCC0Fhh+Z7DLibkwJWIsNz9KYm3FMu0vjMZjgnC9809EtTdkP6E9gUyzgqir72D4Faz8BJ/n0VoUaqgtAODGeXVkWvyRQ4i/PW0E2gwyYSdSHwPSJypgF+8r3Cv0r4n558c5+OFekl3w4kxwax8NzIbsiS0/3ta/nopp8nK+UobtQmCjk8DPgzhAYG5KIr2bDz2MjjvORWFlpAWpi0JUMNRyHgSjeCQv2Z5TVlII2l2s0VsHG27KHRl4DEUZZkda9qJBKMXNDEWj6o2GQ270ZFHVmpyoL+mHDgqJtiZC0fu5Xp75sIuwwHiCR6MRqeECdN0jFFDaul9Zl8/hVDmmE8T/GGfJT10IDPb5dL8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8822.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: g4tibJfEXPexFzoTuwm9LfIG/KyTT8qoJKvxg0fAr9tTIgP4v4sCiHb2g4JZHvHzRW1RmMVVbMx8xcGxQ0EZ4v21nQNXkIGvMvH3B66kWvRgMZGlFwONRrLZYkvDG+YJvQmWLdZZnc1B5Bym4R6GNAIU4MUXlFBDPi+e3/EUTE/N+Nr7fOq7jbMtnEPW2QaZxcfcZBDtgdWURmbgwBkSf67X0dEYHPbYwvttSI2R+Bo6UBMyeiQ9YkFAk3kN+v0FuBkpdLC8oYN3NOGBPRZow76stLAeiLDzaGHtZcqFkstUjfrIai9h93r0myp6pWAvwd9ROpFDQ9Czc18uxP9KLzTMpe+90UmS7DDY3MsVwPBA9K2DguVH2leS3inIURQqhIJClw+Kiakpfgezk9jHCGrQOz2/4jKoJG2lioUX/w37naK3UQkv/Jg05CRPKqaUZ6MhPvzSWBrBVWBdK4YpXej6SlsDhdzhT+4Egstx5hDTxgRoJGJYJbOZLezezeOxXTp0JiUiUjxDKtV/VumdYeaOifLbzZkcoodOROwg4NWsad7sZZPZlWvaQozus8vZhpxzJ1ko6T34DCJHyuAm1NuunuBi8lhEiGmjEegKEmz1b8Vb7cw4y3psSwG9hb8e+hTmfthnDY2KJzR3MU64ywCB52wlappSxDlG7ZSIfbM+hTFVoy6FqR4bBuOXyFAKj3AohySSQzLYAL7SALb6U4TdKVq2JtnwFasnMHe6I73+KwJWPg+D1/LCp5CMpCDwxMX0gd24mJDzsPuBpVdpRpmAz2+j3tI84aDhxZVGizANgEgXYfu9GMI2NQk75Pf5vPON7BhSTsdQLbbXErIiG0UNGyaFvz/FUAMJ00wT+33+4cOYMNHjzy/QEmZl+83stjUZCrFySbCbz/YNDYzbKFOPsqO25kyeY3Yl7bFkrtWmnVV+Et/ULvha4BQUKfOvizRPMgn/GFlxaAd857uWAQGLME7SnbR4390d7sU4Ii9lUwZ1xg84IGZb/v4EIuCcJGan9yZdmdxUYWuqzVPSyx5r4jpkBlzp2gdsrO9eCpvBIx3MwCXWT515oUd++QgqPZp5AUd7PR+2Ajay/i6qVkirIVdaJrLtgrpPiMtyKp7RT7c3Gtuxyp9RSol2FpmFx/+0WX0PSUUeNzmzqu/3CYCvfi3LDxFbuQUtVt/+FAAXzZd7kpe7K0U93suoZNObP6ojXq+jPtt2EKuoDQfgrvuTWDcpBGz5w+IQu1O8WS/C9wClpHGFpRCI0qAhIClMYBt0ARCcklJfaHXu0PLzI3dqkn0bWVcLbJammy/rLeeSyzstaMVm0gJWL5q5a+QsSoXKSLahY2tSvPHRa8Vcqt1zI8QRRiGP1f5NHceyh6FGP7ZK69rLZCK9PxG+Yh7eH6KcJWkP4n9tHa4Tt36FYCcR8eCQ1Bodoxk4T3ik+/xehxrxGt9PIUXP+y+QT7Akc1fpgw1km0flpyhRHx/4SRG5iplhzddgrjbYDJedVjp6f4338QvnsBozSsm/79QZWX6dRWmltQdg/AA3OZc6DU6+cqDYVEKrv7nhk7R+jdVoqKmwEXyB4QZBW8+cmb6/ X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7ea61284-dede-4a24-4131-08dc32a99446 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8822.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2024 06:51:49.9852 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8KTo4MvLOBC6WHQb85tToVXSx3B79qD+VskwcsQ/iliNHCYN4yyIjppWVF4vk74TFzrMigjMohWuEipVRXInCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9304 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791490386558958424 X-GMAIL-MSGID: 1791490386558958424 |
Series |
[v6,1/9] dt-bindings: usb: usbmisc-imx: add fsl,imx8ulp-usbmisc compatible
|
|
Commit Message
Xu Yang
Feb. 21, 2024, 2:58 p.m. UTC
As more and more NXP i.MX chips come out, it becomes harder to maintain
ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to
this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add
a new schema for NXP ChipIdea USB2 Controller.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
Changes in v6:
- new patch
---
.../bindings/usb/ci-hdrc-usb2-imx.yaml | 75 +++++++++++++++++++
1 file changed, 75 insertions(+)
create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml
Comments
On Wed, Feb 21, 2024 at 10:58:41PM +0800, Xu Yang wrote: > As more and more NXP i.MX chips come out, it becomes harder to maintain > ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to > this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add > a new schema for NXP ChipIdea USB2 Controller. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v6: > - new patch > --- > .../bindings/usb/ci-hdrc-usb2-imx.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > new file mode 100644 > index 000000000000..2ec62f564bf5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/usb/ci-hdrc-usb2-imx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP USB2 ChipIdea USB controller > + > +maintainers: > + - Xu Yang <xu.yang_2@nxp.com> > + > +properties: > + compatible: > + oneOf: > + - enum: > + - fsl,imx27-usb > + - items: > + - enum: > + - fsl,imx23-usb > + - fsl,imx25-usb > + - fsl,imx28-usb > + - fsl,imx35-usb > + - fsl,imx50-usb > + - fsl,imx51-usb > + - fsl,imx53-usb > + - fsl,imx6q-usb > + - fsl,imx6sl-usb > + - fsl,imx6sx-usb > + - fsl,imx6ul-usb > + - fsl,imx7d-usb > + - fsl,vf610-usb > + - const: fsl,imx27-usb > + - items: > + - enum: > + - fsl,imx8dxl-usb > + - fsl,imx8ulp-usb > + - const: fsl,imx7ulp-usb > + - const: fsl,imx6ul-usb > + - items: > + - enum: > + - fsl,imx8mm-usb > + - fsl,imx8mn-usb > + - const: fsl,imx7d-usb > + - const: fsl,imx27-usb > + - items: > + - enum: > + - fsl,imx6sll-usb > + - fsl,imx7ulp-usb > + - const: fsl,imx6ul-usb > + - const: fsl,imx27-usb Now you just duplicated all the compatibles, and now any new compatibles have to be added in 2 places. For this to work, you have to split ci-hdrc-usb2.yaml into 2 files. One with all the common properties and one with compatibles (minus imx). This is also needed if imx has any extra properties the other don't. Didn't I say this already? Rob
Hi Rob, > > On Wed, Feb 21, 2024 at 10:58:41PM +0800, Xu Yang wrote: > > As more and more NXP i.MX chips come out, it becomes harder to maintain > > ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to > > this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add > > a new schema for NXP ChipIdea USB2 Controller. > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > Changes in v6: > > - new patch > > --- > > .../bindings/usb/ci-hdrc-usb2-imx.yaml | 75 +++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci- > hdrc-usb2-imx.yaml > > new file mode 100644 > > index 000000000000..2ec62f564bf5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > > @@ -0,0 +1,75 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/usb/ci-hdrc- > usb2- > imx.yaml%23&data=05%7C02%7Cxu.yang_2%40nxp.com%7C4ac0c60cd4b4433f0f9f08dc34782572%7C686ea1d3bc2b4c6fa92c > d99c5c301635%7C0%7C0%7C638442937830606824%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=7p1DzvYmBsTgN44jypH7lc56z9hVBsFBYXUwsblk9z8%3D&reserv > ed=0 > > +$schema: http://devicetree.org/meta- > schemas%2Fcore.yaml%23&data=05%7C02%7Cxu.yang_2%40nxp.com%7C4ac0c60cd4b4433f0f9f08dc34782572%7C686ea1d3 > bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638442937830615622%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=fWWy9enbGK5yeKiovday7go3Gss5L%2F%2Fe%2F > OZcANny0QA%3D&reserved=0 > > + > > +title: NXP USB2 ChipIdea USB controller > > + > > +maintainers: > > + - Xu Yang <xu.yang_2@nxp.com> > > + > > +properties: > > + compatible: > > + oneOf: > > + - enum: > > + - fsl,imx27-usb > > + - items: > > + - enum: > > + - fsl,imx23-usb > > + - fsl,imx25-usb > > + - fsl,imx28-usb > > + - fsl,imx35-usb > > + - fsl,imx50-usb > > + - fsl,imx51-usb > > + - fsl,imx53-usb > > + - fsl,imx6q-usb > > + - fsl,imx6sl-usb > > + - fsl,imx6sx-usb > > + - fsl,imx6ul-usb > > + - fsl,imx7d-usb > > + - fsl,vf610-usb > > + - const: fsl,imx27-usb > > + - items: > > + - enum: > > + - fsl,imx8dxl-usb > > + - fsl,imx8ulp-usb > > + - const: fsl,imx7ulp-usb > > + - const: fsl,imx6ul-usb > > + - items: > > + - enum: > > + - fsl,imx8mm-usb > > + - fsl,imx8mn-usb > > + - const: fsl,imx7d-usb > > + - const: fsl,imx27-usb > > + - items: > > + - enum: > > + - fsl,imx6sll-usb > > + - fsl,imx7ulp-usb > > + - const: fsl,imx6ul-usb > > + - const: fsl,imx27-usb > > Now you just duplicated all the compatibles, and now any new compatibles > have to be added in 2 places. For this to work, you have to split > ci-hdrc-usb2.yaml into 2 files. One with all the common properties and > one with compatibles (minus imx). This is also needed if imx has any > extra properties the other don't. > > Didn't I say this already? > Yes, I know. But according to your words, I need to split ci-hdrc-usb2.yaml into 1 common file and more than 1 vendor specific files (imx, nvidia, qcom, nuvoton and others). In this patchset, I only focus on imx part and KK said he or someone will take over other parts, therefore I just duplicated all the imx compatibles. If I only create imx specific yaml file and remove all compatilbles from common file, nvidia, qcom, nuvoton and others compatible info will be lost, is this feasible? Or should I create mutiple vendor specific files at the same time? Thanks, Xu Yang
On Fri, Feb 23, 2024 at 7:56 AM Xu Yang <xu.yang_2@nxp.com> wrote: > > Hi Rob, > > > > > On Wed, Feb 21, 2024 at 10:58:41PM +0800, Xu Yang wrote: > > > As more and more NXP i.MX chips come out, it becomes harder to maintain > > > ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to > > > this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add > > > a new schema for NXP ChipIdea USB2 Controller. > > > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > > > --- > > > Changes in v6: > > > - new patch > > > --- > > > .../bindings/usb/ci-hdrc-usb2-imx.yaml | 75 +++++++++++++++++++ > > > 1 file changed, 75 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci- > > hdrc-usb2-imx.yaml > > > new file mode 100644 > > > index 000000000000..2ec62f564bf5 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > > > @@ -0,0 +1,75 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/usb/ci-hdrc- > > usb2- > > imx.yaml%23&data=05%7C02%7Cxu.yang_2%40nxp.com%7C4ac0c60cd4b4433f0f9f08dc34782572%7C686ea1d3bc2b4c6fa92c > > d99c5c301635%7C0%7C0%7C638442937830606824%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi > > LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=7p1DzvYmBsTgN44jypH7lc56z9hVBsFBYXUwsblk9z8%3D&reserv > > ed=0 > > > +$schema: http://devicetree.org/meta- > > schemas%2Fcore.yaml%23&data=05%7C02%7Cxu.yang_2%40nxp.com%7C4ac0c60cd4b4433f0f9f08dc34782572%7C686ea1d3 > > bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638442937830615622%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC > > JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=fWWy9enbGK5yeKiovday7go3Gss5L%2F%2Fe%2F > > OZcANny0QA%3D&reserved=0 > > > + > > > +title: NXP USB2 ChipIdea USB controller > > > + > > > +maintainers: > > > + - Xu Yang <xu.yang_2@nxp.com> > > > + > > > +properties: > > > + compatible: > > > + oneOf: > > > + - enum: > > > + - fsl,imx27-usb > > > + - items: > > > + - enum: > > > + - fsl,imx23-usb > > > + - fsl,imx25-usb > > > + - fsl,imx28-usb > > > + - fsl,imx35-usb > > > + - fsl,imx50-usb > > > + - fsl,imx51-usb > > > + - fsl,imx53-usb > > > + - fsl,imx6q-usb > > > + - fsl,imx6sl-usb > > > + - fsl,imx6sx-usb > > > + - fsl,imx6ul-usb > > > + - fsl,imx7d-usb > > > + - fsl,vf610-usb > > > + - const: fsl,imx27-usb > > > + - items: > > > + - enum: > > > + - fsl,imx8dxl-usb > > > + - fsl,imx8ulp-usb > > > + - const: fsl,imx7ulp-usb > > > + - const: fsl,imx6ul-usb > > > + - items: > > > + - enum: > > > + - fsl,imx8mm-usb > > > + - fsl,imx8mn-usb > > > + - const: fsl,imx7d-usb > > > + - const: fsl,imx27-usb > > > + - items: > > > + - enum: > > > + - fsl,imx6sll-usb > > > + - fsl,imx7ulp-usb > > > + - const: fsl,imx6ul-usb > > > + - const: fsl,imx27-usb > > > > Now you just duplicated all the compatibles, and now any new compatibles > > have to be added in 2 places. For this to work, you have to split > > ci-hdrc-usb2.yaml into 2 files. One with all the common properties and > > one with compatibles (minus imx). This is also needed if imx has any > > extra properties the other don't. > > > > Didn't I say this already? > > > > Yes, I know. > > But according to your words, I need to split ci-hdrc-usb2.yaml into 1 common > file and more than 1 vendor specific files (imx, nvidia, qcom, nuvoton and > others). In this patchset, I only focus on imx part and KK said he or someone > will take over other parts, therefore I just duplicated all the imx compatibles. This series is just wasting our time because it can't be applied without that. > If I only create imx specific yaml file and remove all compatilbles from common > file, nvidia, qcom, nuvoton and others compatible info will be lost, is this > feasible? Or should I create mutiple vendor specific files at the same time? You don't have to split each vendor to a separate vendor schema file. Just move everything common to ci-hdrc-usb2-common.yaml and add a reference to it. Then imx can reference the common file. Rob
On 23/02/2024 15:56, Xu Yang wrote: > Hi Rob, > >> >> On Wed, Feb 21, 2024 at 10:58:41PM +0800, Xu Yang wrote: >>> As more and more NXP i.MX chips come out, it becomes harder to maintain >>> ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to >>> this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add >>> a new schema for NXP ChipIdea USB2 Controller. >>> >>> Signed-off-by: Xu Yang <xu.yang_2@nxp.com> >>> >>> --- >>> Changes in v6: >>> - new patch >>> --- >>> .../bindings/usb/ci-hdrc-usb2-imx.yaml | 75 +++++++++++++++++++ >>> 1 file changed, 75 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci- >> hdrc-usb2-imx.yaml >>> new file mode 100644 >>> index 000000000000..2ec62f564bf5 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml >>> @@ -0,0 +1,75 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/usb/ci-hdrc- >> usb2- >> imx.yaml%23&data=05%7C02%7Cxu.yang_2%40nxp.com%7C4ac0c60cd4b4433f0f9f08dc34782572%7C686ea1d3bc2b4c6fa92c >> d99c5c301635%7C0%7C0%7C638442937830606824%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIi >> LCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=7p1DzvYmBsTgN44jypH7lc56z9hVBsFBYXUwsblk9z8%3D&reserv >> ed=0 >>> +$schema: http://devicetree.org/meta- >> schemas%2Fcore.yaml%23&data=05%7C02%7Cxu.yang_2%40nxp.com%7C4ac0c60cd4b4433f0f9f08dc34782572%7C686ea1d3 >> bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638442937830615622%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLC >> JQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata=fWWy9enbGK5yeKiovday7go3Gss5L%2F%2Fe%2F >> OZcANny0QA%3D&reserved=0 >>> + >>> +title: NXP USB2 ChipIdea USB controller >>> + >>> +maintainers: >>> + - Xu Yang <xu.yang_2@nxp.com> >>> + >>> +properties: >>> + compatible: >>> + oneOf: >>> + - enum: >>> + - fsl,imx27-usb >>> + - items: >>> + - enum: >>> + - fsl,imx23-usb >>> + - fsl,imx25-usb >>> + - fsl,imx28-usb >>> + - fsl,imx35-usb >>> + - fsl,imx50-usb >>> + - fsl,imx51-usb >>> + - fsl,imx53-usb >>> + - fsl,imx6q-usb >>> + - fsl,imx6sl-usb >>> + - fsl,imx6sx-usb >>> + - fsl,imx6ul-usb >>> + - fsl,imx7d-usb >>> + - fsl,vf610-usb >>> + - const: fsl,imx27-usb >>> + - items: >>> + - enum: >>> + - fsl,imx8dxl-usb >>> + - fsl,imx8ulp-usb >>> + - const: fsl,imx7ulp-usb >>> + - const: fsl,imx6ul-usb >>> + - items: >>> + - enum: >>> + - fsl,imx8mm-usb >>> + - fsl,imx8mn-usb >>> + - const: fsl,imx7d-usb >>> + - const: fsl,imx27-usb >>> + - items: >>> + - enum: >>> + - fsl,imx6sll-usb >>> + - fsl,imx7ulp-usb >>> + - const: fsl,imx6ul-usb >>> + - const: fsl,imx27-usb >> >> Now you just duplicated all the compatibles, and now any new compatibles >> have to be added in 2 places. For this to work, you have to split >> ci-hdrc-usb2.yaml into 2 files. One with all the common properties and >> one with compatibles (minus imx). This is also needed if imx has any >> extra properties the other don't. >> >> Didn't I say this already? >> > > Yes, I know. > > But according to your words, I need to split ci-hdrc-usb2.yaml into 1 common > file and more than 1 vendor specific files (imx, nvidia, qcom, nuvoton and > others). In this patchset, I only focus on imx part and KK said he or someone > will take over other parts, therefore I just duplicated all the imx compatibles. Someone will take over their bits, but it does not mean you can duplicate IMX. Why you cannot use the approach I asked - move IMX out of that schema? https://lore.kernel.org/all/a0134089-a283-488b-8d7f-3f59dd938b60@linaro.org/ Look: "... and move IMX to own file." Move is not "copy". Please run: `man mv` > If I only create imx specific yaml file and remove all compatilbles from common Why would you remove ALL of others? What is the point of this. > file, nvidia, qcom, nuvoton and others compatible info will be lost, is this > feasible? Or should I create mutiple vendor specific files at the same time? You can take a look how it is done in my recent Qualcomm PCI dt-bindings series. Best regards, Krzysztof
> > On 23/02/2024 15:56, Xu Yang wrote: > > Hi Rob, > > > >> > >> On Wed, Feb 21, 2024 at 10:58:41PM +0800, Xu Yang wrote: > >>> As more and more NXP i.MX chips come out, it becomes harder to maintain > >>> ci-hdrc-usb2.yaml if more stuffs like property restrictions are added to > >>> this file. This will separate i.MX parts out of ci-hdrc-usb2.yaml and add > >>> a new schema for NXP ChipIdea USB2 Controller. > >>> > >>> Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > >>> > >>> --- > >>> Changes in v6: > >>> - new patch > >>> --- > >>> .../bindings/usb/ci-hdrc-usb2-imx.yaml | 75 +++++++++++++++++++ > >>> 1 file changed, 75 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > b/Documentation/devicetree/bindings/usb/ci- > >> hdrc-usb2-imx.yaml > >>> new file mode 100644 > >>> index 000000000000..2ec62f564bf5 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml > >>> @@ -0,0 +1,75 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 [...] > > > If I only create imx specific yaml file and remove all compatilbles from common > > Why would you remove ALL of others? What is the point of this. I originally thought ci-hdrc-usb2.yaml should be removed and only ci-hdrc-usb2-comm.yaml is kept. So I'm not sure where other compatibles should go. I looked though your Qualcomm PCI dt-bindings series and now I know how to do. Thanks, Xu Yang
diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml new file mode 100644 index 000000000000..2ec62f564bf5 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-usb2-imx.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/usb/ci-hdrc-usb2-imx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP USB2 ChipIdea USB controller + +maintainers: + - Xu Yang <xu.yang_2@nxp.com> + +properties: + compatible: + oneOf: + - enum: + - fsl,imx27-usb + - items: + - enum: + - fsl,imx23-usb + - fsl,imx25-usb + - fsl,imx28-usb + - fsl,imx35-usb + - fsl,imx50-usb + - fsl,imx51-usb + - fsl,imx53-usb + - fsl,imx6q-usb + - fsl,imx6sl-usb + - fsl,imx6sx-usb + - fsl,imx6ul-usb + - fsl,imx7d-usb + - fsl,vf610-usb + - const: fsl,imx27-usb + - items: + - enum: + - fsl,imx8dxl-usb + - fsl,imx8ulp-usb + - const: fsl,imx7ulp-usb + - const: fsl,imx6ul-usb + - items: + - enum: + - fsl,imx8mm-usb + - fsl,imx8mn-usb + - const: fsl,imx7d-usb + - const: fsl,imx27-usb + - items: + - enum: + - fsl,imx6sll-usb + - fsl,imx7ulp-usb + - const: fsl,imx6ul-usb + - const: fsl,imx27-usb + +allOf: + - $ref: ci-hdrc-usb2.yaml# + +required: + - compatible + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/imx7d-clock.h> + + usb@30b10000 { + compatible = "fsl,imx7d-usb", "fsl,imx27-usb"; + reg = <0x30b10000 0x200>; + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX7D_USB_CTRL_CLK>; + fsl,usbphy = <&usbphynop1>; + fsl,usbmisc = <&usbmisc1 0>; + phy-clkgate-delay-us = <400>; + }; + +...