Message ID | 20240208172024.23625-4-shikemeng@huaweicloud.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-57735-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:50ea:b0:106:860b:bbdd with SMTP id r10csp45617dyd; Thu, 8 Feb 2024 01:27:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IETGGo/aSNzHprrdcz4QuZXbsVG5ZpZY3fFprYEz9WNelAZCeB5rAzBpZtDTB9JxD6tQh4w X-Received: by 2002:a05:6870:46a2:b0:219:4033:a215 with SMTP id a34-20020a05687046a200b002194033a215mr9244934oap.7.1707384471482; Thu, 08 Feb 2024 01:27:51 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707384471; cv=pass; d=google.com; s=arc-20160816; b=SvWSkoOqUMdlHjfRCfNbJDWbRl9wxk1Fiqvq2jlt7RW32FfwE49jS6bjM+DMglBC0g fEN27RhhuKiBLcExJR+vp6zQ1kH8ikU3RrmAFP0YFo6WIdBwbN61c30Himy4J7v0orAp cLHlcN/lhrHdu4xELm0YZVu0yVqr6YZK0Lk/N4jfLP29RjVc0RyEqrBWUnal9MAUSQOu AzIFjo6d6uv0y0cMXDiY6G1sXcA5o6SnB0vY/oSJRqwtIOx3kSkvdRdt/IS8v2OtDBGR r61MTgkgukqas5ggiTLcnf3sbeyUcgJo8IIX+NAGMSf176NPqa1caJo7TPGfIWt7r2Uv 9I0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from; bh=ktE1ckKOJCPNgXPXdi/5acIKqdJz5MC/I++Xo/qlKGw=; fh=lD/xcg9NMZOqk1752ymnnG6ybxgNzWHM2JXiHYWVuds=; b=ez22lCTOu6TfevlBZILES4oyIKUEGLrk9PdB9aksNVwsziMadFmt8IXgK7rEsU+Moc Lh6+2L3yoA79eV1uM9v1yD0MzlHZJcIbwRlggsE7aAZ5nyytAB23UFhUF7tCbA9ciw9z T+BoM3+eF8M7iUA7oP5gvZgDcRtB4Fm3nrqZ3TT208gZlnW4u7SzZipmDNTWJUr1byY/ xHOh3/7G6/kw03LQGqJKtsHalxhEqRJwhn3eB1wFoGxSFxCsWv/WUZbGG3QDUzcT3zL7 Nw7E3c78dzy/4b5lCu1t0i0wCIm37AKZta8rN40+Q5ZtvWbNWl/1fxxaKscSCBHHqfm7 zpDg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-57735-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57735-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=2; AJvYcCVfOpVcD76J8Q2IFPsZh1rhZhkTf3KFN4Uw2SWJz/7fK4EjjHhKRGqjpR+XxHQmNdnOnaHcFaC45QVZaLwdiDNoZtQbCw== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y28-20020a63b51c000000b005dc494e62d8si673864pge.543.2024.02.08.01.27.51 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Feb 2024 01:27:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-57735-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=huaweicloud.com); spf=pass (google.com: domain of linux-kernel+bounces-57735-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-57735-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 3F75A285051 for <ouuuleilei@gmail.com>; Thu, 8 Feb 2024 09:27:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0DC3D76418; Thu, 8 Feb 2024 09:23:16 +0000 (UTC) Received: from dggsgout12.his.huawei.com (unknown [45.249.212.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9C6DE6EB75; Thu, 8 Feb 2024 09:23:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.249.212.56 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707384193; cv=none; b=Q0iErvCqDvW3KYs22BjHOUgcMQi6NkHbJ3GMkwtqsrKM3cbEz7DfRTVPvm4kjGO5L0pP86hzTepIf7G3MDf7vBMf+wWdJwCH/BvPJ+zNaBtW6hEAfTz3d4pJoIcT2viup3NdHCf4bP8d2axUiD+/sscDzHsWTny2RnFPxNnVdjs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707384193; c=relaxed/simple; bh=5OM/RsInbbF774iZl5AEDt/9K4ap0ekY6wYxHcth7Gk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Dc3GtmuEfXfiMXMBiWiS5RIXMgA98zUznQvzK5CgWqtKrW4yYcAAC9OLMiEqtS1GcdZnDSsSAOBITtXxqRWgnXht7+nwiE+plHGtqkcRG3dxRVCYs7UrD3aABEKVLGI7Qt+OSvuDZt3qpdyUYqj+Thm/0/p3i1L8Go5KfVrDvhY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com; spf=pass smtp.mailfrom=huaweicloud.com; arc=none smtp.client-ip=45.249.212.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=huaweicloud.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huaweicloud.com Received: from mail.maildlp.com (unknown [172.19.163.216]) by dggsgout12.his.huawei.com (SkyGuard) with ESMTP id 4TVs3B6c7Cz4f3js1; Thu, 8 Feb 2024 17:23:02 +0800 (CST) Received: from mail02.huawei.com (unknown [10.116.40.75]) by mail.maildlp.com (Postfix) with ESMTP id 6BBC11A09D8; Thu, 8 Feb 2024 17:23:07 +0800 (CST) Received: from huaweicloud.com (unknown [10.175.124.27]) by APP2 (Coremail) with SMTP id Syh0CgAnSQx4ncRl3tGXDQ--.8574S5; Thu, 08 Feb 2024 17:23:07 +0800 (CST) From: Kemeng Shi <shikemeng@huaweicloud.com> To: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/7] fs/writeback: remove unused parameter wb of finish_writeback_work Date: Fri, 9 Feb 2024 01:20:20 +0800 Message-Id: <20240208172024.23625-4-shikemeng@huaweicloud.com> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20240208172024.23625-1-shikemeng@huaweicloud.com> References: <20240208172024.23625-1-shikemeng@huaweicloud.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: Syh0CgAnSQx4ncRl3tGXDQ--.8574S5 X-Coremail-Antispam: 1UD129KBjvJXoW7Ar1fCF47Jr4DtFWrKF1xZrb_yoW8JFyrpr y5Kr1DJFW2vr47KF4Duay2grnrK3ykKry3Gr4rWa12qr1SvF43Kay0gFy8tr1UJr9xZFWf Zr4vvrW8Jr40yr7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUBjb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M280x2IEY4vEnII2IxkI6r1a6r45M2 8IrcIa0xkI8VA2jI8067AKxVWUWwA2048vs2IY020Ec7CjxVAFwI0_Gr0_Xr1l8cAvFVAK 0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4 x0Y4vE2Ix0cI8IcVCY1x0267AKxVWxJVW8Jr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2 z4x0Y4vEx4A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4 xG64xvF2IEw4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v2 6r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x0EwI xGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E7480 Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7 IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1lIxAIcVCF04k2 6cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxV AFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07jy0PhUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790322379109647364 X-GMAIL-MSGID: 1790322379109647364 |
Series |
Fixes and cleanups to fs-writeback
|
|
Commit Message
Kemeng Shi
Feb. 8, 2024, 5:20 p.m. UTC
Remove unused parameter wb of finish_writeback_work.
Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
---
fs/fs-writeback.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
Comments
On Fri, 2024-02-09 at 01:20 +0800, Kemeng Shi wrote: > Remove unused parameter wb of finish_writeback_work. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Tim Chen <tim.c.chen@linux.intel.com> > --- > fs/fs-writeback.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index edb0cff51673..2619f74ced70 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb) > spin_unlock_irq(&wb->work_lock); > } > > -static void finish_writeback_work(struct bdi_writeback *wb, > - struct wb_writeback_work *work) > +static void finish_writeback_work(struct wb_writeback_work *work) > { > struct wb_completion *done = work->done; > > @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb, > list_add_tail(&work->list, &wb->work_list); > mod_delayed_work(bdi_wq, &wb->dwork, 0); > } else > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > > spin_unlock_irq(&wb->work_lock); > } > @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb) > while ((work = get_next_work_item(wb)) != NULL) { > trace_writeback_exec(wb, work); > wrote += wb_writeback(wb, work); > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > } > > /*
On Fri 09-02-24 01:20:20, Kemeng Shi wrote: > Remove unused parameter wb of finish_writeback_work. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Sure. Feel free to add: Reviewed-by: Jan Kara <jack@suse.cz> Honza > --- > fs/fs-writeback.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index edb0cff51673..2619f74ced70 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb) > spin_unlock_irq(&wb->work_lock); > } > > -static void finish_writeback_work(struct bdi_writeback *wb, > - struct wb_writeback_work *work) > +static void finish_writeback_work(struct wb_writeback_work *work) > { > struct wb_completion *done = work->done; > > @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb, > list_add_tail(&work->list, &wb->work_list); > mod_delayed_work(bdi_wq, &wb->dwork, 0); > } else > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > > spin_unlock_irq(&wb->work_lock); > } > @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb) > while ((work = get_next_work_item(wb)) != NULL) { > trace_writeback_exec(wb, work); > wrote += wb_writeback(wb, work); > - finish_writeback_work(wb, work); > + finish_writeback_work(work); > } > > /* > -- > 2.30.0 >
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index edb0cff51673..2619f74ced70 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -166,8 +166,7 @@ static void wb_wakeup_delayed(struct bdi_writeback *wb) spin_unlock_irq(&wb->work_lock); } -static void finish_writeback_work(struct bdi_writeback *wb, - struct wb_writeback_work *work) +static void finish_writeback_work(struct wb_writeback_work *work) { struct wb_completion *done = work->done; @@ -196,7 +195,7 @@ static void wb_queue_work(struct bdi_writeback *wb, list_add_tail(&work->list, &wb->work_list); mod_delayed_work(bdi_wq, &wb->dwork, 0); } else - finish_writeback_work(wb, work); + finish_writeback_work(work); spin_unlock_irq(&wb->work_lock); } @@ -2285,7 +2284,7 @@ static long wb_do_writeback(struct bdi_writeback *wb) while ((work = get_next_work_item(wb)) != NULL) { trace_writeback_exec(wb, work); wrote += wb_writeback(wb, work); - finish_writeback_work(wb, work); + finish_writeback_work(work); } /*