RISC-V: Point our Python scripts at python3

Message ID 20240209165323.20623-2-palmer@rivosinc.com
State Accepted
Headers
Series RISC-V: Point our Python scripts at python3 |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Palmer Dabbelt Feb. 9, 2024, 4:53 p.m. UTC
  This builds for me, and I frequently have python-is-python3 type
packages installed so I think I've been implicitly testing it for a
while.  Looks like Kito's tested similar configurations, and the
bugzilla indicates we should be moving over.

gcc/ChangeLog:

	PR 109668
	* config/riscv/arch-canonicalize: Move to python3
	* config/riscv/multilib-generator: Likewise
---
I am in no way a Python expert, but I think this is functionally a NOP
for the configurations I've been building/testing.  It's passing a
simple cross build.

---
 gcc/config/riscv/arch-canonicalize  | 2 +-
 gcc/config/riscv/multilib-generator | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
  

Comments

Jeff Law Feb. 13, 2024, 3:55 p.m. UTC | #1
On 2/9/24 09:53, Palmer Dabbelt wrote:
> This builds for me, and I frequently have python-is-python3 type
> packages installed so I think I've been implicitly testing it for a
> while.  Looks like Kito's tested similar configurations, and the
> bugzilla indicates we should be moving over.
> 
> gcc/ChangeLog:
> 
> 	PR 109668
> 	* config/riscv/arch-canonicalize: Move to python3
> 	* config/riscv/multilib-generator: Likewise
Just to summarize from the coordination call this morning.  We've agreed 
this should go forward.  While there is minor risk (this code is rarely 
run), it's something we're prepared to handle if there is fallout.

Jeff
  
Kito Cheng Feb. 23, 2024, 4:29 a.m. UTC | #2
I guess Palmer is too busy, so committed to trunk :P

On Tue, Feb 13, 2024 at 11:55 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>
>
>
> On 2/9/24 09:53, Palmer Dabbelt wrote:
> > This builds for me, and I frequently have python-is-python3 type
> > packages installed so I think I've been implicitly testing it for a
> > while.  Looks like Kito's tested similar configurations, and the
> > bugzilla indicates we should be moving over.
> >
> > gcc/ChangeLog:
> >
> >       PR 109668
> >       * config/riscv/arch-canonicalize: Move to python3
> >       * config/riscv/multilib-generator: Likewise
> Just to summarize from the coordination call this morning.  We've agreed
> this should go forward.  While there is minor risk (this code is rarely
> run), it's something we're prepared to handle if there is fallout.
>
> Jeff
  
Palmer Dabbelt Feb. 23, 2024, 5:24 p.m. UTC | #3
On Thu, 22 Feb 2024 20:29:37 PST (-0800), Kito Cheng wrote:
> I guess Palmer is too busy, so committed to trunk :P

Thanks, I got distracted with some work stuff ;)

>
> On Tue, Feb 13, 2024 at 11:55 PM Jeff Law <jeffreyalaw@gmail.com> wrote:
>>
>>
>>
>> On 2/9/24 09:53, Palmer Dabbelt wrote:
>> > This builds for me, and I frequently have python-is-python3 type
>> > packages installed so I think I've been implicitly testing it for a
>> > while.  Looks like Kito's tested similar configurations, and the
>> > bugzilla indicates we should be moving over.
>> >
>> > gcc/ChangeLog:
>> >
>> >       PR 109668
>> >       * config/riscv/arch-canonicalize: Move to python3
>> >       * config/riscv/multilib-generator: Likewise
>> Just to summarize from the coordination call this morning.  We've agreed
>> this should go forward.  While there is minor risk (this code is rarely
>> run), it's something we're prepared to handle if there is fallout.
>>
>> Jeff
  

Patch

diff --git a/gcc/config/riscv/arch-canonicalize b/gcc/config/riscv/arch-canonicalize
index 629bed85347..8f7d040cdeb 100755
--- a/gcc/config/riscv/arch-canonicalize
+++ b/gcc/config/riscv/arch-canonicalize
@@ -1,4 +1,4 @@ 
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 # Tool for canonical RISC-V architecture string.
 # Copyright (C) 2011-2024 Free Software Foundation, Inc.
diff --git a/gcc/config/riscv/multilib-generator b/gcc/config/riscv/multilib-generator
index 1a957878d0c..25cb6762ea7 100755
--- a/gcc/config/riscv/multilib-generator
+++ b/gcc/config/riscv/multilib-generator
@@ -1,4 +1,4 @@ 
-#!/usr/bin/env python
+#!/usr/bin/env python3
 
 # RISC-V multilib list generator.
 # Copyright (C) 2011-2024 Free Software Foundation, Inc.