Message ID | 20240222-clk-mv200-v3-2-f30795b50318@outlook.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-75123-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp1155673dyc; Wed, 21 Feb 2024 08:42:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX2SsWyCzVkPzWQ2U4SaLmpVydb9HJgyoZJHYRhz4L6L/lqDA4dm8KXCH3Db6i9v4XbQJrcApFgZ0OPacCEY3LPnZbbHg== X-Google-Smtp-Source: AGHT+IHkb+2pTxSUD3V6kX/1yyc2Smt0IaOfDmRvHLHymWZkNh2xe3EZO2NFjCPFNkHhi3lLcht3 X-Received: by 2002:a05:6214:2687:b0:68f:3c39:c63e with SMTP id gm7-20020a056214268700b0068f3c39c63emr16887032qvb.6.1708533770491; Wed, 21 Feb 2024 08:42:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708533770; cv=pass; d=google.com; s=arc-20160816; b=nvsd5LfthoMpvziUM+j6B3oyM6oUw6/jybm4+llo11t6GM/YbWtgjDXKOTWD4pyppx AvkbkQJLaoxNXez6VXQFEV+wFMVpZMQY5fFm7LN1iNDSNNmSBDtEIoTnVWnj4yKRwsdp lscJp04yCYLFkpj2ehbjghWS5FEiZV6/wkRi/EQzQWZX1g8YuLM3Pj3VFzU7UMeRsHjj QYWab40uRer7Qn3tuf7L+VKUta4mOWBRrJXJGQ5jKX6QeC22H0gu+T/vSKzHAfkZA+OB g0Ed4tH3zZrAMUSp88DGp4Af9kUcMN64FTGCVbR+JutNT7puc3eUHedIXo4CdjE326x0 eREw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=reply-to:cc:to:in-reply-to:references:message-id :content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:date:from:dkim-signature; bh=f+/hWReF2EDaOUOIFZdLzrZFalQGc5eGjIOAJfRWj30=; fh=61jQp11ptjJt97TUxWe8+hyuLMCiql6kVojnsyhWm9A=; b=C9V8K+mSpzkBqbruN1TbjCCUSKvTqhwB2ETPNCFRtZrM8n7AMoY7cLLLDZ3VoiaKLS 74Y0XWmxA6+mHeqJ6opM17ubv1qmRLWfDSgoru/cBrVuOW08Pdgjziagu1orY1G+1aOI 49njoIfN1XkRcysOtOiHMO/SwCC1Z9vjBhKW5QCd59GS9ooygrhGVg3InNOejcWMh0FE cKOB1/A+PCZeqrWcrXol7UDpa+TVyOSCAfS2BhFkM7q8Um6ksuinK5lsBHdYOsk4lm9T f4sArg8YuIxOHpK27vbS+EO2+kYunDsFEEabyRHhnmqYuKC0hUJfMRGRVnD9EZ70WyGN 0mOg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VfDJIHCe; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75123-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75123-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id hf1-20020a0562140e8100b0068f78b7739dsi6084804qvb.528.2024.02.21.08.42.50 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 08:42:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-75123-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VfDJIHCe; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-75123-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-75123-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 499C01C21B01 for <ouuuleilei@gmail.com>; Wed, 21 Feb 2024 16:42:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 53CD885268; Wed, 21 Feb 2024 16:41:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VfDJIHCe" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94DBE8062A; Wed, 21 Feb 2024 16:41:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708533681; cv=none; b=f8h0f+bq8GPcZa+jT323L0e4vPaQc235iV5fivnTbT56Vt1GZJfssqEkRZ3C5gp0llUeeS+LU461o2BmsnOT+brqRBuYETdlbuerDHingwLbIfsDQ6Wg05eD17p3AtRTzRV/UCD3cZILAjhXmyk0sYjY/c7ZoMvqCfFKH+EW0K0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708533681; c=relaxed/simple; bh=L1+xlxuXwgUWeDmdy7tXdySuBS1Cj2Lrew9vVB8GLAQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=q/1Gn5UmraGc+z+ZnSq0PoB9bhSRuuTuSZg3QNVYPID2OvoLBtGVvvBF6qSEZHapJZhLpollTuBp0X6C4bpzeDyR44Icy4LmoaFuX1EdmuCbj/6Sn31HZDmXANm/sqZ+CfkiZVqfAED52t7fdyD2TmzOIUJANFv/ENxjeuRIwD0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VfDJIHCe; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 4687DC43394; Wed, 21 Feb 2024 16:41:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708533681; bh=L1+xlxuXwgUWeDmdy7tXdySuBS1Cj2Lrew9vVB8GLAQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=VfDJIHCeJSvOQawjAI2kuNtRJQPzl8p3WZaO8kg0iYRDN81Fu1ZcfEqNxGnhDvla9 hOeC6YfOYV7NhndG2E3Dpp2RH8JqcXYuw+RSkU5SCmds18df9ZDdW1uLsv5nTCa/8c 3Bhs65rvoAsc3RMIE08MZDWWVOhgk1b4AA73BoUR+zP+FgsZkPBsZLDOQ8bsDKJ06N SX5sIkWCDfyzwdB75bG3wXI2Oh+c8iZDrvNTaEfHHZUbRGVWtCwnGWG1+5lzCfYj22 1qQhPxOvmzX1WwRLMG3udwxIrH1yNWK/IZ91yE9Xz6SF/MLZPMGDXeJsVkYkevOkMK wgGdSFocHB6Cw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F042C5478B; Wed, 21 Feb 2024 16:41:21 +0000 (UTC) From: Yang Xiwen via B4 Relay <devnull+forbidden405.outlook.com@kernel.org> Date: Thu, 22 Feb 2024 00:41:05 +0800 Subject: [PATCH v3 2/8] ARM: dts: hisilicon: add missing compatibles to CRG node Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240222-clk-mv200-v3-2-f30795b50318@outlook.com> References: <20240222-clk-mv200-v3-0-f30795b50318@outlook.com> In-Reply-To: <20240222-clk-mv200-v3-0-f30795b50318@outlook.com> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Xiwen <forbidden405@outlook.com> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708533664; l=766; i=forbidden405@outlook.com; s=20230724; h=from:subject:message-id; bh=tSrn3Xx19dNkcc4kh+ZnlOdA9N28v4ji6ZA0jvly4RQ=; b=5BCNDQfT7CjgnN2jJMO2HjSM6j0VK6bm+CdCgzfdrrknvjWDL3zs2VSGfNMtjj3l0/lNw+ty2 W9EU7FpZ9GMATHftPFrA4bNKEeHKJq62DDrU2GSkptjMtbKGq9kDWxK X-Developer-Key: i=forbidden405@outlook.com; a=ed25519; pk=qOD5jhp891/Xzc+H/PZ8LWVSWE3O/XCQnAg+5vdU2IU= X-Endpoint-Received: by B4 Relay for forbidden405@outlook.com/20230724 with auth_id=67 X-Original-From: Yang Xiwen <forbidden405@outlook.com> Reply-To: <forbidden405@outlook.com> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791527506936064523 X-GMAIL-MSGID: 1791527506936064523 |
Series |
clk: hisilicon: add support for Hi3798MV200
|
|
Commit Message
Yang Xiwen via B4 Relay
Feb. 21, 2024, 4:41 p.m. UTC
From: Yang Xiwen <forbidden405@outlook.com> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent binding changes. Signed-off-by: Yang Xiwen <forbidden405@outlook.com> --- arch/arm/boot/dts/hisilicon/hi3519.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > Add "syscon" and "simple-mfd" compatibles to CRG node due to recent > binding changes. Why? You claimed you added them in the bindings because DTS has them. In DTS you claim reason is: binding has them. That's confusing. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > arch/arm/boot/dts/hisilicon/hi3519.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/hisilicon/hi3519.dtsi b/arch/arm/boot/dts/hisilicon/hi3519.dtsi > index a42b71cdc5d7..da46e01b8fdc 100644 > --- a/arch/arm/boot/dts/hisilicon/hi3519.dtsi > +++ b/arch/arm/boot/dts/hisilicon/hi3519.dtsi > @@ -35,7 +35,7 @@ clk_3m: clk_3m { > }; > > crg: clock-reset-controller@12010000 { > - compatible = "hisilicon,hi3519-crg"; > + compatible = "hisilicon,hi3519-crg", "syscon", "simple-mfd"; Why? This does not make much sense. No children here, no usage as syscon. Best regards, Krzysztof
On 2/23/2024 2:08 AM, Krzysztof Kozlowski wrote: > On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent >> binding changes. > Why? You claimed you added them in the bindings because DTS has them. In > DTS you claim reason is: binding has them. > > That's confusing. Because the old txt based binding claimed there should not be a "syscon" and "simple-mfd". But it exists in hi3798cv200.dtsi. And i think it does no harm to be there. So should i do it in two commits? > >> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >> --- >> arch/arm/boot/dts/hisilicon/hi3519.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/hisilicon/hi3519.dtsi b/arch/arm/boot/dts/hisilicon/hi3519.dtsi >> index a42b71cdc5d7..da46e01b8fdc 100644 >> --- a/arch/arm/boot/dts/hisilicon/hi3519.dtsi >> +++ b/arch/arm/boot/dts/hisilicon/hi3519.dtsi >> @@ -35,7 +35,7 @@ clk_3m: clk_3m { >> }; >> >> crg: clock-reset-controller@12010000 { >> - compatible = "hisilicon,hi3519-crg"; >> + compatible = "hisilicon,hi3519-crg", "syscon", "simple-mfd"; > Why? This does not make much sense. No children here, no usage as syscon. > > > > Best regards, > Krzysztof >
On 22/02/2024 19:13, Yang Xiwen wrote: > On 2/23/2024 2:08 AM, Krzysztof Kozlowski wrote: >> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote: >>> From: Yang Xiwen <forbidden405@outlook.com> >>> >>> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent >>> binding changes. >> Why? You claimed you added them in the bindings because DTS has them. In >> DTS you claim reason is: binding has them. >> >> That's confusing. > > > Because the old txt based binding claimed there should not be a "syscon" > and "simple-mfd". > > > But it exists in hi3798cv200.dtsi. And i think it does no harm to be > there. So should i do it in two commits? hi3798cv200 is not hi3519, is it? You are adding simple-mfd to one SoC because some other has it? I don't see reason to do that. Er, why? Best regards, Krzysztof
On 2/23/2024 2:18 AM, Krzysztof Kozlowski wrote: > On 22/02/2024 19:13, Yang Xiwen wrote: >> On 2/23/2024 2:08 AM, Krzysztof Kozlowski wrote: >>> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote: >>>> From: Yang Xiwen <forbidden405@outlook.com> >>>> >>>> Add "syscon" and "simple-mfd" compatibles to CRG node due to recent >>>> binding changes. >>> Why? You claimed you added them in the bindings because DTS has them. In >>> DTS you claim reason is: binding has them. >>> >>> That's confusing. >> >> Because the old txt based binding claimed there should not be a "syscon" >> and "simple-mfd". >> >> >> But it exists in hi3798cv200.dtsi. And i think it does no harm to be >> there. So should i do it in two commits? > hi3798cv200 is not hi3519, is it? You are adding simple-mfd to one SoC > because some other has it? I don't see reason to do that. Er, why? I think it's the careless HiSilicon people who simply forgot to add it. CRG core on these SoCs are very similar. They only provided a bunch of clocks and resets. Some register offsets in them are even the same across SoCs. So I'll say all CRG devices are "syscon" and "simple-mfd". In fact, i do have TRM for Hi3519 so i can prove what i said is true. > > Best regards, > Krzysztof >
diff --git a/arch/arm/boot/dts/hisilicon/hi3519.dtsi b/arch/arm/boot/dts/hisilicon/hi3519.dtsi index a42b71cdc5d7..da46e01b8fdc 100644 --- a/arch/arm/boot/dts/hisilicon/hi3519.dtsi +++ b/arch/arm/boot/dts/hisilicon/hi3519.dtsi @@ -35,7 +35,7 @@ clk_3m: clk_3m { }; crg: clock-reset-controller@12010000 { - compatible = "hisilicon,hi3519-crg"; + compatible = "hisilicon,hi3519-crg", "syscon", "simple-mfd"; #clock-cells = <1>; #reset-cells = <2>; reg = <0x12010000 0x10000>;