diff mbox series

arm64: defconfig: Enable zram, xfs and loading compressed FW support

Message ID 20240221125928.3711050-1-javierm@redhat.com
State New
Headers
Series arm64: defconfig: Enable zram, xfs and loading compressed FW support |

Commit Message

Javier Martinez Canillas Feb. 21, 2024, 12:59 p.m. UTC 
  These options are needed by some Linux distributions (e.g: Fedora), so
let's enable them to make it easier for developers using such distros.

Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---

 arch/arm64/configs/defconfig | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Brian Masney Feb. 21, 2024, 2:02 p.m. UTC | #1 
On Wed, Feb 21, 2024 at 01:59:17PM +0100, Javier Martinez Canillas wrote:
> These options are needed by some Linux distributions (e.g: Fedora), so
> let's enable them to make it easier for developers using such distros.
> 
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>

Reviewed-by: Brian Masney <bmasney@redhat.com>
Arnd Bergmann Feb. 21, 2024, 3:31 p.m. UTC | #2 
On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
> These options are needed by some Linux distributions (e.g: Fedora), so
> let's enable them to make it easier for developers using such distros.
>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---

Acked-by: Arnd Bergmann <arnd@arndb.de>

> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>  CONFIG_EXT2_FS=y
>  CONFIG_EXT3_FS=y
>  CONFIG_EXT4_FS_POSIX_ACL=y
> +CONFIG_XFS_FS=m
>  CONFIG_BTRFS_FS=m
>  CONFIG_BTRFS_FS_POSIX_ACL=y

Unfortunately this will increase build time noticeably, but
I agree it is the right thing to do.

Can you send it (with any other acks) to soc@kernel.org so
I can merge it from there?

        Arnd
Krzysztof Kozlowski Feb. 21, 2024, 3:39 p.m. UTC | #3 
On 21/02/2024 16:31, Arnd Bergmann wrote:
> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>> These options are needed by some Linux distributions (e.g: Fedora), so
>> let's enable them to make it easier for developers using such distros.
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>> ---
> 
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> 
>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>  CONFIG_EXT2_FS=y
>>  CONFIG_EXT3_FS=y
>>  CONFIG_EXT4_FS_POSIX_ACL=y
>> +CONFIG_XFS_FS=m
>>  CONFIG_BTRFS_FS=m
>>  CONFIG_BTRFS_FS_POSIX_ACL=y
> 
> Unfortunately this will increase build time noticeably, but
> I agree it is the right thing to do.
> 
> Can you send it (with any other acks) to soc@kernel.org so
> I can merge it from there?

Due to XFS, please include:

Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

so this will not be precedence used for further patches like this
(Maxime already used such argument, so I want to be sure it will not be
used against me in the future)

Best regards,
Krzysztof
Maxime Ripard Feb. 21, 2024, 3:49 p.m. UTC | #4 
On Wed, Feb 21, 2024 at 04:39:18PM +0100, Krzysztof Kozlowski wrote:
> On 21/02/2024 16:31, Arnd Bergmann wrote:
> > On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
> >> These options are needed by some Linux distributions (e.g: Fedora), so
> >> let's enable them to make it easier for developers using such distros.
> >>
> >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> >> ---
> > 
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > 
> >> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
> >>  CONFIG_EXT2_FS=y
> >>  CONFIG_EXT3_FS=y
> >>  CONFIG_EXT4_FS_POSIX_ACL=y
> >> +CONFIG_XFS_FS=m
> >>  CONFIG_BTRFS_FS=m
> >>  CONFIG_BTRFS_FS_POSIX_ACL=y
> > 
> > Unfortunately this will increase build time noticeably, but
> > I agree it is the right thing to do.
> > 
> > Can you send it (with any other acks) to soc@kernel.org so
> > I can merge it from there?
> 
> Due to XFS, please include:
> 
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> so this will not be precedence used for further patches like this
> (Maxime already used such argument, so I want to be sure it will not be
> used against me in the future)

For the record, I didn't use anything against *you*. I'd just like
consistency over how defconfig rules are applied.

Maxime
Krzysztof Kozlowski Feb. 21, 2024, 3:52 p.m. UTC | #5 
On 21/02/2024 16:49, Maxime Ripard wrote:
> On Wed, Feb 21, 2024 at 04:39:18PM +0100, Krzysztof Kozlowski wrote:
>> On 21/02/2024 16:31, Arnd Bergmann wrote:
>>> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>>>> These options are needed by some Linux distributions (e.g: Fedora), so
>>>> let's enable them to make it easier for developers using such distros.
>>>>
>>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>>> ---
>>>
>>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>>>
>>>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>>>  CONFIG_EXT2_FS=y
>>>>  CONFIG_EXT3_FS=y
>>>>  CONFIG_EXT4_FS_POSIX_ACL=y
>>>> +CONFIG_XFS_FS=m
>>>>  CONFIG_BTRFS_FS=m
>>>>  CONFIG_BTRFS_FS_POSIX_ACL=y
>>>
>>> Unfortunately this will increase build time noticeably, but
>>> I agree it is the right thing to do.
>>>
>>> Can you send it (with any other acks) to soc@kernel.org so
>>> I can merge it from there?
>>
>> Due to XFS, please include:
>>
>> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> so this will not be precedence used for further patches like this
>> (Maxime already used such argument, so I want to be sure it will not be
>> used against me in the future)
> 
> For the record, I didn't use anything against *you*. I'd just like
> consistency over how defconfig rules are applied.

True, apologies if it seemed to harsh. I meant the discussion, so maybe
better:
"Maxime used such argument with discussion with me, so I want to be sure
there is no silent ack from me in the future."

Best regards,
Krzysztof
Javier Martinez Canillas Feb. 21, 2024, 7:06 p.m. UTC | #6 
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> writes:

> On 21/02/2024 16:31, Arnd Bergmann wrote:
>> On Wed, Feb 21, 2024, at 13:59, Javier Martinez Canillas wrote:
>>> These options are needed by some Linux distributions (e.g: Fedora), so
>>> let's enable them to make it easier for developers using such distros.
>>>
>>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>>> ---
>> 
>> Acked-by: Arnd Bergmann <arnd@arndb.de>
>> 
>>> @@ -1595,6 +1599,7 @@ CONFIG_HTE_TEGRA194_TEST=m
>>>  CONFIG_EXT2_FS=y
>>>  CONFIG_EXT3_FS=y
>>>  CONFIG_EXT4_FS_POSIX_ACL=y
>>> +CONFIG_XFS_FS=m
>>>  CONFIG_BTRFS_FS=m
>>>  CONFIG_BTRFS_FS_POSIX_ACL=y
>> 
>> Unfortunately this will increase build time noticeably, but
>> I agree it is the right thing to do.
>> 
>> Can you send it (with any other acks) to soc@kernel.org so
>> I can merge it from there?
>
> Due to XFS, please include:
>
> Nacked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>

Don't worry, I won't to re-send anything if you disagree with the change.

> so this will not be precedence used for further patches like this
> (Maxime already used such argument, so I want to be sure it will not be
> used against me in the future)
>

I used the same argument and is a fair one in my opinion. Removing other
filesystems should send the correct message, if that is the agreegment.
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 056a6cc546a4..12aebbba814e 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -241,6 +241,8 @@  CONFIG_PCI_EPF_TEST=m
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_FW_LOADER_USER_HELPER=y
+CONFIG_FW_LOADER_COMPRESS=y
+CONFIG_MODULE_COMPRESS_XZ=y
 CONFIG_HISILICON_LPC=y
 CONFIG_TEGRA_ACONNECT=m
 CONFIG_MHI_BUS_PCI_GENERIC=m
@@ -275,6 +277,8 @@  CONFIG_MTD_NAND_FSL_IFC=y
 CONFIG_MTD_NAND_QCOM=y
 CONFIG_MTD_SPI_NOR=y
 CONFIG_MTD_UBI=m
+CONFIG_ZRAM=m
+CONFIG_ZRAM_WRITEBACK=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_NBD=m
 CONFIG_VIRTIO_BLK=y
@@ -1595,6 +1599,7 @@  CONFIG_HTE_TEGRA194_TEST=m
 CONFIG_EXT2_FS=y
 CONFIG_EXT3_FS=y
 CONFIG_EXT4_FS_POSIX_ACL=y
+CONFIG_XFS_FS=m
 CONFIG_BTRFS_FS=m
 CONFIG_BTRFS_FS_POSIX_ACL=y
 CONFIG_FANOTIFY=y