Message ID | 20240213134817.3347574-1-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-63611-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp549296dyb; Tue, 13 Feb 2024 05:55:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXQcGgR6CXeiM24eIwB3vRpEvSbPCxrCtqTGP7yGSkk4p4T1zXfhLns/rfC96AEdn8upgra7MpwSyeC3gNfgsWtQ9/2Jg== X-Google-Smtp-Source: AGHT+IHRC/pdmKQXE9OClUDl/pFIuLCo7xkjtz7XnZ0smGhkhj49Cf8akE/goq6UNhJH7IyJjws+ X-Received: by 2002:a05:6a21:2d8f:b0:19e:cce1:ed7d with SMTP id ty15-20020a056a212d8f00b0019ecce1ed7dmr7797477pzb.32.1707832500524; Tue, 13 Feb 2024 05:55:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707832500; cv=pass; d=google.com; s=arc-20160816; b=YJjO05Gz3CBo3X4S3owC0sj295r72TKLXxiz92kYC3nyrrkymcC4TBT2K1vrKqDhXO +mXJrAt1D4kfSwc+yRxl/RrDaSPQ6xMqRTZqNMdYhxnBga7/8CnvbNCUwRZdpcO0BKPr gziKOkPMy0JYfW8J3R73yAQWkPL7v0sXFaairARJJv69xUX6ljaZEeEfeKhKnxbOk1OQ tHtlYHQMlKtXjgEMroMrpwFEcV/CupgQ9Py8DMsPx3krU59GySAO/krLD8lqE0LKJvqY tFkqWe4qxXSiL7JLxxu7AHFAY66gRBi7MbfAOZss5JfiIZ2fsNCnTD+wX2Z/RP7OSSP2 YDKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=UpWnTxzGRXvsxJXQzlWCOCHtfIK9W1L0F/UufqAvOK8=; fh=0qMpVSCIXJX3SjbKYSJi/O7na8o/8ChnCdhlaUvLrSY=; b=vaTCzE8GNbuxpNKS22jnaUn/L6secPS8bnjaBjKix99H6bNdlRc8EpG6P2tBpSmv3C Vx/FjYUiV02nGPFTsPeFLDaSunXOhMcNpqhZgXiyr/To0v5V/leaeCjti0tmidMHD/7G wJZHzSCjVxbigGc1cSbEx88xEvWOhq2hs9pq8yzAaN+58dXu9X+YDVAyWv5Ak1L5tpN4 2+hE78F0DJyTWPweVCUMfWGGElshLOjP+P23etEVDLaY61jgGpq/j6mi8PLAoVDWbwNQ M0HxMGigtJt8H20G+2St+TbsZDQHvg2u6G6vZ3vdRjZBkdbOcgYbaPH6T4Mizy8sgrwv t7Ew==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X2GzlSb8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63611-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63611-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCWA/TluYeWMWeUYRJTXqrG3udmEgCsr/sArFaxkdvsnc8eNQuwiJalUmOn1t3zuoqXA5U7zqRidRIKik5gySehLQ2QL0Q== Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id ix6-20020a170902f80600b001d8ca62ce0fsi1986842plb.637.2024.02.13.05.55.00 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 05:55:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-63611-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=X2GzlSb8; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-63611-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-63611-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 11BCAB21F71 for <ouuuleilei@gmail.com>; Tue, 13 Feb 2024 13:48:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id DFCFA56764; Tue, 13 Feb 2024 13:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="X2GzlSb8" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6533756465 for <linux-kernel@vger.kernel.org>; Tue, 13 Feb 2024 13:48:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707832105; cv=none; b=HQDiJBs9M+bL5X3MC9mgMyAkD9IFoXXZD+B4A100B2Fb6quQo/uPFnTDBezHYXsZnHd1H+W60ysm2fx4ELSsjDk6Zg3DFpUw4bgSjh3U1IspWIphjPn4b61JiXKqnQTA4oFzQjyFjW88MGmO/iY6LbGvG8ps1aj1bZysl+oYaaU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707832105; c=relaxed/simple; bh=26cXrqFjrg0ao0r9xUFAr1Dg4GgkrO8FmiGX8abfNuM=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=h/H7eS+0y8jT1BEwIXknVsZgrTgIie8/Tji39rtWjv4I/K7tuP00WIgrEokS8sHbeob836JbpPVvDV73+heWcwtUdPuAS5yTSZ7ngSNmlrNQTZ0MJ2vzZt/VPTbDevZp4ayOFvCbBqhf16sv5tTOgMT1tWhfCNxKpuoDBc3rvj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=X2GzlSb8; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A354C433C7; Tue, 13 Feb 2024 13:48:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707832103; bh=26cXrqFjrg0ao0r9xUFAr1Dg4GgkrO8FmiGX8abfNuM=; h=From:To:Cc:Subject:Date:From; b=X2GzlSb8rmaizrJ0LylQls2sNtypF+9i+aT25Vuuvh7WYZjxmctA3xM2UEvgXAHQ9 LkHZlxozy10NCqsfaltRaUMEVm1POUxpoifOXVzrPA/7gyXDeedg54An0zypsT5+Bm 5pL153obBaefWUE4e90RlGfLmnHfeYrp8lYPzkTZ+MQkti4KJPa6SEXkE2vy29EgEB ybIafh9Y/c0rAcuxQpDQ880xxUtDcVNVqnV34nzeQnDVi2C1vnRp07/VQKJO6SgBd1 mMfBjKc5K4eYKyYJPaorx6Ar5BXdJS9P2vSyOtN0fOwTUeorMq/U7/HBLji2sl0VHG CPPlBN4LzpySQ== From: Arnd Bergmann <arnd@kernel.org> To: Lucas De Marchi <lucas.demarchi@intel.com>, Oded Gabbay <ogabbay@kernel.org>, =?utf-8?q?Thomas_Hellstr=C3=B6m?= <thomas.hellstrom@linux.intel.com> Cc: Arnd Bergmann <arnd@arndb.de>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Matt Roper <matthew.d.roper@intel.com>, Matthew Brost <matthew.brost@intel.com>, Riana Tauro <riana.tauro@intel.com>, Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n Date: Tue, 13 Feb 2024 14:48:05 +0100 Message-Id: <20240213134817.3347574-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790792171843956523 X-GMAIL-MSGID: 1790792171843956523 |
Series |
drm/xe: skip building debugfs code for CONFIG_DEBUG_FS=n
|
|
Commit Message
Arnd Bergmann
Feb. 13, 2024, 1:48 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> Some of the debugfs functions are stubbed out in these configurations, so trying to build the .c file with the definition fails: In file included from include/uapi/linux/posix_types.h:5, from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27: drivers/gpu/drm/i915/display/intel_pipe_crc.c: At top level: include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void' 8 | #define NULL ((void *)0) | ^~~~ drivers/gpu/drm/i915/display/intel_pipe_crc.c:549:20: note: in expansion of macro 'intel_crtc_get_crc_sources' 549 | const char *const *intel_crtc_get_crc_sources(struct drm_crtc *crtc, | ^~~~~~~~~~~~~~~~~~~~~~~~~~ Stop trying to build them by making the Makefile entries conditional, same as for the i915 driver. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/xe/Makefile | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
Comments
On Tue, 13 Feb 2024, Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Some of the debugfs functions are stubbed out in these configurations, > so trying to build the .c file with the definition fails: > > In file included from include/uapi/linux/posix_types.h:5, > from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27: > drivers/gpu/drm/i915/display/intel_pipe_crc.c: At top level: > include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void' > 8 | #define NULL ((void *)0) > | ^~~~ > drivers/gpu/drm/i915/display/intel_pipe_crc.c:549:20: note: in expansion of macro 'intel_crtc_get_crc_sources' > 549 | const char *const *intel_crtc_get_crc_sources(struct drm_crtc *crtc, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~ > > Stop trying to build them by making the Makefile entries conditional, > same as for the i915 driver. Already fixed by commit 439987f6f471 ("drm/xe: don't build debugfs files when CONFIG_DEBUG_FS=n") in drm-xe-next. Maybe that needs to be picked up for -fixes? BR, Jani. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/gpu/drm/xe/Makefile | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile > index efcf0ab7a1a6..7c10ffdb7809 100644 > --- a/drivers/gpu/drm/xe/Makefile > +++ b/drivers/gpu/drm/xe/Makefile > @@ -213,8 +213,6 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ > i915-display/intel_ddi.o \ > i915-display/intel_ddi_buf_trans.o \ > i915-display/intel_display.o \ > - i915-display/intel_display_debugfs.o \ > - i915-display/intel_display_debugfs_params.o \ > i915-display/intel_display_device.o \ > i915-display/intel_display_driver.o \ > i915-display/intel_display_irq.o \ > @@ -258,7 +256,6 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ > i915-display/intel_modeset_setup.o \ > i915-display/intel_modeset_verify.o \ > i915-display/intel_panel.o \ > - i915-display/intel_pipe_crc.o \ > i915-display/intel_pmdemand.o \ > i915-display/intel_pps.o \ > i915-display/intel_psr.o \ > @@ -275,6 +272,13 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ > i915-display/skl_universal_plane.o \ > i915-display/skl_watermark.o > > +ifdef CONFIG_DEBUG_FS > +xe-$(CONFIG_DRM_XE_DISPLAY) += \ > + i915-display/intel_display_debugfs.o \ > + i915-display/intel_display_debugfs_params.o \ > + i915-display/intel_pipe_crc.o > +endif > + > ifeq ($(CONFIG_ACPI),y) > xe-$(CONFIG_DRM_XE_DISPLAY) += \ > i915-display/intel_acpi.o \
On Tue, Feb 13, 2024, at 15:55, Jani Nikula wrote: > On Tue, 13 Feb 2024, Arnd Bergmann <arnd@kernel.org> wrote: >> From: Arnd Bergmann <arnd@arndb.de> >> >> Some of the debugfs functions are stubbed out in these configurations, >> so trying to build the .c file with the definition fails: >> >> In file included from include/uapi/linux/posix_types.h:5, >> from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27: >> drivers/gpu/drm/i915/display/intel_pipe_crc.c: At top level: >> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void' >> 8 | #define NULL ((void *)0) >> | ^~~~ >> drivers/gpu/drm/i915/display/intel_pipe_crc.c:549:20: note: in expansion of macro 'intel_crtc_get_crc_sources' >> 549 | const char *const *intel_crtc_get_crc_sources(struct drm_crtc *crtc, >> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >> >> Stop trying to build them by making the Makefile entries conditional, >> same as for the i915 driver. > > Already fixed by commit 439987f6f471 ("drm/xe: don't build debugfs files > when CONFIG_DEBUG_FS=n") in drm-xe-next. > > Maybe that needs to be picked up for -fixes? I made sure that this still happens in linux-next today, but it does not seem to contain 439987f6f471. Arnd
+Stephen On Tue, Feb 13, 2024 at 03:58:54PM +0100, Arnd Bergmann wrote: >On Tue, Feb 13, 2024, at 15:55, Jani Nikula wrote: >> On Tue, 13 Feb 2024, Arnd Bergmann <arnd@kernel.org> wrote: >>> From: Arnd Bergmann <arnd@arndb.de> >>> >>> Some of the debugfs functions are stubbed out in these configurations, >>> so trying to build the .c file with the definition fails: >>> >>> In file included from include/uapi/linux/posix_types.h:5, >>> from drivers/gpu/drm/i915/display/intel_pipe_crc.c:27: >>> drivers/gpu/drm/i915/display/intel_pipe_crc.c: At top level: >>> include/linux/stddef.h:8:16: error: expected identifier or '(' before 'void' >>> 8 | #define NULL ((void *)0) >>> | ^~~~ >>> drivers/gpu/drm/i915/display/intel_pipe_crc.c:549:20: note: in expansion of macro 'intel_crtc_get_crc_sources' >>> 549 | const char *const *intel_crtc_get_crc_sources(struct drm_crtc *crtc, >>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~ >>> >>> Stop trying to build them by making the Makefile entries conditional, >>> same as for the i915 driver. >> >> Already fixed by commit 439987f6f471 ("drm/xe: don't build debugfs files >> when CONFIG_DEBUG_FS=n") in drm-xe-next. >> >> Maybe that needs to be picked up for -fixes? > >I made sure that this still happens in linux-next today, but >it does not seem to contain 439987f6f471. Looking at https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e it seems we still don't have drm-xe-next branch in linux-next. Stephen, could you please add it? Or do I have to do something on my end before that? This is the branch: https://gitlab.freedesktop.org/drm/xe/kernel drm-xe-next thanks Lucas De Marchi > > Arnd
Hi Lucas, On Tue, 20 Feb 2024 23:29:54 -0600 Lucas De Marchi <lucas.demarchi@intel.com> wrote: > > Looking at https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e > it seems we still don't have drm-xe-next branch in linux-next. > > Stephen, could you please add it? Or do I have to do something on my end > before that? This is the branch: > > https://gitlab.freedesktop.org/drm/xe/kernel drm-xe-next Added from tomorrow. Currently the only contact is yourself. Do you want anyone else (or a mailing list) as well? Do you want the drm-xe-fixes branch included as well? Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgement of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window. You will need to ensure that the patches/commits in your tree/series have been: * submitted under GPL v2 (or later) and include the Contributor's Signed-off-by, * posted to the relevant mailing list, * reviewed by you (or another maintainer of your subsystem tree), * successfully unit tested, and * destined for the current or next Linux merge window. Basically, this should be just what you would send to Linus (or ask him to fetch). It is allowed to be rebased if you deem it necessary.
On Wed, Feb 21, 2024 at 05:21:17PM +1100, Stephen Rothwell wrote: >Hi Lucas, > >On Tue, 20 Feb 2024 23:29:54 -0600 Lucas De Marchi <lucas.demarchi@intel.com> wrote: >> >> Looking at https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=2d5c7b7eb345249cb34d42cbc2b97b4c57ea944e >> it seems we still don't have drm-xe-next branch in linux-next. >> >> Stephen, could you please add it? Or do I have to do something on my end >> before that? This is the branch: >> >> https://gitlab.freedesktop.org/drm/xe/kernel drm-xe-next > >Added from tomorrow. Currently the only contact is yourself. Do you >want anyone else (or a mailing list) as well? > >Do you want the drm-xe-fixes branch included as well? I don't think it's needed since drm-xe-next covers what is in drm-xe-fixes. Please add other maintainers and mailing list: M: Oded Gabbay <ogabbay@kernel.org> M: Thomas Hellström <thomas.hellstrom@linux.intel.com> L: intel-xe@lists.freedesktop.org Looking at drm-intel and drm-misc, they are using a special for-linux-next. We may eventually adopt the same workflow, but I will have to check with other maintainers. thanks Lucas De Marchi > >Thanks for adding your subsystem tree as a participant of linux-next. As >you may know, this is not a judgement of your code. The purpose of >linux-next is for integration testing and to lower the impact of >conflicts between subsystems in the next merge window. > >You will need to ensure that the patches/commits in your tree/series have >been: > * submitted under GPL v2 (or later) and include the Contributor's > Signed-off-by, > * posted to the relevant mailing list, > * reviewed by you (or another maintainer of your subsystem tree), > * successfully unit tested, and > * destined for the current or next Linux merge window. > >Basically, this should be just what you would send to Linus (or ask him >to fetch). It is allowed to be rebased if you deem it necessary. > >-- >Cheers, >Stephen Rothwell >sfr@canb.auug.org.au
Hi Lucas, On Wed, 21 Feb 2024 13:45:35 -0600 Lucas De Marchi <lucas.demarchi@intel.com> wrote: > > I don't think it's needed since drm-xe-next covers what is in > drm-xe-fixes. Please add other maintainers and mailing list: > > M: Oded Gabbay <ogabbay@kernel.org> > M: Thomas Hellström <thomas.hellstrom@linux.intel.com> > L: intel-xe@lists.freedesktop.org Added.
On Wed, 21 Feb 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote: > Looking at drm-intel and drm-misc, they are using a special > for-linux-next. We may eventually adopt the same workflow, but I will > have to check with other maintainers. The idea is to try to better reflect what's actually going to next. For example, drm-intel-next starts targeting "next next" after about -rc6. But we haven't properly automated the cutoff point, it only kicks in at release. So there's still a window when linux-next sees "next next" stuff that gets dropped. Using drm-xe-next directly makes for a longer window. BR, Jani.
diff --git a/drivers/gpu/drm/xe/Makefile b/drivers/gpu/drm/xe/Makefile index efcf0ab7a1a6..7c10ffdb7809 100644 --- a/drivers/gpu/drm/xe/Makefile +++ b/drivers/gpu/drm/xe/Makefile @@ -213,8 +213,6 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_ddi.o \ i915-display/intel_ddi_buf_trans.o \ i915-display/intel_display.o \ - i915-display/intel_display_debugfs.o \ - i915-display/intel_display_debugfs_params.o \ i915-display/intel_display_device.o \ i915-display/intel_display_driver.o \ i915-display/intel_display_irq.o \ @@ -258,7 +256,6 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_modeset_setup.o \ i915-display/intel_modeset_verify.o \ i915-display/intel_panel.o \ - i915-display/intel_pipe_crc.o \ i915-display/intel_pmdemand.o \ i915-display/intel_pps.o \ i915-display/intel_psr.o \ @@ -275,6 +272,13 @@ xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/skl_universal_plane.o \ i915-display/skl_watermark.o +ifdef CONFIG_DEBUG_FS +xe-$(CONFIG_DRM_XE_DISPLAY) += \ + i915-display/intel_display_debugfs.o \ + i915-display/intel_display_debugfs_params.o \ + i915-display/intel_pipe_crc.o +endif + ifeq ($(CONFIG_ACPI),y) xe-$(CONFIG_DRM_XE_DISPLAY) += \ i915-display/intel_acpi.o \