diff mbox series

[v2,5/7] mmc: sdhci_am654: Update comments in sdhci_am654_set_clock

Message ID 20240207011520.3128382-6-jm@ti.com
State New
Headers
Series Add tuning algorithm for delay chain |

Commit Message

Judith Mendez Feb. 7, 2024, 1:15 a.m. UTC 
  The sdhci_am654_set_clock function is also used to enable
delay chain, therefore fix comments to be more generic in
case we are not enabling DLL.

Fixes: fe52e2fbc6ef ("mmc: sdhci_am654: Fix conditions for enabling dll")
Signed-off-by: Judith Mendez <jm@ti.com>
---
 drivers/mmc/host/sdhci_am654.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Adrian Hunter Feb. 16, 2024, 5:11 p.m. UTC | #1 
On 7/02/24 03:15, Judith Mendez wrote:
> The sdhci_am654_set_clock function is also used to enable
> delay chain, therefore fix comments to be more generic in
> case we are not enabling DLL.
> 
> Fixes: fe52e2fbc6ef ("mmc: sdhci_am654: Fix conditions for enabling dll")

Similar to patch 4, Fixes tag is probably not warranted.

> Signed-off-by: Judith Mendez <jm@ti.com>
> ---
>  drivers/mmc/host/sdhci_am654.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
> index 35ba7d921690..3755a015f328 100644
> --- a/drivers/mmc/host/sdhci_am654.c
> +++ b/drivers/mmc/host/sdhci_am654.c
> @@ -279,7 +279,7 @@ static void sdhci_am654_set_clock(struct sdhci_host *host, unsigned int clock)
>  
>  	sdhci_set_clock(host, clock);
>  
> -	/* Setup DLL Output TAP delay */
> +	/* Setup Output TAP delay */
>  	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>  
>  	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
> @@ -322,7 +322,7 @@ static void sdhci_j721e_4bit_set_clock(struct sdhci_host *host,
>  	u32 itap_del_ena;
>  	u32 mask, val;
>  
> -	/* Setup DLL Output TAP delay */
> +	/* Setup Output TAP delay */
>  	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>  
>  	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
Judith Mendez Feb. 20, 2024, 8:14 p.m. UTC | #2 
Hi Adrian,

On 2/16/24 11:11 AM, Adrian Hunter wrote:
> On 7/02/24 03:15, Judith Mendez wrote:
>> The sdhci_am654_set_clock function is also used to enable
>> delay chain, therefore fix comments to be more generic in
>> case we are not enabling DLL.
>>
>> Fixes: fe52e2fbc6ef ("mmc: sdhci_am654: Fix conditions for enabling dll")
> 
> Similar to patch 4, Fixes tag is probably not warranted.

Will fix for V3, thanks.

> 
>> Signed-off-by: Judith Mendez <jm@ti.com>
>> ---
>>   drivers/mmc/host/sdhci_am654.c | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
>> index 35ba7d921690..3755a015f328 100644
>> --- a/drivers/mmc/host/sdhci_am654.c
>> +++ b/drivers/mmc/host/sdhci_am654.c
>> @@ -279,7 +279,7 @@ static void sdhci_am654_set_clock(struct sdhci_host *host, unsigned int clock)
>>   
>>   	sdhci_set_clock(host, clock);
>>   
>> -	/* Setup DLL Output TAP delay */
>> +	/* Setup Output TAP delay */
>>   	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>>   
>>   	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
>> @@ -322,7 +322,7 @@ static void sdhci_j721e_4bit_set_clock(struct sdhci_host *host,
>>   	u32 itap_del_ena;
>>   	u32 mask, val;
>>   
>> -	/* Setup DLL Output TAP delay */
>> +	/* Setup Output TAP delay */
>>   	otap_del_sel = sdhci_am654->otap_del_sel[timing];
>>   
>>   	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
> 

~ Judith
diff mbox series

Patch

diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
index 35ba7d921690..3755a015f328 100644
--- a/drivers/mmc/host/sdhci_am654.c
+++ b/drivers/mmc/host/sdhci_am654.c
@@ -279,7 +279,7 @@  static void sdhci_am654_set_clock(struct sdhci_host *host, unsigned int clock)
 
 	sdhci_set_clock(host, clock);
 
-	/* Setup DLL Output TAP delay */
+	/* Setup Output TAP delay */
 	otap_del_sel = sdhci_am654->otap_del_sel[timing];
 
 	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
@@ -322,7 +322,7 @@  static void sdhci_j721e_4bit_set_clock(struct sdhci_host *host,
 	u32 itap_del_ena;
 	u32 mask, val;
 
-	/* Setup DLL Output TAP delay */
+	/* Setup Output TAP delay */
 	otap_del_sel = sdhci_am654->otap_del_sel[timing];
 
 	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;