diff mbox series

can: m_can: Add check for devm_clk_get

Message ID 20221123063651.26199-1-jiasheng@iscas.ac.cn
State New
Headers
Series can: m_can: Add check for devm_clk_get |

Commit Message

Jiasheng Jiang Nov. 23, 2022, 6:36 a.m. UTC 
  Since the devm_clk_get may return error,
it should be better to add check for the cdev->hclk,
as same as cdev->cclk.

Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
---
 drivers/net/can/m_can/m_can.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc Kleine-Budde Nov. 24, 2022, 2:44 p.m. UTC | #1 
On 23.11.2022 14:36:51, Jiasheng Jiang wrote:
> Since the devm_clk_get may return error,
> it should be better to add check for the cdev->hclk,
> as same as cdev->cclk.
> 
> Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>

Applied to linux-can.

Thanks,
Marc
diff mbox series

Patch

diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
index 00d11e95fd98..e5575d2755e4 100644
--- a/drivers/net/can/m_can/m_can.c
+++ b/drivers/net/can/m_can/m_can.c
@@ -1909,7 +1909,7 @@  int m_can_class_get_clocks(struct m_can_classdev *cdev)
 	cdev->hclk = devm_clk_get(cdev->dev, "hclk");
 	cdev->cclk = devm_clk_get(cdev->dev, "cclk");
 
-	if (IS_ERR(cdev->cclk)) {
+	if (IS_ERR(cdev->hclk) || IS_ERR(cdev->cclk)) {
 		dev_err(cdev->dev, "no clock found\n");
 		ret = -ENODEV;
 	}