diff mbox series

[v2,1/5] dt-bindings: memory-controller: st,stm32: add MP25 support

Message ID 20240219140202.85680-2-christophe.kerello@foss.st.com
State New
Headers
Series memory: stm32-fmc2-ebi: Add MP25 FMC2 support |

Commit Message

Christophe Kerello Feb. 19, 2024, 2:01 p.m. UTC 
  Add a new compatible string to support MP25 SoC.

On MP1 SoC, RNB signal (NAND controller signal) and NWAIT signal (PSRAM
controller signal) have been integrated together in the SoC. That means
that the NAND controller and the PSRAM controller (if the signal is
used) can not be used at the same time. On MP25 SoC, the 2 signals can
be used outside the SoC, so there is no more restrictions.

MP1 SoC also embeds revision 1.1 of the FMC2 IP when MP25 SoC embeds
revision 2.0 of the FMC2 IP.

MP25 SoC is also using PSCI OS-initiated mode, so allow a single
'power-domains' entry for STM32 FMC2. As MP1 will move on PSCI
OS-initiated mode, add this property as optional for all FMC2 variants.

Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com>
---
Changes in v2:
 - V1 patch 1 and 2 have been squashed and commit message has been updated.

 .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml     | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Feb. 20, 2024, 9:56 a.m. UTC | #1 
On 19/02/2024 15:01, Christophe Kerello wrote:
> Add a new compatible string to support MP25 SoC.
> 
> On MP1 SoC, RNB signal (NAND controller signal) and NWAIT signal (PSRAM
> controller signal) have been integrated together in the SoC. That means
> that the NAND controller and the PSRAM controller (if the signal is
> used) can not be used at the same time. On MP25 SoC, the 2 signals can
> be used outside the SoC, so there is no more restrictions.
> 
> MP1 SoC also embeds revision 1.1 of the FMC2 IP when MP25 SoC embeds
> revision 2.0 of the FMC2 IP.
> 

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 21, 2024, 8:27 a.m. UTC | #2 
On 20/02/2024 10:56, Krzysztof Kozlowski wrote:
> On 19/02/2024 15:01, Christophe Kerello wrote:
>> Add a new compatible string to support MP25 SoC.
>>
>> On MP1 SoC, RNB signal (NAND controller signal) and NWAIT signal (PSRAM
>> controller signal) have been integrated together in the SoC. That means
>> that the NAND controller and the PSRAM controller (if the signal is
>> used) can not be used at the same time. On MP25 SoC, the 2 signals can
>> be used outside the SoC, so there is no more restrictions.
>>
>> MP1 SoC also embeds revision 1.1 of the FMC2 IP when MP25 SoC embeds
>> revision 2.0 of the FMC2 IP.
>>
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 

Heh, that's actually a patch for me.

Un-acked.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
index 14f1833d37c9..84ac6f50a6fc 100644
--- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml
@@ -23,7 +23,9 @@  maintainers:
 
 properties:
   compatible:
-    const: st,stm32mp1-fmc2-ebi
+    enum:
+      - st,stm32mp1-fmc2-ebi
+      - st,stm32mp25-fmc2-ebi
 
   reg:
     maxItems: 1
@@ -34,6 +36,9 @@  properties:
   resets:
     maxItems: 1
 
+  power-domains:
+    maxItems: 1
+
   "#address-cells":
     const: 2