Message ID | 20240217-tab3-limit-usable-memory-range-v1-1-49cc9c86a5cc@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-70025-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:693c:2685:b0:108:e6aa:91d0 with SMTP id mn5csp467690dyc; Sat, 17 Feb 2024 11:03:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVv40kNOm1im48t/WBCjasth5VVqi3xXlrq9xYRVDNAO5sqZ8WCk8kAuN5Ux/Jy4BbW4Vorz0kDi/c4G2iPX63bV+LxqQ== X-Google-Smtp-Source: AGHT+IELKmmdgaarEqNadUZRgF/SPW6jzTlDs24t8MYa/kwaZpdbOUV1qt+c59yitsNuSzjuWdNK X-Received: by 2002:ac2:51a3:0:b0:511:7f2f:47a3 with SMTP id f3-20020ac251a3000000b005117f2f47a3mr5893434lfk.8.1708196588029; Sat, 17 Feb 2024 11:03:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708196588; cv=pass; d=google.com; s=arc-20160816; b=jcWJcC443wuO/R3cIRa9FSc/6YfUOEevuB7FrOw3A/JhiLsA9hfRNSTsR1RgIXcFrF d1pZLakbv/SqZp6QJljJuWJ/UNBU0c+9GXZMr7me+BbFmOotQjZi4z5Jdo+uChP9i0fg wyHOv93p7GpQ8xDZul8lBt4dCLBpijdeFlPpHkwbY58M4lElisaZOXPFZ+kvLGA2q2z4 hgmuHmbPnAVJO/IIl1e2y1b6MQ3JAmn461ziU1nV9RPobqQ1c1hvgayIZtg71RWiE9kI jdXRS7yNSLr09rveFPDha0+HtgIkm1cb/U0/wCJpLSinmGvjqEIK4i4LtfquFDJpGehy vz8A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:message-id:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:subject:date :from:dkim-signature; bh=4Lac2picLjLIoJIqmJ3jwHeZk9Y07zDWjhfc+5OdXmQ=; fh=r5IbzkzXQGy38MblmS6tAkGqqhY9UeUz9yjOTADJfDA=; b=iJHGcQqrIFtrfEBaL7fwS7f2ENY7tNkb/HvornmUrSy1p+YeEOhNTvuleHDv+bqF/V 9IIdy2RadMeMSxXNtS8JBnewYsq8xr4ZiNzmNdnp9rZuwmV1EDsgfNr0oN4Nj10HrkfG j/GecgWeVHXPuPH4KQ+wuLXoxZS7NPQVQ7fxKG7SdFaYTvJatPVaG3RLfiJtuyGY6Trn Yg/suJA4Izs/JBDiq5VjxbKEahqYDguO19hTb+SPMW1PVrEPLPoE0FNVxc49Ry3Jfjgh aJ8dZFpBmN1b4Br5Z/f0eS+EFQ6zDYo8fAraTGbuyAVD5i6wrUjTh2n8ylkKtYomhlaK /Z4Q==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XkdgYNN9; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-70025-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70025-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n5-20020a1709061d0500b00a3d6895b2d5si979329ejh.496.2024.02.17.11.03.07 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 11:03:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-70025-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=XkdgYNN9; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-70025-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-70025-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id A1AA71F23217 for <ouuuleilei@gmail.com>; Sat, 17 Feb 2024 19:03:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 30BAF7E581; Sat, 17 Feb 2024 19:02:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XkdgYNN9" Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 142AF6DCF5; Sat, 17 Feb 2024 19:02:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708196572; cv=none; b=OVFR4A3RemaiLuUm34SYMiV4I4ot7cGsyWM3RiTC5bcYB2jD71QTcNQvCdACmb5CfKX3FnnqzerFCCky1pdSKWp/pxblDIyYE9UFC3M7lDyzXgnipCcFqhvdm3CyK2slBxNgWThozOFD7rc5HLwcbKbHOKCHm+c+npxDMvHXfa8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708196572; c=relaxed/simple; bh=+gahNNXw/Pm22B5Zq6yjilwXg3lroxCbpY8aZXPC0Go=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=IhRe0AnBR/tCJHk+C/XLB7PwDDyiaZ2Y7hPdTMWMfD1QNiqT+71fuQux5/61wC9iVmOpQsJom5xXmE03QFIg3apo8JkGjNOl89teBJcZUpXdrjF5o9am+ggpU91qd9QMB5Vik7ZdzQ9dbB8J0LbmbRqNmsINOy9TZnN768TS5IM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XkdgYNN9; arc=none smtp.client-ip=209.85.208.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-563fe793e1cso1850319a12.3; Sat, 17 Feb 2024 11:02:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708196569; x=1708801369; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=4Lac2picLjLIoJIqmJ3jwHeZk9Y07zDWjhfc+5OdXmQ=; b=XkdgYNN9oirm/pltqghFaJLCsjqh67q+7fB8kSa6US8bBSrDOzgmehcuOq3QT15hlj Ru2MwBmFCnZaQzp2/GGXNDLZhIhUJB+nWUDbEr6+kKMyg+s2rKJh1yjky42QIY2u6a26 3NTRHs40aRa0E8SeHQwPaGmoJrEtBnaxYd2XRyPwwi7BE5kBFqpqj7vqpqyOMk8gF7WO fyQEFLyBH3K8ZF/I7BYQpc6zLdjiCkNL46QcrxlIbIMAY6AI1reHsROvDurO7SFWHPNJ XKOcPoRf0oNvKg/p8vNpne52iqS+W1/dK6KqHA9Z5ggY17P7J6tY3yi6JANGLvTzARZk qyDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708196569; x=1708801369; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4Lac2picLjLIoJIqmJ3jwHeZk9Y07zDWjhfc+5OdXmQ=; b=lQfTakS0X29Tgw90tuM/ruKKVwMnLaWYiS5/8NFdKNj+cdW9JLRNozZPKWCfhVSXZy QhJe7pHfN3FfftXSra9ZIwCS+P1BMH1SuvXP384kEHrHy5f33txMK7y5GRtePO6usBq7 YMK7UwR66jjH/ixeC5jxtkkWPVvZdL/pkZHS00hj5vrXZVLYjwz5mHoj9hCcouYNG+zu dxteiczJ2FCgizox47OAu3Mr1hC7QiPVXSgBvzrMEwJGX9RD7vGf+SD418Tz17CBU010 Lud0Qu7IhxIWvSQFnLVKNIS3UCK4GmAiIPMnO3Ekn3xP6T5XOvnEZAHwDvrijj3bt7qT CNEw== X-Forwarded-Encrypted: i=1; AJvYcCU+S0JYXf9xNJA6HDfQDBQhXLgsEf4RhpNUhnOulRlbnY9tiV3sGQd2VnpT/2KjQvkrho83KNVRFMCH3Xu16ypdV+BxmPtaGBuNu9AtwRWTM+rV5ocHloBm2EY7twjJT9kUFIJyatUSdrlVJblVlQU= X-Gm-Message-State: AOJu0Yxjzg1T7kMwlt4LjfAADOpyF9NDnjzhqPCDNIIk0vcEGRkdxwPb F4rOPERmWjymeVbEH/2e9xoWvs9R/I+QAAJ+0LWSEgJttFFVZhBC X-Received: by 2002:a17:906:d0c8:b0:a3e:3810:9e43 with SMTP id bq8-20020a170906d0c800b00a3e38109e43mr804180ejb.21.1708196569247; Sat, 17 Feb 2024 11:02:49 -0800 (PST) Received: from hex.my.domain (83.8.201.110.ipv4.supernova.orange.pl. [83.8.201.110]) by smtp.gmail.com with ESMTPSA id n26-20020a1709061d1a00b00a3e4ce615dfsm317769ejh.197.2024.02.17.11.02.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Feb 2024 11:02:48 -0800 (PST) From: Artur Weber <aweber.kernel@gmail.com> Date: Sat, 17 Feb 2024 20:02:47 +0100 Subject: [PATCH] ARM: dts: exynos4212-tab3: limit usable memory range Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240217-tab3-limit-usable-memory-range-v1-1-49cc9c86a5cc@gmail.com> X-B4-Tracking: v=1; b=H4sIANYC0WUC/x2N0QpAQBAAf0X7bMudK/Ir8nDcHlsO7SGSf3d5n JpmHogkTBGa7AGhkyOvSwKVZzBMdhkJ2SUGXWhTaFXhbvsSZw684xFtPxMGCqvcKL+tnPLe1m4 wxkGKbEKer3/Qdu/7ARq6LKhwAAAA To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com> Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Artur Weber <aweber.kernel@gmail.com> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1708196568; l=1185; i=aweber.kernel@gmail.com; s=20231030; h=from:subject:message-id; bh=+gahNNXw/Pm22B5Zq6yjilwXg3lroxCbpY8aZXPC0Go=; b=tZNoBo5ZsG/QVrkuKO4TO2NXuvdUYWYw6UF8A7eAE5hPJ1Y/QjjwPuwqKIFnNtAwt2PAeHRPg plW6pTjZszjASx/zTH5uq7Vy023lVkJTaOTCyCzjWrOmFWRxugBbWAH X-Developer-Key: i=aweber.kernel@gmail.com; a=ed25519; pk=RhDBfWbJEHqDibXbhNEBAnc9FMkyznGxX/hwfhL8bv8= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1791173945432735565 X-GMAIL-MSGID: 1791173945432735565 |
Series |
ARM: dts: exynos4212-tab3: limit usable memory range
|
|
Commit Message
Artur Weber
Feb. 17, 2024, 7:02 p.m. UTC
The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an
incorrect available memory range over ATAG_MEM. Limit the usable
memory in the DTS to prevent it from doing so, without having to
disable ATAG support.
Signed-off-by: Artur Weber <aweber.kernel@gmail.com>
---
arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++
1 file changed, 6 insertions(+)
---
base-commit: 0f1dd5e91e2ba3990143645faff2bcce2d99778e
change-id: 20240217-tab3-limit-usable-memory-range-1d1ffa8dc44d
Best regards,
Comments
Hi Artur, On Sat, Feb 17, 2024 at 08:02:47PM +0100, Artur Weber wrote: > The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an > incorrect available memory range over ATAG_MEM. Limit the usable > memory in the DTS to prevent it from doing so, without having to > disable ATAG support. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > --- > arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi > index e5254e32aa8f..9bc05961577d 100644 > --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi > @@ -45,6 +45,12 @@ chosen { > /* Default S-BOOT bootloader loads initramfs here */ > linux,initrd-start = <0x42000000>; > linux,initrd-end = <0x42800000>; > + > + /* > + * Stock bootloader provides incorrect memory size in ATAG_MEM; > + * override it here > + */ > + linux,usable-memory-range = <0x40000000 0x3fc00000>; Maybe it would make sense to set the memory reg to <0x40000000 0x60000000> (1.5 GiB) and move the comment about last 512(/516) MiB being weird/broken here instead. It looks a bit weird that the memory range and usable-memory-range are identical, and device tree should describe hardware, which technically has 1.5 GiB RAM. From a functional point of view it does not really matter, so in any case: Reviewed-by: Henrik Grimler <henrik@grimler.se> > }; > > firmware@204f000 { > > --- > base-commit: 0f1dd5e91e2ba3990143645faff2bcce2d99778e > change-id: 20240217-tab3-limit-usable-memory-range-1d1ffa8dc44d > > Best regards, > -- > Artur Weber <aweber.kernel@gmail.com> >
On 17/02/2024 20:02, Artur Weber wrote: > The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an > incorrect available memory range over ATAG_MEM. Limit the usable > memory in the DTS to prevent it from doing so, without having to > disable ATAG support. > > Signed-off-by: Artur Weber <aweber.kernel@gmail.com> > --- > arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi > index e5254e32aa8f..9bc05961577d 100644 > --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi > +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi > @@ -45,6 +45,12 @@ chosen { > /* Default S-BOOT bootloader loads initramfs here */ > linux,initrd-start = <0x42000000>; > linux,initrd-end = <0x42800000>; > + > + /* > + * Stock bootloader provides incorrect memory size in ATAG_MEM; > + * override it here > + */ > + linux,usable-memory-range = <0x40000000 0x3fc00000>; Applied and dropped: chosen: linux,usable-memory-range:0: [4611686019496935424] is too short Does not look you tested the bindings. Please observe that we have dedicated subsystem profile since a release: https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures Best regards, Krzysztof
On 19.02.2024 08:44, Krzysztof Kozlowski wrote: > On 17/02/2024 20:02, Artur Weber wrote: >> The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an >> incorrect available memory range over ATAG_MEM. Limit the usable >> memory in the DTS to prevent it from doing so, without having to >> disable ATAG support. >> >> Signed-off-by: Artur Weber <aweber.kernel@gmail.com> >> --- >> arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >> index e5254e32aa8f..9bc05961577d 100644 >> --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >> +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >> @@ -45,6 +45,12 @@ chosen { >> /* Default S-BOOT bootloader loads initramfs here */ >> linux,initrd-start = <0x42000000>; >> linux,initrd-end = <0x42800000>; >> + >> + /* >> + * Stock bootloader provides incorrect memory size in ATAG_MEM; >> + * override it here >> + */ >> + linux,usable-memory-range = <0x40000000 0x3fc00000>; > > Applied and dropped: > chosen: linux,usable-memory-range:0: [4611686019496935424] is too short This seems to be a binding issue; the DT schema expects a 64-bit memory address and size, and doesn't allow a 32-bit range. I've tested the DTS on my device and this property seems to be handled fine, so I think this should allow 32-bit values as well. I've opened a PR[1] against devicetree-org/dt-schema (where the schema for the chosen node is stored) to try and fix this. If my approach is incorrect, feel free to comment there as well. Best regards Artur [1] https://github.com/devicetree-org/dt-schema/pull/128 > > Does not look you tested the bindings. > > Please observe that we have dedicated subsystem profile since a release: > https://www.kernel.org/doc/html/latest/process/maintainers.html#arm-samsung-s3c-s5p-and-exynos-arm-architectures > > Best regards, > Krzysztof >
On 19/02/2024 20:49, Artur Weber wrote: > On 19.02.2024 08:44, Krzysztof Kozlowski wrote: >> On 17/02/2024 20:02, Artur Weber wrote: >>> The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an >>> incorrect available memory range over ATAG_MEM. Limit the usable >>> memory in the DTS to prevent it from doing so, without having to >>> disable ATAG support. >>> >>> Signed-off-by: Artur Weber <aweber.kernel@gmail.com> >>> --- >>> arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >>> index e5254e32aa8f..9bc05961577d 100644 >>> --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >>> +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >>> @@ -45,6 +45,12 @@ chosen { >>> /* Default S-BOOT bootloader loads initramfs here */ >>> linux,initrd-start = <0x42000000>; >>> linux,initrd-end = <0x42800000>; >>> + >>> + /* >>> + * Stock bootloader provides incorrect memory size in ATAG_MEM; >>> + * override it here >>> + */ >>> + linux,usable-memory-range = <0x40000000 0x3fc00000>; >> >> Applied and dropped: >> chosen: linux,usable-memory-range:0: [4611686019496935424] is too short > > This seems to be a binding issue; the DT schema expects a 64-bit memory > address and size, and doesn't allow a 32-bit range. I've tested the DTS > on my device and this property seems to be handled fine, so I think this > should allow 32-bit values as well. Regardless where is the issue: please test before sending. > > I've opened a PR[1] against devicetree-org/dt-schema (where the schema > for the chosen node is stored) to try and fix this. If my approach is > incorrect, feel free to comment there as well. According to Rob's comments, the DTS is the issue. Best regards, Krzysztof
On 21/02/2024 09:26, Krzysztof Kozlowski wrote: > On 19/02/2024 20:49, Artur Weber wrote: >> On 19.02.2024 08:44, Krzysztof Kozlowski wrote: >>> On 17/02/2024 20:02, Artur Weber wrote: >>>> The stock bootloader on the Samsung Galaxy Tab 3 8.0 provides an >>>> incorrect available memory range over ATAG_MEM. Limit the usable >>>> memory in the DTS to prevent it from doing so, without having to >>>> disable ATAG support. >>>> >>>> Signed-off-by: Artur Weber <aweber.kernel@gmail.com> >>>> --- >>>> arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >>>> index e5254e32aa8f..9bc05961577d 100644 >>>> --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >>>> +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi >>>> @@ -45,6 +45,12 @@ chosen { >>>> /* Default S-BOOT bootloader loads initramfs here */ >>>> linux,initrd-start = <0x42000000>; >>>> linux,initrd-end = <0x42800000>; >>>> + >>>> + /* >>>> + * Stock bootloader provides incorrect memory size in ATAG_MEM; >>>> + * override it here >>>> + */ >>>> + linux,usable-memory-range = <0x40000000 0x3fc00000>; >>> >>> Applied and dropped: >>> chosen: linux,usable-memory-range:0: [4611686019496935424] is too short >> >> This seems to be a binding issue; the DT schema expects a 64-bit memory >> address and size, and doesn't allow a 32-bit range. I've tested the DTS >> on my device and this property seems to be handled fine, so I think this >> should allow 32-bit values as well. > > Regardless where is the issue: please test before sending. > >> >> I've opened a PR[1] against devicetree-org/dt-schema (where the schema >> for the chosen node is stored) to try and fix this. If my approach is >> incorrect, feel free to comment there as well. > > > According to Rob's comments, the DTS is the issue. With updated dtschema I still see the same warning. Is something else missing? Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi index e5254e32aa8f..9bc05961577d 100644 --- a/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi +++ b/arch/arm/boot/dts/samsung/exynos4212-tab3.dtsi @@ -45,6 +45,12 @@ chosen { /* Default S-BOOT bootloader loads initramfs here */ linux,initrd-start = <0x42000000>; linux,initrd-end = <0x42800000>; + + /* + * Stock bootloader provides incorrect memory size in ATAG_MEM; + * override it here + */ + linux,usable-memory-range = <0x40000000 0x3fc00000>; }; firmware@204f000 {