[v2,2/2] dt-bindings: arm: rockchip: Add Toybrick TB-RK3588X

Message ID 20240218085314.658223-2-zhangzj@rock-chips.com
State New
Headers
Series [v2,1/2] arm64: dts: rockchip: Add devicetree support for TB-RK3588X board |

Commit Message

Elon Zhang Feb. 18, 2024, 8:53 a.m. UTC
  Add devicetree binding for Toybrick TB-RK3588X board from Rockchip Toybrick.

Signed-off-by: Elon Zhang <zhangzj@rock-chips.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Krzysztof Kozlowski Feb. 19, 2024, 8:15 a.m. UTC | #1
On 18/02/2024 09:53, Elon Zhang wrote:
> Add devicetree binding for Toybrick TB-RK3588X board from Rockchip Toybrick.
> 
> Signed-off-by: Elon Zhang <zhangzj@rock-chips.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 5cf5cbef2cf5..d29df97c7b25 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -878,6 +878,11 @@ properties:
>            - const: rockchip,rv1108-evb
>            - const: rockchip,rv1108
>  
> +      - description: Rockchip Toybrick TB-RK3588X board
> +        items:
> +          - const: rockchip,rk3588-toybrick-x0
> +          - const: rockchip,rk3588

Assuming you keep it in-order with existing ordering in this file:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
  
Weizhao Ouyang Feb. 19, 2024, 8:20 a.m. UTC | #2
On Sun, Feb 18, 2024 at 4:53 PM Elon Zhang <zhangzj@rock-chips.com> wrote:
>
> Add devicetree binding for Toybrick TB-RK3588X board from Rockchip Toybrick.
>
> Signed-off-by: Elon Zhang <zhangzj@rock-chips.com>

Reviewed-by: Weizhao Ouyang <weizhao.ouyang@arm.com>

BR,
Weizhao

> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 5cf5cbef2cf5..d29df97c7b25 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -878,6 +878,11 @@ properties:
>            - const: rockchip,rv1108-evb
>            - const: rockchip,rv1108
>
> +      - description: Rockchip Toybrick TB-RK3588X board
> +        items:
> +          - const: rockchip,rk3588-toybrick-x0
> +          - const: rockchip,rk3588
> +
>        - description: Theobroma Systems PX30-uQ7 with Haikou baseboard
>          items:
>            - const: tsd,px30-ringneck-haikou
> --
> 2.34.1
>
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 5cf5cbef2cf5..d29df97c7b25 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -878,6 +878,11 @@  properties:
           - const: rockchip,rv1108-evb
           - const: rockchip,rv1108
 
+      - description: Rockchip Toybrick TB-RK3588X board
+        items:
+          - const: rockchip,rk3588-toybrick-x0
+          - const: rockchip,rk3588
+
       - description: Theobroma Systems PX30-uQ7 with Haikou baseboard
         items:
           - const: tsd,px30-ringneck-haikou