| Message ID | 20221122202957.5748c6ce@endymion.delvare |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2404908wrr;
Tue, 22 Nov 2022 11:40:00 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf5diNYAk5GIU3/av7nvpAJLEpst1jFqqYZXuB2kCG4OHs8HR4hQsJtk8Z9FmZl597Uu2Z66
X-Received: by 2002:a17:906:fca7:b0:7ae:9677:d8dd with SMTP id
qw7-20020a170906fca700b007ae9677d8ddmr4568007ejb.71.1669146000716;
Tue, 22 Nov 2022 11:40:00 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1669146000; cv=none;
d=google.com; s=arc-20160816;
b=o5CLSACQ4ub5/lp6FqzWdgJ/ezSk4p3Rqxze4xINd8AuqAQRPPbyvJRohLCtFu8BVt
mI4q3pJi1s57pCBr8Tzg8+aJ08ttqeKGc0o18tEWbVDMKnG52e7TsVjbCPETDzkOrT/C
gh9xhGhM11nTerwRe7G0LOdtYnPBjBRACRzk+Cz/PFeg99JDq10qbJqUE1D9zDm/xQPP
Hf4zdy86nJb4ZIDE0i76fArYfU5VU0fYKPLG7lwexQXDmDrdHQJIhPKjiKGNQGYq91sa
vhbFXx7DhgIfk02Xs5xjO1KjCxWEyxr8J43DlpSONJHglIzFFxwytmw09AriYzKybuoA
nJKw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:organization:message-id:subject:cc:to:from:date:dkim-signature
:dkim-signature;
bh=BQQ6SkeM32iHC028rz7Wm1yS+iisemztI32hP0ps9jU=;
b=jB5lBTt7eFX5IVVn1QdS9SkIXxklDIi1zQTTrww2VvSjC3Vn5G0BRpkpCghKwFP7vy
KdyXCNlex49KWvpxihQKSbAGZ/8LjcXVNAsGdJYbwVSMIWTbUe0HPbzOZyUjdFBBEATf
7Atb8sUN18frgpql2FlVG67M3X3YRASvTrdVMUQfpI4ISSj7dluPqgg+TgsMl7gLISfw
mx6Y5qC2wkhHasivN8QgiD9iLKCR4gzeBFum7lvMtCjQ3DK7eegNMgpHJc8IX5nDHuCw
rKjNX1WIQ7j02wH70qnP9L2QDGaNemzoIRS+831CZyheA+l/qRL1IJZmFdxSCWMpecaG
e26w==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FCjayIvw;
dkim=neutral (no key) header.i=@suse.de;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
t14-20020a056402524e00b00461a32e0e38si5813213edd.306.2022.11.22.11.39.35;
Tue, 22 Nov 2022 11:40:00 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=FCjayIvw;
dkim=neutral (no key) header.i=@suse.de;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S234777AbiKVTaC (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others);
Tue, 22 Nov 2022 14:30:02 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52892 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234131AbiKVTaB (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 22 Nov 2022 14:30:01 -0500
Received: from smtp-out2.suse.de (smtp-out2.suse.de
[IPv6:2001:67c:2178:6::1d])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEE288FFAC
for <linux-kernel@vger.kernel.org>;
Tue, 22 Nov 2022 11:29:59 -0800 (PST)
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de
[192.168.254.74])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature ECDSA (P-521) server-digest
SHA512)
(No client certificate requested)
by smtp-out2.suse.de (Postfix) with ESMTPS id A99D31F45E;
Tue, 22 Nov 2022 19:29:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;
s=susede2_rsa;
t=1669145398;
h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=BQQ6SkeM32iHC028rz7Wm1yS+iisemztI32hP0ps9jU=;
b=FCjayIvwliwfmk0GVGX10IFFKAhL1ltEp2Bjy+yrUQT+cRbCdtuP8adisHT1oJjo1rSPGY
8Dfnx3isapFk5bP+5i/XiAh4gc6uN+Jkf+XdPn4A+FYG4FZ6CDllzzXBfkA0ueyLonONS7
6SvVLnTb7ve4O1qok9lnsobLI+E4xCc=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
s=susede2_ed25519; t=1669145398;
h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=BQQ6SkeM32iHC028rz7Wm1yS+iisemztI32hP0ps9jU=;
b=gc2svArjaTCcGNMKjNu7nlycDMQl4ozJKWl8dw4l944ZKTmHLMLgQxavirjnSVAz/arNG/
Asyq3qZukCuiJfCw==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de
[192.168.254.74])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature ECDSA (P-521) server-digest
SHA512)
(No client certificate requested)
by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 68FBD13B01;
Tue, 22 Nov 2022 19:29:58 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
by imap2.suse-dmz.suse.de with ESMTPSA
id j0DlFzYjfWNcEgAAMHmgww
(envelope-from <jdelvare@suse.de>); Tue, 22 Nov 2022 19:29:58 +0000
Date: Tue, 22 Nov 2022 20:29:57 +0100
From: Jean Delvare <jdelvare@suse.de>
To: linux-mtd@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>
Subject: [PATCH] mtd: onenand: omap2: Drop obsolete dependency on
COMPILE_TEST
Message-ID: <20221122202957.5748c6ce@endymion.delvare>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.32; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1750226436632142342?=
X-GMAIL-MSGID: =?utf-8?q?1750226436632142342?=
|
| Series |
mtd: onenand: omap2: Drop obsolete dependency on COMPILE_TEST
|
|
Commit Message
Jean Delvare
Nov. 22, 2022, 7:29 p.m. UTC
Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.
It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Vignesh Raghavendra <vigneshr@ti.com>
---
drivers/mtd/nand/onenand/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Tue, 2022-11-22 at 19:29:57 UTC, Jean Delvare wrote: > Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it > is possible to test-build any driver which depends on OF on any > architecture by explicitly selecting OF. Therefore depending on > COMPILE_TEST as an alternative is no longer needed. > > It is actually better to always build such drivers with OF enabled, > so that the test builds are closer to how each driver will actually be > built on its intended target. Building them without OF may not test > much as the compiler will optimize out potentially large parts of the > code. In the worst case, this could even pop false positive warnings. > Dropping COMPILE_TEST here improves the quality of our testing and > avoids wasting time on non-existent issues. > > Signed-off-by: Jean Delvare <jdelvare@suse.de> > Cc: Kyungmin Park <kyungmin.park@samsung.com> > Cc: Miquel Raynal <miquel.raynal@bootlin.com> > Cc: Richard Weinberger <richard@nod.at> > Cc: Vignesh Raghavendra <vigneshr@ti.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
--- linux-6.0.orig/drivers/mtd/nand/onenand/Kconfig +++ linux-6.0/drivers/mtd/nand/onenand/Kconfig @@ -25,7 +25,7 @@ config MTD_ONENAND_GENERIC config MTD_ONENAND_OMAP2 tristate "OneNAND on OMAP2/OMAP3 support" depends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && ARM) - depends on OF || COMPILE_TEST + depends on OF help Support for a OneNAND flash device connected to an OMAP2/OMAP3 SoC via the GPMC memory controller.