diff mbox series

leds: ktd2692: add gpiolib dependency

Message ID 20240213165602.2230970-1-arnd@kernel.org
State New
Headers
Series leds: ktd2692: add gpiolib dependency |

Commit Message

Arnd Bergmann Feb. 13, 2024, 4:55 p.m. UTC 
  From: Arnd Bergmann <arnd@arndb.de>

The expresswire module requires gpiolib, so anything selecting it
also needs this dependency:

WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
  Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
  Selected by [y]:
  - LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]

Fixes: e59a15af7aa6 ("leds: ktd2692: Convert to use ExpressWire library")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/leds/flash/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Thompson Feb. 15, 2024, 11:45 a.m. UTC | #1 
On Tue, Feb 13, 2024 at 05:55:50PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The expresswire module requires gpiolib, so anything selecting it
> also needs this dependency:
>
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
>   Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]
>
> Fixes: e59a15af7aa6 ("leds: ktd2692: Convert to use ExpressWire library")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.
Lee Jones Feb. 23, 2024, 3:35 p.m. UTC | #2 
On Tue, 13 Feb 2024 17:55:50 +0100, Arnd Bergmann wrote:
> The expresswire module requires gpiolib, so anything selecting it
> also needs this dependency:
> 
> WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE
>   Depends on [n]: NEW_LEDS [=y] && GPIOLIB [=n]
>   Selected by [y]:
>   - LEDS_KTD2692 [=y] && NEW_LEDS [=y] && LEDS_CLASS_FLASH [=y] && OF [=y]
> 
> [...]

Applied, thanks!

[1/1] leds: ktd2692: add gpiolib dependency
      commit: 52380f87d190e1e3f376f6a01d70bca753e81251

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
index 01998d71a6a2..809b6d98bb3e 100644
--- a/drivers/leds/flash/Kconfig
+++ b/drivers/leds/flash/Kconfig
@@ -23,6 +23,7 @@  config LEDS_AS3645A
 config LEDS_KTD2692
 	tristate "LED support for Kinetic KTD2692 flash LED controller"
 	depends on OF
+	depends on GPIOLIB
 	select LEDS_EXPRESSWIRE
 	help
 	  This option enables support for Kinetic KTD2692 LED flash connected