[v5,1/2] dt-bindings: i2c: pca954x: Add custom properties for MAX7357
Commit Message
From: Patrick Rudolph <patrick.rudolph@9elements.com>
Maxim Max7357 has a configuration register to enable additional
features. These features aren't enabled by default & its up to
board designer to enable the same as it may have unexpected side effects.
These should be validated for proper functioning & detection of devices
in secondary bus as sometimes it can cause secondary bus being disabled.
Add booleans for:
- maxim,isolate-stuck-channel
- maxim,send-flush-out-sequence
- maxim,preconnection-wiggle-test-enable
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Changes in V5:
- Append Reviewer-by
Changes in V4:
- Drop max7358.
Changes in V3:
- Update commit message
Changes in V2:
- Update properties.
---
.../bindings/i2c/i2c-mux-pca954x.yaml | 30 +++++++++++++++++++
1 file changed, 30 insertions(+)
base-commit: 957bd221ac7b2b56cbdf56739e3a94d4f479209e
Comments
Hi Naresh,
On Tue, Feb 13, 2024 at 07:52:26PM +0530, Naresh Solanki wrote:
> From: Patrick Rudolph <patrick.rudolph@9elements.com>
>
> Maxim Max7357 has a configuration register to enable additional
> features. These features aren't enabled by default & its up to
> board designer to enable the same as it may have unexpected side effects.
>
> These should be validated for proper functioning & detection of devices
> in secondary bus as sometimes it can cause secondary bus being disabled.
>
> Add booleans for:
> - maxim,isolate-stuck-channel
> - maxim,send-flush-out-sequence
> - maxim,preconnection-wiggle-test-enable
>
> Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
this series was already applied and I sent the notification.
Didn't you receive it?
You can check here[*] (branch i2c/i2c-host).
Thanks,
Andi
[*] https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git/log/?h=i2c/i2c-host
Hi Andi,
On Thu, 15 Feb 2024 at 02:42, Andi Shyti <andi.shyti@kernel.org> wrote:
>
> Hi Naresh,
>
> On Tue, Feb 13, 2024 at 07:52:26PM +0530, Naresh Solanki wrote:
> > From: Patrick Rudolph <patrick.rudolph@9elements.com>
> >
> > Maxim Max7357 has a configuration register to enable additional
> > features. These features aren't enabled by default & its up to
> > board designer to enable the same as it may have unexpected side effects.
> >
> > These should be validated for proper functioning & detection of devices
> > in secondary bus as sometimes it can cause secondary bus being disabled.
> >
> > Add booleans for:
> > - maxim,isolate-stuck-channel
> > - maxim,send-flush-out-sequence
> > - maxim,preconnection-wiggle-test-enable
> >
> > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
> > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
>
> this series was already applied and I sent the notification.
> Didn't you receive it?
>
> You can check here[*] (branch i2c/i2c-host).
Acknowledged. Thanks.
Regards,
Naresh
>
> Thanks,
> Andi
>
> [*] https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git/log/?h=i2c/i2c-host
@@ -71,6 +71,23 @@ properties:
description: A voltage regulator supplying power to the chip. On PCA9846
the regulator supplies power to VDD2 (core logic) and optionally to VDD1.
+ maxim,isolate-stuck-channel:
+ type: boolean
+ description: Allows to use non faulty channels while a stuck channel is
+ isolated from the upstream bus. If not set all channels are isolated from
+ the upstream bus until the fault is cleared.
+
+ maxim,send-flush-out-sequence:
+ type: boolean
+ description: Send a flush-out sequence to stuck auxiliary buses
+ automatically after a stuck channel is being detected.
+
+ maxim,preconnection-wiggle-test-enable:
+ type: boolean
+ description: Send a STOP condition to the auxiliary buses when the switch
+ register activates a channel to detect a stuck high fault. On fault the
+ channel is isolated from the upstream bus.
+
required:
- compatible
- reg
@@ -95,6 +112,19 @@ allOf:
"#interrupt-cells": false
interrupt-controller: false
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - maxim,max7357
+ then:
+ properties:
+ maxim,isolate-stuck-channel: false
+ maxim,send-flush-out-sequence: false
+ maxim,preconnection-wiggle-test-enable: false
+
unevaluatedProperties: false
examples: