| Message ID | 20240212174822.77734-3-christophe.kerello@foss.st.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-62134-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:bc8a:b0:106:860b:bbdd with SMTP id dn10csp73001dyb;
Mon, 12 Feb 2024 09:52:03 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IEjP9ETFLIKMwDo+PA+O2DQSIJRoJiuYea4A9BdsYCHmF+wWhGYawu9B7nEDbdq3FZ9Q84d
X-Received: by 2002:aa7:ce12:0:b0:561:d726:201 with SMTP id
d18-20020aa7ce12000000b00561d7260201mr1075924edv.10.1707760323044;
Mon, 12 Feb 2024 09:52:03 -0800 (PST)
ARC-Seal: i=2; a=rsa-sha256; t=1707760323; cv=pass;
d=google.com; s=arc-20160816;
b=id+hvODluQpyfKVX/xNZi9dZ7tlYKYWj9Wq60tEXz74LKKNUZ1I1eG/QsQ+mAOn/xG
D5nfaLbB/dx9ZF3nqCym86R5XeIBRLj2d0JIyEkYIIxJ2CYmUfA7JrG4shKR/tKybzOG
ZDVwNFqMv+YxuO6CsoFb/MGFxHacKYdoQuf1hvjRsTlrrDdXblF96apUvyLz2sZxCcoT
C7bmcGuSyXkSYYgKLeoVAlYXoA077pizibntOsZTmWYPAvmMM6fiXpJvqD0LZ772xRWh
8uMXcR/AGEQkdfmtHLjmXf7pc3VDpQiRiywz/WcM7CNXg/TNKHT/M0MDz5tWdhKGWX2Y
LGGg==
ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=X5FzM+bKH9CfiJVb/5vMppNol/5mtkgXoVYxjRsJvyc=;
fh=612RSkYqV/jrmiA59josNZZtyuFHCi2dx3pBmzAsmBM=;
b=0SDuZq6pegLxdySZqOC2Yy8/ACHqeykbp+lrqZSQE/xcE5n0HGdNh2ekEmqDpk5tBY
Tf102p7b0n1AYJQ0Fuy/xMvnfo2rDeoyPAc/lQWoQy8zkE/x6sQ2f6fFpWWD2DISdYMG
9IRRZ9UhJOrzV1tUUomkSxQfIZ6HVNmtgBFbkmeVjnAA2/jM01fUaP6tHHH88Yx4C7Zb
wfutta65BNIKNPE5avpsV9nksAl8+C57K3V78bvjnyMFrA8LnXaB/V2tSr8x4Fk0wVI0
ekgStf/TzW5JFCVzhNzSuRR2x3cEV5ZqA/WXV0G87uGH1YPYJAfmLbeWM73r4tGC5kVb
fCwA==;
dara=google.com
ARC-Authentication-Results: i=2; mx.google.com;
dkim=pass header.i=@foss.st.com header.s=selector1 header.b="z2/7CTCJ";
arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass
dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com);
spf=pass (google.com: domain of
linux-kernel+bounces-62134-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-62134-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com
X-Forwarded-Encrypted: i=2;
AJvYcCVIQN28WH3T8Y4l0m6WiagitY4W+NFECi+hhYzYAjjPAeywaPketCLxF9BwpU39fIih7sZiv/ZE0wrHITSu3a3HSxqcuA==
Received: from am.mirrors.kernel.org (am.mirrors.kernel.org.
[2604:1380:4601:e00::3])
by mx.google.com with ESMTPS id
x24-20020a50d618000000b00561b8eba0d6si1085668edi.484.2024.02.12.09.52.02
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 12 Feb 2024 09:52:03 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-62134-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Authentication-Results: mx.google.com;
dkim=pass header.i=@foss.st.com header.s=selector1 header.b="z2/7CTCJ";
arc=pass (i=1 spf=pass spfdomain=foss.st.com dkim=pass
dkdomain=foss.st.com dmarc=pass fromdomain=foss.st.com);
spf=pass (google.com: domain of
linux-kernel+bounces-62134-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:4601:e00::3 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-62134-ouuuleilei=gmail.com@vger.kernel.org";
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=foss.st.com
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by am.mirrors.kernel.org (Postfix) with ESMTPS id 9F63D1F21DB9
for <ouuuleilei@gmail.com>; Mon, 12 Feb 2024 17:52:02 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id E078545014;
Mon, 12 Feb 2024 17:50:47 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com
header.b="z2/7CTCJ"
Received: from mx07-00178001.pphosted.com (mx07-00178001.pphosted.com
[185.132.182.106])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6CF8E3F9CE;
Mon, 12 Feb 2024 17:50:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
arc=none smtp.client-ip=185.132.182.106
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
t=1707760245; cv=none;
b=ffoagSVdwvIw3XG1v/yFVeA9xNhfLGn3UlQyXLWeFFwN6bwHow9lcXG57Zx330WG0aDKNEYkY9w6+dTVyspXLt4383Sjr8Rfk4AiMhpUzSJcV+0GnCBENxvKuy1XJnoxGDrNYOuFc1CXP7M2nvaF7RCaVF91AZXRFkJbXPXxH0s=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
s=arc-20240116; t=1707760245; c=relaxed/simple;
bh=nqyn+NMPR3Qp4kmN/ffUDDJqekW6aeJgiis655KEkbA=;
h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:
MIME-Version:Content-Type;
b=tHlgIsZfe+TGCn7vEAnBO1xFJ3eKw+1ZAk6ZZoL/qzjh5uWLe8syod0o3zELnQWjUu6qwc1qRXg2XMumQdT+jA20J0UDRZKE2igQGlklxwB92j3+muU8zMSVf5x08lVx5Li/4V9IGM2XSeeN+KxQkJ/bB4rYl7UZJoL4S2/bNm8=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=foss.st.com;
spf=pass smtp.mailfrom=foss.st.com;
dkim=pass (2048-bit key) header.d=foss.st.com header.i=@foss.st.com
header.b=z2/7CTCJ; arc=none smtp.client-ip=185.132.182.106
Authentication-Results: smtp.subspace.kernel.org;
dmarc=pass (p=none dis=none) header.from=foss.st.com
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=foss.st.com
Received: from pps.filterd (m0369458.ppops.net [127.0.0.1])
by mx07-00178001.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id
41CEQj5x018688;
Mon, 12 Feb 2024 18:50:11 +0100
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=
selector1; bh=X5FzM+bKH9CfiJVb/5vMppNol/5mtkgXoVYxjRsJvyc=; b=z2
/7CTCJwgOTdOfiEWRG7uoiVStPGN4WnYG6/gHzmcZ/MkiK5Mu8+wP5bXfbU5kSbA
H8MWbiDT9zY0G6HqbWDiaAEjkyRXi/PhQ1df4v/cZwmfgoTzyVEPJ/OkSGUQtwQM
a46ZgVpMUFvNzGhSHutem3z03C7+yIWC1yOPRZl+u4hQTJmtZEQzuAkpBKjRL0RS
Cn7VHuTV2g+JLlVMgwk9+hpVsOc9pkX4myqYdFofMSwRFJDn1NzQpuOB/NZQdNPA
OBdoX5FmNYQaQ837RGpcPwBuUbffgrZdKeqRKIgmZ9SfSmby5i9qdTzJKX/zx0ea
DKVsx1tbOWyrZy4diD/Q==
Received: from beta.dmz-ap.st.com (beta.dmz-ap.st.com [138.198.100.35])
by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3w6kk4naxm-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);
Mon, 12 Feb 2024 18:50:10 +0100 (CET)
Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20])
by beta.dmz-ap.st.com (STMicroelectronics) with ESMTP id 073E44002D;
Mon, 12 Feb 2024 18:50:08 +0100 (CET)
Received: from Webmail-eu.st.com (shfdag1node3.st.com [10.75.129.71])
by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 66E49275757;
Mon, 12 Feb 2024 18:49:07 +0100 (CET)
Received: from localhost (10.201.22.200) by SHFDAG1NODE3.st.com (10.75.129.71)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 12 Feb
2024 18:49:07 +0100
From: Christophe Kerello <christophe.kerello@foss.st.com>
To: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<krzysztof.kozlowski@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>
CC: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<devicetree@vger.kernel.org>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Christophe Kerello
<christophe.kerello@foss.st.com>
Subject: [PATCH 02/12] dt-bindings: memory-controller: st,stm32: add
'power-domains' property
Date: Mon, 12 Feb 2024 18:48:12 +0100
Message-ID: <20240212174822.77734-3-christophe.kerello@foss.st.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20240212174822.77734-1-christophe.kerello@foss.st.com>
References: <20240212174822.77734-1-christophe.kerello@foss.st.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE3.st.com
(10.75.129.71)
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
definitions=2024-02-12_15,2024-02-12_03,2023-05-22_02
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1790716488228578763
X-GMAIL-MSGID: 1790716488228578763
|
| Series |
Add MP25 FMC2 support
|
|
Commit Message
Christophe Kerello
Feb. 12, 2024, 5:48 p.m. UTC
From: Patrick Delaunay <patrick.delaunay@foss.st.com> On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain. Allow a single 'power-domains' entry for STM32 FMC2. Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> --- .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 3 +++ 1 file changed, 3 insertions(+)
Comments
On Mon, Feb 12, 2024 at 06:48:12PM +0100, Christophe Kerello wrote: > From: Patrick Delaunay <patrick.delaunay@foss.st.com> > > On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain. > Allow a single 'power-domains' entry for STM32 FMC2. This should be squashed with patch 1, since they both modify the same file and this power-domain is part of the addition of mp25 support. If the mp1 doesn't have power domains, shouldn't you constrain the property to mp25 only? Cheers, Conor. > > Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> > --- > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml > index 12e6afeceffd..84ac6f50a6fc 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml > @@ -36,6 +36,9 @@ properties: > resets: > maxItems: 1 > > + power-domains: > + maxItems: 1 > + > "#address-cells": > const: 2 > > -- > 2.25.1 >
On 2/12/24 19:33, Conor Dooley wrote: > On Mon, Feb 12, 2024 at 06:48:12PM +0100, Christophe Kerello wrote: >> From: Patrick Delaunay <patrick.delaunay@foss.st.com> >> >> On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain. >> Allow a single 'power-domains' entry for STM32 FMC2. > > This should be squashed with patch 1, since they both modify the same > file and this power-domain is part of the addition of mp25 support. Hi Conor, Ok, I will squash this patch with patch 1. > > If the mp1 doesn't have power domains, shouldn't you constrain the > property to mp25 only? > As this property is optional, I do not see the need to constrain the property to MP25 only, but if you think that it should be the case, I will do it. Regards, Christophe Kerello. > Cheers, > Conor. > >> >> Signed-off-by: Patrick Delaunay <patrick.delaunay@foss.st.com> >> Signed-off-by: Christophe Kerello <christophe.kerello@foss.st.com> >> --- >> .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml >> index 12e6afeceffd..84ac6f50a6fc 100644 >> --- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml >> +++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml >> @@ -36,6 +36,9 @@ properties: >> resets: >> maxItems: 1 >> >> + power-domains: >> + maxItems: 1 >> + >> "#address-cells": >> const: 2 >> >> -- >> 2.25.1 >> >> >> ______________________________________________________ >> Linux MTD discussion mailing list >> http://lists.infradead.org/mailman/listinfo/linux-mtd/
On 13/02/2024 11:57, Christophe Kerello wrote: > > > On 2/12/24 19:33, Conor Dooley wrote: >> On Mon, Feb 12, 2024 at 06:48:12PM +0100, Christophe Kerello wrote: >>> From: Patrick Delaunay <patrick.delaunay@foss.st.com> >>> >>> On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain. >>> Allow a single 'power-domains' entry for STM32 FMC2. >> >> This should be squashed with patch 1, since they both modify the same >> file and this power-domain is part of the addition of mp25 support. > > Hi Conor, > > Ok, I will squash this patch with patch 1. > >> >> If the mp1 doesn't have power domains, shouldn't you constrain the >> property to mp25 only? >> > > As this property is optional, I do not see the need to constrain the > property to MP25 only, but if you think that it should be the case, I > will do it. The question is: is this property valid for the old/existing variant? Best regards, Krzysztof
On 2/13/24 12:57, Krzysztof Kozlowski wrote: > On 13/02/2024 11:57, Christophe Kerello wrote: >> >> >> On 2/12/24 19:33, Conor Dooley wrote: >>> On Mon, Feb 12, 2024 at 06:48:12PM +0100, Christophe Kerello wrote: >>>> From: Patrick Delaunay <patrick.delaunay@foss.st.com> >>>> >>>> On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain. >>>> Allow a single 'power-domains' entry for STM32 FMC2. >>> >>> This should be squashed with patch 1, since they both modify the same >>> file and this power-domain is part of the addition of mp25 support. >> >> Hi Conor, >> >> Ok, I will squash this patch with patch 1. >> >>> >>> If the mp1 doesn't have power domains, shouldn't you constrain the >>> property to mp25 only? >>> >> >> As this property is optional, I do not see the need to constrain the >> property to MP25 only, but if you think that it should be the case, I >> will do it. > > The question is: is this property valid for the old/existing variant? > Hi Krzysztof, It is not currently valid but there is a plan to move MP1 on PSCI OS-initiated. Regards, Christophe Kerello. > Best regards, > Krzysztof >
On 13/02/2024 16:57, Christophe Kerello wrote: > > > On 2/13/24 12:57, Krzysztof Kozlowski wrote: >> On 13/02/2024 11:57, Christophe Kerello wrote: >>> >>> >>> On 2/12/24 19:33, Conor Dooley wrote: >>>> On Mon, Feb 12, 2024 at 06:48:12PM +0100, Christophe Kerello wrote: >>>>> From: Patrick Delaunay <patrick.delaunay@foss.st.com> >>>>> >>>>> On STM32MP25 SOC, STM32 FMC2 memory controller is in a power domain. >>>>> Allow a single 'power-domains' entry for STM32 FMC2. >>>> >>>> This should be squashed with patch 1, since they both modify the same >>>> file and this power-domain is part of the addition of mp25 support. >>> >>> Hi Conor, >>> >>> Ok, I will squash this patch with patch 1. >>> >>>> >>>> If the mp1 doesn't have power domains, shouldn't you constrain the >>>> property to mp25 only? >>>> >>> >>> As this property is optional, I do not see the need to constrain the >>> property to MP25 only, but if you think that it should be the case, I >>> will do it. >> >> The question is: is this property valid for the old/existing variant? >> > > Hi Krzysztof, > > It is not currently valid but there is a plan to move MP1 on PSCI > OS-initiated. OK Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml index 12e6afeceffd..84ac6f50a6fc 100644 --- a/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/st,stm32-fmc2-ebi.yaml @@ -36,6 +36,9 @@ properties: resets: maxItems: 1 + power-domains: + maxItems: 1 + "#address-cells": const: 2