[v1,01/10] dt-bindings: soc: rockchip: add clock to RK3588 VO grf

Message ID 20240209181831.104687-2-sebastian.reichel@collabora.com
State New
Headers
Series RK3588 USBDP support |

Commit Message

Sebastian Reichel Feb. 9, 2024, 6:17 p.m. UTC
  The RK3588 VO GRF needs a clock. This adds the clock to the allowed
properties, makes it mandatory for the RK3588 VO grf and disallows it
for any other Rockchip grf.

Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 .../devicetree/bindings/soc/rockchip/grf.yaml | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
  

Comments

Conor Dooley Feb. 11, 2024, 5:27 p.m. UTC | #1
On Fri, Feb 09, 2024 at 07:17:17PM +0100, Sebastian Reichel wrote:
> The RK3588 VO GRF needs a clock. This adds the clock to the allowed
> properties, makes it mandatory for the RK3588 VO grf and disallows it
> for any other Rockchip grf.
> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
  

Patch

diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
index 9793ea6f0fe6..20bc1f46384c 100644
--- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
+++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
@@ -66,6 +66,9 @@  properties:
   reg:
     maxItems: 1
 
+  clocks:
+    maxItems: 1
+
   "#address-cells":
     const: 1
 
@@ -248,6 +251,22 @@  allOf:
 
           unevaluatedProperties: false
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - rockchip,rk3588-vo-grf
+
+    then:
+      required:
+        - clocks
+
+    else:
+      properties:
+        clocks: false
+
+
 examples:
   - |
     #include <dt-bindings/clock/rk3399-cru.h>