[v1,9/9] arm64: dts: ti: k3-am6*: Fix bootph-all property in MMC node

Message ID 20240207225526.3953230-10-jm@ti.com
State New
Headers
Series Fix MMC properties on Sitara devices |

Commit Message

Judith Mendez Feb. 7, 2024, 10:55 p.m. UTC
  Add missing bootph-all property for AM62p MMC0 and AM64x
MMC0 nodes.

Move the location of bootph-all property in MMC1 for
k3-am62p5-sk to match Sitara board files.

Signed-off-by: Judith Mendez <jm@ti.com>
---
 arch/arm64/boot/dts/ti/k3-am62p5-sk.dts | 3 ++-
 arch/arm64/boot/dts/ti/k3-am642-evm.dts | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)
  

Comments

Nishanth Menon Feb. 9, 2024, 5:27 p.m. UTC | #1
On 16:55-20240207, Judith Mendez wrote:
>  &sdhci1 {
>  	/* SD/MMC */
> +	bootph-all;
>  	status = "okay";
>  	vmmc-supply = <&vdd_mmc1>;
>  	vqmmc-supply = <&vddshv_sdio>;
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&main_mmc1_pins_default>;
>  	disable-wp;
> -	bootph-all;

NAK! Read [1]


[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
  
Judith Mendez Feb. 9, 2024, 10:27 p.m. UTC | #2
Hi Nishanth,

On 2/9/24 11:27 AM, Nishanth Menon wrote:
> On 16:55-20240207, Judith Mendez wrote:
>>   &sdhci1 {
>>   	/* SD/MMC */
>> +	bootph-all;
>>   	status = "okay";
>>   	vmmc-supply = <&vdd_mmc1>;
>>   	vqmmc-supply = <&vddshv_sdio>;
>>   	pinctrl-names = "default";
>>   	pinctrl-0 = <&main_mmc1_pins_default>;
>>   	disable-wp;
>> -	bootph-all;
> 
> NAK! Read [1]
> 
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n117
> 

No worries, I can remove this change.

~ Judith
  

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
index 5c9b73726ebd..17c6c2fc0e09 100644
--- a/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am62p5-sk.dts
@@ -410,6 +410,7 @@  &main_i2c2 {
 };
 
 &sdhci0 {
+	bootph-all;
 	status = "okay";
 	ti,driver-strength-ohm = <50>;
 	disable-wp;
@@ -417,13 +418,13 @@  &sdhci0 {
 
 &sdhci1 {
 	/* SD/MMC */
+	bootph-all;
 	status = "okay";
 	vmmc-supply = <&vdd_mmc1>;
 	vqmmc-supply = <&vddshv_sdio>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&main_mmc1_pins_default>;
 	disable-wp;
-	bootph-all;
 };
 
 &cpsw3g {
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 83f2b00726b5..84619782e52d 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -493,6 +493,7 @@  eeprom@0 {
 
 /* eMMC */
 &sdhci0 {
+	bootph-all;
 	status = "okay";
 	non-removable;
 	ti,driver-strength-ohm = <50>;