Message ID | 20240207102802.200220-2-dharma.b@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-56316-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp2133685dyb; Wed, 7 Feb 2024 02:30:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQbl08AL+c8z0UyPXZrx9ctDZ1t7hdSYU5+2minZhKFGJBu4xjc3CgEez9OuuEPEYnhAgg X-Received: by 2002:a17:90b:1b12:b0:296:d6e9:89e8 with SMTP id nu18-20020a17090b1b1200b00296d6e989e8mr2486089pjb.45.1707301807329; Wed, 07 Feb 2024 02:30:07 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707301807; cv=pass; d=google.com; s=arc-20160816; b=wc+2X/40QMLuzCx07L0blFLkEzuuRDicyB4Zf/nwTTVetkOxaDiolW6rGS4f0EL5yZ 9F/ueQTAfLMa9x8ZXJDItG+G6rz0bg4tl+56vQUJsXIweIOoowlMoC3eQKGJUNcimizc De0X3JjY1RscE8rGdchfpg0KvmmZO7x7X7PnVUKU9gDtS1HW346sVjUOFUnjPVNV79Ql /kBsTIiIwPLiGyttxUlNz/NoXVOTYiCEyUlJ14InwH8QCK2k3vGm6x3qbULieQqWJOF2 Ezvj8hnMGv5XoQWM8ag+i2t2obcQZn+9YT7KT7EPZZ99lL77Me69kiT6BmcoDwRMTOka ab2Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=X5TbEG7jS0LH0jHbUG4bNIDg16PHpkDqPMlwefTE92o=; fh=f3EoLwuCLXiVGVaMSL9CF563mGpGZwx8Dz9pdCvmNak=; b=mmJDMvZXXtE2tOrpoFM1pCd7KMr0JnAo9/+wvZWS6FASJCeOLoi5bUtEEF/u8siLum DqUNYl0wEI6gNJcbGaAqVQ/7jGSeIqNNDwJtKUilIgVOmVmv4oHARou44C4/G4yYH+x0 G/CYShT+cPJioYl3amK0Y8zryKDfGR6qf9mET2BUOGnFRG6vKC8iekgO+7aMFy7l4fD4 TqWM4yRPzIyKLkszedw58tnOSNJCqor50eN9oCVA4KiL8v9AEl4WUyqxnIP8pF8ciqlM 9/QWOvzp8NhgX4rQ03L+Sn5H8X05nkx0fLdPyVpQnazI1tA2RZg6pTUX1WCAEfi5a4h1 7BjQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=oQhD+jfg; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-56316-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56316-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com X-Forwarded-Encrypted: i=2; AJvYcCVUt+rKQr3gPI8tTryI9KrN7COQuAXNO0QaI7mOCanAusNiqbu8TX4Vf7n0+KCWrJ3e0O0kWCsykALUXouJo96fpk+9qQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id p2-20020a17090a868200b002900606c264si2937409pjn.27.2024.02.07.02.30.07 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Feb 2024 02:30:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-56316-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=oQhD+jfg; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-56316-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-56316-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4D383286003 for <ouuuleilei@gmail.com>; Wed, 7 Feb 2024 10:29:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D9CCF28DC9; Wed, 7 Feb 2024 10:28:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="oQhD+jfg" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 200DB25605 for <linux-kernel@vger.kernel.org>; Wed, 7 Feb 2024 10:28:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.153.233 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707301724; cv=none; b=S6UIFlOiqqOPWe0ETu3OR+ri7j3aJdWxzUHpbj4Wh7XeA3K7CIsbPao/DckVw7TMdb3hBguBx+paONoNViOUM0fTGzq31VTjpln/+xw3EJXv0laEwzc/yMGJkbr2ZvU/QNahceGoPMJmJNGHVMBQdKsBIO+C+hGj6B8B2Yeq0wI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707301724; c=relaxed/simple; bh=GOMKUhohovEESOBI01fYSkJRAFOSlM/SYSPjI3Xc1RU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bt2waxfU6xl+7YhGYNFI1HX+4KEJ4tHlJitOtLRFxQkkGCuJtaVTgbNLd6OKErmfURyPAor2GRZacaFRiaHpj0IXd3fP17H64u9K0G+TQQTNG/mTq41C3crXgv7sIFUkp3Wb7s7fBNJdIYANiOZ9tDTip4aiLran11eWjZW8eOg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=oQhD+jfg; arc=none smtp.client-ip=68.232.153.233 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1707301723; x=1738837723; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GOMKUhohovEESOBI01fYSkJRAFOSlM/SYSPjI3Xc1RU=; b=oQhD+jfgJjTKpL65i1dD4qq7ntUeOitCAYb6MoJC83az5HiTSmZQyGTf 8dSba5EX8WdaZqet7LsGhWprZVcOF7aigdZfXCa3dIg22jTv17CeoPCf4 HkuhkA11dyib7p5BB+4cZCwR8u86h/rEVZeYqwkKdKMCCjs3kX89ch+kW fFxFuPCPRzmrhfPRPEcmbYf1hyQq135i/RCsKVTe3D/r/Wm2CGUrKMcs4 ikvI/KE6rGn29ZMU0DjMznd+CpBeGEa7tzEDP9KwXXYJT44WT6jvhnEXp ciV4zfzxB0K4/NIpy1bpTjYIp4VHHJQ4gcMyuhK+aky32AASyBZsD3mU5 g==; X-CSE-ConnectionGUID: JxZ+DPsRTh6mZRhRbF3CqA== X-CSE-MsgGUID: 19oCjIaDRAe9EnhbpB/i8g== X-IronPort-AV: E=Sophos;i="6.05,250,1701154800"; d="scan'208";a="246623770" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 07 Feb 2024 03:28:41 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.87.72) by chn-vm-ex02.mchp-main.com (10.10.87.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 7 Feb 2024 03:28:28 -0700 Received: from che-lt-i70843lx.microchip.com (10.10.85.11) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Wed, 7 Feb 2024 03:28:16 -0700 From: Dharma Balasubiramani <dharma.b@microchip.com> To: <andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>, <rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>, <jernej.skrabec@gmail.com>, <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>, <tzimmermann@suse.de>, <airlied@gmail.com>, <daniel@ffwll.ch>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <dharma.b@microchip.com>, <manikandan.m@microchip.com>, <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>, <linux@armlinux.org.uk>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <claudiu.beznea@tuxon.dev>, <geert+renesas@glider.be>, <arnd@arndb.de>, <palmer@rivosinc.com>, <akpm@linux-foundation.org>, <gerg@linux-m68k.org>, <rdunlap@infradead.org>, <vbabka@suse.cz>, <linux-arm-kernel@lists.infradead.org> CC: Rob Herring <robh@kernel.org> Subject: [PATCH v3 1/4] dt-bindings: display: bridge: add sam9x75-lvds compatible Date: Wed, 7 Feb 2024 15:57:59 +0530 Message-ID: <20240207102802.200220-2-dharma.b@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240207102802.200220-1-dharma.b@microchip.com> References: <20240207102802.200220-1-dharma.b@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790235699871159846 X-GMAIL-MSGID: 1790235699871159846 |
Series |
LVDS Controller Support for SAM9X75 SoC
|
|
Commit Message
Dharma Balasubiramani
Feb. 7, 2024, 10:27 a.m. UTC
Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage Differential Signaling (LVDS) Controller found on some Microchip's sam9x7 series System-on-Chip (SoC) devices. This binding will be used to define the properties and configuration for the LVDS Controller in DT. Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> Reviewed-by: Rob Herring <robh@kernel.org> --- Changelog v2 -> v3 - No changes. v1 -> v2 - Remove '|' in description, as there is no formatting to preserve. - Remove 'gclk' from clock-names as there is only one clock(pclk). - Remove the unused headers and include only used ones. - Change the compatible name specific to SoC (sam9x75) instead of entire series. - Change file name to match the compatible name. --- .../bridge/microchip,sam9x75-lvds.yaml | 55 +++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml
Comments
$subject: dt-bindings: display: bridge: add sam9x75-lvds compatible If there's a respin for some reason, please update the subject to match what the commit is actually doing (adding a whole binding). Cheers, Conor.
On 07/02/2024 11:27, Dharma Balasubiramani wrote: > Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage > Differential Signaling (LVDS) Controller found on some Microchip's sam9x7 > series System-on-Chip (SoC) devices. This binding will be used to define > the properties and configuration for the LVDS Controller in DT. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> Not tested... Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline), work on fork of kernel (don't, instead use mainline) or you ignore some maintainers (really don't). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. Best regards, Krzysztof
On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 07/02/2024 11:27, Dharma Balasubiramani wrote: >> Add the 'sam9x75-lvds' compatible binding, which describes the Low Voltage >> Differential Signaling (LVDS) Controller found on some Microchip's sam9x7 >> series System-on-Chip (SoC) devices. This binding will be used to define >> the properties and configuration for the LVDS Controller in DT. >> >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > > Not tested... > > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline), work on fork of kernel > (don't, instead use mainline) or you ignore some maintainers (really > don't). Just use b4 and everything should be fine, although remember > about `b4 prep --auto-to-cc` if you added new patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. Apologies for the oversight, somehow it got missed. > > Please kindly resend and include all necessary To/Cc entries. I will resend the series including all necessary To/Cc entries. Thanks. > > > Best regards, > Krzysztof > -- With Best Regards, Dharma B.
Hi Conor, On 07/02/24 9:22 pm, Conor Dooley wrote: > $subject: dt-bindings: display: bridge: add sam9x75-lvds compatible > > If there's a respin for some reason, please update the subject to match > what the commit is actually doing (adding a whole binding). Absolutely, I'll make the adjustment as follows: "dt-bindings: display: bridge: add sam9x75-lvds binding" > > Cheers, > Conor. -- With Best Regards, Dharma B.
On 09/02/24 7:50 pm, Dharma B wrote: > On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know >> the content is safe >> >> On 07/02/2024 11:27, Dharma Balasubiramani wrote: >>> Add the 'sam9x75-lvds' compatible binding, which describes the Low >>> Voltage >>> Differential Signaling (LVDS) Controller found on some Microchip's >>> sam9x7 >>> series System-on-Chip (SoC) devices. This binding will be used to define >>> the properties and configuration for the LVDS Controller in DT. >>> >>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >> >> Not tested... >> >> Please use scripts/get_maintainers.pl to get a list of necessary people >> and lists to CC. It might happen, that command when run on an older >> kernel, gives you outdated entries. Therefore please be sure you base >> your patches on recent Linux kernel. >> >> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >> people, so fix your workflow. Tools might also fail if you work on some >> ancient tree (don't, instead use mainline), work on fork of kernel >> (don't, instead use mainline) or you ignore some maintainers (really >> don't). Just use b4 and everything should be fine, although remember >> about `b4 prep --auto-to-cc` if you added new patches to the patchset. >> >> You missed at least devicetree list (maybe more), so this won't be >> tested by automated tooling. Performing review on untested code might be >> a waste of time. > > Apologies for the oversight, somehow it got missed. The get_maintainer.pl seems to be inconsistent with the results. linux$ ./scripts/get_maintainer.pl *patch | wc -l ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch. Add -f to options? 31 linux$ ./scripts/get_maintainer.pl *patch | wc -l ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch. Add -f to options? 29 linux$ ./scripts/get_maintainer.pl *patch | wc -l ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch. Add -f to options? 30 linux$ ./scripts/get_maintainer.pl *patch | wc -l ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't appear to be a patch. Add -f to options? 30 Anyway, I will add the largest recipients list in v4. >> >> Please kindly resend and include all necessary To/Cc entries. > > I will resend the series including all necessary To/Cc entries. > > Thanks. >> >> >> Best regards, >> Krzysztof >> > -- With Best Regards, Dharma B.
On 09/02/2024 16:02, Dharma.B@microchip.com wrote: > On 09/02/24 7:50 pm, Dharma B wrote: >> On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>> the content is safe >>> >>> On 07/02/2024 11:27, Dharma Balasubiramani wrote: >>>> Add the 'sam9x75-lvds' compatible binding, which describes the Low >>>> Voltage >>>> Differential Signaling (LVDS) Controller found on some Microchip's >>>> sam9x7 >>>> series System-on-Chip (SoC) devices. This binding will be used to define >>>> the properties and configuration for the LVDS Controller in DT. >>>> >>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >>> >>> Not tested... >>> >>> Please use scripts/get_maintainers.pl to get a list of necessary people >>> and lists to CC. It might happen, that command when run on an older >>> kernel, gives you outdated entries. Therefore please be sure you base >>> your patches on recent Linux kernel. >>> >>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>> people, so fix your workflow. Tools might also fail if you work on some >>> ancient tree (don't, instead use mainline), work on fork of kernel >>> (don't, instead use mainline) or you ignore some maintainers (really >>> don't). Just use b4 and everything should be fine, although remember >>> about `b4 prep --auto-to-cc` if you added new patches to the patchset. >>> >>> You missed at least devicetree list (maybe more), so this won't be >>> tested by automated tooling. Performing review on untested code might be >>> a waste of time. >> >> Apologies for the oversight, somehow it got missed. > > The get_maintainer.pl seems to be inconsistent with the results. > > linux$ ./scripts/get_maintainer.pl *patch | wc -l > ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't > appear to be a patch. Add -f to options? > 31 > linux$ ./scripts/get_maintainer.pl *patch | wc -l > ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't > appear to be a patch. Add -f to options? > 29 > linux$ ./scripts/get_maintainer.pl *patch | wc -l > ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't > appear to be a patch. Add -f to options? > 30 > linux$ ./scripts/get_maintainer.pl *patch | wc -l > ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't > appear to be a patch. Add -f to options? > 30 Why would you add 30 addresses, including many unrelated people, to the cc-list? You must add only maintainers (so also reviewers) and mailing lists. Best regards, Krzysztof
On 09/02/2024 17:05, Krzysztof Kozlowski wrote: > On 09/02/2024 16:02, Dharma.B@microchip.com wrote: >> On 09/02/24 7:50 pm, Dharma B wrote: >>> On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: >>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>>> the content is safe >>>> >>>> On 07/02/2024 11:27, Dharma Balasubiramani wrote: >>>>> Add the 'sam9x75-lvds' compatible binding, which describes the Low >>>>> Voltage >>>>> Differential Signaling (LVDS) Controller found on some Microchip's >>>>> sam9x7 >>>>> series System-on-Chip (SoC) devices. This binding will be used to define >>>>> the properties and configuration for the LVDS Controller in DT. >>>>> >>>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >>>> >>>> Not tested... >>>> >>>> Please use scripts/get_maintainers.pl to get a list of necessary people >>>> and lists to CC. It might happen, that command when run on an older >>>> kernel, gives you outdated entries. Therefore please be sure you base >>>> your patches on recent Linux kernel. >>>> >>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>>> people, so fix your workflow. Tools might also fail if you work on some >>>> ancient tree (don't, instead use mainline), work on fork of kernel >>>> (don't, instead use mainline) or you ignore some maintainers (really >>>> don't). Just use b4 and everything should be fine, although remember >>>> about `b4 prep --auto-to-cc` if you added new patches to the patchset. >>>> >>>> You missed at least devicetree list (maybe more), so this won't be >>>> tested by automated tooling. Performing review on untested code might be >>>> a waste of time. >>> >>> Apologies for the oversight, somehow it got missed. >> >> The get_maintainer.pl seems to be inconsistent with the results. >> >> linux$ ./scripts/get_maintainer.pl *patch | wc -l >> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >> appear to be a patch. Add -f to options? >> 31 >> linux$ ./scripts/get_maintainer.pl *patch | wc -l >> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >> appear to be a patch. Add -f to options? >> 29 >> linux$ ./scripts/get_maintainer.pl *patch | wc -l >> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >> appear to be a patch. Add -f to options? >> 30 >> linux$ ./scripts/get_maintainer.pl *patch | wc -l >> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >> appear to be a patch. Add -f to options? >> 30 > > Why would you add 30 addresses, including many unrelated people, to the > cc-list? You must add only maintainers (so also reviewers) and mailing > lists. Really, why do you Cc MM folks on this patch? Just read what get_maintainer.pl tells you, e.g. when it says that someone made one commit to maintainers file, shall this person be Cc-ed? No, it should be obvious... Best regards, Krzysztof
Hi Krzysztof, On 09/02/24 9:40 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 09/02/2024 17:05, Krzysztof Kozlowski wrote: >> On 09/02/2024 16:02, Dharma.B@microchip.com wrote: >>> On 09/02/24 7:50 pm, Dharma B wrote: >>>> On 08/02/24 2:31 pm, Krzysztof Kozlowski wrote: >>>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>>>> the content is safe >>>>> >>>>> On 07/02/2024 11:27, Dharma Balasubiramani wrote: >>>>>> Add the 'sam9x75-lvds' compatible binding, which describes the Low >>>>>> Voltage >>>>>> Differential Signaling (LVDS) Controller found on some Microchip's >>>>>> sam9x7 >>>>>> series System-on-Chip (SoC) devices. This binding will be used to define >>>>>> the properties and configuration for the LVDS Controller in DT. >>>>>> >>>>>> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >>>>> >>>>> Not tested... >>>>> >>>>> Please use scripts/get_maintainers.pl to get a list of necessary people >>>>> and lists to CC. It might happen, that command when run on an older >>>>> kernel, gives you outdated entries. Therefore please be sure you base >>>>> your patches on recent Linux kernel. >>>>> >>>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of >>>>> people, so fix your workflow. Tools might also fail if you work on some >>>>> ancient tree (don't, instead use mainline), work on fork of kernel >>>>> (don't, instead use mainline) or you ignore some maintainers (really >>>>> don't). Just use b4 and everything should be fine, although remember >>>>> about `b4 prep --auto-to-cc` if you added new patches to the patchset. >>>>> >>>>> You missed at least devicetree list (maybe more), so this won't be >>>>> tested by automated tooling. Performing review on untested code might be >>>>> a waste of time. >>>> >>>> Apologies for the oversight, somehow it got missed. >>> >>> The get_maintainer.pl seems to be inconsistent with the results. >>> >>> linux$ ./scripts/get_maintainer.pl *patch | wc -l >>> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >>> appear to be a patch. Add -f to options? >>> 31 >>> linux$ ./scripts/get_maintainer.pl *patch | wc -l >>> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >>> appear to be a patch. Add -f to options? >>> 29 >>> linux$ ./scripts/get_maintainer.pl *patch | wc -l >>> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >>> appear to be a patch. Add -f to options? >>> 30 >>> linux$ ./scripts/get_maintainer.pl *patch | wc -l >>> ./scripts/get_maintainer.pl: file '0000-cover-letter.patch' doesn't >>> appear to be a patch. Add -f to options? >>> 30 >> >> Why would you add 30 addresses, including many unrelated people, to the >> cc-list? You must add only maintainers (so also reviewers) and mailing >> lists. > > Really, why do you Cc MM folks on this patch? Just read what > get_maintainer.pl tells you, e.g. when it says that someone made one > commit to maintainers file, shall this person be Cc-ed? No, it should be > obvious... Thank you for bringing this to my attention. I sincerely apologize for any oversight. Moving forward, I will ensure to utilize 'b4 prep --auto-to-cc' to obtain the accurate To and CC list. > > Best regards, > Krzysztof > -- With Best Regards, Dharma B.
diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml new file mode 100644 index 000000000000..862ef441ac9f --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x75-lvds.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/microchip,sam9x75-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip SAM9X75 LVDS Controller + +maintainers: + - Dharma Balasubiramani <dharma.b@microchip.com> + +description: + The Low Voltage Differential Signaling Controller (LVDSC) manages data + format conversion from the LCD Controller internal DPI bus to OpenLDI + LVDS output signals. LVDSC functions include bit mapping, balanced mode + management, and serializer. + +properties: + compatible: + const: microchip,sam9x75-lvds + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: Peripheral Bus Clock + + clock-names: + items: + - const: pclk + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + #include <dt-bindings/clock/at91.h> + lvds-controller@f8060000 { + compatible = "microchip,sam9x75-lvds"; + reg = <0xf8060000 0x100>; + interrupts = <56 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&pmc PMC_TYPE_PERIPHERAL 56>; + clock-names = "pclk"; + };