Message ID | 20240206130017.7839-5-subhajit.ghosh@tweaklogic.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-54984-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1520062dyb; Tue, 6 Feb 2024 05:02:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGYt784+f8QVyQP+M58GjnsP0Fz9TtNo6fHHW2BoO3Xkq/DJJdHh9e/QUPxT210BtAJuBuC X-Received: by 2002:a05:6870:7185:b0:219:ae38:d30c with SMTP id d5-20020a056870718500b00219ae38d30cmr1898013oah.58.1707224537490; Tue, 06 Feb 2024 05:02:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707224537; cv=pass; d=google.com; s=arc-20160816; b=0wCkZKoQnM6kCSTMtSY3Z34BX3POIkIw+IiRVx2ysJgS71w8XBKDaajlbD8FlpG9BT Quohb1eWAQmW+HJFEyDFLxgljRVo+lrSDVduycIaCIzr9x1ufV3jIGMU7uEiplfB9+mb NnmwoAwcNZI5B+dN70Dy1Z4T5X+nXauPBFin6ivHV86aaOnCCEtqFIz8+BESx9YsPoE5 YnBhTmVIEH0DgWwZDGXGyZuxXjBARxnWVjOA+mzORWe9+jwtEwy0ONsKSpZRQ0fMO2sV Rg4xVtxp9zSecXhXbQhe7VZyiM7fDaDUTiJJU2Jt7VRVdwrAu+I3UBxn2Sr7AftZeQwf Sqmw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=fwuOrU+QhGdqY/THguCCrdFISX4fEOqvHfqpDmjiBhI=; fh=FQvtmABr8b8ppinGTv/VqQgYiHN1l6K7dzTIF7qtfrk=; b=QPOTRsJT0Hd1LavZQ5IRc+O57Lr41le+mH1HQ7qcry/4QlmyLCFgkajt1SL6VxNcrH rJEcB5UKcRm1wl899VwFJzHio21kpcyz/x2VTsRNx8I4kvLJ3HwRNyFb6b+xWjbHZYqN zKA9avs8A6uHRzIPHEIo+ERVdmRaFSI4Ysv+aiwQA10QxLCKHE2Znd14tmSYcm9hDWW6 b0MT9RTJ/KqopRVc+kV8jNyCbR7dY79sCgzg94KC8frjsYL3mfDss5hxi0TPek9clLpn cNRmLnQf6q/sA1drKStlHVxc9F0wygFcO+p4SXaaeIUe6XNWblibBML1Q9+SxFYvbY8d hjhQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tweaklogic.com header.s=google header.b="HlA0d/X5"; arc=pass (i=1 spf=pass spfdomain=tweaklogic.com dkim=pass dkdomain=tweaklogic.com); spf=pass (google.com: domain of linux-kernel+bounces-54984-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54984-ouuuleilei=gmail.com@vger.kernel.org" X-Forwarded-Encrypted: i=1; AJvYcCXvH8wHxbiTOfrHpl3u3JsQOMkXK6rXOSg+FMQXD+aJyT3Z6U+Aad4GO9sR2i5Jqzj76jZRsFDCzAmYDmdU4Yumbi7Vyg== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id ay35-20020a056122182300b004c02c7ba864si301767vkb.48.2024.02.06.05.02.17 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 05:02:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-54984-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@tweaklogic.com header.s=google header.b="HlA0d/X5"; arc=pass (i=1 spf=pass spfdomain=tweaklogic.com dkim=pass dkdomain=tweaklogic.com); spf=pass (google.com: domain of linux-kernel+bounces-54984-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-54984-ouuuleilei=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3E8121C22D97 for <ouuuleilei@gmail.com>; Tue, 6 Feb 2024 13:02:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 36BA4130E54; Tue, 6 Feb 2024 13:01:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b="HlA0d/X5" Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F3E6213173E for <linux-kernel@vger.kernel.org>; Tue, 6 Feb 2024 13:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707224483; cv=none; b=KbnhB/2HxSrItTUdGdBgSR2jGoYADXzq5+XWupnURwxEsephl5ne0KMuOQiDphyS0hADExvIpScqvsR/L2vdRktH8Fk24zV/lU257kny1tuKrTTJqTPl0/1TV3j/jejt+M75rOtpiy9tQGg7uzjRDFM8MITWthLy0q7vSZeQ38w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707224483; c=relaxed/simple; bh=lQXA3whtFGndqBJ+W38lPtZ3yGQ5+Hlm/9LV6dvwNI0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=SJd4T7cQy4HK9ep+/1Mz0LNIg2/8fj2fZIG9lq9RZhvy9b7+PWLcsTZkP+tZH05Za5ltLbwdTx5NCZWDWRUZ3+8pB9wrSB7VuNuvI8Sap6wB21XVZm+1uY96W1kNrZVuQy834/AjlUyXXa7eQM4pDwAWP3MPgGUvR2cNRditpLY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com; spf=pass smtp.mailfrom=tweaklogic.com; dkim=pass (2048-bit key) header.d=tweaklogic.com header.i=@tweaklogic.com header.b=HlA0d/X5; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tweaklogic.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tweaklogic.com Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-296cca91667so346700a91.3 for <linux-kernel@vger.kernel.org>; Tue, 06 Feb 2024 05:01:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1707224481; x=1707829281; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fwuOrU+QhGdqY/THguCCrdFISX4fEOqvHfqpDmjiBhI=; b=HlA0d/X5cLRgaDfR3BgDZa1aTgcyo+7kBkDPwOE6Cbw5qppnxVtubmkOHMvuzwL0L1 qbfiJkc9fLusQw/NuUoFo1Ve0osyNQ/0YU0VEbAWXCRqZKv1T6yIYq3ct1OxOuWeyIqU kvPMvGOl/2wOpXPYQyVRUud/5ZzhEhQrIqcX6DdOJW9E8xi3FE8d8kqaly2NAdpYRNWE KBeS66GYBztWagAKafa69YugWYILoBxu6R26jWVWApHRN24GJozSWbRxapr8AUBs8rBZ IjIpKSwibqhLfNuofi2YYfVyUZTzR24UzMuf4vD1hQrqPwzDUdY8Xxo8jeG7BOOWSHNH ekGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707224481; x=1707829281; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fwuOrU+QhGdqY/THguCCrdFISX4fEOqvHfqpDmjiBhI=; b=mVoYQhTrLAAUrlbVEhblyc1+OlHIeY9/XfABnXBd4MWb/CUt1J4YXPji3XgZ/TG2gT yc8ELhkvYU4pwtAeRA5WOncCAozBsFsIfjXfzHZ86y3nZeEvkPbgqVNV8wcwNaFh8MZW K5cZ19Qe/NUkpJltLpyzMWLP0ZzK9vG9KVphTVjpxcXcqo6e5tobBmo2f297p6Mnib3J gBRNJxZ89iHAuOIyPzamHZ40iOaRSzoGykKt+sjRXAZeBVzgiVYhbe68sGOjBTjotgQJ IeCjF47OiqxxRacrxo9M7UCmn4pTJG0iZtmEJ2CpNhjZagDZU6CZJlDht3JHZe6GO9Wi 4gXw== X-Gm-Message-State: AOJu0Yww6HdYgHqM+/xnc1KHL9/FpQomYCaFzIPExa2rLPM8XjMpgNbd QnMMyCrTTicuTeUHMSLjqhc+xL8ny/G24yRzDgnhmoTFCDKz1wKJbADLg5Az8Dw= X-Received: by 2002:a17:90b:ecc:b0:296:3489:6d6b with SMTP id gz12-20020a17090b0ecc00b0029634896d6bmr2199517pjb.42.1707224481257; Tue, 06 Feb 2024 05:01:21 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCXI6T/McMbE9ioeYgmIZz7zJlE8VZO90i8SeZF9O0xujvc7xtVgS+83kM13DpBTsGf0lJ4ZjWMjlllP22iDy92xzf1sxStm8QKlFFIb3e+vlZvcDPuG7aNVMyLtuvRCC0j1izCzwUhk5gbajQ3OvB6lxA8KHEIGVyCnWiWgXY/PNIBqdocSN0tzkJGT9nxD+gwmppUv9OMsFiDcr8dRfxwhMx4NQ38TFfnp6KFIWajMmmGxAEwY/cZd0YFV1+eb8UMPMd+e2zjzZJ+/M5gfZtRSD92bSOZF0igLS1nYx2MQOY10afv3+whFZ/2k6MOmgjoUAgNkHBIOzrpDF9OWxMNiPX72F2dKG9Bf9IDNdc1NFB/3s2GVw066r7bc+ISJ7x5oN6Cy3NpK7g/EiQv1vY7QSvDBa/wv4rdf0kEpaVWrFAXNlpM9hQNkNNPcjoXc1v312c9uR43GmEtDYyEU187iL+HLb4bafefZUWos+wu3vcV/z3n6tn3C/uFbaVrAbNDlZWyOMa/AhucEh7hXKhb15WkXpw== Received: from localhost.localdomain ([180.150.113.62]) by smtp.gmail.com with ESMTPSA id s1-20020a170902ea0100b001d958f8ab2bsm1782167plg.107.2024.02.06.05.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 05:01:20 -0800 (PST) From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> To: Jonathan Cameron <jic23@kernel.org>, Lars-Peter Clausen <lars@metafoo.de>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Matti Vaittinen <mazziesaccount@gmail.com>, Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Marek Vasut <marex@denx.de>, Anshul Dalal <anshulusr@gmail.com>, Javier Carrasco <javier.carrasco.cruz@gmail.com> Cc: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>, Matt Ranostay <matt@ranostay.sg>, Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 4/5] dt-bindings: iio: light: Avago APDS9306 Date: Tue, 6 Feb 2024 23:30:16 +1030 Message-Id: <20240206130017.7839-5-subhajit.ghosh@tweaklogic.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240206130017.7839-1-subhajit.ghosh@tweaklogic.com> References: <20240206130017.7839-1-subhajit.ghosh@tweaklogic.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790154676525725672 X-GMAIL-MSGID: 1790154676525725672 |
Series |
Support for Avago APDS9306 Ambient Light Sensor
|
|
Commit Message
Subhajit Ghosh
Feb. 6, 2024, 1 p.m. UTC
Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor.
Extend avago,apds9300.yaml schema file to support apds9306 device.
this patch depends on patch:
"dt-bindings: iio: light: adps9300: Update interrupt definitions"
Signed-off-by: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
---
v5 -> v6:
- Write proper commit messages
- Add vdd-supply in a separate commit
- Add Interrupt macro in a separate commit
Link: https://lore.kernel.org/all/1d0a80a6-dba5-4db8-a7a8-73d4ffe7a37e@linaro.org/
v2 -> v5:
- Removed 'required' for Interrupts and 'oneOf' for compatibility strings
as per below reviews:
Link: https://lore.kernel.org/lkml/20231028142944.7e210eb6@jic23-huawei/
Link: https://lore.kernel.org/lkml/22e9e5e9-d26a-46e9-8986-5062bbfd72ec@linaro.org/
---
Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On 06/02/2024 14:00, Subhajit Ghosh wrote: > Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor. > Extend avago,apds9300.yaml schema file to support apds9306 device. > > this patch depends on patch: > "dt-bindings: iio: light: adps9300: Update interrupt definitions" Drop the paragraph, not helping. There is no dependency here. Best regards, Krzysztof
Hi Krzysztof, On 8/2/24 18:48, Krzysztof Kozlowski wrote: > On 06/02/2024 14:00, Subhajit Ghosh wrote: >> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor. >> Extend avago,apds9300.yaml schema file to support apds9306 device. >> >> this patch depends on patch: >> "dt-bindings: iio: light: adps9300: Update interrupt definitions" > > Drop the paragraph, not helping. There is no dependency here. In the submitting patches guide, I read that if one patch depends on another, it should be mentioned. If I try to apply this patch with "git am", it fails without first applying the patch dependency mentioned above. Is that fine? Again, sorry about the silly questions, just don't want to assume stuff! > > Best regards, > Krzysztof > Thank you for reviewing. Regards, Subhajit Ghosh
On Thu, Feb 08, 2024 at 09:21:17PM +1030, Subhajit Ghosh wrote: > Hi Krzysztof, > > On 8/2/24 18:48, Krzysztof Kozlowski wrote: > > On 06/02/2024 14:00, Subhajit Ghosh wrote: > > > Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor. > > > Extend avago,apds9300.yaml schema file to support apds9306 device. > > > > > > this patch depends on patch: > > > "dt-bindings: iio: light: adps9300: Update interrupt definitions" > > > > Drop the paragraph, not helping. There is no dependency here. > In the submitting patches guide, I read that if one patch depends > on another, it should be mentioned. > If I try to apply this patch with "git am", it fails without > first applying the patch dependency mentioned above. Is that fine? > Again, sorry about the silly questions, just don't want to assume stuff! It's another patch in the same series, I don't think you should bother mentioning this at all. If there's a dependency on another series, then you should mention it under the --- line. Cheers, Conor.
On 08/02/2024 11:51, Subhajit Ghosh wrote: > Hi Krzysztof, > > On 8/2/24 18:48, Krzysztof Kozlowski wrote: >> On 06/02/2024 14:00, Subhajit Ghosh wrote: >>> Driver support for Avago (Broadcom) APDS9306 Ambient Light Sensor. >>> Extend avago,apds9300.yaml schema file to support apds9306 device. >>> >>> this patch depends on patch: >>> "dt-bindings: iio: light: adps9300: Update interrupt definitions" >> >> Drop the paragraph, not helping. There is no dependency here. > In the submitting patches guide, I read that if one patch depends > on another, it should be mentioned. On another patchset! Not on other patch within patchset. Anyway, submitting patches don't tell to store it in Git forever because it does not make sense. Third, there is no dependency. > If I try to apply this patch with "git am", it fails without > first applying the patch dependency mentioned above. Is that fine? It's just context. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml index e07a074f6acf..b750096530bc 100644 --- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml @@ -12,11 +12,13 @@ maintainers: description: | Datasheet: https://www.avagotech.com/docs/AV02-1077EN Datasheet: https://www.avagotech.com/docs/AV02-4191EN + Datasheet: https://www.avagotech.com/docs/AV02-4755EN properties: compatible: enum: - avago,apds9300 + - avago,apds9306 - avago,apds9960 reg: