diff mbox series

[v2,5/5] pwm: dwc: use pm_sleep_ptr() macro

Message ID 20240208070529.28562-6-raag.jadav@intel.com
State New
Headers
Series DesignWare PWM improvements |

Commit Message

Raag Jadav Feb. 8, 2024, 7:05 a.m. UTC 
  Since we don't have runtime PM handles here, we should be using
pm_sleep_ptr() macro, so that the compiler can discard it in case
CONFIG_PM_SLEEP=n.

Fixes: 30b5b066fa83 ("pwm: dwc: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions")
Signed-off-by: Raag Jadav <raag.jadav@intel.com>
---
 drivers/pwm/pwm-dwc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Feb. 8, 2024, 5:22 p.m. UTC | #1 
On Thu, Feb 08, 2024 at 12:35:29PM +0530, Raag Jadav wrote:
> Since we don't have runtime PM handles here, we should be using
> pm_sleep_ptr() macro, so that the compiler can discard it in case
> CONFIG_PM_SLEEP=n.

> Fixes: 30b5b066fa83 ("pwm: dwc: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions")

Fixes always should go first in the series.
Uwe Kleine-König Feb. 15, 2024, 11:22 a.m. UTC | #2 
On Thu, Feb 08, 2024 at 07:22:52PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 08, 2024 at 12:35:29PM +0530, Raag Jadav wrote:
> > Since we don't have runtime PM handles here, we should be using
> > pm_sleep_ptr() macro, so that the compiler can discard it in case
> > CONFIG_PM_SLEEP=n.
> 
> > Fixes: 30b5b066fa83 ("pwm: dwc: Use DEFINE_SIMPLE_DEV_PM_OPS for PM functions")
> 
> Fixes always should go first in the series.

No need to resend for that, I'll pick patches 3-5 in the order I
consider sensible. Git seems to handle that just fine.

Best regards
Uwe
diff mbox series

Patch

diff --git a/drivers/pwm/pwm-dwc.c b/drivers/pwm/pwm-dwc.c
index cc5bba977f47..bb39cc34f895 100644
--- a/drivers/pwm/pwm-dwc.c
+++ b/drivers/pwm/pwm-dwc.c
@@ -127,7 +127,7 @@  static struct pci_driver dwc_pwm_driver = {
 	.remove = dwc_pwm_remove,
 	.id_table = dwc_pwm_id_table,
 	.driver = {
-		.pm = pm_ptr(&dwc_pwm_pm_ops),
+		.pm = pm_sleep_ptr(&dwc_pwm_pm_ops),
 	},
 };