diff mbox series

maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set

Message ID 20221119055117.14094-1-rdunlap@infradead.org
State New
Headers
Series maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set |

Commit Message

Randy Dunlap Nov. 19, 2022, 5:51 a.m. UTC 
  Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
"depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
any kconfig dependencies.

WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
  Depends on [n]: DEBUG_KERNEL [=n]
  Selected by [y]:
  - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reported-by: kernel test robot <lkp@intel.com>
Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Liam Howlett <liam.howlett@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org
---
 lib/Kconfig.debug |    1 +
 1 file changed, 1 insertion(+)

Comments

Liam R. Howlett Nov. 23, 2022, 6:53 p.m. UTC | #1 
Thanks Randy.  I'm going to look into doing as Geert requested and avoid
pulling in dependencies, but this is the right thing to do for now.

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>


* Randy Dunlap <rdunlap@infradead.org> [221119 00:51]:
> Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
> "depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
> any kconfig dependencies.
> 
> WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
>   Depends on [n]: DEBUG_KERNEL [=n]
>   Selected by [y]:
>   - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Liam Howlett <liam.howlett@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> ---
>  lib/Kconfig.debug |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2259,6 +2259,7 @@ config TEST_XARRAY
>  	tristate "Test the XArray code at runtime"
>  
>  config TEST_MAPLE_TREE
> +	depends on DEBUG_KERNEL
>  	select DEBUG_MAPLE_TREE
>  	tristate "Test the Maple Tree code at runtime"
>
diff mbox series

Patch

diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2259,6 +2259,7 @@  config TEST_XARRAY
 	tristate "Test the XArray code at runtime"
 
 config TEST_MAPLE_TREE
+	depends on DEBUG_KERNEL
 	select DEBUG_MAPLE_TREE
 	tristate "Test the Maple Tree code at runtime"