diff mbox series

[v2,1/2] dt-bindings: net: dp83826: support TX data voltage tuning

Message ID 20240207175845.764775-1-catalin.popescu@leica-geosystems.com
State New
Headers
Series [v2,1/2] dt-bindings: net: dp83826: support TX data voltage tuning |

Commit Message

POPESCU Catalin Feb. 7, 2024, 5:58 p.m. UTC 
  Add properties ti,cfg-dac-minus-one-milli-percent and
ti,cfg-dac-plus-one-milli-percent to support voltage tuning
of logical levels -1/+1 of the MLT-3 encoded TX data.

Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
---
Changes in v2:
 - squash the 2 DT bindings patches in one single patch
 - drop redundant "binding" from the DT bindings patch title
 - rename DT properties and define them as percentage
 - add default value for each new DT property
---
 .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)


base-commit: 6d280f4d760e3bcb4a8df302afebf085b65ec982
prerequisite-patch-id: 0000000000000000000000000000000000000000

Comments

Krzysztof Kozlowski Feb. 8, 2024, 7:35 a.m. UTC | #1 
On 07/02/2024 18:58, Catalin Popescu wrote:
> Add properties ti,cfg-dac-minus-one-milli-percent and
> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
> of logical levels -1/+1 of the MLT-3 encoded TX data.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
> Changes in v2:
>  - squash the 2 DT bindings patches in one single patch
>  - drop redundant "binding" from the DT bindings patch title
>  - rename DT properties and define them as percentage
>  - add default value for each new DT property
> ---
>  .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> index db74474207ed..6bbd465e51d6 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> @@ -62,6 +62,24 @@ properties:
>         for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
>         to transmit data.
>  
> +  ti,cfg-dac-minus-one-milli-percent:
> +    description: |
> +       DP83826 PHY only.
> +       Sets the voltage ratio (with respect to the nominal value)
> +       of the logical level -1 for the MLT-3 encoded TX data.
> +    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
> +           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]

I see all values being multiple of basis points, so why not using -bp
suffix?


Best regards,
Krzysztof
POPESCU Catalin Feb. 8, 2024, 8:48 a.m. UTC | #2 
On 08.02.24 08:35, Krzysztof Kozlowski wrote:
> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On 07/02/2024 18:58, Catalin Popescu wrote:
>> Add properties ti,cfg-dac-minus-one-milli-percent and
>> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
>> of logical levels -1/+1 of the MLT-3 encoded TX data.
>>
>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>> ---
>> Changes in v2:
>>   - squash the 2 DT bindings patches in one single patch
>>   - drop redundant "binding" from the DT bindings patch title
>>   - rename DT properties and define them as percentage
>>   - add default value for each new DT property
>> ---
>>   .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>> index db74474207ed..6bbd465e51d6 100644
>> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>> @@ -62,6 +62,24 @@ properties:
>>          for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
>>          to transmit data.
>>
>> +  ti,cfg-dac-minus-one-milli-percent:
>> +    description: |
>> +       DP83826 PHY only.
>> +       Sets the voltage ratio (with respect to the nominal value)
>> +       of the logical level -1 for the MLT-3 encoded TX data.
>> +    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
>> +           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
> I see all values being multiple of basis points, so why not using -bp
> suffix?

I can read :

   "-bp$":
     $ref: types.yaml#/definitions/int32-array
     description: basis points (1/100 of a percent)

In my case it's 1/1000 of a percent. As I'm not sure exactly what the 
author meant by "basis points", would this apply to my patch as well?

>
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Feb. 8, 2024, 8:50 a.m. UTC | #3 
On 08/02/2024 09:48, POPESCU Catalin wrote:
> On 08.02.24 08:35, Krzysztof Kozlowski wrote:
>> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>
>> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>>
>>
>> On 07/02/2024 18:58, Catalin Popescu wrote:
>>> Add properties ti,cfg-dac-minus-one-milli-percent and
>>> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
>>> of logical levels -1/+1 of the MLT-3 encoded TX data.
>>>
>>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>>> ---
>>> Changes in v2:
>>>   - squash the 2 DT bindings patches in one single patch
>>>   - drop redundant "binding" from the DT bindings patch title
>>>   - rename DT properties and define them as percentage
>>>   - add default value for each new DT property
>>> ---
>>>   .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
>>>   1 file changed, 18 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>> index db74474207ed..6bbd465e51d6 100644
>>> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>> @@ -62,6 +62,24 @@ properties:
>>>          for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
>>>          to transmit data.
>>>
>>> +  ti,cfg-dac-minus-one-milli-percent:
>>> +    description: |
>>> +       DP83826 PHY only.
>>> +       Sets the voltage ratio (with respect to the nominal value)
>>> +       of the logical level -1 for the MLT-3 encoded TX data.
>>> +    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
>>> +           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
>> I see all values being multiple of basis points, so why not using -bp
>> suffix?
> 
> I can read :
> 
>    "-bp$":
>      $ref: types.yaml#/definitions/int32-array
>      description: basis points (1/100 of a percent)
> 
> In my case it's 1/1000 of a percent. As I'm not sure exactly what the 
> author meant by "basis points", would this apply to my patch as well?

So please show me the value which does not fit in -bp.

Best regards,
Krzysztof
POPESCU Catalin Feb. 8, 2024, 9:08 a.m. UTC | #4 
On 08.02.24 09:50, Krzysztof Kozlowski wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On 08/02/2024 09:48, POPESCU Catalin wrote:
>> On 08.02.24 08:35, Krzysztof Kozlowski wrote:
>>> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>
>>> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>>>
>>>
>>> On 07/02/2024 18:58, Catalin Popescu wrote:
>>>> Add properties ti,cfg-dac-minus-one-milli-percent and
>>>> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
>>>> of logical levels -1/+1 of the MLT-3 encoded TX data.
>>>>
>>>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>>>> ---
>>>> Changes in v2:
>>>>    - squash the 2 DT bindings patches in one single patch
>>>>    - drop redundant "binding" from the DT bindings patch title
>>>>    - rename DT properties and define them as percentage
>>>>    - add default value for each new DT property
>>>> ---
>>>>    .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
>>>>    1 file changed, 18 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>> index db74474207ed..6bbd465e51d6 100644
>>>> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>> @@ -62,6 +62,24 @@ properties:
>>>>           for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
>>>>           to transmit data.
>>>>
>>>> +  ti,cfg-dac-minus-one-milli-percent:
>>>> +    description: |
>>>> +       DP83826 PHY only.
>>>> +       Sets the voltage ratio (with respect to the nominal value)
>>>> +       of the logical level -1 for the MLT-3 encoded TX data.
>>>> +    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
>>>> +           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
>>> I see all values being multiple of basis points, so why not using -bp
>>> suffix?
>> I can read :
>>
>>     "-bp$":
>>       $ref: types.yaml#/definitions/int32-array
>>       description: basis points (1/100 of a percent)
>>
>> In my case it's 1/1000 of a percent. As I'm not sure exactly what the
>> author meant by "basis points", would this apply to my patch as well?
> So please show me the value which does not fit in -bp.

"Basis points" doesn't mean anything to me, that's why I was asking for 
confirmation :)
I don't have any issue to use "-bp" at all, I'm not pusing against.

>
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Feb. 8, 2024, 9:12 a.m. UTC | #5 
On 08/02/2024 10:08, POPESCU Catalin wrote:
> On 08.02.24 09:50, Krzysztof Kozlowski wrote:
>> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>>
>>
>> On 08/02/2024 09:48, POPESCU Catalin wrote:
>>> On 08.02.24 08:35, Krzysztof Kozlowski wrote:
>>>> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>>
>>>> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>>>>
>>>>
>>>> On 07/02/2024 18:58, Catalin Popescu wrote:
>>>>> Add properties ti,cfg-dac-minus-one-milli-percent and
>>>>> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
>>>>> of logical levels -1/+1 of the MLT-3 encoded TX data.
>>>>>
>>>>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>>>>> ---
>>>>> Changes in v2:
>>>>>    - squash the 2 DT bindings patches in one single patch
>>>>>    - drop redundant "binding" from the DT bindings patch title
>>>>>    - rename DT properties and define them as percentage
>>>>>    - add default value for each new DT property
>>>>> ---
>>>>>    .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
>>>>>    1 file changed, 18 insertions(+)
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>>> index db74474207ed..6bbd465e51d6 100644
>>>>> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>>> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>>> @@ -62,6 +62,24 @@ properties:
>>>>>           for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
>>>>>           to transmit data.
>>>>>
>>>>> +  ti,cfg-dac-minus-one-milli-percent:
>>>>> +    description: |
>>>>> +       DP83826 PHY only.
>>>>> +       Sets the voltage ratio (with respect to the nominal value)
>>>>> +       of the logical level -1 for the MLT-3 encoded TX data.
>>>>> +    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
>>>>> +           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
>>>> I see all values being multiple of basis points, so why not using -bp
>>>> suffix?
>>> I can read :
>>>
>>>     "-bp$":
>>>       $ref: types.yaml#/definitions/int32-array
>>>       description: basis points (1/100 of a percent)
>>>
>>> In my case it's 1/1000 of a percent. As I'm not sure exactly what the
>>> author meant by "basis points", would this apply to my patch as well?
>> So please show me the value which does not fit in -bp.
> 
> "Basis points" doesn't mean anything to me, that's why I was asking for 
> confirmation :)
> I don't have any issue to use "-bp" at all, I'm not pusing against.

https://en.wikipedia.org/wiki/Basis_point

Looks like all your values fit there, at least for these devices. Maybe
you would need to be sure other devices do not require mpercent after all.

Best regards,
Krzysztof
POPESCU Catalin Feb. 8, 2024, 9:19 a.m. UTC | #6 
On 08.02.24 10:12, Krzysztof Kozlowski wrote:
> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>
>
> On 08/02/2024 10:08, POPESCU Catalin wrote:
>> On 08.02.24 09:50, Krzysztof Kozlowski wrote:
>>> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>>>
>>>
>>> On 08/02/2024 09:48, POPESCU Catalin wrote:
>>>> On 08.02.24 08:35, Krzysztof Kozlowski wrote:
>>>>> [You don't often get email from krzysztof.kozlowski@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>>>>>
>>>>> This email is not from Hexagon’s Office 365 instance. Please be careful while clicking links, opening attachments, or replying to this email.
>>>>>
>>>>>
>>>>> On 07/02/2024 18:58, Catalin Popescu wrote:
>>>>>> Add properties ti,cfg-dac-minus-one-milli-percent and
>>>>>> ti,cfg-dac-plus-one-milli-percent to support voltage tuning
>>>>>> of logical levels -1/+1 of the MLT-3 encoded TX data.
>>>>>>
>>>>>> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
>>>>>> ---
>>>>>> Changes in v2:
>>>>>>     - squash the 2 DT bindings patches in one single patch
>>>>>>     - drop redundant "binding" from the DT bindings patch title
>>>>>>     - rename DT properties and define them as percentage
>>>>>>     - add default value for each new DT property
>>>>>> ---
>>>>>>     .../devicetree/bindings/net/ti,dp83822.yaml    | 18 ++++++++++++++++++
>>>>>>     1 file changed, 18 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>>>> index db74474207ed..6bbd465e51d6 100644
>>>>>> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
>>>>>> @@ -62,6 +62,24 @@ properties:
>>>>>>            for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
>>>>>>            to transmit data.
>>>>>>
>>>>>> +  ti,cfg-dac-minus-one-milli-percent:
>>>>>> +    description: |
>>>>>> +       DP83826 PHY only.
>>>>>> +       Sets the voltage ratio (with respect to the nominal value)
>>>>>> +       of the logical level -1 for the MLT-3 encoded TX data.
>>>>>> +    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
>>>>>> +           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
>>>>> I see all values being multiple of basis points, so why not using -bp
>>>>> suffix?
>>>> I can read :
>>>>
>>>>      "-bp$":
>>>>        $ref: types.yaml#/definitions/int32-array
>>>>        description: basis points (1/100 of a percent)
>>>>
>>>> In my case it's 1/1000 of a percent. As I'm not sure exactly what the
>>>> author meant by "basis points", would this apply to my patch as well?
>>> So please show me the value which does not fit in -bp.
>> "Basis points" doesn't mean anything to me, that's why I was asking for
>> confirmation :)
>> I don't have any issue to use "-bp" at all, I'm not pusing against.
> https://en.wikipedia.org/wiki/Basis_point
>
> Looks like all your values fit there, at least for these devices. Maybe
> you would need to be sure other devices do not require mpercent after all.
Got it! Indeed, "-bp" completely fits my need.
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
index db74474207ed..6bbd465e51d6 100644
--- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
+++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
@@ -62,6 +62,24 @@  properties:
        for the PHY.  The internal delay for the PHY is fixed to 3.5ns relative
        to transmit data.
 
+  ti,cfg-dac-minus-one-milli-percent:
+    description: |
+       DP83826 PHY only.
+       Sets the voltage ratio (with respect to the nominal value)
+       of the logical level -1 for the MLT-3 encoded TX data.
+    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
+           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
+    default: 100000
+
+  ti,cfg-dac-plus-one-milli-percent:
+    description: |
+       DP83826 PHY only.
+       Sets the voltage ratio (with respect to the nominal value)
+       of the logical level +1 for the MLT-3 encoded TX data.
+    enum: [50000, 56250, 62500, 68750, 75000, 81250, 87500, 93750, 100000,
+           106250, 112500, 118750, 125000, 131250, 137500, 143750, 150000]
+    default: 100000
+
 required:
   - reg