Message ID | 20240206220447.3102-1-W_Armin@gmx.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-55667-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp1850056dyb; Tue, 6 Feb 2024 14:05:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFEgY6leayzslHoio+YpYW6s4EzcSc8NV6NdjzjTS4tpB23COFIJ38p+RDtALF8e8GBrGDe X-Received: by 2002:a0c:cb10:0:b0:68c:850d:7b95 with SMTP id o16-20020a0ccb10000000b0068c850d7b95mr3160382qvk.37.1707257152829; Tue, 06 Feb 2024 14:05:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707257152; cv=pass; d=google.com; s=arc-20160816; b=Zl+MwZItiSZFm+LvIRfAF9anp0oa4buH/5Iq2T3YDMrhUEY1GJ8qdCmF4QEkjHAKPa mcP+TwiMgQ0jnWc8mr4uip/tsrpcs9oa/HNTvVPNV2PjdliIq8lnr87sE6y3Rsr+TLMX tPv5lfU14vhBF8vsTtXqkcmFR2i5FVk07Fi0RzfDMI5JNyYDfTmgSdmu+d/59tIRGHpi 96g1SlsQe8vEelSdA9q8CbDac+xXLlTJFVqRcS1r4unHk09YP9L3YQOVOwBojYG0rdM2 lBihqGuKOk9z5ZTkMxBYONwb47jFoTHuhDk6Bv7Xsfm6gG/G5Jc5TBGwqHQSCgamnHF8 8ZfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:message-id:date :subject:cc:to:from:dkim-signature; bh=CI6P8WBXQOamMDxqjNyjCKPd0612F5pRynA+ojAC6e4=; fh=Rwjl9QOSG/RqQpsrtHFvnAPQiAz8FyHbOzcMAIS19qw=; b=FQenBFSrRm0vt35Ce36eRzK8Z1hR6jjQw+pjWJY8hYoHYuiGA4B2uHyCBD/3Shv5dk 9/T2r233Km4Dj8X9j6WuSUfctPzyXnOJ7H7tmeXn3py1AJYYa2QzADj6USTPvnZcWgc3 BTnWZRVvuujQrlMXCfKo7sclZ45KbLERnrthYdkeCNmIQ41/enEbLFyE/UhS++ctB0II JfGvW+Zp6PvVY+/FcrZ9VRMtXDhFQ2P9H63AXhQCUgaezH+q8xEFvdgVbxubZZSMQA1V eqDpi9GScairdUMz1GtnK5aVty+STgms9743ilEPufhYDXfsYahMmNUzMGLkHsWnSy3Y oHAg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=uLEsDdvr; arc=pass (i=1 spf=pass spfdomain=gmx.de dkim=pass dkdomain=gmx.de dmarc=pass fromdomain=gmx.de); spf=pass (google.com: domain of linux-kernel+bounces-55667-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55667-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de X-Forwarded-Encrypted: i=1; AJvYcCXC9cwIK/KJ22/0TwsRN26uNVbrP5+j7enp0LSJJGl0zCZRT9syjvDAT+zIZJWZJH6LSnQ8Ykec1p9t+mjfuk6h/ainRA== Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i10-20020ad4410a000000b0068c508e015dsi3252932qvp.299.2024.02.06.14.05.52 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Feb 2024 14:05:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-55667-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmx.de header.s=s31663417 header.b=uLEsDdvr; arc=pass (i=1 spf=pass spfdomain=gmx.de dkim=pass dkdomain=gmx.de dmarc=pass fromdomain=gmx.de); spf=pass (google.com: domain of linux-kernel+bounces-55667-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-55667-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=gmx.de Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 9D9E31C21DE4 for <ouuuleilei@gmail.com>; Tue, 6 Feb 2024 22:05:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 12AF61CD17; Tue, 6 Feb 2024 22:05:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b="uLEsDdvr" Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAA611BC20; Tue, 6 Feb 2024 22:05:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.22 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257112; cv=none; b=SfuelkJ9/kMJOs63q6FGkmh1RlwFNN7O1x11nc/B3CPjEVwoKxC+K3Wvp2cxFGH+0tCcf38XkSxDxcoVcKHu77bdZqNq8IS15HKw2ZiP3Dva4ruLSevTkmPZvUfBB2hOrDA2BrpPaVQJKUhNuVC/mcpaGWEsRnCez+ZhBpmcU80= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707257112; c=relaxed/simple; bh=NDUyZqbfNLTQiXuIWY2WA7uhM6lD4SItVlaGr+B6T6c=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Wyg5u2rdpdAguYifYzEEBc+NbLhdLnHaCnz/HT3uy7HlIayu1RZLYGC2H4sIZ1aK/gOfeeODptFfXKbPY7qCQry3hJ0kibB3yEMJji408hVVf6y/X3b++hrDvOZR4g58otIzsds0N3LO+2vfrMo0bYHyW6Wdk5aYZmKVGlKOKEk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de; spf=pass smtp.mailfrom=gmx.de; dkim=pass (2048-bit key) header.d=gmx.de header.i=w_armin@gmx.de header.b=uLEsDdvr; arc=none smtp.client-ip=212.227.17.22 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1707257100; x=1707861900; i=w_armin@gmx.de; bh=NDUyZqbfNLTQiXuIWY2WA7uhM6lD4SItVlaGr+B6T6c=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=uLEsDdvrcWRVnhprP0UrgsrOsPalld2E1M0JcDieRGAJE5iYgZFxebXpdoCKYGaa AY0rBZdVEcU2rE0bn+/3FRan0EhtaXDzcX5ypU4lqkWOzV2A+Rgc/6x/a/ejo54YF Mu1RXzzl9mm1NU4CbOOOCwvVVi1okaudIg6pX8AtLI0lDfWjNGor3RNcThusbbuOj /xZqwtm9a16JG0bm353QkX8RZY3ruITBVw/K1VpCvnAb+YPvuNs6GUwCsLX6tZYBt 4ZExq3KGEODLs53Smw1RnkeEEHhOOQ6j1hdsJAFSzU8RRl5fXTxjxFCKz9CrGT/8b 0NfeIlguRXKiSCLA2A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from mx-amd-b650.users.agdsn.de ([141.30.226.129]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mof9F-1rDmwX0YXp-00p6ut; Tue, 06 Feb 2024 23:05:00 +0100 From: Armin Wolf <W_Armin@gmx.de> To: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/4] platform/x86: wmi: Check if WMxx control method exists Date: Tue, 6 Feb 2024 23:04:44 +0100 Message-Id: <20240206220447.3102-1-W_Armin@gmx.de> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:EbPnQIq2qjLcvrZhzs/4oVtEcQuSYO+IVBIrKFXPD+2vHJScH+4 JecIMfiItoB59RQS5tN06+d/4reTYJVaYLgvUurGl5Pg24f1/VqZMcurTYuqS72kGUUB2u9 yJ8LJyTkMN4aaSa8/cBdxXqXOugWhJjg9ufamjpXcuPV4jQeb2BuLtSRoNOghEnbGZN4S5/ sSm3ArutxrZganvGU1qNQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:9k1+nBJUUnc=;8RH+2D2XDGPEx8aG+E9Xmp2k46V V/eh78PXdd72aGRQm9ypNrAB3mLEh2c7zKrmifctM1rIIu4L9g4TqAKPyU4TFdPKQTPmXVEML 4FL20ssIeP23bVlZwYyyJkBEj2Q642Om2wfswzRiF8NeMDEZOnIil+XlznbQZUzCqPcnsHYfH TLvNlftj+dNLUzq+Px8vnPi3cqCQvv5DDsIQrIxusYaXohBA/eCsjBrbWYspSG1xRQp5UseP2 AacNnFYv+EDhoyCbN8HKVHK5EDyoipSP9DpHSRQfvbAstV09rMazAXq+aEG+8mHOzfcgjykQR /6rN2OsU/zaEw8SnsvO9luyIFeEM3vlOFnzl1r4Nx/922aUMdtdI+GdGSKFA0Yq8YK/htdQYm sxs/9hl4cNs1g1c16i4ed+04ltxk9HjOk83+NXxTOaZeDoJf81io1LVMuz17jxbsNdl9qHREH mqqOjHtgBEaeetMEf3/1lR3yoN+7+5OMiH5fQp64ryoJZqOb6lEdETSCtWlbWsm+4gW9JRMr8 aSN/MlC81exJEkjzSay7q2siakWgbN9ApWWR0UJMuZ7ITgbtHVZivRvXH57IO6EwENqa6fq9R 9DB8C9joMLcn7EEUhjTFrQ1kxYHkS+iMw9N4tw0nsUwJBJH1l9LuebUxfZ4OFO7PZyPpQ+Dno 5gvEOUV43CRHnjHCQ1bmLEhITtog/byFsfEK+SOMRqriRAN6TO7zSbRswV29Pbj1aFcLYCIQR J9uMbt/uu0PRlkuNRNx+ztFn2n51l9sff9pktsJvfGn2MBa3r5mRNCW9GgCGd/MTPWqlPi7mo 8Zb9XX0wW9wEgtT/i3QLX+0HOoJmYcGafhSs2l9DzymW0= X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790188876378506183 X-GMAIL-MSGID: 1790188876378506183 |
Series |
[1/4] platform/x86: wmi: Check if WMxx control method exists
|
|
Commit Message
Armin Wolf
Feb. 6, 2024, 10:04 p.m. UTC
Some devices like the MSI GF63-12VF contain WMI method blocks
without providing the necessary WMxx ACPI control methods.
Avoid creating WMI devices for such WMI method blocks since
the resulting WMI device is going to be unusable.
Signed-off-by: Armin Wolf <W_Armin@gmx.de>
---
drivers/platform/x86/wmi.c | 9 +++++++++
1 file changed, 9 insertions(+)
--
2.39.2
Comments
On Tue, 06 Feb 2024 23:04:44 +0100, Armin Wolf wrote: > Some devices like the MSI GF63-12VF contain WMI method blocks > without providing the necessary WMxx ACPI control methods. > Avoid creating WMI devices for such WMI method blocks since > the resulting WMI device is going to be unusable. > > Thank you for your contribution, it has been applied to my local review-ilpo branch. Note it will show up in the public platform-drivers-x86/review-ilpo branch only once I've pushed my local branch there, which might take a while. The list of commits applied: [1/4] platform/x86: wmi: Check if WMxx control method exists commit: 7f1b998a9108f7fd465039323d5fc2599b8cae77 [2/4] platform/x86: wmi: Use FW_BUG when warning about missing control methods commit: d0c595a11785573aad3b9e32ae293c48757eceff [3/4] platform/x86: wmi: Remove unnecessary out-of-memory message commit: 49c67cd5b6a4b611ac775de3831f5e739dd580f2 [4/4] platform/x86: wmi: Replace pr_err() with dev_err() commit: fde7da1072f3c0239a80b590e7b75c9411e8b630 -- i.
diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 3c288e8f404b..9d544c85e5a8 100644 --- a/drivers/platform/x86/wmi.c +++ b/drivers/platform/x86/wmi.c @@ -990,6 +990,15 @@ static int wmi_create_device(struct device *wmi_bus_dev, } if (wblock->gblock.flags & ACPI_WMI_METHOD) { + get_acpi_method_name(wblock, 'M', method); + if (!acpi_has_method(device->handle, method)) { + dev_warn(wmi_bus_dev, + FW_BUG "%s method block execution control method not found\n", + method); + + return -ENXIO; + } + wblock->dev.dev.type = &wmi_type_method; goto out_init; }