diff mbox series

[v1,1/2] dt-bindings: pwm: sophgo: add pwm for Sophgo CV1800 series SoC.

Message ID 20240207055856.672184-2-qiujingbao.dlmu@gmail.com
State New
Headers
Series [v1,1/2] dt-bindings: pwm: sophgo: add pwm for Sophgo CV1800 series SoC. |

Commit Message

Jingbao Qiu Feb. 7, 2024, 5:58 a.m. UTC 
  Add devicetree binding to describe the PWM for Sophgo CV1800 SoC.

Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
---
 .../bindings/pwm/sophgo,cv1800-pwm.yaml       | 45 +++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/pwm/sophgo,cv1800-pwm.yaml

Comments

Krzysztof Kozlowski Feb. 7, 2024, 7:45 a.m. UTC | #1 
On 07/02/2024 06:58, Jingbao Qiu wrote:
> Add devicetree binding to describe the PWM for Sophgo CV1800 SoC.
> 
> Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> ---
>  .../bindings/pwm/sophgo,cv1800-pwm.yaml       | 45 +++++++++++++++++++
>  1 file changed, 45 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/sophgo,cv1800-pwm.yaml
> 

If there is going to be resend: drop full stop from subject and re-order
maintainers and description to match convention (look at other schemas
and example-schema).

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Jingbao Qiu Feb. 7, 2024, 7:53 a.m. UTC | #2 
On Wed, Feb 7, 2024 at 3:45 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 07/02/2024 06:58, Jingbao Qiu wrote:
> > Add devicetree binding to describe the PWM for Sophgo CV1800 SoC.
> >
> > Signed-off-by: Jingbao Qiu <qiujingbao.dlmu@gmail.com>
> > ---
> >  .../bindings/pwm/sophgo,cv1800-pwm.yaml       | 45 +++++++++++++++++++
> >  1 file changed, 45 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/pwm/sophgo,cv1800-pwm.yaml
> >
>
> If there is going to be resend: drop full stop from subject and re-order
> maintainers and description to match convention (look at other schemas
> and example-schema).

Thank you for your suggestion. I will fix it.

Best regards,
Jingbao Qiu
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/pwm/sophgo,cv1800-pwm.yaml b/Documentation/devicetree/bindings/pwm/sophgo,cv1800-pwm.yaml
new file mode 100644
index 000000000000..7fcdf98b27fd
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/sophgo,cv1800-pwm.yaml
@@ -0,0 +1,45 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/sophgo,cv1800-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sophgo CV1800 PWM controller
+
+description:
+  The chip provides a set of four independent PWM channel outputs.
+
+maintainers:
+  - Jingbao Qiu <qiujingbao.dlmu@gmail.com>
+
+allOf:
+  - $ref: pwm.yaml#
+
+properties:
+  compatible:
+    const: sophgo,cv1800-pwm
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  "#pwm-cells":
+    const: 3
+
+required:
+  - compatible
+  - reg
+  - clocks
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    pwm0: pwm@3060000 {
+        compatible = "sophgo,cv1800-pwm";
+        reg = <0x3060000 0x1000>;
+        clocks = <&clk 60>;
+        #pwm-cells = <3>;
+    };