diff mbox series

cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig

Message ID 20240204094613.40687-1-masahiroy@kernel.org
State New
Headers
Series cxl: remove CONFIG_CXL_PMU entry in drivers/cxl/Kconfig |

Commit Message

Masahiro Yamada Feb. 4, 2024, 9:46 a.m. UTC 
  Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
added the config entries for CXL_PMU in drivers/cxl/Kconfig and
drivers/perf/Kconfig, so it can be toggled from multiple locations:

[1] Device Drivers
     -> PCI support
       -> CXL (Compute Expres Link) Devices
         -> CXL Performance Monitoring Unit

[2] Device Drivers
     -> Performance monitor support
       -> CXL Performance Monitoring Unit

This complicates things, and nobody else does this.

I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
the compilation of drivers/perf/cxl_pmu.c.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
---

 drivers/cxl/Kconfig | 13 -------------
 1 file changed, 13 deletions(-)

Comments

Davidlohr Bueso Feb. 5, 2024, 8:54 p.m. UTC | #1 
On Sun, 04 Feb 2024, Masahiro Yamada wrote:

>Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
>added the config entries for CXL_PMU in drivers/cxl/Kconfig and
>drivers/perf/Kconfig, so it can be toggled from multiple locations:
>
>[1] Device Drivers
>     -> PCI support
>       -> CXL (Compute Expres Link) Devices
>         -> CXL Performance Monitoring Unit
>
>[2] Device Drivers
>     -> Performance monitor support
>       -> CXL Performance Monitoring Unit
>
>This complicates things, and nobody else does this.
>
>I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
>the compilation of drivers/perf/cxl_pmu.c.

Completely agree. In general we should try to keep config
options minimal where possible.

Acked-by: Davidlohr Bueso <dave@stgolabs.net>

>
>Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
>---
>
> drivers/cxl/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
>diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
>index 67998dbd1d46..5f3c9c5529b9 100644
>--- a/drivers/cxl/Kconfig
>+++ b/drivers/cxl/Kconfig
>@@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
>	  If unsure, or if this kernel is meant for production environments,
>	  say N.
>
>-config CXL_PMU
>-	tristate "CXL Performance Monitoring Unit"
>-	default CXL_BUS
>-	depends on PERF_EVENTS
>-	help
>-	  Support performance monitoring as defined in CXL rev 3.0
>-	  section 13.2: Performance Monitoring. CXL components may have
>-	  one or more CXL Performance Monitoring Units (CPMUs).
>-
>-	  Say 'y/m' to enable a driver that will attach to performance
>-	  monitoring units and provide standard perf based interfaces.
>-
>-	  If unsure say 'm'.
> endif
>--
>2.40.1
>
Dave Jiang Feb. 5, 2024, 10:07 p.m. UTC | #2 
On 2/4/24 2:46 AM, Masahiro Yamada wrote:
> Commit 5d7107c72796 ("perf: CXL Performance Monitoring Unit driver")
> added the config entries for CXL_PMU in drivers/cxl/Kconfig and
> drivers/perf/Kconfig, so it can be toggled from multiple locations:
> 
> [1] Device Drivers
>      -> PCI support
>        -> CXL (Compute Expres Link) Devices
>          -> CXL Performance Monitoring Unit
> 
> [2] Device Drivers
>      -> Performance monitor support
>        -> CXL Performance Monitoring Unit
> 
> This complicates things, and nobody else does this.
> 
> I kept the one in drivers/perf/Kconfig because CONFIG_CXL_PMU controls
> the compilation of drivers/perf/cxl_pmu.c.
> 
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> 
>  drivers/cxl/Kconfig | 13 -------------
>  1 file changed, 13 deletions(-)
> 
> diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
> index 67998dbd1d46..5f3c9c5529b9 100644
> --- a/drivers/cxl/Kconfig
> +++ b/drivers/cxl/Kconfig
> @@ -144,17 +144,4 @@ config CXL_REGION_INVALIDATION_TEST
>  	  If unsure, or if this kernel is meant for production environments,
>  	  say N.
>  
> -config CXL_PMU
> -	tristate "CXL Performance Monitoring Unit"
> -	default CXL_BUS
> -	depends on PERF_EVENTS
> -	help
> -	  Support performance monitoring as defined in CXL rev 3.0
> -	  section 13.2: Performance Monitoring. CXL components may have
> -	  one or more CXL Performance Monitoring Units (CPMUs).
> -
> -	  Say 'y/m' to enable a driver that will attach to performance
> -	  monitoring units and provide standard perf based interfaces.
> -
> -	  If unsure say 'm'.
>  endif
diff mbox series

Patch

diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig
index 67998dbd1d46..5f3c9c5529b9 100644
--- a/drivers/cxl/Kconfig
+++ b/drivers/cxl/Kconfig
@@ -144,17 +144,4 @@  config CXL_REGION_INVALIDATION_TEST
 	  If unsure, or if this kernel is meant for production environments,
 	  say N.
 
-config CXL_PMU
-	tristate "CXL Performance Monitoring Unit"
-	default CXL_BUS
-	depends on PERF_EVENTS
-	help
-	  Support performance monitoring as defined in CXL rev 3.0
-	  section 13.2: Performance Monitoring. CXL components may have
-	  one or more CXL Performance Monitoring Units (CPMUs).
-
-	  Say 'y/m' to enable a driver that will attach to performance
-	  monitoring units and provide standard perf based interfaces.
-
-	  If unsure say 'm'.
 endif