diff mbox series

rpmsg: core: make rpmsg_bus const

Message ID 20240204-bus_cleanup-rpmsg-v1-1-1703508c23b7@marliere.net
State New
Headers
Series rpmsg: core: make rpmsg_bus const |

Commit Message

Ricardo B. Marliere Feb. 4, 2024, 8:32 p.m. UTC 
  Now that the driver core can properly handle constant struct bus_type,
move the rpmsg_bus variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 drivers/rpmsg/rpmsg_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 80255b24efbe83a6a01600484b6959259a30ded5
change-id: 20240204-bus_cleanup-rpmsg-1a5f6ab69a24

Best regards,

Comments

Greg KH Feb. 5, 2024, 12:47 p.m. UTC | #1 
On Sun, Feb 04, 2024 at 05:32:05PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rpmsg_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mathieu Poirier Feb. 5, 2024, 8:45 p.m. UTC | #2 
On Sun, Feb 04, 2024 at 05:32:05PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the rpmsg_bus variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  drivers/rpmsg/rpmsg_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> index 8abc7d022ff7..4295c01a2861 100644
> --- a/drivers/rpmsg/rpmsg_core.c
> +++ b/drivers/rpmsg/rpmsg_core.c
> @@ -605,7 +605,7 @@ static void rpmsg_dev_remove(struct device *dev)
>  		rpmsg_destroy_ept(rpdev->ept);
>  }
>  
> -static struct bus_type rpmsg_bus = {
> +static const struct bus_type rpmsg_bus = {
>  	.name		= "rpmsg",
>  	.match		= rpmsg_dev_match,
>  	.dev_groups	= rpmsg_dev_groups,
>

Applied.

Thanks,
Mathieu

> ---
> base-commit: 80255b24efbe83a6a01600484b6959259a30ded5
> change-id: 20240204-bus_cleanup-rpmsg-1a5f6ab69a24
> 
> Best regards,
> -- 
> Ricardo B. Marliere <ricardo@marliere.net>
>
diff mbox series

Patch

diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
index 8abc7d022ff7..4295c01a2861 100644
--- a/drivers/rpmsg/rpmsg_core.c
+++ b/drivers/rpmsg/rpmsg_core.c
@@ -605,7 +605,7 @@  static void rpmsg_dev_remove(struct device *dev)
 		rpmsg_destroy_ept(rpdev->ept);
 }
 
-static struct bus_type rpmsg_bus = {
+static const struct bus_type rpmsg_bus = {
 	.name		= "rpmsg",
 	.match		= rpmsg_dev_match,
 	.dev_groups	= rpmsg_dev_groups,