Message ID | 20231209225135.4055334-1-colin.i.king@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:bcd1:0:b0:403:3b70:6f57 with SMTP id r17csp6269301vqy; Sat, 9 Dec 2023 14:52:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IHP1nay8PS+YeET9Kby5G8q2CD5smvNiGtCpm7yhj/OiJLMhq3Z2dsJ4hEFzRdJfsQs323z X-Received: by 2002:a05:6a20:5526:b0:190:2b27:aa34 with SMTP id ko38-20020a056a20552600b001902b27aa34mr2581471pzb.62.1702162339027; Sat, 09 Dec 2023 14:52:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702162339; cv=none; d=google.com; s=arc-20160816; b=SHxZ/FQ8IUMrhu0HQKljAhEaWbZCZsKm1ELkeLcJTTjevUmy5NWU4l7UsVW/n4xF2v nf84j4ztHTrcxUzCBzP41Cpl3aG5aREGfTqaD9eecbHswd9odXvyrnyozWzG+97hcdHy 3bwdCTbXuYvWQOVa3eovfBT0p8vNs/u93BLVjVLspsZSJt1nxAmv/LSrRGLEKg9ueojl nNM6vKeim+Welhs8R7Y1W/JSsMomNyC8jfFMfFt4feN8VO9FrnLijWtOTMK2Q3TRiXiI Yg9gOI4Nhw0bSaUbtIN8pTETnSdmW5TqjhCXfAlIFFUrpfYbpg1FUUwg0fCtT/Itlfaq 5EWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jiKQMydv0yccuw3WqYLVo3Netyg+0OTtTTWArCeoSKY=; fh=f/YbSV3HoIg8QI+RM46dEKSE6E98IiCQCkYe5QCHq9U=; b=Ehei6CviUm7ebMM8vTAcMWt//HkZgV52M+fLS+P4PWAny2cGQJ1oQ66lb8uFy6NLWt oxz9Uqj1DKvkUytXsx2HRYM0bc7Zt9NLAt2wNp8S6+Ew3smDbJ/05ShwCHHj0G+OnYtg aozW4LuydB2gcQv7qP/KNA10+0M+AiKhPx9ubG5bL4fQpT+thOaYnxq6On4v2bx5IxBC tosyUlsQSVwD9veyU45c4zpc4n0OHcZY+rn9c5tnxTKIWGv4Mcns4xn2pgkThf1flX8S PU77Op5tQW7yqszV6xgpx4HBhnb8SwjFACcGQnSXzsdLZ9hXGMA0ofH/mYmEsbbehkrI 9TTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=I3tpzAHz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id 1-20020a17090a08c100b00286c13656dcsi3788789pjn.187.2023.12.09.14.52.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 14:52:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=I3tpzAHz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 89D93807FC0B; Sat, 9 Dec 2023 14:51:51 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231285AbjLIWvd (ORCPT <rfc822;kartikey406@gmail.com> + 99 others); Sat, 9 Dec 2023 17:51:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjLIWvc (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 9 Dec 2023 17:51:32 -0500 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E63115; Sat, 9 Dec 2023 14:51:38 -0800 (PST) Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3332ad5b3e3so3170159f8f.2; Sat, 09 Dec 2023 14:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702162297; x=1702767097; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jiKQMydv0yccuw3WqYLVo3Netyg+0OTtTTWArCeoSKY=; b=I3tpzAHzzJPp2aZUlnspAbs+YrXXvhGV4/fWlAuJQdsGhhMA6uRo1GDLO3ujL1nhG3 N3mdoUf2m+GMtcPj79CaKwtveDfRTztVC4saeivZ/h1L1h7U1aRnECNHRVpenmSrF9mE VmfWmkcNZBsvRCgQzFb8eWSi8uvn7LmbZoMh/4VcONYQYDHg59OGGmP5Ca6lENA0MLMp AG8Kcm1+FcSRr9MeA49BsYgQ5X3xEw7Kog6QNyql6j0CIOWhNHX7vOBgQf+Pkjdbk6Bw mjZzlpUObTcthoWdHCNR2TUvzxsO1ttlEXYOQM7a7up9iAE/t1EBAOcrNOlygoBsgTRw x3Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702162297; x=1702767097; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jiKQMydv0yccuw3WqYLVo3Netyg+0OTtTTWArCeoSKY=; b=iKNVrPz6+vWFiGxVatWq39OlKxiHEidAzHiC4O/bGj4aC0zoVRYl+8v8yd+QvRta+1 +OhWQBki1uIlF/HSJbpM3Dr4vd7klcwouTgoEozMQnn8CGiuKkqZPeb+Z/b7NW7K/imI GK8T+mDLLMrA/qFZYkJF57Ih9tj/9DzZoFx9buJtBN3/31bZ+jq5K5JN6jorJ4b5qIro aM4I9IwzP0eZWHoeKJcYu0OnUt2Esrv5bCEMFrsNDUQr93BDsRgj7x1o0DYngK8W9vv3 mmzHm3vV3en0Pb/m4h5zbgLSeZClRLpLT2werppldSTe5prylj1xcf9EvXCFgX/KOLHr hA1g== X-Gm-Message-State: AOJu0YxVdtMUoUQBtqqKlVa+sNm0rY87Aq5G7E705xMD7J9bNzEKRvu+ j23wWBgdjTsoc8GAi0b2/v8= X-Received: by 2002:a05:6000:4d0:b0:332:eeba:ee8b with SMTP id h16-20020a05600004d000b00332eebaee8bmr913794wri.24.1702162296902; Sat, 09 Dec 2023 14:51:36 -0800 (PST) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id w14-20020a5d608e000000b003333c2c313bsm5157467wrt.100.2023.12.09.14.51.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 14:51:36 -0800 (PST) From: Colin Ian King <colin.i.king@gmail.com> To: Tariq Toukan <tariqt@nvidia.com>, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, netdev@vger.kernel.org, linux-rdma@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] mlx4: Fix spelling mistake: "mape" -> "map" Date: Sat, 9 Dec 2023 22:51:35 +0000 Message-Id: <20231209225135.4055334-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sat, 09 Dec 2023 14:51:51 -0800 (PST) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1784846577036885757 X-GMAIL-MSGID: 1784846577036885757 |
Series |
[next] mlx4: Fix spelling mistake: "mape" -> "map"
|
|
Commit Message
Colin Ian King
Dec. 9, 2023, 10:51 p.m. UTC
There is a spelling mistake in a mlx4_err error message. Fix it.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
drivers/net/ethernet/mellanox/mlx4/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: > There is a spelling mistake in a mlx4_err error message. Fix it. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Hi Colin, I am guessing that you are focusing on error messages and other user-facing spelling errors (perhaps you told me f2f in the hallway track at Kernel Recipes). But I do wonder if you have plans to address other spelling errors in this driver. codespell flags many, including 'segements' in a comment in the same file. In any case, Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, 12 Dec 2023 20:30:43 +0000 Simon Horman wrote: > On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: > > There is a spelling mistake in a mlx4_err error message. Fix it. > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Hi Colin, > > I am guessing that you are focusing on error messages and other user-facing > spelling errors (perhaps you told me f2f in the hallway track at Kernel > Recipes). But I do wonder if you have plans to address other spelling > errors in this driver. codespell flags many, including 'segements' in a > comment in the same file. It'd be great to fix all the codespell issues with one path, IMO.
On 12/12/2023 20:30, Simon Horman wrote: > On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: >> There is a spelling mistake in a mlx4_err error message. Fix it. >> >> Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > Hi Colin, > > I am guessing that you are focusing on error messages and other user-facing > spelling errors (perhaps you told me f2f in the hallway track at Kernel > Recipes). But I do wonder if you have plans to address other spelling > errors in this driver. codespell flags many, including 'segements' in a > comment in the same file. Yes, there are so many trivial spelling mistakes and typos across the kernel that I'm just focusing on user facing error messages for the moment. Colin > > In any case, > > Reviewed-by: Simon Horman <horms@kernel.org>
On Tue, Dec 12, 2023 at 01:19:13PM -0800, Jakub Kicinski wrote: > On Tue, 12 Dec 2023 20:30:43 +0000 Simon Horman wrote: > > On Sat, Dec 09, 2023 at 10:51:35PM +0000, Colin Ian King wrote: > > > There is a spelling mistake in a mlx4_err error message. Fix it. > > > > > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > > > > Hi Colin, > > > > I am guessing that you are focusing on error messages and other user-facing > > spelling errors (perhaps you told me f2f in the hallway track at Kernel > > Recipes). But I do wonder if you have plans to address other spelling > > errors in this driver. codespell flags many, including 'segements' in a > > comment in the same file. > > It'd be great to fix all the codespell issues with one path, IMO. For the record, I have sent a follow up here: - [PATCH net-nex] mlx4: Address spelling errors https://lore.kernel.org/netdev/20240205-mlx5-codespell-v1-1-63b86dffbb61@kernel.org/
diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c index 2581226836b5..43cbe4e5d0c4 100644 --- a/drivers/net/ethernet/mellanox/mlx4/main.c +++ b/drivers/net/ethernet/mellanox/mlx4/main.c @@ -1508,7 +1508,7 @@ static int mlx4_port_map_set(struct mlx4_dev *dev, struct mlx4_port_map *v2p) priv->v2p.port1 = port1; priv->v2p.port2 = port2; } else { - mlx4_err(dev, "Failed to change port mape: %d\n", err); + mlx4_err(dev, "Failed to change port map: %d\n", err); } }