diff mbox series

dma: dma-sysfs: make dma_subsys const

Message ID 20240204-bus_cleanup-sh-v1-1-44ced951bb16@marliere.net
State New
Headers
Series dma: dma-sysfs: make dma_subsys const |

Commit Message

Ricardo B. Marliere Feb. 4, 2024, 3:15 p.m. UTC 
  Now that the driver core can properly handle constant struct bus_type,
move the dma_subsys variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
---
 arch/sh/drivers/dma/dma-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


---
base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
change-id: 20240204-bus_cleanup-sh-6d3c136da6bb

Best regards,

Comments

Geert Uytterhoeven Feb. 4, 2024, 8:45 p.m. UTC | #1 
On Sun, Feb 4, 2024 at 4:14 PM Ricardo B. Marliere <ricardo@marliere.net> wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dma_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
John Paul Adrian Glaubitz Feb. 5, 2024, 5:17 a.m. UTC | #2 
Hi Ricardo,

On Sun, 2024-02-04 at 12:15 -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dma_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> ---
>  arch/sh/drivers/dma/dma-sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
> index 431bc18f0a41..9f666280d80c 100644
> --- a/arch/sh/drivers/dma/dma-sysfs.c
> +++ b/arch/sh/drivers/dma/dma-sysfs.c
> @@ -15,7 +15,7 @@
>  #include <linux/string.h>
>  #include <asm/dma.h>
>  
> -static struct bus_type dma_subsys = {
> +static const struct bus_type dma_subsys = {
>  	.name = "dma",
>  	.dev_name = "dma",
>  };
> 
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240204-bus_cleanup-sh-6d3c136da6bb
> 
> Best regards,

Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>

Thanks for your patch. I will merge it into my linux-sh this weekend
after returning from FOSDEM, either this evening or tomorrow.

Thanks,
Adrian
Ricardo B. Marliere Feb. 5, 2024, 12:09 p.m. UTC | #3 
On  5 Feb 06:17, John Paul Adrian Glaubitz wrote:
> Hi Ricardo,
> 
> On Sun, 2024-02-04 at 12:15 -0300, Ricardo B. Marliere wrote:
> > Now that the driver core can properly handle constant struct bus_type,
> > move the dma_subsys variable to be a constant structure as well,
> > placing it into read-only memory which can not be modified at runtime.
> > 
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>
> > ---
> >  arch/sh/drivers/dma/dma-sysfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
> > index 431bc18f0a41..9f666280d80c 100644
> > --- a/arch/sh/drivers/dma/dma-sysfs.c
> > +++ b/arch/sh/drivers/dma/dma-sysfs.c
> > @@ -15,7 +15,7 @@
> >  #include <linux/string.h>
> >  #include <asm/dma.h>
> >  
> > -static struct bus_type dma_subsys = {
> > +static const struct bus_type dma_subsys = {
> >  	.name = "dma",
> >  	.dev_name = "dma",
> >  };
> > 
> > ---
> > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> > change-id: 20240204-bus_cleanup-sh-6d3c136da6bb
> > 
> > Best regards,
> 
> Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> 
> Thanks for your patch. I will merge it into my linux-sh this weekend
> after returning from FOSDEM, either this evening or tomorrow.

Hi John,

thanks for reviewing. I was wondering if your tree should be listed
under SUPERH in the MAINTAINERS file? I didn't find it there and had to
do some searching.

All the best,
-	Ricardo.


> 
> Thanks,
> Adrian
> 
> -- 
>  .''`.  John Paul Adrian Glaubitz
> : :' :  Debian Developer
> `. `'   Physicist
>   `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913
Greg KH Feb. 5, 2024, 12:51 p.m. UTC | #4 
On Sun, Feb 04, 2024 at 12:15:09PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the dma_subsys variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
John Paul Adrian Glaubitz Feb. 5, 2024, 4:34 p.m. UTC | #5 
Hi Ricardo,

On Mon, 2024-02-05 at 09:09 -0300, Ricardo B. Marliere wrote:
> thanks for reviewing. I was wondering if your tree should be listed
> under SUPERH in the MAINTAINERS file? I didn't find it there and had to
> do some searching.

You're absolutely right. I got my tree set up after I was added to the
MAINTAINERS file, so I eventually forgot to add the URL to my tree.

I will send a patch this week to correct that. Thanks for the heads-up!

Adrian
diff mbox series

Patch

diff --git a/arch/sh/drivers/dma/dma-sysfs.c b/arch/sh/drivers/dma/dma-sysfs.c
index 431bc18f0a41..9f666280d80c 100644
--- a/arch/sh/drivers/dma/dma-sysfs.c
+++ b/arch/sh/drivers/dma/dma-sysfs.c
@@ -15,7 +15,7 @@ 
 #include <linux/string.h>
 #include <asm/dma.h>
 
-static struct bus_type dma_subsys = {
+static const struct bus_type dma_subsys = {
 	.name = "dma",
 	.dev_name = "dma",
 };