Message ID | 20240204212207.3158914-2-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-51910-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:168b:b0:106:860b:bbdd with SMTP id ma11csp536796dyb; Sun, 4 Feb 2024 13:22:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFd2EKaXhXnTgsPi3oLHraqsU4yZcLQfw+Z5hWOCjcg8REoaZSDQodUOAanDDmGEfCj7ZzK X-Received: by 2002:a17:903:41cd:b0:1d9:9aed:cf30 with SMTP id u13-20020a17090341cd00b001d99aedcf30mr5208093ple.30.1707081770942; Sun, 04 Feb 2024 13:22:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707081770; cv=pass; d=google.com; s=arc-20160816; b=gZBs+ynaRj/hbfuQ0cN8tAYknLhL0XVUHb5mN51TS3gM84w1+kSFE8YKVbkZCwcy6D 4IhdCIpyjcdg2DOimp/SvqU3S8oH3qQBUEQ8qMkSbUMKjGwKH0FA9pkULfCY/hV9GR34 bwLnE/WQyC/R/yLQ92uJboApEDOG4q95LKaBCy05fE1TmZVRhHD3hQQirQxhfbXpqmKz esfHvQecHhe0w/dJfvjfP/cGAU/31XZELIQtm+FJoscBi/U7YDDoB7GJBJ0OUQA4TwEZ xt0n6wTUTFCHDzKtBG/D5CoJ/+B8J4UUL08ZzO5lQQlYHdVI+WQe/eZIg4+js6G8mYXh aSHw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=5/o5PzINiSr6rh+bKQYjVsqVJiQlFDUM+dm6j1Rcm7Q=; fh=RbQJP8ySm1BlHe6//qixk7BT2PN9brubWVHjbFocydM=; b=wCg/E/reRWVQGz7KThvi5AknPA0l2VxOyUJ/9/qZ6XhyQR1jJHNrsangPJPUCo4XV9 on3ClqVg8UPBkTvfne4qXpq+AfrwZsEWYekeSGcC3svAgCljrC/yQWuygMc/UkixdvuN 6vTlGYXcyCi6sb6Gmx/n/9Wg9qYfCAout3joszDo7gwMhgiOwf9AoEivkUJSlyvtzYL4 1BASUwLeXnRj0IzZ21Z+ae1ZTXl237bpH1LZyJxE7NlgU7cwu9zxJS9yQZk3eZM9uymE Qt6/MYvBIu5Lba2j0hkVgPo2GHdxGXFOctmsZDxXXju3cHnycuvsOqYUpSaAJ15pN+Kf YqJg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=myFRwBFw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-51910-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51910-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=1; AJvYcCWVDSZXvNq2J7iI++B2IZ4LI0EsyqZIO3petUEQNaq8ZIMCfbn8C8c7F0lltx5gq2iF8Vs9H4cexMbeemaTmlH6zC56FQ== Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d23-20020a631d57000000b005ce08c4bff1si4822125pgm.754.2024.02.04.13.22.50 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Feb 2024 13:22:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-51910-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=myFRwBFw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-51910-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-51910-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id B22B528231B for <ouuuleilei@gmail.com>; Sun, 4 Feb 2024 21:22:50 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9CDC62C69A; Sun, 4 Feb 2024 21:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="myFRwBFw" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E03362C68F; Sun, 4 Feb 2024 21:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707081756; cv=none; b=KnWoO+Poqq8S7Edq/JjxPBjlRldu6W+AM9IipgsRQWHZtpJ0P8c3BKZ+oPmT46fMysBWpDitYKK+A1i0Ggjf55VrH4tFZ4vSAEoY92z8lY4INDLstLgcWlVcuHQugPtfleEBPYe1PQ4tfY7hXghhhVWQRvfgBoXloZL+Um6chik= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707081756; c=relaxed/simple; bh=19YsFeFhaGh/mSKxE5Vjn63fd5qD0OXsxFoyJDZmE8I=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=mHkuZoJ+iy2XzNMzUqvTcEI1mBwqaZ00ElP5584iXs4Np1EnzXRAuuJJM+UK1lBsXk9Ou7nD5oJ1DQlBUhcelRBqErirIrbDCXkLlJoB0F6UxgVGafIoSdKHaBU7Smw+gLuKC+YoEnW4vkPHThcDOTyOQIXtsPX/9S7iIBITvSQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=myFRwBFw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76C63C433F1; Sun, 4 Feb 2024 21:22:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707081755; bh=19YsFeFhaGh/mSKxE5Vjn63fd5qD0OXsxFoyJDZmE8I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=myFRwBFwMCZmakox81paGcwuF+C8pJP+j6xPXIsuXVlyPjXZrHpsz/cPsbBSXwf81 d3YEFKFiOyKeCSiKVm1TkNXBamw4R2oyivuX7qvwN9Vkw6UBRqXNQMGNLUn38TTeRU R7U46kLUkG1m2nIAuCzoQZlXJ5nUe1tN53CynyKDGYf/iwJnFw/GAAdMXTsEx0oXpf Q8VQ/zLIZxGyfC5I175QLoVSY9HdVqV7zQGiv9a/IYYvDWAs5X9pVUHA+Xpcdk4hkb DWnCK7/6YfKVlWpr2qfv+FXCXSrboC3cArvXdujC4TTRX9sHKBJXdK691t5hhs0D3c ReXX9WH9P0B2g== From: Arnd Bergmann <arnd@kernel.org> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Neil Armstrong <neil.armstrong@linaro.org> Cc: Arnd Bergmann <arnd@arndb.de>, Weidong Wang <wangweidong.a@awinic.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ASoC: fix SND_SOC_WCD939X dependencies Date: Sun, 4 Feb 2024 22:22:02 +0100 Message-Id: <20240204212207.3158914-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240204212207.3158914-1-arnd@kernel.org> References: <20240204212207.3158914-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1790004975100540585 X-GMAIL-MSGID: 1790004975100540585 |
Series |
[1/2] ASoC: SOF: amd: fix SND_AMD_SOUNDWIRE_ACPI dependencies
|
|
Commit Message
Arnd Bergmann
Feb. 4, 2024, 9:22 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> SND_SOC_WCD939X has an optional dependency on TYPEC, so the newly added SND_SOC_WCD939X_SDW option that selects it needs the same dependency, otherwise it can fail randconfig builds like: WARNING: unmet direct dependencies detected for SND_SOC_WCD939X Depends on [m]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_WCD939X_SDW [=y] && (SOUNDWIRE [=y] || !SOUNDWIRE [=y]) && (TYPEC [=m] || !TYPEC [=m]) Selected by [y]: - SND_SOC_WCD939X_SDW [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SOUNDWIRE [=y] arm-linux-gnueabi-ld: sound/soc/codecs/wcd939x.o: in function `wcd939x_soc_codec_remove': wcd939x.c:(.text+0x1950): undefined reference to `wcd_clsh_ctrl_free' arm-linux-gnueabi-ld: sound/soc/codecs/wcd939x.o: in function `wcd939x_codec_ear_dac_event': wcd939x.c:(.text+0x35d8): undefined reference to `wcd_clsh_ctrl_set_state' arm-linux-gnueabi-ld: sound/soc/codecs/wcd939x.o: in function `wcd939x_codec_enable_hphr_pa': wcd939x.c:(.text+0x39b0): undefined reference to `wcd_clsh_ctrl_set_state' arm-linux-gnueabi-ld: wcd939x.c:(.text+0x39dc): undefined reference to `wcd_clsh_set_hph_mode' arm-linux-gnueabi-ld: wcd939x.c:(.text+0x3bc0): undefined reference to `wcd_clsh_ctrl_set_state' Fixes: be2af391cea0 ("ASoC: codecs: Add WCD939x Soundwire devices driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- sound/soc/codecs/Kconfig | 1 + 1 file changed, 1 insertion(+)
Comments
On 04/02/2024 22:22, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > SND_SOC_WCD939X has an optional dependency on TYPEC, so the newly added > SND_SOC_WCD939X_SDW option that selects it needs the same dependency, otherwise > it can fail randconfig builds like: > > WARNING: unmet direct dependencies detected for SND_SOC_WCD939X > Depends on [m]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_WCD939X_SDW [=y] && (SOUNDWIRE [=y] || !SOUNDWIRE [=y]) && (TYPEC [=m] > || !TYPEC [=m]) > Selected by [y]: > - SND_SOC_WCD939X_SDW [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SOUNDWIRE [=y] > arm-linux-gnueabi-ld: sound/soc/codecs/wcd939x.o: in function `wcd939x_soc_codec_remove': > wcd939x.c:(.text+0x1950): undefined reference to `wcd_clsh_ctrl_free' > arm-linux-gnueabi-ld: sound/soc/codecs/wcd939x.o: in function `wcd939x_codec_ear_dac_event': > wcd939x.c:(.text+0x35d8): undefined reference to `wcd_clsh_ctrl_set_state' > arm-linux-gnueabi-ld: sound/soc/codecs/wcd939x.o: in function `wcd939x_codec_enable_hphr_pa': > wcd939x.c:(.text+0x39b0): undefined reference to `wcd_clsh_ctrl_set_state' > arm-linux-gnueabi-ld: wcd939x.c:(.text+0x39dc): undefined reference to `wcd_clsh_set_hph_mode' > arm-linux-gnueabi-ld: wcd939x.c:(.text+0x3bc0): undefined reference to `wcd_clsh_ctrl_set_state' > > Fixes: be2af391cea0 ("ASoC: codecs: Add WCD939x Soundwire devices driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > sound/soc/codecs/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig > index 75d88bd1dc6f..58ee431edfd8 100644 > --- a/sound/soc/codecs/Kconfig > +++ b/sound/soc/codecs/Kconfig > @@ -2084,6 +2084,7 @@ config SND_SOC_WCD939X > > config SND_SOC_WCD939X_SDW > tristate "WCD9390/WCD9395 Codec - SDW" > + depends on TYPEC || !TYPEC > select SND_SOC_WCD939X > select SND_SOC_WCD_MBHC > select REGMAP_IRQ Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 75d88bd1dc6f..58ee431edfd8 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -2084,6 +2084,7 @@ config SND_SOC_WCD939X config SND_SOC_WCD939X_SDW tristate "WCD9390/WCD9395 Codec - SDW" + depends on TYPEC || !TYPEC select SND_SOC_WCD939X select SND_SOC_WCD_MBHC select REGMAP_IRQ