| Message ID | 20231223221213.774868-5-andreas@kemnade.info |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel+bounces-10598-ouuuleilei=gmail.com@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:7300:2483:b0:fb:cd0c:d3e with SMTP id q3csp1884668dyi;
Sat, 23 Dec 2023 14:13:48 -0800 (PST)
X-Google-Smtp-Source:
AGHT+IFUjYty2GuinlBDlheUXN/4NH6sb/a5s14TeH8zNGHOVYPFuzJpBoTo+0wZFUG6+hSqEvB1
X-Received: by 2002:a05:6871:713:b0:203:c39d:f522 with SMTP id
f19-20020a056871071300b00203c39df522mr3961024oap.90.1703369628259;
Sat, 23 Dec 2023 14:13:48 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1703369628; cv=none;
d=google.com; s=arc-20160816;
b=dP6RUrswWlqNYlK2IfFYR7YBtm14eWkeRgGx7dRpZZL1yMut7PQdEXPNJ+DaVkRpCb
wnnccnTT5rnUANN31RKkqzQX880kIl/XEZu31EzzOue2oW/GTc1mZaK6qD878qHCuYgy
Qi73CX7YoZ3WFi9LZo0xTt1y58Luma2VhBk10QS7QQHrCHFGHdfPznm6KRML1ltlfkAf
z1Bfa2Rv7pFwiv5G/P0MaLI2ysp10vPQCJKLPkJH6GjF4RRH62dfz+2EQOS1T6/gj/K5
zzByfn/VeMAdtF8ntGy9blK9Eq/LCKB7hUSGhS9CIeREy25OrF7l2475Y7NZJUd28o8H
fGAg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=content-transfer-encoding:mime-version:list-unsubscribe
:list-subscribe:list-id:precedence:references:in-reply-to:message-id
:date:subject:to:from:dkim-signature;
bh=b1HMz+ohMNl8A5LPDegcPK2gw7uCgp/vFwsqaqz/imM=;
fh=19PAcIZvNFNleegirCCdfUNxsGxQC+zmYor10Ufsvac=;
b=UhJ7V0tloIhU0s3JqKEB95bc9a82lF3o2KBpXlhhUr3Ro0JIydkzfmmr0V/Olnt6iG
bAFChtVGAQqpa4SsCXm7SJUe85tN46QK9wUrOa+l+QknHv46SCPfPPpK/HgiKaYP9aNL
vP824PEweT9wvEs33LuGoQNnXwQp/w1eKTEhJY3A3UNvgNAGjdq2lajznOeavgThRk3a
bE5jiE3AgX6so2apRP2aGT0M517Nt4NdMU6swTROULXz38e+zUAvc0JllgPcvcODm+NJ
WShCDnih7QdbiJoxIhN78tc5Il86K0oDcKu6LDlhd93M+C59jf8M5ARBjWpj9X7B81mA
yW7w==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=fail header.i=@kemnade.info header.s=20220719 header.b=9VLlq4HG;
spf=pass (google.com: domain of
linux-kernel+bounces-10598-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-10598-ouuuleilei=gmail.com@vger.kernel.org"
Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org.
[2604:1380:45e3:2400::1])
by mx.google.com with ESMTPS id
l10-20020a65680a000000b005ce03c8d175si1541455pgt.810.2023.12.23.14.13.48
for <ouuuleilei@gmail.com>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 23 Dec 2023 14:13:48 -0800 (PST)
Received-SPF: pass (google.com: domain of
linux-kernel+bounces-10598-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Authentication-Results: mx.google.com;
dkim=fail header.i=@kemnade.info header.s=20220719 header.b=9VLlq4HG;
spf=pass (google.com: domain of
linux-kernel+bounces-10598-ouuuleilei=gmail.com@vger.kernel.org designates
2604:1380:45e3:2400::1 as permitted sender)
smtp.mailfrom="linux-kernel+bounces-10598-ouuuleilei=gmail.com@vger.kernel.org"
Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org
[52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by sv.mirrors.kernel.org (Postfix) with ESMTPS id 0B1B4282CCC
for <ouuuleilei@gmail.com>; Sat, 23 Dec 2023 22:13:48 +0000 (UTC)
Received: from localhost.localdomain (localhost.localdomain [127.0.0.1])
by smtp.subspace.kernel.org (Postfix) with ESMTP id 72250224E7;
Sat, 23 Dec 2023 22:12:47 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dkim=fail reason="signature verification failed" (2048-bit key)
header.d=kemnade.info header.i=@kemnade.info header.b="9VLlq4HG"
X-Original-To: linux-kernel@vger.kernel.org
Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by smtp.subspace.kernel.org (Postfix) with ESMTPS id 891B118053;
Sat, 23 Dec 2023 22:12:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
dmarc=none (p=none dis=none) header.from=kemnade.info
Authentication-Results: smtp.subspace.kernel.org;
spf=pass smtp.mailfrom=kemnade.info
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=kemnade.info; s=20220719; h=Content-Transfer-Encoding:MIME-Version:
References:In-Reply-To:Message-Id:Date:Subject:To:From:Sender:Reply-To:Cc:
Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:
List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=b1HMz+ohMNl8A5LPDegcPK2gw7uCgp/vFwsqaqz/imM=; b=9VLlq4HGCfbmZy4/v3pcoPm62r
3S/m3nXnPC7Rnd9mF2GaAKPmFZS9SXBa4FDrLzxwoWKibvw+BEkYdvjqrwZAk3IyhsXbRpcqgULWg
xnnvZzGQlUDEZ9ByXJa3Hk9/LHabwdJGzEhFJYGFXXctzQ3Y0rQrAtnHYMAZQcDaviz814EGIb49C
NYOYCuGxOG6QfmYcxzqIXfQPf4a3Lnm7s4yfJ/KGeBd14L558JkdX4O/vz6161ML4zuNdp7Mzg8dr
2DOxgVk01ZSb66MHawHK3SJlsHttSbEqucaxnmvbz/JTo071Swd001FIt7uzFUufYuEkNhARVdG3l
hS2JwNBw==;
Received: from p200301077700c3001a3da2fffebfd33a.dip0.t-ipconnect.de
([2003:107:7700:c300:1a3d:a2ff:febf:d33a] helo=aktux)
by mail.andi.de1.cc with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
(Exim 4.94.2)
(envelope-from <andreas@kemnade.info>)
id 1rHAEL-007f7e-CM; Sat, 23 Dec 2023 23:12:25 +0100
Received: from andi by aktux with local (Exim 4.96)
(envelope-from <andreas@kemnade.info>)
id 1rHAEK-003FaM-2N;
Sat, 23 Dec 2023 23:12:24 +0100
From: Andreas Kemnade <andreas@kemnade.info>
To: dmitry.torokhov@gmail.com,
robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org,
shawnguo@kernel.org,
s.hauer@pengutronix.de,
kernel@pengutronix.de,
festevam@gmail.com,
linux-imx@nxp.com,
rydberg@bitmath.org,
andreas@kemnade.info,
linus.walleij@linaro.org,
Jonathan.Cameron@huawei.com,
u.kleine-koenig@pengutronix.de,
heiko@sntech.de,
linux-input@vger.kernel.org,
devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] ARM: dts: imx6sl-tolino-shine2hd: fix touchscreen
rotation
Date: Sat, 23 Dec 2023 23:12:13 +0100
Message-Id: <20231223221213.774868-5-andreas@kemnade.info>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20231223221213.774868-1-andreas@kemnade.info>
References: <20231223221213.774868-1-andreas@kemnade.info>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1786112511392367753
X-GMAIL-MSGID: 1786112511392367753
|
| Series |
Input: zforce_ts: standard properties
|
|
Commit Message
Andreas Kemnade
Dec. 23, 2023, 10:12 p.m. UTC
The display is in landscape orientation, but the touchscreen is in portrait
orientation. Specify that properly in the devicetree.
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
Comments
On Sat, Dec 23, 2023 at 11:12:13PM +0100, Andreas Kemnade wrote: > The display is in landscape orientation, but the touchscreen is in portrait > orientation. Specify that properly in the devicetree. This needs to be merged by the board maintainer. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> > --- > arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts > index 815119c12bd48..5636fb3661e8a 100644 > --- a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts > +++ b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts > @@ -141,8 +141,10 @@ zforce: touchscreen@50 { > interrupts = <6 IRQ_TYPE_EDGE_FALLING>; Could you please prepare a patch changing this to IRQ_TYPE_LEVEL_LOW to match what the driver is actually doing? > vdd-supply = <&ldo1_reg>; > reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; > - x-size = <1072>; > - y-size = <1448>; > + touchscreen-size-x = <1072>; > + touchscreen-size-y = <1448>; > + touchscreen-swapped-x-y; > + touchscreen-inverted-x; > }; > > /* TODO: TPS65185 PMIC for E Ink at 0x68 */ > -- > 2.39.2 > Thanks.
On Sat, Dec 23, 2023 at 11:12:13PM +0100, Andreas Kemnade wrote: > The display is in landscape orientation, but the touchscreen is in portrait > orientation. Specify that properly in the devicetree. > > Signed-off-by: Andreas Kemnade <andreas@kemnade.info> Applied, thanks!
diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts index 815119c12bd48..5636fb3661e8a 100644 --- a/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts +++ b/arch/arm/boot/dts/nxp/imx/imx6sl-tolino-shine2hd.dts @@ -141,8 +141,10 @@ zforce: touchscreen@50 { interrupts = <6 IRQ_TYPE_EDGE_FALLING>; vdd-supply = <&ldo1_reg>; reset-gpios = <&gpio5 9 GPIO_ACTIVE_LOW>; - x-size = <1072>; - y-size = <1448>; + touchscreen-size-x = <1072>; + touchscreen-size-y = <1448>; + touchscreen-swapped-x-y; + touchscreen-inverted-x; }; /* TODO: TPS65185 PMIC for E Ink at 0x68 */