diff mbox series

[v1] ALSA: hda/realtek: Remove two HP Laptops using CS35L41

Message ID 20240202161727.321373-1-sbinding@opensource.cirrus.com
State New
Headers
Series [v1] ALSA: hda/realtek: Remove two HP Laptops using CS35L41 |

Commit Message

Stefan Binding Feb. 2, 2024, 4:17 p.m. UTC 
  These two HP laptops are changing configurations.

Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
---
 sound/pci/hda/patch_realtek.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Takashi Iwai Feb. 2, 2024, 4:37 p.m. UTC | #1 
On Fri, 02 Feb 2024 17:17:27 +0100,
Stefan Binding wrote:
> 
> These two HP laptops are changing configurations.

What exactly does this mean?  The PCI SSIDs are no longer valid, or
the quirk became wrong, or what?


thanks,

Takashi
Stefan Binding Feb. 2, 2024, 4:49 p.m. UTC | #2 
Hi Takashi,

On 02/02/2024 16:37, Takashi Iwai wrote:
> On Fri, 02 Feb 2024 17:17:27 +0100,
> Stefan Binding wrote:
>> These two HP laptops are changing configurations.
> What exactly does this mean?  The PCI SSIDs are no longer valid, or
> the quirk became wrong, or what?
>
>
> thanks,
>
> Takashi

The SKUs, and associated SSIDs, are no longer going to include the CS35L41.
They may come back, but will need a different quirk.Sorry for the churn.

Thanks,
Stefan
Takashi Iwai Feb. 2, 2024, 5:06 p.m. UTC | #3 
On Fri, 02 Feb 2024 17:49:06 +0100,
Stefan Binding wrote:
> 
> Hi Takashi,
> 
> On 02/02/2024 16:37, Takashi Iwai wrote:
> > On Fri, 02 Feb 2024 17:17:27 +0100,
> > Stefan Binding wrote:
> >> These two HP laptops are changing configurations.
> > What exactly does this mean?  The PCI SSIDs are no longer valid, or
> > the quirk became wrong, or what?
> > 
> > 
> > thanks,
> > 
> > Takashi
> 
> The SKUs, and associated SSIDs, are no longer going to include the CS35L41.
> They may come back, but will need a different quirk.Sorry for the churn.

OK, care to resubmit with those explanations?


thanks,

Takashi
diff mbox series

Patch

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 348505edf063..3d7e7b32fcf4 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9855,8 +9855,6 @@  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x8cdd, "HP Spectre", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8cde, "HP Spectre", ALC287_FIXUP_CS35L41_I2C_2),
 	SND_PCI_QUIRK(0x103c, 0x8cf5, "HP ZBook Studio 16", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
-	SND_PCI_QUIRK(0x103c, 0x8d01, "HP EliteBook G12", ALC287_FIXUP_CS35L41_I2C_4),
-	SND_PCI_QUIRK(0x103c, 0x8d08, "HP EliteBook 1045 G12", ALC287_FIXUP_CS35L41_I2C_4),
 	SND_PCI_QUIRK(0x1043, 0x103e, "ASUS X540SA", ALC256_FIXUP_ASUS_MIC),
 	SND_PCI_QUIRK(0x1043, 0x103f, "ASUS TX300", ALC282_FIXUP_ASUS_TX300),
 	SND_PCI_QUIRK(0x1043, 0x106d, "Asus K53BE", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),