diff mbox series

[02/12] dt-bindings: arm: keystone: ti-sci: Add reboot-controller child node

Message ID 20240131221957.213717-3-afd@ti.com
State New
Headers
Series Add TI-SCI reboot driver |

Commit Message

Andrew Davis Jan. 31, 2024, 10:19 p.m. UTC 
  The TI-SCI firmware supports rebooting the system in addition to the
functions already listed here, document child node for the same.

Signed-off-by: Andrew Davis <afd@ti.com>
---
 .../devicetree/bindings/arm/keystone/ti,sci.yaml          | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Conor Dooley Feb. 1, 2024, 6:42 p.m. UTC | #1 
On Wed, Jan 31, 2024 at 04:19:47PM -0600, Andrew Davis wrote:
> The TI-SCI firmware supports rebooting the system in addition to the
> functions already listed here, document child node for the same.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> ---
>  .../devicetree/bindings/arm/keystone/ti,sci.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index c24ad0968f3ef..e392175b33c74 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -83,6 +83,10 @@ properties:
>      type: object
>      $ref: /schemas/reset/ti,sci-reset.yaml#
>  
> +  reboot-controller:
> +    type: object
> +    $ref: /schemas/power/reset/ti,sci-reboot.yaml#
> +
>  required:
>    - compatible
>    - mbox-names
> @@ -126,4 +130,8 @@ examples:
>          compatible = "ti,sci-reset";
>          #reset-cells = <2>;
>        };
> +
> +      k3_reboot: reboot-controller {
> +        compatible = "ti,sci-reboot";
> +      };
>      };
> -- 
> 2.39.2
>
Rob Herring Feb. 1, 2024, 11:03 p.m. UTC | #2 
On Wed, Jan 31, 2024 at 04:19:47PM -0600, Andrew Davis wrote:
> The TI-SCI firmware supports rebooting the system in addition to the
> functions already listed here, document child node for the same.
> 
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>  .../devicetree/bindings/arm/keystone/ti,sci.yaml          | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> index c24ad0968f3ef..e392175b33c74 100644
> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
> @@ -83,6 +83,10 @@ properties:
>      type: object
>      $ref: /schemas/reset/ti,sci-reset.yaml#
>  
> +  reboot-controller:
> +    type: object
> +    $ref: /schemas/power/reset/ti,sci-reboot.yaml#

Don't need a ref just for a single property.

But then why do we need a node here at all? Can't you assume reboot 
support for TI-SCI firmware (i.e. based on the parent node). Then you 
don't need a DT update to add the feature.

Rob
Andrew Davis Feb. 1, 2024, 11:50 p.m. UTC | #3 
On 2/1/24 5:03 PM, Rob Herring wrote:
> On Wed, Jan 31, 2024 at 04:19:47PM -0600, Andrew Davis wrote:
>> The TI-SCI firmware supports rebooting the system in addition to the
>> functions already listed here, document child node for the same.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>>   .../devicetree/bindings/arm/keystone/ti,sci.yaml          | 8 ++++++++
>>   1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> index c24ad0968f3ef..e392175b33c74 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> @@ -83,6 +83,10 @@ properties:
>>       type: object
>>       $ref: /schemas/reset/ti,sci-reset.yaml#
>>   
>> +  reboot-controller:
>> +    type: object
>> +    $ref: /schemas/power/reset/ti,sci-reboot.yaml#
> 
> Don't need a ref just for a single property.
> 
> But then why do we need a node here at all? Can't you assume reboot
> support for TI-SCI firmware (i.e. based on the parent node). Then you
> don't need a DT update to add the feature.
> 

We could yes, but then again we could do the same for all the
child nodes of this system-controller parent node. Might even
have been better that way, for now I'm trying to be consistent
with what is already here (child node per service provided,
even though the services are always the same).

Andrew

> Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
index c24ad0968f3ef..e392175b33c74 100644
--- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
+++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
@@ -83,6 +83,10 @@  properties:
     type: object
     $ref: /schemas/reset/ti,sci-reset.yaml#
 
+  reboot-controller:
+    type: object
+    $ref: /schemas/power/reset/ti,sci-reboot.yaml#
+
 required:
   - compatible
   - mbox-names
@@ -126,4 +130,8 @@  examples:
         compatible = "ti,sci-reset";
         #reset-cells = <2>;
       };
+
+      k3_reboot: reboot-controller {
+        compatible = "ti,sci-reboot";
+      };
     };