diff mbox series

vdpa_sim_net: Offer VIRTIO_NET_F_STATUS

Message ID 20221117155502.1394700-1-eperezma@redhat.com
State New
Headers
Series vdpa_sim_net: Offer VIRTIO_NET_F_STATUS |

Commit Message

Eugenio Perez Martin Nov. 17, 2022, 3:55 p.m. UTC 
  VIRTIO_NET_S_LINK_UP is already returned in config reads since vdpasim
creation, but the feature bit was not offered to the driver.

Tested modifying VIRTIO_NET_S_LINK_UP and different values of "status"
in qemu virtio-net options, using vhost_vdpa.

Not considering as a fix, because there should be no driver trusting in
this config read before the feature flag.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefano Garzarella Nov. 17, 2022, 4:25 p.m. UTC | #1 
On Thu, Nov 17, 2022 at 04:55:02PM +0100, Eugenio Pérez wrote:
>VIRTIO_NET_S_LINK_UP is already returned in config reads since vdpasim
>creation, but the feature bit was not offered to the driver.
>
>Tested modifying VIRTIO_NET_S_LINK_UP and different values of "status"
>in qemu virtio-net options, using vhost_vdpa.
>
>Not considering as a fix, because there should be no driver trusting in
>this config read before the feature flag.
>
>Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 1 +
> 1 file changed, 1 insertion(+)

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
Lei Yang Nov. 23, 2022, 11:35 a.m. UTC | #2 
QE applied this path in the test environment, and did regression
testing with a vdpa simulator device; there are no new issues raised
by this patch.

Tested-by: Lei Yang <leiyang@redhat.com>

Eugenio Pérez <eperezma@redhat.com> 于2022年11月23日周三 18:36写道：
>
> VIRTIO_NET_S_LINK_UP is already returned in config reads since vdpasim
> creation, but the feature bit was not offered to the driver.
>
> Tested modifying VIRTIO_NET_S_LINK_UP and different values of "status"
> in qemu virtio-net options, using vhost_vdpa.
>
> Not considering as a fix, because there should be no driver trusting in
> this config read before the feature flag.
>
> Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
> ---
>  drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> index c3cb225ea469..30cfcfcf97f7 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
> @@ -27,6 +27,7 @@
>
>  #define VDPASIM_NET_FEATURES   (VDPASIM_FEATURES | \
>                                  (1ULL << VIRTIO_NET_F_MAC) | \
> +                                (1ULL << VIRTIO_NET_F_STATUS) | \
>                                  (1ULL << VIRTIO_NET_F_MTU) | \
>                                  (1ULL << VIRTIO_NET_F_CTRL_VQ) | \
>                                  (1ULL << VIRTIO_NET_F_CTRL_MAC_ADDR))
> --
> 2.31.1
>
>
diff mbox series

Patch

diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
index c3cb225ea469..30cfcfcf97f7 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim_net.c
@@ -27,6 +27,7 @@ 
 
 #define VDPASIM_NET_FEATURES	(VDPASIM_FEATURES | \
 				 (1ULL << VIRTIO_NET_F_MAC) | \
+				 (1ULL << VIRTIO_NET_F_STATUS) | \
 				 (1ULL << VIRTIO_NET_F_MTU) | \
 				 (1ULL << VIRTIO_NET_F_CTRL_VQ) | \
 				 (1ULL << VIRTIO_NET_F_CTRL_MAC_ADDR))