Message ID | 20240129-x13s-touchscreen-v3-1-c4a933034145@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-43138-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp692554dyb; Mon, 29 Jan 2024 08:49:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IGnydLCHk4uDrlCB3dlIeXJDwJYmL4yYvu9j9r1lBIDHUuK0ZlJOfQwUuEX9Zhp2aJXc4Zd X-Received: by 2002:a05:6402:13cc:b0:55e:f9c4:3525 with SMTP id a12-20020a05640213cc00b0055ef9c43525mr2326496edx.30.1706546966090; Mon, 29 Jan 2024 08:49:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706546966; cv=pass; d=google.com; s=arc-20160816; b=jU+HWLgMCY7P6DK9b3otrIXtasBSADPIvZogiF4P0Su/v0WuvNBfjgKIKThD1q8XZw sd/VXWdPxaJr1BvUjKCsOaL2gyXsgq88ya9qD0MIcrfJW719UDye8MdQP48bQJQ34Pzj pGaHXMM1SuW38K0OOCDEw1ak5r9evrvcLrLX/up5BDJHIGdIiJkOWTA4GDhmJ5I484MY WGoZPFKywWtQKS2fHzlgSpZ19Pt4GAXwsxKWqFqmGsmTEQO543xLb7pE1dWekvY48zvr U5rnh1IjeK90IMHQcRNefmxXxTfZSEifn/9GhBX7eZnbS9aFYdjwqm63uMPnIO0cyPtc +nCg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=yWcwasbMTli/mA5DcycGXWMtS/vMlr7FR2DA8r+wqoQ=; fh=JASAEPYKLgS69vVDzsrNlPvFdidWhQf3L3WUeeF5VWc=; b=q4gOKvMmkoGKcYREr9350cZe8NFaxiha5sfYCnie6RJbCOsKKRSIRs5lg5EQAnrguu BxQRIRd+wQNnlYPvfNYk970ndokE2qEmDaP1/82S2C476LFWHRhnEFKQkRbsj0aWyUgT UW1pRoBm1pmd9ZByeBfrkQ7BYn7XmOSqZOdyXOoE7CRsbpgrOgbDj8i6ABkKwpIW18so UAMc+QBhh3lMZCX1N2WRkDoFt4lT192T8zHh9St1bmZ7lI7tWjQQmtNatps2ATmQ8wsW 1qZaEqABvesezLAnnMVMjGVUOp3bubLZmh7XoEfyo368sid8nrlcfMq2dUYKUYKbH7pK Wr3w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=NBGccvIq; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-43138-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43138-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id n7-20020a5099c7000000b0055cbf54ae9esi3615603edb.570.2024.01.29.08.49.25 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 08:49:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-43138-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=NBGccvIq; arc=pass (i=1 spf=pass spfdomain=quicinc.com dkim=pass dkdomain=quicinc.com dmarc=pass fromdomain=quicinc.com); spf=pass (google.com: domain of linux-kernel+bounces-43138-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-43138-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 926DA1F244B3 for <ouuuleilei@gmail.com>; Mon, 29 Jan 2024 16:49:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 66F3C15957A; Mon, 29 Jan 2024 16:48:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="NBGccvIq" Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B58A154BF0; Mon, 29 Jan 2024 16:48:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706546882; cv=none; b=uPQBNBLiD3y4e0IClu1VLenX9mdB8q0JIS5JKpU37uVY+ZGUASs7MJWemjX9JlHzGxpXYbXt7GAJ4zP84L/Gomeq4clQYt5eEn17upAOKHuxyU8zxVo7S0zpw3b+0Ocsan2w/0YRSsHjJTJMn0ve6kqk4SbSUvgokMa2gsKN0OM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706546882; c=relaxed/simple; bh=wRxyeE1FYChaTRbmRTHXVTWt4fK4t6i35GhQJNVbcDo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-ID:References: In-Reply-To:To:CC; b=qQy+CqF8wiG12NaAhh4wCOvJZLZJseksxQ1WdFrRq9EUdgH3wKjui2B+BGJgJkbK2CUM1/5SFP3J/bUf+r+Cyr9BwutYoHMmZMGzuWCrKUEHljvZFV7LxxQwXDRb8Y3+/r9lc7XfDIiZX0O1Yc3nk7jxpknPxDm9nasGpRdkK2I= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=NBGccvIq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 40TFelt5022360; Mon, 29 Jan 2024 16:47:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= from:date:subject:mime-version:content-type :content-transfer-encoding:message-id:references:in-reply-to:to :cc; s=qcppdkim1; bh=yWcwasbMTli/mA5DcycGXWMtS/vMlr7FR2DA8r+wqoQ =; b=NBGccvIqHa1D2CPJ9nLbDCk6HuQQ5Or3I/y1+VlcFHhYXNuFvceS5gYfls3 6EsV/aAaMAALMq5ZfsaCJXnU3sGU6nEtDYtmqZN3fyUZt4pS/2wlXmnnQRnps/W2 qhyuDpB9rhm6BWyqV/yczW+mRm97TV+yLFZijwKEGcbNlXP6gpKw9aHn+DFOr3CO Jl7ktzOzPERCNl7xD9PXCyqMSuJ01oKuHRxZvE0llrZukMXWmAG+ngjijtVZjak+ UKx0LW68jgEO/wmwa4Cctk3XUAKMmI7Obm/uHiAN49dxPtvSIQ/+qvvdMAcQQZv8 SV2aIjUXbYeWjXjrD1Jg3b4G0vw== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3vxevdr69f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 16:47:49 +0000 (GMT) Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 40TGlmhU016566 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 29 Jan 2024 16:47:48 GMT Received: from [169.254.0.1] (10.49.16.6) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Mon, 29 Jan 2024 08:47:47 -0800 From: Bjorn Andersson <quic_bjorande@quicinc.com> Date: Mon, 29 Jan 2024 08:47:47 -0800 Subject: [PATCH v3 1/2] dt-bindings: HID: i2c-hid: Document reset-related properties Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-ID: <20240129-x13s-touchscreen-v3-1-c4a933034145@quicinc.com> References: <20240129-x13s-touchscreen-v3-0-c4a933034145@quicinc.com> In-Reply-To: <20240129-x13s-touchscreen-v3-0-c4a933034145@quicinc.com> To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, Jiri Kosina <jikos@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Johan Hovold <johan+linaro@kernel.org> CC: <linux-arm-msm@vger.kernel.org>, <linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Bjorn Andersson <quic_bjorande@quicinc.com> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=ed25519-sha256; t=1706546867; l=1308; i=quic_bjorande@quicinc.com; s=20230915; h=from:subject:message-id; bh=wRxyeE1FYChaTRbmRTHXVTWt4fK4t6i35GhQJNVbcDo=; b=svdO0R1HjoxjFsLgFyZvHI+eiAS+FHqdn1ByUv5P6pbSbvlyV5YCR4JGXySsupsN43If2dM3C /d614pvcSTXDWsfaMLC35Yo+rOeaEA8VpktxXRVnEku5n4pGOw/tav2 X-Developer-Key: i=quic_bjorande@quicinc.com; a=ed25519; pk=VkhObtljigy9k0ZUIE1Mvr0Y+E1dgBEH9WoLQnUtbIM= X-ClientProxiedBy: nalasex01b.na.qualcomm.com (10.47.209.197) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: szsRmFwLl5YV6uMV-5PMqidy9Y8EVTuj X-Proofpoint-ORIG-GUID: szsRmFwLl5YV6uMV-5PMqidy9Y8EVTuj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-29_10,2024-01-29_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 clxscore=1015 mlxscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 adultscore=0 impostorscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2401190000 definitions=main-2401290124 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789444191690574570 X-GMAIL-MSGID: 1789444191690574570 |
Series |
arm64: dts: qcom: sc8280xp-x13s: Enable touchscreen
|
|
Commit Message
Bjorn Andersson
Jan. 29, 2024, 4:47 p.m. UTC
Some I2C HID devices has a reset pin and requires that some specified time elapses after this reset pin is deasserted, before communication with the device is attempted. The Linux implementation is looking for these in the "reset-gpios" and "post-reset-deassert-delay-ms" properties already, so use these property names. Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com> --- Documentation/devicetree/bindings/input/hid-over-i2c.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Comments
On Mon, Jan 29, 2024 at 08:47:47AM -0800, Bjorn Andersson wrote: > Some I2C HID devices has a reset pin and requires that some specified > time elapses after this reset pin is deasserted, before communication > with the device is attempted. > > The Linux implementation is looking for these in the "reset-gpios" and > "post-reset-deassert-delay-ms" properties already, so use these property > names. > + post-reset-deassert-delay-ms: > + description: Time required by the device after reset has been deasserted, > + before it is ready for communication. > + > + reset-gpios: true Hmm, for the third time, it seems you ignored my comment that you need to remove the comment about these properties from the driver as part of this series. /* * Note this is a kernel internal device-property set by x86 platform code, * this MUST not be used in devicetree files without first adding it to * the DT bindings. */ if (!device_property_read_u32(dev, "post-reset-deassert-delay-ms", &val)) ihid_of->post_reset_delay_ms = val; > + > touchscreen-inverted-x: true > > touchscreen-inverted-y: true Johan
On Mon, Jan 29, 2024 at 05:56:47PM +0100, Johan Hovold wrote: > On Mon, Jan 29, 2024 at 08:47:47AM -0800, Bjorn Andersson wrote: > > Some I2C HID devices has a reset pin and requires that some specified > > time elapses after this reset pin is deasserted, before communication > > with the device is attempted. > > > > The Linux implementation is looking for these in the "reset-gpios" and > > "post-reset-deassert-delay-ms" properties already, so use these property > > names. > > > + post-reset-deassert-delay-ms: > > + description: Time required by the device after reset has been deasserted, > > + before it is ready for communication. > > + > > + reset-gpios: true > > Hmm, for the third time, it seems you ignored my comment that you need > to remove the comment about these properties from the driver as part of > this series. > > /* > * Note this is a kernel internal device-property set by x86 platform code, > * this MUST not be used in devicetree files without first adding it to > * the DT bindings. > */ > if (!device_property_read_u32(dev, "post-reset-deassert-delay-ms", &val)) > ihid_of->post_reset_delay_ms = val; DT devices should have a specific compatible that gives enough detail to handle this delay or *any* other power sequencing requirement. OTOH, we've already got one other delay property, what's one more. Sigh. Acked-by: Rob Herring <robh@kernel.org> Rob
On Wed, Jan 31, 2024 at 02:22:39PM -0600, Rob Herring wrote: > On Mon, Jan 29, 2024 at 05:56:47PM +0100, Johan Hovold wrote: > > On Mon, Jan 29, 2024 at 08:47:47AM -0800, Bjorn Andersson wrote: > > > Some I2C HID devices has a reset pin and requires that some specified > > > time elapses after this reset pin is deasserted, before communication > > > with the device is attempted. > > > > > > The Linux implementation is looking for these in the "reset-gpios" and > > > "post-reset-deassert-delay-ms" properties already, so use these property > > > names. > > > > > + post-reset-deassert-delay-ms: > > > + description: Time required by the device after reset has been deasserted, > > > + before it is ready for communication. > > > + > > > + reset-gpios: true > > > > Hmm, for the third time, it seems you ignored my comment that you need > > to remove the comment about these properties from the driver as part of > > this series. > > > > /* > > * Note this is a kernel internal device-property set by x86 platform code, > > * this MUST not be used in devicetree files without first adding it to > > * the DT bindings. > > */ > > if (!device_property_read_u32(dev, "post-reset-deassert-delay-ms", &val)) > > ihid_of->post_reset_delay_ms = val; > > DT devices should have a specific compatible that gives enough detail to > handle this delay or *any* other power sequencing requirement. > > OTOH, we've already got one other delay property, what's one more. Sigh. > > Acked-by: Rob Herring <robh@kernel.org> Right, and I guess we could do this now before this new property gets more use. Who knows if those delays are actually correct or may need to be tweaked down the line. Apparently we only have one specific i2c-hid compatible in the kernel (and it's not yet used by the driver). Johan
diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml index 138caad96a29..f07ff4cb3d26 100644 --- a/Documentation/devicetree/bindings/input/hid-over-i2c.yaml +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.yaml @@ -50,6 +50,12 @@ properties: description: Time required by the device after enabling its regulators or powering it on, before it is ready for communication. + post-reset-deassert-delay-ms: + description: Time required by the device after reset has been deasserted, + before it is ready for communication. + + reset-gpios: true + touchscreen-inverted-x: true touchscreen-inverted-y: true