diff mbox series

[v3,2/2] dt-bindings: Add MPQ8785 voltage regulator device

Message ID 20240131055526.2700452-2-ythsu0511@gmail.com
State New
Headers
Series [v3,1/2] hwmon: Add driver for MPS MPQ8785 Synchronous Step-Down Converter |

Commit Message

徐永謄 Jan. 31, 2024, 5:55 a.m. UTC 
  Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.

Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
---
 Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Guenter Roeck Jan. 31, 2024, 6:13 a.m. UTC | #1 
On 1/30/24 21:55, Charles Hsu wrote:
> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> 
> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>

This should be the first patch of the series.

Thanks,
Guenter
Conor Dooley Jan. 31, 2024, 3:41 p.m. UTC | #2 
On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> 
> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> ---
>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> index 79dcd92c4a43..088b23ed2ae6 100644
> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> @@ -129,6 +129,8 @@ properties:
>            - mps,mp2975
>              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>            - mps,mp5990
> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> +          - mps,mpq8785

q sorts before 2, otherwise
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
>            - honeywell,hi6130
>              # IBM Common Form Factor Power Supply Versions (all versions)
> -- 
> 2.34.1
>
徐永謄 Feb. 1, 2024, 12:34 a.m. UTC | #3 
On Wed, Jan 31, 2024 at 11:41 PM Conor Dooley <conor@kernel.org> wrote:
>
> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> >
> > Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 79dcd92c4a43..088b23ed2ae6 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -129,6 +129,8 @@ properties:
> >            - mps,mp2975
> >              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
> >            - mps,mp5990
> > +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> > +          - mps,mpq8785
>
> q sorts before 2, otherwise
Okay, I got it.
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>
> Cheers,
> Conor.
>
> >              # Honeywell Humidicon HIH-6130 humidity/temperature sensor
> >            - honeywell,hi6130
> >              # IBM Common Form Factor Power Supply Versions (all versions)
> > --
> > 2.34.1
> >
Guenter Roeck Feb. 1, 2024, 12:41 a.m. UTC | #4 
On 1/31/24 07:41, Conor Dooley wrote:
> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>
>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>> ---
>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 79dcd92c4a43..088b23ed2ae6 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -129,6 +129,8 @@ properties:
>>             - mps,mp2975
>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>             - mps,mp5990
>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>> +          - mps,mpq8785
> 
> q sorts before 2, otherwise

It does ? Not in ASCII. Am I missing something ?

Thanks,
Guenter
Krzysztof Kozlowski Feb. 1, 2024, 7:47 a.m. UTC | #5 
On 01/02/2024 01:41, Guenter Roeck wrote:
> On 1/31/24 07:41, Conor Dooley wrote:
>> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>>
>>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>>> ---
>>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> index 79dcd92c4a43..088b23ed2ae6 100644
>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> @@ -129,6 +129,8 @@ properties:
>>>             - mps,mp2975
>>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>>             - mps,mp5990
>>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>>> +          - mps,mpq8785
>>
>> q sorts before 2, otherwise
> 
> It does ? Not in ASCII. Am I missing something ?

Also `sort` agrees with q being after numbers.

Best regards,
Krzysztof
Krzysztof Kozlowski Feb. 1, 2024, 7:52 a.m. UTC | #6 
On 31/01/2024 16:41, Conor Dooley wrote:
> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>
>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>> ---
>>  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>> index 79dcd92c4a43..088b23ed2ae6 100644
>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>> @@ -129,6 +129,8 @@ properties:
>>            - mps,mp2975
>>              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>            - mps,mp5990
>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>> +          - mps,mpq8785
> 
> q sorts before 2, otherwise
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

I will sort the file and my patch should go via Rob's tree, I guess, so
maybe this one could go as well?

Best regards,
Krzysztof
Conor Dooley Feb. 1, 2024, 8:20 a.m. UTC | #7 
On Thu, Feb 01, 2024 at 08:47:07AM +0100, Krzysztof Kozlowski wrote:
> On 01/02/2024 01:41, Guenter Roeck wrote:
> > On 1/31/24 07:41, Conor Dooley wrote:
> >> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> >>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> >>>
> >>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> >>> ---
> >>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> >>>   1 file changed, 2 insertions(+)
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> index 79dcd92c4a43..088b23ed2ae6 100644
> >>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> >>> @@ -129,6 +129,8 @@ properties:
> >>>             - mps,mp2975
> >>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
> >>>             - mps,mp5990
> >>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> >>> +          - mps,mpq8785
> >>
> >> q sorts before 2, otherwise
> > 
> > It does ? Not in ASCII. Am I missing something ?
> 
> Also `sort` agrees with q being after numbers.

Disregard that comment so.
Conor Dooley Feb. 1, 2024, 8:28 a.m. UTC | #8 
On Thu, Feb 01, 2024 at 08:34:32AM +0800, 徐永謄 wrote:
> On Wed, Jan 31, 2024 at 11:41 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
> > > Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
> > >
> > > Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > index 79dcd92c4a43..088b23ed2ae6 100644
> > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > > @@ -129,6 +129,8 @@ properties:
> > >            - mps,mp2975
> > >              # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
> > >            - mps,mp5990
> > > +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
> > > +          - mps,mpq8785
> >
> > q sorts before 2, otherwise
> Okay, I got it.

Apparently I am wrong, sorry about that! Please ignore this comment.

Thanks,
Conor.
Guenter Roeck Feb. 1, 2024, 1:22 p.m. UTC | #9 
On 1/31/24 23:52, Krzysztof Kozlowski wrote:
> On 31/01/2024 16:41, Conor Dooley wrote:
>> On Wed, Jan 31, 2024 at 01:55:26PM +0800, Charles Hsu wrote:
>>> Monolithic Power Systems, Inc. (MPS) synchronous step-down converter.
>>>
>>> Signed-off-by: Charles Hsu <ythsu0511@gmail.com>
>>> ---
>>>   Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> index 79dcd92c4a43..088b23ed2ae6 100644
>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> @@ -129,6 +129,8 @@ properties:
>>>             - mps,mp2975
>>>               # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
>>>             - mps,mp5990
>>> +            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
>>> +          - mps,mpq8785
>>
>> q sorts before 2, otherwise
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> I will sort the file and my patch should go via Rob's tree, I guess, so
> maybe this one could go as well?
> 

Sure, fine with me. I applied the patch to the hwmon tree, but I have no problems
dropping it from there. Sorry, I never know if I should take .yaml patches or not.

Guenter
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
index 79dcd92c4a43..088b23ed2ae6 100644
--- a/Documentation/devicetree/bindings/trivial-devices.yaml
+++ b/Documentation/devicetree/bindings/trivial-devices.yaml
@@ -129,6 +129,8 @@  properties:
           - mps,mp2975
             # Monolithic Power Systems Inc. multi-phase hot-swap controller mp5990
           - mps,mp5990
+            # Monolithic Power Systems Inc. synchronous step-down converter mpq8785
+          - mps,mpq8785
             # Honeywell Humidicon HIH-6130 humidity/temperature sensor
           - honeywell,hi6130
             # IBM Common Form Factor Power Supply Versions (all versions)