Message ID | 20240122082947.21645-2-dharma.b@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-32520-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2bc4:b0:101:a8e8:374 with SMTP id hx4csp2435331dyb; Mon, 22 Jan 2024 00:31:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFR+nRQyU6QElzkgdMFSdLCSHbWnIccRvmUywVzLHonVOXq0c/lj/xdv7LHp+nrsQvB/WHs X-Received: by 2002:a05:6a00:3ccd:b0:6db:ea8b:52a2 with SMTP id ln13-20020a056a003ccd00b006dbea8b52a2mr107036pfb.30.1705912264270; Mon, 22 Jan 2024 00:31:04 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1705912264; cv=pass; d=google.com; s=arc-20160816; b=DJ8ZRtg+UsCZyNZ2bGuLfh229SDC4yElRfrJRSwu3ouR7r/YYVejAFu3o9H8GE3tFE HAki7vKaVhXgt8bQTOvxnFxV1tfR4tdLNiGPEYQl0aCi1Caamm4OKerXgTY/6fFcbsUH uxyvJJluay8pR3lg4rI4zuav/n72XnLmQWYy6LDAoIqFoq+ag+De8yy6+cyeD6TLp1p9 CzVx7rLZ+Vz/A0+WXhknX0z6pGyADaDGqS9N3wSvIfwbHR3+fPCO2J67mZCHNLFqTE9Q yuBNqYOWOWYfhKZjXUR53J2AUcqGF59ylAs0hSwU3uZHovKXPahDRdM2lyJralg/KEuw lrng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=o61Fzc4qqWqHTzwl77lrebKW+P2ItqbUiwzTd1SJ6+w=; fh=ShT/nu4sdhQsA2jTd+R3E7R91Uy6RwB9wgFzFvccfoM=; b=KB1zmrFhEG2flmYmnJe5+wLzpqNs+LQalKhfVPE7R+v8UM154XeQMk4ZxcOBGTiklY MKLCUjkdspwvZNZRqJnVreTF8vS5YkGlkkIWafjP5C1UAkKh9d7ir198adLTvlIPrN+y /aF5nq5oXJq5VxpFRd/Tp/BRkaRIvsol6Deh7/Zbnj1OFpy9izxbO3AMMmfEJ0pw+gwY atA2a4nr2NRcXneExhnmSp15chrqLFn48xPZ5MRU1A/r0JnhAgSr0T6OiWhd7hyya/qL 0B8MrVom5tBMAZMLAv8dmZ8c7m7iR8Dl3DOA0pE0MMGsrqwaZR/wCU0e+jkjuS1IdrKY tQ8w== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Ms03aeg4; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-32520-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32520-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id n5-20020a634d45000000b005cf60f46fabsi7758311pgl.24.2024.01.22.00.31.04 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jan 2024 00:31:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-32520-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=Ms03aeg4; arc=pass (i=1 spf=pass spfdomain=microchip.com dkim=pass dkdomain=microchip.com dmarc=pass fromdomain=microchip.com); spf=pass (google.com: domain of linux-kernel+bounces-32520-ouuuleilei=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-32520-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=REJECT dis=NONE) header.from=microchip.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id D8C9C285C92 for <ouuuleilei@gmail.com>; Mon, 22 Jan 2024 08:31:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2395C38F8F; Mon, 22 Jan 2024 08:30:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b="Ms03aeg4" Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B1EAC38386; Mon, 22 Jan 2024 08:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=68.232.154.123 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705912217; cv=none; b=qgslJjqK6hX3o8s2doLF7av4QY/N9EnpRL0o9QHAgTCW2xGCms4xlwPE3GMlDE4nPQQSD0NarL9WjuoziRoIvJRyb127kTdDCx3zxkrpnUjnU2PSxrJl96lDZrRlNNis7b6PAzWKctY5DVc0YsDkFqRTrb9z8C4vO2UnNyOEZek= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705912217; c=relaxed/simple; bh=Rf5MI82lZHhYGSDhwKtyN1xGV0ZqSdRkhIta/II4uNE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=BVE72F1WWVp+kbfJEowWWEOPGTlHYQVr/iNl+paKNGHqkl1ObgXiSDMT6/zOYeMZ2dMgPajVun3wVJ6vi4xLBt8fJUEWwNMl9LoDHVXXIf2BnxlYzqRsqDp+FluAgfY69iKyl+FMH/Cr9ZObrlls2Tz7CFVTc7iLTPiHv+/F9fM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com; spf=pass smtp.mailfrom=microchip.com; dkim=pass (2048-bit key) header.d=microchip.com header.i=@microchip.com header.b=Ms03aeg4; arc=none smtp.client-ip=68.232.154.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=microchip.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=microchip.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1705912215; x=1737448215; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Rf5MI82lZHhYGSDhwKtyN1xGV0ZqSdRkhIta/II4uNE=; b=Ms03aeg47J/n5pf0XBWeuT9dbvr5sf3ru0WJHdAIPi3LZW+WFEF8oiBX DG45oUCKc2rODgCKrrt7Z+Yn+85Y4ArPt0NZRwvjpdLBv0UP+rjRBMuwZ ETOJxRkk2AQP2vAfmM2NwDKJe7FydCBiNKxUSy0iysnbrCG17ytMrBkmm 9CqAB3j3DjdM7w7rIzlnxRf2FtvnJ0QhljBIOOgbp1/eTFR4FPVTXgfYi zd1lHXP7WUmki4Qn9QioWiCOMklu3n/yX6l94779D6xOrnXBkV5DthlQl c2IomLIDC9HG7x6dOzvNjjK+mJioQNwcd4YmNXKJBrvb2/RNipXFLcqHl w==; X-CSE-ConnectionGUID: C6zQ2Iq3QDa7pYOudyjy+g== X-CSE-MsgGUID: iDsarLzDRj6WJ7QX1eoRtg== X-IronPort-AV: E=Sophos;i="6.05,211,1701154800"; d="scan'208";a="15086355" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 22 Jan 2024 01:30:14 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 22 Jan 2024 01:30:04 -0700 Received: from che-lt-i70843lx.microchip.com (10.10.85.11) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2507.35 via Frontend Transport; Mon, 22 Jan 2024 01:29:57 -0700 From: Dharma Balasubiramani <dharma.b@microchip.com> To: <manikandan.m@microchip.com>, <dharma.b@microchip.com>, <andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>, <rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>, <jonas@kwiboo.se>, <jernej.skrabec@gmail.com>, <airlied@gmail.com>, <daniel@ffwll.ch>, <maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>, <tzimmermann@suse.de>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <dri-devel@lists.freedesktop.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org> CC: <linux4microchip@microchip.com> Subject: [PATCH 1/3] dt-bindings: display: bridge: add sam9x7-lvds compatible Date: Mon, 22 Jan 2024 13:59:45 +0530 Message-ID: <20240122082947.21645-2-dharma.b@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240122082947.21645-1-dharma.b@microchip.com> References: <20240122082947.21645-1-dharma.b@microchip.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1788778658490681477 X-GMAIL-MSGID: 1788778658490681477 |
Series |
LVDS Controller Support for SAM9X7 SoC
|
|
Commit Message
Dharma Balasubiramani
Jan. 22, 2024, 8:29 a.m. UTC
Add the 'sam9x7-lvds' compatible binding, which describes the
Low Voltage Differential Signaling (LVDS) Controller found on Microchip's
sam9x7 series System-on-Chip (SoC) devices. This binding will be used to
define the properties and configuration for the LVDS Controller in DT.
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
---
.../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml
Comments
On 22/01/2024 09:29, Dharma Balasubiramani wrote: > Add the 'sam9x7-lvds' compatible binding, which describes the > Low Voltage Differential Signaling (LVDS) Controller found on Microchip's > sam9x7 series System-on-Chip (SoC) devices. This binding will be used to > define the properties and configuration for the LVDS Controller in DT. > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > --- > .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ > 1 file changed, 59 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > > diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > new file mode 100644 > index 000000000000..8c2c5b858c85 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Microchip SAM9X7 LVDS Controller What is the "X"? > + > +maintainers: > + - Dharma Balasubiramani <dharma.b@microchip.com> > + > +description: | Do not need '|' unless you need to preserve formatting. > + The Low Voltage Differential Signaling Controller (LVDSC) manages data > + format conversion from the LCD Controller internal DPI bus to OpenLDI > + LVDS output signals. LVDSC functions include bit mapping, balanced mode > + management, and serializer. > + > +properties: > + compatible: > + const: microchip,sam9x7-lvds What is "x"? Wildcard? Then no, don't use it and instead use proper SoC version number. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: Peripheral Bus Clock > + > + clock-names: > + items: > + - const: pclk > + - const: gclk > + minItems: 1 No, you just said you have one clock. > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/at91.h> > + #include <dt-bindings/dma/at91.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> This header is not used. Include only used ones (and missing interrupt). > + > + lvds-controller@f8060000 { > + compatible = "microchip,sam9x7-lvds"; > + reg = <0xf8060000 0x100>; > + interrupts = <56 IRQ_TYPE_LEVEL_HIGH 0>; What is "0"? > + clocks = <&pmc PMC_TYPE_PERIPHERAL 56>; > + clock-names = "pclk"; > + }; Best regards, Krzysztof
On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: > On 22/01/2024 09:29, Dharma Balasubiramani wrote: > > Add the 'sam9x7-lvds' compatible binding, which describes the > > Low Voltage Differential Signaling (LVDS) Controller found on Microchip's > > sam9x7 series System-on-Chip (SoC) devices. This binding will be used to > > define the properties and configuration for the LVDS Controller in DT. > > > > Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> > > --- > > .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ > > 1 file changed, 59 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > > new file mode 100644 > > index 000000000000..8c2c5b858c85 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > > @@ -0,0 +1,59 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Microchip SAM9X7 LVDS Controller > > What is the "X"? > > > + > > +maintainers: > > + - Dharma Balasubiramani <dharma.b@microchip.com> > > + > > +description: | > > Do not need '|' unless you need to preserve formatting. > > > + The Low Voltage Differential Signaling Controller (LVDSC) manages data > > + format conversion from the LCD Controller internal DPI bus to OpenLDI > > + LVDS output signals. LVDSC functions include bit mapping, balanced mode > > + management, and serializer. > > + > > +properties: > > + compatible: > > + const: microchip,sam9x7-lvds > > What is "x"? Wildcard? Then no, don't use it and instead use proper SoC > version number. These SoCs actually do have an x in their name. However, and I do always get confused here, the sam9x7 is a series of SoCs (the cover letter does say this) rather than a specific device. I think the series current consists of a sam9x70 sam9x72 and a sam9x75. The devices are largely similar, but I am not sure if the sam9x70 supports LVDS at all. Having a compatible for the series does not seem correct to me. Cheers, Conor.
Hi Krzysztof, On 22/01/24 9:21 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 22/01/2024 09:29, Dharma Balasubiramani wrote: >> Add the 'sam9x7-lvds' compatible binding, which describes the >> Low Voltage Differential Signaling (LVDS) Controller found on Microchip's >> sam9x7 series System-on-Chip (SoC) devices. This binding will be used to >> define the properties and configuration for the LVDS Controller in DT. >> >> Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com> >> --- >> .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >> >> diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >> new file mode 100644 >> index 000000000000..8c2c5b858c85 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >> @@ -0,0 +1,59 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Microchip SAM9X7 LVDS Controller > > What is the "X Answered below > >> + >> +maintainers: >> + - Dharma Balasubiramani <dharma.b@microchip.com> >> + >> +description: | > > Do not need '|' unless you need to preserve formatting. Sure, I will drop it. > >> + The Low Voltage Differential Signaling Controller (LVDSC) manages data >> + format conversion from the LCD Controller internal DPI bus to OpenLDI >> + LVDS output signals. LVDSC functions include bit mapping, balanced mode >> + management, and serializer. >> + >> +properties: >> + compatible: >> + const: microchip,sam9x7-lvds > > What is "x"? Wildcard? Then no, don't use it and instead use proper SoC > version number. The term 'X' doesn't serve as a wildcard; rather, it directly represents the name of the SoC series, I should use sam9x75,sam9x72 instead of sam9x7. > >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + items: >> + - description: Peripheral Bus Clock >> + >> + clock-names: >> + items: >> + - const: pclk >> + - const: gclk >> + minItems: 1 > > No, you just said you have one clock. Certainly, I need to exclude the gclk. Thanks. > >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/clock/at91.h> >> + #include <dt-bindings/dma/at91.h> >> + #include <dt-bindings/interrupt-controller/arm-gic.h> > > This header is not used. Include only used ones (and missing interrupt). > >> + >> + lvds-controller@f8060000 { >> + compatible = "microchip,sam9x7-lvds"; >> + reg = <0xf8060000 0x100>; >> + interrupts = <56 IRQ_TYPE_LEVEL_HIGH 0>; > > What is "0"? Please refer "Documentation/devicetree/bindings/interrupt-controller/atmel,aic.txt" The third cell is used to specify the irq priority from 0 (lowest) to 7(highest). -- With Best Regards, Dharma B. > >> + clocks = <&pmc PMC_TYPE_PERIPHERAL 56>; >> + clock-names = "pclk"; >> + }; > > Best regards, > Krzysztof >
Hi Conor, On 22/01/24 10:07 pm, Conor Dooley wrote: > On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: >> On 22/01/2024 09:29, Dharma Balasubiramani wrote: >>> Add the 'sam9x7-lvds' compatible binding, which describes the >>> Low Voltage Differential Signaling (LVDS) Controller found on Microchip's >>> sam9x7 series System-on-Chip (SoC) devices. This binding will be used to >>> define the properties and configuration for the LVDS Controller in DT. >>> >>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com> >>> --- >>> .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ >>> 1 file changed, 59 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>> new file mode 100644 >>> index 000000000000..8c2c5b858c85 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>> @@ -0,0 +1,59 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id:http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# >>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Microchip SAM9X7 LVDS Controller >> What is the "X"? >> >>> + >>> +maintainers: >>> + - Dharma Balasubiramani<dharma.b@microchip.com> >>> + >>> +description: | >> Do not need '|' unless you need to preserve formatting. >> >>> + The Low Voltage Differential Signaling Controller (LVDSC) manages data >>> + format conversion from the LCD Controller internal DPI bus to OpenLDI >>> + LVDS output signals. LVDSC functions include bit mapping, balanced mode >>> + management, and serializer. >>> + >>> +properties: >>> + compatible: >>> + const: microchip,sam9x7-lvds >> What is "x"? Wildcard? Then no, don't use it and instead use proper SoC >> version number. > These SoCs actually do have an x in their name. However, and I do always > get confused here, the sam9x7 is a series of SoCs (the cover letter does > say this) rather than a specific device. > I think the series current consists of a sam9x70 sam9x72 and a sam9x75. > The devices are largely similar, but I am not sure if the sam9x70 > supports LVDS at all. Having a compatible for the series does not seem > correct to me. Yes, you are correct. Only sam9x72 and sam9x75 have LVDS support, while sam9x70 does not. I will revise the compatibility to include both sam9x72 and sam9x75, as outlined below: properties: compatible: enum: - microchip,sam9x72-lvds - microchip,sam9x75-lvds Additionally, I will update the driver accordingly. Thank you. -- With Best Regards, Dharma B. > > Cheers, > Conor.
On Tue, Jan 23, 2024 at 03:39:13AM +0000, Dharma.B@microchip.com wrote: > Hi Conor, > > On 22/01/24 10:07 pm, Conor Dooley wrote: > > On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: > >> On 22/01/2024 09:29, Dharma Balasubiramani wrote: > >>> Add the 'sam9x7-lvds' compatible binding, which describes the > >>> Low Voltage Differential Signaling (LVDS) Controller found on Microchip's > >>> sam9x7 series System-on-Chip (SoC) devices. This binding will be used to > >>> define the properties and configuration for the LVDS Controller in DT. > >>> > >>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com> > >>> --- > >>> .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ > >>> 1 file changed, 59 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > >>> new file mode 100644 > >>> index 000000000000..8c2c5b858c85 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml > >>> @@ -0,0 +1,59 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id:http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# > >>> +$schema:http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Microchip SAM9X7 LVDS Controller > >> What is the "X"? > >> > >>> + > >>> +maintainers: > >>> + - Dharma Balasubiramani<dharma.b@microchip.com> > >>> + > >>> +description: | > >> Do not need '|' unless you need to preserve formatting. > >> > >>> + The Low Voltage Differential Signaling Controller (LVDSC) manages data > >>> + format conversion from the LCD Controller internal DPI bus to OpenLDI > >>> + LVDS output signals. LVDSC functions include bit mapping, balanced mode > >>> + management, and serializer. > >>> + > >>> +properties: > >>> + compatible: > >>> + const: microchip,sam9x7-lvds > >> What is "x"? Wildcard? Then no, don't use it and instead use proper SoC > >> version number. > > These SoCs actually do have an x in their name. However, and I do always > > get confused here, the sam9x7 is a series of SoCs (the cover letter does > > say this) rather than a specific device. > > I think the series current consists of a sam9x70 sam9x72 and a sam9x75. > > The devices are largely similar, but I am not sure if the sam9x70 > > supports LVDS at all. Having a compatible for the series does not seem > > correct to me. > Yes, you are correct. Only sam9x72 and sam9x75 have LVDS support, while > sam9x70 does not. I will revise the compatibility to include both > sam9x72 and sam9x75, as outlined below: > > properties: > compatible: > enum: > - microchip,sam9x72-lvds > - microchip,sam9x75-lvds I would presume these 2 are the same, but the above implies they aren't. I think what you had is fine assuming these are all fundamentally the same part with just packaging or fused off h/w differences. Rob
On 31/01/24 12:42 am, Rob Herring wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On Tue, Jan 23, 2024 at 03:39:13AM +0000, Dharma.B@microchip.com wrote: >> Hi Conor, >> >> On 22/01/24 10:07 pm, Conor Dooley wrote: >>> On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: >>>> On 22/01/2024 09:29, Dharma Balasubiramani wrote: >>>>> Add the 'sam9x7-lvds' compatible binding, which describes the >>>>> Low Voltage Differential Signaling (LVDS) Controller found on Microchip's >>>>> sam9x7 series System-on-Chip (SoC) devices. This binding will be used to >>>>> define the properties and configuration for the LVDS Controller in DT. >>>>> >>>>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com> >>>>> --- >>>>> .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ >>>>> 1 file changed, 59 insertions(+) >>>>> create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>> new file mode 100644 >>>>> index 000000000000..8c2c5b858c85 >>>>> --- /dev/null >>>>> +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>> @@ -0,0 +1,59 @@ >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>> +%YAML 1.2 >>>>> +--- >>>>> +$id:http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# >>>>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>>>> + >>>>> +title: Microchip SAM9X7 LVDS Controller >>>> What is the "X"? >>>> >>>>> + >>>>> +maintainers: >>>>> + - Dharma Balasubiramani<dharma.b@microchip.com> >>>>> + >>>>> +description: | >>>> Do not need '|' unless you need to preserve formatting. >>>> >>>>> + The Low Voltage Differential Signaling Controller (LVDSC) manages data >>>>> + format conversion from the LCD Controller internal DPI bus to OpenLDI >>>>> + LVDS output signals. LVDSC functions include bit mapping, balanced mode >>>>> + management, and serializer. >>>>> + >>>>> +properties: >>>>> + compatible: >>>>> + const: microchip,sam9x7-lvds >>>> What is "x"? Wildcard? Then no, don't use it and instead use proper SoC >>>> version number. >>> These SoCs actually do have an x in their name. However, and I do always >>> get confused here, the sam9x7 is a series of SoCs (the cover letter does >>> say this) rather than a specific device. >>> I think the series current consists of a sam9x70 sam9x72 and a sam9x75. >>> The devices are largely similar, but I am not sure if the sam9x70 >>> supports LVDS at all. Having a compatible for the series does not seem >>> correct to me. >> Yes, you are correct. Only sam9x72 and sam9x75 have LVDS support, while >> sam9x70 does not. I will revise the compatibility to include both >> sam9x72 and sam9x75, as outlined below: >> >> properties: >> compatible: >> enum: >> - microchip,sam9x72-lvds >> - microchip,sam9x75-lvds > > I would presume these 2 are the same, but the above implies they > aren't. I think what you had is fine assuming these are all > fundamentally the same part with just packaging or fused off h/w > differences. Yes, so is it okay to have compatible for a series? Shall I go ahead with " compatible: const: microchip,sam9x7-lvds " itself? -- Thanks, Dharma B. > > Rob
On 01/02/2024 05:10, Dharma.B@microchip.com wrote: > On 31/01/24 12:42 am, Rob Herring wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On Tue, Jan 23, 2024 at 03:39:13AM +0000, Dharma.B@microchip.com wrote: >>> Hi Conor, >>> >>> On 22/01/24 10:07 pm, Conor Dooley wrote: >>>> On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: >>>>> On 22/01/2024 09:29, Dharma Balasubiramani wrote: >>>>>> Add the 'sam9x7-lvds' compatible binding, which describes the >>>>>> Low Voltage Differential Signaling (LVDS) Controller found on Microchip's >>>>>> sam9x7 series System-on-Chip (SoC) devices. This binding will be used to >>>>>> define the properties and configuration for the LVDS Controller in DT. >>>>>> >>>>>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com> >>>>>> --- >>>>>> .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ >>>>>> 1 file changed, 59 insertions(+) >>>>>> create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>>> new file mode 100644 >>>>>> index 000000000000..8c2c5b858c85 >>>>>> --- /dev/null >>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>>> @@ -0,0 +1,59 @@ >>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>>> +%YAML 1.2 >>>>>> +--- >>>>>> +$id:http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# >>>>>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>>>>> + >>>>>> +title: Microchip SAM9X7 LVDS Controller >>>>> What is the "X"? >>>>> >>>>>> + >>>>>> +maintainers: >>>>>> + - Dharma Balasubiramani<dharma.b@microchip.com> >>>>>> + >>>>>> +description: | >>>>> Do not need '|' unless you need to preserve formatting. >>>>> >>>>>> + The Low Voltage Differential Signaling Controller (LVDSC) manages data >>>>>> + format conversion from the LCD Controller internal DPI bus to OpenLDI >>>>>> + LVDS output signals. LVDSC functions include bit mapping, balanced mode >>>>>> + management, and serializer. >>>>>> + >>>>>> +properties: >>>>>> + compatible: >>>>>> + const: microchip,sam9x7-lvds >>>>> What is "x"? Wildcard? Then no, don't use it and instead use proper SoC >>>>> version number. >>>> These SoCs actually do have an x in their name. However, and I do always >>>> get confused here, the sam9x7 is a series of SoCs (the cover letter does >>>> say this) rather than a specific device. >>>> I think the series current consists of a sam9x70 sam9x72 and a sam9x75. >>>> The devices are largely similar, but I am not sure if the sam9x70 >>>> supports LVDS at all. Having a compatible for the series does not seem >>>> correct to me. >>> Yes, you are correct. Only sam9x72 and sam9x75 have LVDS support, while >>> sam9x70 does not. I will revise the compatibility to include both >>> sam9x72 and sam9x75, as outlined below: >>> >>> properties: >>> compatible: >>> enum: >>> - microchip,sam9x72-lvds >>> - microchip,sam9x75-lvds >> >> I would presume these 2 are the same, but the above implies they >> aren't. I think what you had is fine assuming these are all >> fundamentally the same part with just packaging or fused off h/w >> differences. > > Yes, so is it okay to have compatible for a series? Shall I go ahead with > " > compatible: > const: microchip,sam9x7-lvds You said 9x70, which would match such 9x7 "series", is different, so I still think series should not be used. I don't know much about Microchip naming scheme, so this x is always confusing. However if these are the same, maybe just use sam9x72? Best regards, Krzysztof
On 01/02/24 1:09 pm, Krzysztof Kozlowski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > On 01/02/2024 05:10, Dharma.B@microchip.com wrote: >> On 31/01/24 12:42 am, Rob Herring wrote: >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >>> >>> On Tue, Jan 23, 2024 at 03:39:13AM +0000, Dharma.B@microchip.com wrote: >>>> Hi Conor, >>>> >>>> On 22/01/24 10:07 pm, Conor Dooley wrote: >>>>> On Mon, Jan 22, 2024 at 04:51:16PM +0100, Krzysztof Kozlowski wrote: >>>>>> On 22/01/2024 09:29, Dharma Balasubiramani wrote: >>>>>>> Add the 'sam9x7-lvds' compatible binding, which describes the >>>>>>> Low Voltage Differential Signaling (LVDS) Controller found on Microchip's >>>>>>> sam9x7 series System-on-Chip (SoC) devices. This binding will be used to >>>>>>> define the properties and configuration for the LVDS Controller in DT. >>>>>>> >>>>>>> Signed-off-by: Dharma Balasubiramani<dharma.b@microchip.com> >>>>>>> --- >>>>>>> .../display/bridge/microchip,sam9x7-lvds.yaml | 59 +++++++++++++++++++ >>>>>>> 1 file changed, 59 insertions(+) >>>>>>> create mode 100644 Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>>>> >>>>>>> diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>>>> new file mode 100644 >>>>>>> index 000000000000..8c2c5b858c85 >>>>>>> --- /dev/null >>>>>>> +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml >>>>>>> @@ -0,0 +1,59 @@ >>>>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>>>>>> +%YAML 1.2 >>>>>>> +--- >>>>>>> +$id:http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# >>>>>>> +$schema:http://devicetree.org/meta-schemas/core.yaml# >>>>>>> + >>>>>>> +title: Microchip SAM9X7 LVDS Controller >>>>>> What is the "X"? >>>>>> >>>>>>> + >>>>>>> +maintainers: >>>>>>> + - Dharma Balasubiramani<dharma.b@microchip.com> >>>>>>> + >>>>>>> +description: | >>>>>> Do not need '|' unless you need to preserve formatting. >>>>>> >>>>>>> + The Low Voltage Differential Signaling Controller (LVDSC) manages data >>>>>>> + format conversion from the LCD Controller internal DPI bus to OpenLDI >>>>>>> + LVDS output signals. LVDSC functions include bit mapping, balanced mode >>>>>>> + management, and serializer. >>>>>>> + >>>>>>> +properties: >>>>>>> + compatible: >>>>>>> + const: microchip,sam9x7-lvds >>>>>> What is "x"? Wildcard? Then no, don't use it and instead use proper SoC >>>>>> version number. >>>>> These SoCs actually do have an x in their name. However, and I do always >>>>> get confused here, the sam9x7 is a series of SoCs (the cover letter does >>>>> say this) rather than a specific device. >>>>> I think the series current consists of a sam9x70 sam9x72 and a sam9x75. >>>>> The devices are largely similar, but I am not sure if the sam9x70 >>>>> supports LVDS at all. Having a compatible for the series does not seem >>>>> correct to me. >>>> Yes, you are correct. Only sam9x72 and sam9x75 have LVDS support, while >>>> sam9x70 does not. I will revise the compatibility to include both >>>> sam9x72 and sam9x75, as outlined below: >>>> >>>> properties: >>>> compatible: >>>> enum: >>>> - microchip,sam9x72-lvds >>>> - microchip,sam9x75-lvds >>> >>> I would presume these 2 are the same, but the above implies they >>> aren't. I think what you had is fine assuming these are all >>> fundamentally the same part with just packaging or fused off h/w >>> differences. >> >> Yes, so is it okay to have compatible for a series? Shall I go ahead with >> " >> compatible: >> const: microchip,sam9x7-lvds > > You said 9x70, which would match such 9x7 "series", is different, so I > still think series should not be used. I don't know much about Microchip > naming scheme, so this x is always confusing. However if these are the > same, maybe just use sam9x72? sam9x75 is the first board to be available publicly; hence, I shall use the "microchip,sam9x75-lvds" compatible and reuse the same in other boards that (features same IP) will come later. > > Best regards, > Krzysztof > -- With Best Regards, Dharma B.
diff --git a/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml new file mode 100644 index 000000000000..8c2c5b858c85 --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/microchip,sam9x7-lvds.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/bridge/microchip,sam9x7-lvds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Microchip SAM9X7 LVDS Controller + +maintainers: + - Dharma Balasubiramani <dharma.b@microchip.com> + +description: | + The Low Voltage Differential Signaling Controller (LVDSC) manages data + format conversion from the LCD Controller internal DPI bus to OpenLDI + LVDS output signals. LVDSC functions include bit mapping, balanced mode + management, and serializer. + +properties: + compatible: + const: microchip,sam9x7-lvds + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + clocks: + items: + - description: Peripheral Bus Clock + + clock-names: + items: + - const: pclk + - const: gclk + minItems: 1 + +required: + - compatible + - reg + - interrupts + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/at91.h> + #include <dt-bindings/dma/at91.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + + lvds-controller@f8060000 { + compatible = "microchip,sam9x7-lvds"; + reg = <0xf8060000 0x100>; + interrupts = <56 IRQ_TYPE_LEVEL_HIGH 0>; + clocks = <&pmc PMC_TYPE_PERIPHERAL 56>; + clock-names = "pclk"; + };