diff mbox series

dt-bindings: media: Add sram-size Property for Wave5

Message ID 20240131234008.2108672-1-b-brnich@ti.com
State New
Headers
Series dt-bindings: media: Add sram-size Property for Wave5 |

Commit Message

Brandon Brnich Jan. 31, 2024, 11:40 p.m. UTC 
  Wave521c has capability to use SRAM carveout to store reference data with
purpose of reducing memory bandwidth. To properly use this pool, the driver
expects to have an sram and sram-size node. Without sram-size node, driver
will default value to zero, making sram node irrelevant.

Signed-off-by: Brandon Brnich <b-brnich@ti.com>
---
 Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Rob Herring Feb. 1, 2024, 12:29 a.m. UTC | #1 
On Wed, 31 Jan 2024 17:40:08 -0600, Brandon Brnich wrote:
> Wave521c has capability to use SRAM carveout to store reference data with
> purpose of reducing memory bandwidth. To properly use this pool, the driver
> expects to have an sram and sram-size node. Without sram-size node, driver
> will default value to zero, making sram node irrelevant.
> 
> Signed-off-by: Brandon Brnich <b-brnich@ti.com>
> ---
>  Documentation/devicetree/bindings/media/cnm,wave521c.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/cnm,wave521c.yaml: sram-size: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240131234008.2108672-1-b-brnich@ti.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
index 6a11c1d11fb5..b1916e68443b 100644
--- a/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
+++ b/Documentation/devicetree/bindings/media/cnm,wave521c.yaml
@@ -43,6 +43,11 @@  properties:
       storing it on DMA memory. It is mainly used for the purpose of reducing
       bandwidth.
 
+  sram-size:
+    description:
+      SRAM size reserved for VPU operations. If not specified, size will default
+      to zero.
+
 required:
   - compatible
   - reg
@@ -58,4 +63,5 @@  examples:
         clocks = <&clks 42>;
         interrupts = <42>;
         sram = <&sram>;
+        sram-size = <0x1234>;
     };