diff mbox series

[v2,1/2] dt-bindings: spi: Add Socionext F_OSPI controller bindings

Message ID 20221121014800.13989-2-hayashi.kunihiko@socionext.com
State New
Headers
Series Introduce Socionext F_OSPI SPI flash controller |

Commit Message

Kunihiko Hayashi Nov. 21, 2022, 1:47 a.m. UTC 
  Add devicetree binding documentation for Socionext F_OSPI SPI flash
controller.

Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
 .../bindings/spi/socionext,f-ospi.yaml        | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml

Comments

Krzysztof Kozlowski Nov. 23, 2022, 9:33 a.m. UTC | #1 
On 21/11/2022 02:47, Kunihiko Hayashi wrote:
> Add devicetree binding documentation for Socionext F_OSPI SPI flash
> controller.

Subject: drop second, redundant "bindings".

> 
> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> ---
>  .../bindings/spi/socionext,f-ospi.yaml        | 57 +++++++++++++++++++
>  1 file changed, 57 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
> 
> diff --git a/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
> new file mode 100644
> index 000000000000..e04492c4fc84
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
> @@ -0,0 +1,57 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/spi/socionext,f-ospi.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"

Drop quotes from both lines.

> +
> +title: Socionext F_OSPI controller
> +
> +description: |
> +  The Socionext F_OSPI is a controller used to interface with flash
> +  memories using the SPI communication interface.
> +
> +maintainers:
> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
> +
> +allOf:
> +  - $ref: "spi-controller.yaml#"

Drop quotes.

With above:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Kunihiko Hayashi Nov. 23, 2022, 4:09 p.m. UTC | #2 
Hi Krzysztof,

Thank you for reviewing.

On 2022/11/23 18:33, Krzysztof Kozlowski wrote:
> On 21/11/2022 02:47, Kunihiko Hayashi wrote:
>> Add devicetree binding documentation for Socionext F_OSPI SPI flash
>> controller.
> 
> Subject: drop second, redundant "bindings".

Ah, ok. I didn't notice it. I'll remove it in next.

>> >> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> ---
>>   .../bindings/spi/socionext,f-ospi.yaml        | 57 +++++++++++++++++++
>>   1 file changed, 57 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>> b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>> new file mode 100644
>> index 000000000000..e04492c4fc84
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
>> @@ -0,0 +1,57 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/spi/socionext,f-ospi.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> 
> Drop quotes from both lines.

I see. I'll keep it in mind.

>> +
>> +title: Socionext F_OSPI controller
>> +
>> +description: |
>> +  The Socionext F_OSPI is a controller used to interface with flash
>> +  memories using the SPI communication interface.
>> +
>> +maintainers:
>> +  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>> +
>> +allOf:
>> +  - $ref: "spi-controller.yaml#"
> 
> Drop quotes.

Ditto.

> With above:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

I'll fix the above in v3.

Thank you,

---
Best Regards
Kunihiko Hayashi
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
new file mode 100644
index 000000000000..e04492c4fc84
--- /dev/null
+++ b/Documentation/devicetree/bindings/spi/socionext,f-ospi.yaml
@@ -0,0 +1,57 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/spi/socionext,f-ospi.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Socionext F_OSPI controller
+
+description: |
+  The Socionext F_OSPI is a controller used to interface with flash
+  memories using the SPI communication interface.
+
+maintainers:
+  - Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
+
+allOf:
+  - $ref: "spi-controller.yaml#"
+
+properties:
+  compatible:
+    const: socionext,f-ospi
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  num-cs:
+    minimum: 1
+    maximum: 4
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - "#address-cells"
+  - "#size-cells"
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    ospi0: spi@80000000 {
+        compatible = "socionext,f-ospi";
+        reg = <0x80000000 0x1000>;
+        clocks = <&clks 0>;
+        num-cs = <1>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        flash@0 {
+            compatible = "spansion,s25fl128s", "jedec,spi-nor";
+            reg = <0>;
+            spi-max-frequency = <50000000>;
+        };
+    };