Message ID | 20240130150257.3643657-1-naresh.solanki@9elements.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-44793-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1279860dyb; Tue, 30 Jan 2024 07:03:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IGX75Z+eJgFCcBV7m/DNFOmaiftaikpt0pqAwY76K9hUsrUDDj7f3OOWMc5AifjRVSavueD X-Received: by 2002:a17:907:1750:b0:a36:313f:417 with SMTP id lf16-20020a170907175000b00a36313f0417mr1352103ejc.19.1706627007789; Tue, 30 Jan 2024 07:03:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706627007; cv=pass; d=google.com; s=arc-20160816; b=o/T6/aNHlT3BsxF8gVIgR2TSjIGoOIh9xslgAcQPDDtXkq0eu2SZQcXZH6onHBzo5B f8tJ3sOaVF/hlw8Zi4mvxA/929248P8c4Nb2qVCYab5vZ1f6ny0yMmTSLbTYeXdVzOHw V6oh7sr9QW/oEt2iI4ySLlrvl/274czxqdoJEsnusSb7tK6bTBStLyt5eN2otcG5UwIJ u9WJ1nb9l9TclItuJzvxd2ZMLXuDk5HKa/Z67+jlhknYYLaVRynHQgrB8o5l5YvouIGV u8jz57mhgWyrpcklYEv4DH9CR93Rnxb/UdBNC8IonrDXKoNPmaVXNwJRs3gecoU4dSXC 0PLw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=YqgeOjLTrp275fXzSVIM2wvWsQ14s/UmjFxWLGZ8WQw=; fh=obagWqAMAUYamWnyshQ+gVWsW3/pRPLIeC/XdKVbEGs=; b=X7l8IKmGSLA67Ovwz8VPk27FM85Rh/is2xzJPhqyOqgxVJ/D+d8NJN9eYc2xzmsiCB KK2ot/8Bpn3YYr47DbtCBy7tEfYp2GVC/li/Egl/SXaTGQpI7LhjhSx7w4gGP3jqMpRw CMDopxtEVyg/pEvIRDmBr5TgBO9+XSqcQHxEZiOZ0phIy+Ihxe126fpp51xJkP9TYx9V zsAL/fxZGmvqzu6PD4Ggqk1sNeKFefX7G3X1+8kwIx0X5524pVnrDO9eEniKh4EKRnpz rAjmQtbmpMUae79FCIEzdxP2MSQMdYW2/l9rKz6zA2DhLIB7eiKy4EcPl6SxWITd7Tsh 1K6g== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=Njl6Vr7N; arc=pass (i=1 spf=pass spfdomain=9elements.com dkim=pass dkdomain=9elements.com dmarc=pass fromdomain=9elements.com); spf=pass (google.com: domain of linux-kernel+bounces-44793-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44793-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id e4-20020a170906374400b00a2c297f901asi4407462ejc.313.2024.01.30.07.03.27 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 07:03:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44793-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=Njl6Vr7N; arc=pass (i=1 spf=pass spfdomain=9elements.com dkim=pass dkdomain=9elements.com dmarc=pass fromdomain=9elements.com); spf=pass (google.com: domain of linux-kernel+bounces-44793-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44793-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 630701F277FC for <ouuuleilei@gmail.com>; Tue, 30 Jan 2024 15:03:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 85750823AA; Tue, 30 Jan 2024 15:03:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="Njl6Vr7N" Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04A7D811E2 for <linux-kernel@vger.kernel.org>; Tue, 30 Jan 2024 15:03:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706626984; cv=none; b=q/SsLomWip/j8yfU/xELXAGoYR6gusLLCHMmycEOm5f60Sq/AwUfhHRb+ntCjxZmlNC/llQnvquaShV3NdJVxv5vxIaaOXTV/e+KTiSCewyi2aiuZ/crFsXvVGS8z5bLwNM/ZPwedbNxEWcoDUQ01QtWvCJnMWEwDcxuB0SCQXI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706626984; c=relaxed/simple; bh=e66UCmOx/jtyr6B4zzKxaiG4yuzE3yyOFRm+iNo6W9k=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DNDMnNYUhcCGJGwbi+jEGVm6JxE+llomsLxABcw9fAcfLS0VurXd8bfX9199s7oVdh/38AWzJbZDYKP3EZtFUhzl0hYZNNE7L7ZA5sQSIEk5SlwrUzlHApSg3Lb3l6f1dRM6yOVzQQhRDzeS1yudQpviMmhXwgR5qi2qnYG5whQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com; spf=pass smtp.mailfrom=9elements.com; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b=Njl6Vr7N; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-33af4b34e2cso1011670f8f.1 for <linux-kernel@vger.kernel.org>; Tue, 30 Jan 2024 07:03:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1706626981; x=1707231781; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YqgeOjLTrp275fXzSVIM2wvWsQ14s/UmjFxWLGZ8WQw=; b=Njl6Vr7Nnc5i1YdAovMd6Q+tCyghoWem9DEDi1jVCKcevJPhENWi6lM01pvNZU4VZ2 H8hJYhg++7/iwjORbMA9Q4raTBgeIahHIFtHZYLhmzeKzskw+VP8AEkPPukGgYAERKqR 4mXe8RmEHMHMGUWcFSMx67MMJy636+qflTJWTr33+KXqC7NWKdByZiLHOloVtl+fG3iZ JhsVpmeTNfYIvoyzO2O7cV4C4m+ej+dotmfNPwvQ1VovLRCdYJ6rz/GIvS6LM6+xJsaJ NNahtqHZGlp5YwU23LnIoyuKvGxRzyPWnsINu5kHSzmvaK50UlkeoIwO/qmsaQmDnQmp rD6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706626981; x=1707231781; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YqgeOjLTrp275fXzSVIM2wvWsQ14s/UmjFxWLGZ8WQw=; b=luFfvKhgnVu0j0iy8fb7DWd8LSk8+cqZrqNcCLpWJZdghVj/clZYxCgXwMcxaLt6Br N1VZUPZfZ+GoIBFFqyatxrDNgtbZZXNRTYCHUZa3E8MBtSHU+dskhQjkGq5EPyM4xpAq B73FsOSayyClpVZvh9XVLNs6Q8lnTL3exCk5BNc/HjRbF+xBWJjYI+UeyVaxThEUGOcy vZ3RF+INXQVz7k7jE3WauRrZgOWZ5z8jfOuTYCsU2sL8hOTj0meAuafIeUOfM2avn5YY 7lLwZIrr6NEA3N6dXvZ3BpUgzQaaS4jJ8sxDxRrOfa2liqJ3ffrjo4J1N52S2TXopRC9 Y0Hg== X-Gm-Message-State: AOJu0YwIDujS9IHtPDM6Yluah8a6Q7JxtqIn0lh/FOIJZDLowLFXIXJ4 c3GQQtSHVj6UfKnAsdueMAnLpr7iVVcuQXi9a6pdHGWKBF75q5oHaxAvGaS8S7Y= X-Received: by 2002:adf:f851:0:b0:336:c79d:7504 with SMTP id d17-20020adff851000000b00336c79d7504mr1933342wrq.2.1706626980965; Tue, 30 Jan 2024 07:03:00 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVgO+p/Ww+pfMBpy2xKoWUuxucwFbV6RFbhYbCrLIxA5rYhv/NFEf8PNNpeSIRgQpgg/SJDagPAhsXgbPd9QWzibhp42mMYNxNFRpGbtx6ZnfOwfRs90nj6agBukBpa2/qrQNpWVBl1Weyof/hUJ4YPHMJEAnQsj7bW4YTDhQrEsD23QhA3jBvOBYGLvKwiHxaDogLmPAvjlFs+HydV Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id u17-20020adff891000000b0033ae55db108sm8395287wrp.20.2024.01.30.07.03.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 07:03:00 -0800 (PST) From: Naresh Solanki <naresh.solanki@9elements.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org> Cc: mazziesaccount@gmail.com, Patrick Rudolph <patrick.rudolph@9elements.com>, Naresh Solanki <naresh.solanki@9elements.com>, linux-kernel@vger.kernel.org Subject: [PATCH] regulator (max5970): Fix IRQ handler Date: Tue, 30 Jan 2024 20:32:56 +0530 Message-ID: <20240130150257.3643657-1-naresh.solanki@9elements.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789528121105437115 X-GMAIL-MSGID: 1789528121105437115 |
Series |
regulator (max5970): Fix IRQ handler
|
|
Commit Message
Naresh Solanki
Jan. 30, 2024, 3:02 p.m. UTC
From: Patrick Rudolph <patrick.rudolph@9elements.com> The max5970 datasheet gives the impression that IRQ status bits must be cleared by writing a one to set bits, as those are marked with 'R/C', however tests showed that a zero must be written. Fixes an IRQ storm as the interrupt handler actually clears the IRQ status bits. Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> --- drivers/regulator/max5970-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a
Comments
On Tue, 30 Jan 2024 20:32:56 +0530, Naresh Solanki wrote: > The max5970 datasheet gives the impression that IRQ status bits must > be cleared by writing a one to set bits, as those are marked with 'R/C', > however tests showed that a zero must be written. > > Fixes an IRQ storm as the interrupt handler actually clears the IRQ > status bits. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Thanks! [1/1] regulator (max5970): Fix IRQ handler commit: a3fa9838e8140584a6f338e8516f2b05d3bea812 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/regulator/max5970-regulator.c b/drivers/regulator/max5970-regulator.c index bc88a40a88d4..830a1c4cd705 100644 --- a/drivers/regulator/max5970-regulator.c +++ b/drivers/regulator/max5970-regulator.c @@ -392,7 +392,7 @@ static int max597x_regmap_read_clear(struct regmap *map, unsigned int reg, return ret; if (*val) - return regmap_write(map, reg, *val); + return regmap_write(map, reg, 0); return 0; }