Message ID | 20240130120807.460335-1-naresh.solanki@9elements.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-44583-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp1173073dyb; Tue, 30 Jan 2024 04:10:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IF9bBEPMdYV9LTmqlApfvqZtBFOHByUJNIDl3lCYePphkNXHgh8jjM1WukxTdi1QroqdSJR X-Received: by 2002:a05:6402:5207:b0:55e:ef2d:952e with SMTP id s7-20020a056402520700b0055eef2d952emr4900282edd.36.1706616641064; Tue, 30 Jan 2024 04:10:41 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706616641; cv=pass; d=google.com; s=arc-20160816; b=uzfu4ETQEsVQpdDGyP0ah3jyhspZkvdOAixWrf19+2u8FeFAE5ukZx197tTGIdunkv U9ML7jrvU9rN99nBc/R0bPok57IrqcdhhJIjpBayrZ5SlWtdpSYWlJxSqt4k2iCqcLV7 xGE0Y+4KcUFLzmFxCofXTcTUj+jVWmDVsQ55wy8t9/S6duymwdVEl+trNDdPNEDOn2RY 2vmisnD8ee1R8y+msrcz1lXkoj4gvui6LhinqaY12pMRdeTALMxYiXaUwk/qKfh9KUT/ 0niuC9VQltVM8Pmfsa96ggwHXwA+enO5gR1kI9owGyyOILYOlykr68vprWlNVcN9vWwY QmHg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=In0D55Mdq6WXKilN4JPLmFe9w0y3bSsay5sRffELyd0=; fh=Wj5BY+v4aGl4bLnIUvKR2avWSODk/pkq6uLzkIDOxqg=; b=bVfwksWZmrCocxW41btcvkkHPqZ6924JHSpxo+A5+p5eE7QJ3jD0BXPMFiLqPxvRzQ DEp3zL71PLfq350JeOqgUJe3mPy0Fn5nQEymj5gfHEJVLcOKFFZQn7C6jcPgV1r9dgsb IR0rvjJf1IEv5TeoaCJNLF6qjYOirQg++pGnafZmUqo6bII4GO51hdlsae0dmKC1IQBp 1U29qooVU9WgtscDUH1zLG3DSMIgL3Np5/pFnUZV777hsGB3HgB0oFajIsPMCUcivGAZ JfmZ7gvdvlioVYrjcILU9lJMrCwSTge5RPqAJ3L9fgO6l526vJFqXudCMNssmtGLb5TF bHww== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=QhF49jlT; arc=pass (i=1 spf=pass spfdomain=9elements.com dkim=pass dkdomain=9elements.com dmarc=pass fromdomain=9elements.com); spf=pass (google.com: domain of linux-kernel+bounces-44583-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44583-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id u29-20020a50951d000000b0055f0eaf8358si1596800eda.391.2024.01.30.04.10.40 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:10:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-44583-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@9elements.com header.s=google header.b=QhF49jlT; arc=pass (i=1 spf=pass spfdomain=9elements.com dkim=pass dkdomain=9elements.com dmarc=pass fromdomain=9elements.com); spf=pass (google.com: domain of linux-kernel+bounces-44583-ouuuleilei=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-44583-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=9elements.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id AAB0A1F263D3 for <ouuuleilei@gmail.com>; Tue, 30 Jan 2024 12:10:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 949556BB58; Tue, 30 Jan 2024 12:08:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b="QhF49jlT" Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D916A32F for <linux-kernel@vger.kernel.org>; Tue, 30 Jan 2024 12:08:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706616526; cv=none; b=jKI2KzBVJRkX1rdJePPYVbMIfukeMQ6rPWDPTb6SIZer+VVti1/Or0H4gmtJ+sUHMTJvXgigXH5YBRttuDMgV+rQ8LN10m66IZeaNUK4WCHvuGLpiWaSbRmh6TaOyj4Uuxhw7LzcTqE/qYb1um5+RPsQTZlk/SJNkCtmr4n489Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706616526; c=relaxed/simple; bh=zDcAbkLItqPMxxfP3aRTCDFDYSoc9GjSDeC3F04oer0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=erOYCCjK2vrMb0NjUZlsP40ODsvy7wCifJbcNKdsKvTrM1M6TTxXl8F18OuiymmgQZpro8yZgmXMQlDh1xASTg6C7k4vEIdegFELSZL5VH3fQcnuZRwd2wGCakCajsj50Pk2t1JrPJk0aMNev2wroeMVbYXhofXCtyGwAP/0ZmU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com; spf=pass smtp.mailfrom=9elements.com; dkim=pass (2048-bit key) header.d=9elements.com header.i=@9elements.com header.b=QhF49jlT; arc=none smtp.client-ip=209.85.218.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=9elements.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=9elements.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a271a28aeb4so475491766b.2 for <linux-kernel@vger.kernel.org>; Tue, 30 Jan 2024 04:08:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=9elements.com; s=google; t=1706616523; x=1707221323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=In0D55Mdq6WXKilN4JPLmFe9w0y3bSsay5sRffELyd0=; b=QhF49jlTP4HyP1Aa5qS0zvUUoigbQqkg/0Lg2F8+7UYD0tGrU9GxoNOuiTTCujhc8g +9nmxj6rA1CHZhTzagCl2xNqBy3PwpQ39+lRdqtYsgtSsAka8JKAeeU6iR3Ym47ZqidO 6bu72f45bns/XS6xWz1DxxvgEuViFBo3xblZj0jNBxA0lW4zk7Vm013XOUQAcqduvJP9 xGWLAJm8JnIige/2OY3K1+XgQxYdGS9pVHIZjuRd4GfxiW4TZaTCMlqkrfx3ezwZF7rw FS3NkfAW3sYdV/pdpVOvAbC+I4/Cka9hJG/cr41FLsvXGLr3iMhPHkWurtVSaGPo2nzR sl3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706616523; x=1707221323; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=In0D55Mdq6WXKilN4JPLmFe9w0y3bSsay5sRffELyd0=; b=qhSVUlNr6nEJaCsyeYLy6xzNYlk9v8DdIpFerieBLe0WNbpFMjSNpnyfLdHi2ocf3E +FV5nA4nMM5sa3ssqJT+3iWlCKbA7lbEGcNUOsbTAuXyx5Pi1v15GosQCYrKjvP+zz0r D2+VGUTVHp9kI8YrRh6KFifbjLRxu05eoq76mM7M420YTX9IsVlpLPzpxtO1HEakn6dP /afxYRjEzl8w8CKJOs3KCnlK0veNzMfXLHqpnhaGnRhzNVPxMD6f3CLs2K4zFyM7dAlb HJfkjt7YOUz8i2EW1Vxj6oBJWaweI4ddNbTUo1f74pGrl4kJRNKFd4kz/SAV1aiZI7fb 92Mg== X-Gm-Message-State: AOJu0YwT6AnDCf3PDGuYJhqUdic++v/cPHy3kzcyXNuM2EDObrSZ1t6Y 7JBv3P91hzObCZ9cffys6m4btzneWAIxc1VHopZGDjXNir4enO2yZ//RuL5Rd/4= X-Received: by 2002:a17:906:1c50:b0:a35:7438:113d with SMTP id l16-20020a1709061c5000b00a357438113dmr5415571ejg.27.1706616523224; Tue, 30 Jan 2024 04:08:43 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCVVEfzifHvj6OKtuasaqW26a+xizwHZ3E8WMl3oLvw9q1sUgyPHCdTkUDaULnVKunGgFNz/wLhqddeFP/eDAs3/mjn3Ic33YTcJn/e4D2ZQL1QzT9Z0LokBbUfnNIMnJP9k9OTY40OpG8vw4LaBdCx16q0ikCYUp+xxRafwqPa5s51hnlzavQPmRz01D/4p/KbniIVIV0K74NIScTnk3T/OHBSIhkuba23XYHnYHkUH25J2Y/Ux7trcr3NJVhM+EdaQt4pA0XQAlSkWeGUttGpK4h/bw6TIkhksZMwafqp2yS9mPk4R6OuIlJSizShaz+2EQ/RQcMgbEXkc/IU5+BTqKzmnBItij2hmsmCREg== Received: from stroh80.sec.9e.network (ip-078-094-000-051.um19.pools.vodafone-ip.de. [78.94.0.51]) by smtp.gmail.com with ESMTPSA id vv9-20020a170907a68900b00a354a5d2c39sm3751242ejc.31.2024.01.30.04.08.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 04:08:42 -0800 (PST) From: Naresh Solanki <naresh.solanki@9elements.com> To: Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Patrick Rudolph <patrick.rudolph@9elements.com> Cc: mazziesaccount@gmail.com, Naresh Solanki <naresh.solanki@9elements.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] dt-bindings: pinctrl: cy8x95x0: Minor fix & update Date: Tue, 30 Jan 2024 17:38:06 +0530 Message-ID: <20240130120807.460335-1-naresh.solanki@9elements.com> X-Mailer: git-send-email 2.42.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789517251496016422 X-GMAIL-MSGID: 1789517251496016422 |
Series |
[v2] dt-bindings: pinctrl: cy8x95x0: Minor fix & update
|
|
Commit Message
Naresh Solanki
Jan. 30, 2024, 12:08 p.m. UTC
Update maxItems to 60 for gpio-reserved-ranges to allow multiple gpio
reserved ranges.
Add input-enable property to allow configuring a pin as input.
Rearrange allOf
Update example.
Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com>
---
.../bindings/pinctrl/cypress,cy8c95x0.yaml | 28 +++++++++++++++----
1 file changed, 23 insertions(+), 5 deletions(-)
base-commit: 861c0981648f5b64c86fd028ee622096eb7af05a
Comments
On 30/01/2024 13:08, Naresh Solanki wrote: > Update maxItems to 60 for gpio-reserved-ranges to allow multiple gpio > reserved ranges. > Add input-enable property to allow configuring a pin as input. > Rearrange allOf Why? > Update example. > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > --- > .../bindings/pinctrl/cypress,cy8c95x0.yaml | 28 +++++++++++++++---- > 1 file changed, 23 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml > index 7f30ec2f1e54..89ce0cb68834 100644 > --- a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml > @@ -45,7 +45,8 @@ properties: > maxItems: 1 > > gpio-reserved-ranges: > - maxItems: 1 > + minItems: 1 > + maxItems: 60 > > vdd-supply: > description: > @@ -85,6 +86,8 @@ patternProperties: > > bias-disable: true > > + input-enable: true > + > output-high: true > > output-low: true > @@ -101,6 +104,9 @@ patternProperties: > > additionalProperties: false > > +allOf: > + - $ref: pinctrl.yaml# > + That's not a correct placement. > required: > - compatible > - reg > @@ -112,9 +118,6 @@ required: > > additionalProperties: false > > -allOf: > - - $ref: pinctrl.yaml# > - > examples: > - | > #include <dt-bindings/interrupt-controller/arm-gic.h> > @@ -133,6 +136,21 @@ examples: > interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; > interrupt-controller; > vdd-supply = <&p3v3>; > - gpio-reserved-ranges = <5 1>; > + gpio-reserved-ranges = <1 2>, <6 1>, <10 1>, <15 1>; > + > + pinctrl-0 = <&U62160_pins>, <&U62160_ipins>; > + pinctrl-names = "default"; > + U62160_pins: cfg-pins { > + pins = "gp03", "gp16", "gp20", "gp50", "gp51"; Your indentation is totally broken. Best regards, Krzysztof
Hi Krzysztof, On Tue, 30 Jan 2024 at 17:49, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 30/01/2024 13:08, Naresh Solanki wrote: > > Update maxItems to 60 for gpio-reserved-ranges to allow multiple gpio > > reserved ranges. > > Add input-enable property to allow configuring a pin as input. > > Rearrange allOf > > Why? allOf is aligned with other implementations. > > > Update example. > > > > Signed-off-by: Naresh Solanki <naresh.solanki@9elements.com> > > --- > > .../bindings/pinctrl/cypress,cy8c95x0.yaml | 28 +++++++++++++++---- > > 1 file changed, 23 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml > > index 7f30ec2f1e54..89ce0cb68834 100644 > > --- a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml > > +++ b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml > > @@ -45,7 +45,8 @@ properties: > > maxItems: 1 > > > > gpio-reserved-ranges: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 60 > > > > vdd-supply: > > description: > > @@ -85,6 +86,8 @@ patternProperties: > > > > bias-disable: true > > > > + input-enable: true > > + > > output-high: true > > > > output-low: true > > @@ -101,6 +104,9 @@ patternProperties: > > > > additionalProperties: false > > > > +allOf: > > + - $ref: pinctrl.yaml# > > + > > That's not a correct placement. ok. Will remove this specific change. > > > required: > > - compatible > > - reg > > @@ -112,9 +118,6 @@ required: > > > > additionalProperties: false > > > > -allOf: > > - - $ref: pinctrl.yaml# > > - > > examples: > > - | > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > @@ -133,6 +136,21 @@ examples: > > interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; > > interrupt-controller; > > vdd-supply = <&p3v3>; > > - gpio-reserved-ranges = <5 1>; > > + gpio-reserved-ranges = <1 2>, <6 1>, <10 1>, <15 1>; > > + > > + pinctrl-0 = <&U62160_pins>, <&U62160_ipins>; > > + pinctrl-names = "default"; > > + U62160_pins: cfg-pins { > > + pins = "gp03", "gp16", "gp20", "gp50", "gp51"; > > Your indentation is totally broken. sorry I missed checking on this before sending the patch for review. will fix it to use two space for indentation. Regards, Naresh > > > Best regards, > Krzysztof >
On 30/01/2024 13:26, Naresh Solanki wrote: > Hi Krzysztof, > > On Tue, 30 Jan 2024 at 17:49, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 30/01/2024 13:08, Naresh Solanki wrote: >>> Update maxItems to 60 for gpio-reserved-ranges to allow multiple gpio >>> reserved ranges. >>> Add input-enable property to allow configuring a pin as input. >>> Rearrange allOf >> >> Why? > allOf is aligned with other implementations. Which ones? example-schema and other implementations have it in different place. If you align some parts of the code, please align to match the correct code, not other incorrect. How to find it? example-schema is the reference, recent commits are also sometimes good indication. Best regards, Krzysztof
Hi Krzysztof, On Tue, 30 Jan 2024 at 18:01, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 30/01/2024 13:26, Naresh Solanki wrote: > > Hi Krzysztof, > > > > On Tue, 30 Jan 2024 at 17:49, Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 30/01/2024 13:08, Naresh Solanki wrote: > >>> Update maxItems to 60 for gpio-reserved-ranges to allow multiple gpio > >>> reserved ranges. > >>> Add input-enable property to allow configuring a pin as input. > >>> Rearrange allOf > >> > >> Why? > > allOf is aligned with other implementations. > > Which ones? example-schema and other implementations have it in > different place. If you align some parts of the code, please align to > match the correct code, not other incorrect. How to find it? > example-schema is the reference, recent commits are also sometimes good > indication. Yes your right. Will align with example-schema. Thanks. Regards, Naresh > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml index 7f30ec2f1e54..89ce0cb68834 100644 --- a/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml +++ b/Documentation/devicetree/bindings/pinctrl/cypress,cy8c95x0.yaml @@ -45,7 +45,8 @@ properties: maxItems: 1 gpio-reserved-ranges: - maxItems: 1 + minItems: 1 + maxItems: 60 vdd-supply: description: @@ -85,6 +86,8 @@ patternProperties: bias-disable: true + input-enable: true + output-high: true output-low: true @@ -101,6 +104,9 @@ patternProperties: additionalProperties: false +allOf: + - $ref: pinctrl.yaml# + required: - compatible - reg @@ -112,9 +118,6 @@ required: additionalProperties: false -allOf: - - $ref: pinctrl.yaml# - examples: - | #include <dt-bindings/interrupt-controller/arm-gic.h> @@ -133,6 +136,21 @@ examples: interrupts = <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>; interrupt-controller; vdd-supply = <&p3v3>; - gpio-reserved-ranges = <5 1>; + gpio-reserved-ranges = <1 2>, <6 1>, <10 1>, <15 1>; + + pinctrl-0 = <&U62160_pins>, <&U62160_ipins>; + pinctrl-names = "default"; + U62160_pins: cfg-pins { + pins = "gp03", "gp16", "gp20", "gp50", "gp51"; + function = "gpio"; + input-enable; + bias-pull-up; + }; + U62160_ipins: icfg-pins { + pins = "gp04", "gp17", "gp21", "gp52", "gp53"; + function = "gpio"; + input-enable; + bias-pull-up; + }; }; };