Message ID | 1a31a50f01e880f4c137298a12b8023c55f59cdc.1669044155.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1654499wrr; Mon, 21 Nov 2022 07:25:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf4ohU4OHs1xFuo+Dcr3TcCl/q4K0q3h4zWakmcNrH87vM2mFPeTSk01IBmt9lEBSLKznJfw X-Received: by 2002:a17:906:c30a:b0:7ae:e592:fce5 with SMTP id s10-20020a170906c30a00b007aee592fce5mr15734882ejz.390.1669044319684; Mon, 21 Nov 2022 07:25:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669044319; cv=none; d=google.com; s=arc-20160816; b=ADR3dAFX15fOke7WewmIhY/3iMxNYfmwIkM9sBcQRGpyAEhJj7JS77EkkroQHF2pLZ +X7AMDXAnAek1OBK7+qt5WlrNAIjy3XH9nt9+4VQLwnXQGintFd9iBqXHW4DcbILjUSN 34SzugHZFrbBDkU6/kR76b/PHiXKa783iSzPUd3bovJNtyUcPpZnSOGKfwQrYYpkNlyA gvwkoytfps7WJ2QHN2Vb3RXRI6aFJQLgOnQtAZJBUzUZqUh3MK4NhczFUE8pJlMVjg9U gvd7RwmNIS4k3D5FBPuaEd3fMuKKTSTDhK8yPwPjK+nNspBxaQh+VXbf+Yzq7Vfry4pP xErg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Irsm9D0iNbVV4wnb4xPO+GhEGCSPTP1SYq4TOaWi7qI=; b=JwVXrFgvFohRc/BMtXtPBIoyl5Mcpc7tYf81S9UTZIaDKwUkizYGz/FVn6fR4Kp7Ld PAmi+hscS3Yix6OkKYet+bLfA/1hRlW++1h0uVwPfB436KZbRpyOvy4dyzV7A2Ymh4c3 uAP2hF/SjhvGiLg3nLXZC8Z5BCGj0Ygn85vMT+YXwQODAdTTEh67RP/S/lbGp9quWWUC Mplw7zhW6QyUwBGFAe0Og74j2+VOpDEzWuVEC1eo4MgTA7uGm+HJPUyHIppIJf31un0B XwP5d58dhybs+Gi8EYvHAQz6IfNhbxdl/VXr1idQArFgecslpvQjiZOwZyxHSO88olqX o1Wg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id vo15-20020a170907a80f00b0077cfec3a52fsi4872068ejc.839.2022.11.21.07.24.53; Mon, 21 Nov 2022 07:25:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbiKUPX6 (ORCPT <rfc822;cjcooper78@gmail.com> + 99 others); Mon, 21 Nov 2022 10:23:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232296AbiKUPXl (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 21 Nov 2022 10:23:41 -0500 Received: from albert.telenet-ops.be (albert.telenet-ops.be [IPv6:2a02:1800:110:4::f00:1a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 190C71572D for <linux-kernel@vger.kernel.org>; Mon, 21 Nov 2022 07:23:06 -0800 (PST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed10:4821:1ba5:2638:5c3a]) by albert.telenet-ops.be with bizsmtp id n3P32800F5WXlCv063P3d2; Mon, 21 Nov 2022 16:23:04 +0100 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1ox8dT-0019CU-1i; Mon, 21 Nov 2022 16:23:03 +0100 Received: from geert by rox.of.borg with local (Exim 4.93) (envelope-from <geert@linux-m68k.org>) id 1ox8dS-00BPzz-MP; Mon, 21 Nov 2022 16:23:02 +0100 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Yicong Yang <yangyicong@hisilicon.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, John Garry <john.garry@huawei.com>, Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH] hwtracing: HISI_PTT should depend on ARCH_HISI Date: Mon, 21 Nov 2022 16:23:01 +0100 Message-Id: <1a31a50f01e880f4c137298a12b8023c55f59cdc.1669044155.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750119816238113643?= X-GMAIL-MSGID: =?utf-8?q?1750119816238113643?= |
Series |
hwtracing: HISI_PTT should depend on ARCH_HISI
|
|
Commit Message
Geert Uytterhoeven
Nov. 21, 2022, 3:23 p.m. UTC
The HiSilicon PCIe Tune and Trace Device is a PCIe Root Complex
integrated Endpoint (RCiEP) device, which is only present on HiSilicon
SoCs. Hence add a dependency on ARCH_HISI, to prevent asking the user
about this driver when configuring a kernel without HiSilicon SoC
support.
Fixes: ff0de066b4632ccb ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/hwtracing/ptt/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Geert, On 2022/11/21 23:23, Geert Uytterhoeven wrote: > The HiSilicon PCIe Tune and Trace Device is a PCIe Root Complex > integrated Endpoint (RCiEP) device, which is only present on HiSilicon > SoCs. Hence add a dependency on ARCH_HISI, to prevent asking the user > about this driver when configuring a kernel without HiSilicon SoC > support. > I don't think we want this since: 1. Our PCIe IP is very common which does not highly depends on specific platforms, it can be used on other products 2. I'm not sure all the products will have ARCH_HISI. if we have this dependence then we cannot see this configuration The driver config is default to N so I'd prefer to keep it as is. Thanks. > Fixes: ff0de066b4632ccb ("hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > --- > drivers/hwtracing/ptt/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/ptt/Kconfig b/drivers/hwtracing/ptt/Kconfig > index 6d46a09ffeb91992..96ee94a5d5b9fab8 100644 > --- a/drivers/hwtracing/ptt/Kconfig > +++ b/drivers/hwtracing/ptt/Kconfig > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0-only > config HISI_PTT > tristate "HiSilicon PCIe Tune and Trace Device" > - depends on ARM64 || (COMPILE_TEST && 64BIT) > + depends on ARCH_HISI || (COMPILE_TEST && 64BIT) > depends on PCI && HAS_DMA && HAS_IOMEM && PERF_EVENTS > help > HiSilicon PCIe Tune and Trace device exists as a PCIe RCiEP >
diff --git a/drivers/hwtracing/ptt/Kconfig b/drivers/hwtracing/ptt/Kconfig index 6d46a09ffeb91992..96ee94a5d5b9fab8 100644 --- a/drivers/hwtracing/ptt/Kconfig +++ b/drivers/hwtracing/ptt/Kconfig @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only config HISI_PTT tristate "HiSilicon PCIe Tune and Trace Device" - depends on ARM64 || (COMPILE_TEST && 64BIT) + depends on ARCH_HISI || (COMPILE_TEST && 64BIT) depends on PCI && HAS_DMA && HAS_IOMEM && PERF_EVENTS help HiSilicon PCIe Tune and Trace device exists as a PCIe RCiEP