Message ID | 20240129-x1e80100-pci-v2-2-5751ab805483@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel+bounces-42934-ouuuleilei=gmail.com@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:7301:2087:b0:106:209c:c626 with SMTP id gs7csp612408dyb; Mon, 29 Jan 2024 06:47:30 -0800 (PST) X-Google-Smtp-Source: AGHT+IGAB0xxP6DE5xyIb9d/ElwwOTIy9vTnc1nB5ibUOiiK+DOyPHmm7RgC70r0fJEoJdv0Qo0k X-Received: by 2002:a05:6a20:9b:b0:19c:6fb0:2b02 with SMTP id 27-20020a056a20009b00b0019c6fb02b02mr2155121pzg.61.1706539650276; Mon, 29 Jan 2024 06:47:30 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706539650; cv=pass; d=google.com; s=arc-20160816; b=UMxROGItcT1Yl39QzYTkD/Hgn5oLEZuoxyX9J8a5FIGJisUuBWFKbU156WQ0JXCKPy QUpMx31oLtCm2FacXMZ6KOlfnB+WpKAKrPM7RNSekOuakpVl4zvDqFrPVrl63aI+4B4v y61l8Bsc3+X0ItaQFJanpdHW+sEXLot48Me8x7FduPk9HKuyC8I2K8ry/vBQisnPxo1h Qx6X7ppInEbQDV4L94oBT8vWiqepgXIwBxB+05h45g71b6LAaqFAjBh7iQxXQB/3CfaA llHl3aFyVz7z9fVVXSXbWg2pDjyG2T31Tz1QyOShGkQJ9TiWb1B2y815w201f5jJDRwo rw2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :subject:date:from:dkim-signature; bh=L2ZdJpKQBRnfaS4iSb7zJfUhDZu3ZFuYALkM/QlvKws=; fh=XTQdFbfLgG67qL9gLi4vxpDBL4E/eMBOK7gMeZOxD5I=; b=NOoRPtu1UdVF/D7QXQbF3azjqU6e+RJpPEDUheqqKhqfVhticrn0v9sPJVUZTG7gnY Jz8/A5Vhn4cA95nV9OQGsoqfm8F7n3rG4VYJBYZorfByJvl1iTQ7o2fI8jt8HxrscjiN uwfVGV7Trsk8diHXqrAf1wMVpLhsV2kmtk2oUybhOCuWy2rdo/qVo9e1Lhng5TZ2zzqa qohVAdfw6qHCPV8NWQZn9l8i79RqTlVPTvknd6+1jRZ+GZ7tWHpiyXAYFMA7xhA/7rkb f/P+UMqdEv14WrucAMP8xsNw65Rhpf2d46kxjt+R6/M5H/usmTDX01KopI9KwGA8hQzy jhDA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q2RoPQbx; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42934-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42934-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id b13-20020a170902b60d00b001d75eef04f4si5720902pls.104.2024.01.29.06.47.30 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 06:47:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-42934-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Q2RoPQbx; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-42934-ouuuleilei=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-42934-ouuuleilei=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 203AB284D9E for <ouuuleilei@gmail.com>; Mon, 29 Jan 2024 14:42:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 99CC215442B; Mon, 29 Jan 2024 14:41:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Q2RoPQbx" Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 117AE152DFA for <linux-kernel@vger.kernel.org>; Mon, 29 Jan 2024 14:41:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706539299; cv=none; b=mNmOkBoDMH7eza/3bWle8AmrvPkVGOTlHLbgl4TwThVBu3XdjCGFK2iZcvaN5A0KP2vkxbEXlEw87dE88aRQ5TCz9UpRN3GnxsTqEGD6fTPlEGdJ2U53zkxy052eGvZw31m3ULNjs0ZIj4/NabRmFeK92n6VP1TRNro5BBhq+W4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706539299; c=relaxed/simple; bh=8EuammNvz7q0zLsv/fNHGrCFJkNOTUOv7xYPFDSydtM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=n3q6G0GdssTDOdndd2WAziuIvCyNW4GdlPXjydIvj9KTlyz1WOIwEJsyf1FTsHmGK2nIbZK1p8TrIJjaU70FN1OsbxlJx2fy8J6KI1VANZaJOHd9leC8oATZ0YXmvulDea8CnaWShjVkM3O7j9A65Ydhlh4jJntGIIE3Pg/5BL0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Q2RoPQbx; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-55f279dca99so571947a12.3 for <linux-kernel@vger.kernel.org>; Mon, 29 Jan 2024 06:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706539296; x=1707144096; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=L2ZdJpKQBRnfaS4iSb7zJfUhDZu3ZFuYALkM/QlvKws=; b=Q2RoPQbxoit4G+yKmPpYg1oHKcjDC0L+owtUFho6Iz1lMRuJ8rkWQogIx6a2o/Z7mU NHYNyZRr1it7NvwQlxPc8G2qZohKRFQ11o9MBH5Hg/68y+ErzJANZmuhf3BzFgQRAjQq N9k6dMCGXznuTi/bD2fsuQvxp1ZTGI+cTt7ssPsNdKzjspHmYMUo+Bi6q1jDL3mkGEcn dxigM4A4v2CPFii+s0fCFxufVyVluknolOB0mCTRQDea5DRataaGuUoVKKAESHEMPsXa r93lBJ6lyr7ylbrazc/JvhZDqzZF/gbXJEp0mXg0Lf4DRUE+XCl8SV8bTIrwUPYklpA2 Of1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706539296; x=1707144096; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=L2ZdJpKQBRnfaS4iSb7zJfUhDZu3ZFuYALkM/QlvKws=; b=ipQGEz+9iaU01p9a8agHW7YzMu4/oVTM08VeyZvtEAruJySXFPJ4n+xNt7WAcFXOWF f2GYqf3DnppmAgLLUNn8/UGLcYzKklfLbJHb2Padn2GhdE6q3ycVBGsjLpAqTMot8HsM x6LHhaQ4iSICSXJDxO0qYnWLb8d/1xOEPDBKfKcBb1JSugXSJ9QqBAqJMZno9hPHHgSN KnGPo2iazOEmgX3lD8xORsGIb0zTgubaIynm5be5OUEmI1ob77EGmgL68h7/akUYL1BO +8tJ+x1x7uRoyGZjkMbho8vbrIYaPoDwULjHa+hlikCM+m0mLAx5+maHvnitkwhFSFDJ RFJg== X-Gm-Message-State: AOJu0YxpIWzn+iMdMSRAVKZnQuRMxPrRRra/iHZQdSJpr5+63VimCHAl 2QuiHzSBYSmD29EBGd7R5BoTw3abc8LbuQXcnFWcW+PTuxEz7TMRrvSi4elVk3M= X-Received: by 2002:a05:6402:3482:b0:55d:190:5a45 with SMTP id v2-20020a056402348200b0055d01905a45mr4809825edc.4.1706539296237; Mon, 29 Jan 2024 06:41:36 -0800 (PST) Received: from [127.0.1.1] ([79.115.23.25]) by smtp.gmail.com with ESMTPSA id em2-20020a056402364200b0055ec051ab49sm2548415edb.6.2024.01.29.06.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Jan 2024 06:41:35 -0800 (PST) From: Abel Vesa <abel.vesa@linaro.org> Date: Mon, 29 Jan 2024 16:41:20 +0200 Subject: [PATCH RESEND v2 2/2] PCI: qcom: Add X1E80100 PCIe support Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: <linux-kernel.vger.kernel.org> List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20240129-x1e80100-pci-v2-2-5751ab805483@linaro.org> References: <20240129-x1e80100-pci-v2-0-5751ab805483@linaro.org> In-Reply-To: <20240129-x1e80100-pci-v2-0-5751ab805483@linaro.org> To: Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, Lorenzo Pieralisi <lpieralisi@kernel.org>, =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= <kw@linux.com>, Rob Herring <robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Abel Vesa <abel.vesa@linaro.org> X-Mailer: b4 0.12.4 X-Developer-Signature: v=1; a=openpgp-sha256; l=785; i=abel.vesa@linaro.org; h=from:subject:message-id; bh=8EuammNvz7q0zLsv/fNHGrCFJkNOTUOv7xYPFDSydtM=; b=owEBbQKS/ZANAwAKARtfRMkAlRVWAcsmYgBlt7kbluuO7UPwf50lOLVC4XV28LzyrD4IabNlY iwFvTD2k9OJAjMEAAEKAB0WIQRO8+4RTnqPKsqn0bgbX0TJAJUVVgUCZbe5GwAKCRAbX0TJAJUV VqTZD/0Z04vfaJg0gch7xWARMZ5xT8UZyu84ReIKEIpAS9JM3sl8NeOdAW9bPH8cgNhJsYlmNOA XQi0OYZfMFfsIUR3HkSueuqdu784+I27kJQp6hJ8LqdcvhMpuw2nwAB3evbSmBWFxZ2UfkBVh4C icc0ibzcb/nk0urh3FH+SQx+r0RWBc/qNV7jtXdRJPdz0UFhFboSlH0nvIYT5foj+CqO0TelRJZ o0glORL2K2sREvvHyRAYOy0KjhnHk7CgW8EDRakzQy3aYSIUbIbdP/Gt9CzpTe1mr9J5CWD37Vb u1HRQQzeFnpjMUKYPShlTexaQDBiD+iNv2jPAW6ZfZ45KDMSzy8lAkOdedpebegSkRpslw7WMQ6 rs8epzOZRF5qtq4IG03XlACpf/3Hgyj01mTe9DnIXM4Ri+5oe4JzTpW7sS+QIC2X2M5AFVE47g7 oR2gvS79YbQe8M9P6b6DD3mPwjOWr3Udxzyw4Z4akJ84Doq2eGgym/iSk18sCtbUjwdZV66pBUQ 0CbX4g7lrenOiOeoYItxdX+69DLDm5QfZ2a+f/S/5gk3a+zxr++NUOG2TetnEnR5kcnw3w8lKyi +WCBFjGexpYNiZpZJ+669TLvFLtSxDhYLbLvZEzfELEVRpwyMfYL1KCZVMhYa2VzosP//7VStjT JntrtxwQmJ62nfA== X-Developer-Key: i=abel.vesa@linaro.org; a=openpgp; fpr=6AFF162D57F4223A8770EF5AF7BF214136F41FAE X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1789436520168390178 X-GMAIL-MSGID: 1789436520168390178 |
Series |
PCI: qcom: Add PCIe support for X1E80100
|
|
Commit Message
Abel Vesa
Jan. 29, 2024, 2:41 p.m. UTC
Add the compatible and the driver data for X1E80100.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
drivers/pci/controller/dwc/pcie-qcom.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote: > Add the compatible and the driver data for X1E80100. > If you happen to respin the series, please add info about the PCIe controller found on this SoC. Like IP version, Gen speed, max. link width etc... > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > --- > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > index 10f2d0bb86be..2a6000e457bc 100644 > --- a/drivers/pci/controller/dwc/pcie-qcom.c > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { > { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, > { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, > { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, > + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, > { } > }; > > > -- > 2.34.1 >
On Tue, Jan 30, 2024 at 12:25:06PM +0530, Manivannan Sadhasivam wrote: > On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote: > > Add the compatible and the driver data for X1E80100. > > If you happen to respin the series, please add info about the PCIe controller > found on this SoC. Like IP version, Gen speed, max. link width etc... FWIW, I always prefer actual speeds, e.g., "8 GT/s", instead of things like "Gen3", for the reason mentioned in the spec: Terms like "PCIe Gen3" are ambiguous and should be avoided. For example, "gen3" could mean (1) compliant with Base 3.0, (2) compliant with Base 3.1 (last revision of 3.x), (3) compliant with Base 3.0 and supporting 8.0 GT/s, (4) compliant with Base 3.0 or later and supporting 8.0 GT/s, .... Bjorn
On Tue, Jan 30, 2024 at 12:00:40PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 30, 2024 at 12:25:06PM +0530, Manivannan Sadhasivam wrote: > > On Mon, Jan 29, 2024 at 04:41:20PM +0200, Abel Vesa wrote: > > > Add the compatible and the driver data for X1E80100. > > > > If you happen to respin the series, please add info about the PCIe controller > > found on this SoC. Like IP version, Gen speed, max. link width etc... > > FWIW, I always prefer actual speeds, e.g., "8 GT/s", instead of things > like "Gen3", for the reason mentioned in the spec: > > Terms like "PCIe Gen3" are ambiguous and should be avoided. For > example, "gen3" could mean (1) compliant with Base 3.0, (2) > compliant with Base 3.1 (last revision of 3.x), (3) compliant with > Base 3.0 and supporting 8.0 GT/s, (4) compliant with Base 3.0 or > later and supporting 8.0 GT/s, .... > Makes sense. Will keep a note of it, thanks! - Mani
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c index 10f2d0bb86be..2a6000e457bc 100644 --- a/drivers/pci/controller/dwc/pcie-qcom.c +++ b/drivers/pci/controller/dwc/pcie-qcom.c @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, { } };