diff mbox series

dt-bindings: display: bridge: it6505: Add #sound-dai-cells

Message ID 20240126073511.2708574-1-wenst@chromium.org
State New
Headers
Series dt-bindings: display: bridge: it6505: Add #sound-dai-cells |

Commit Message

Chen-Yu Tsai Jan. 26, 2024, 7:35 a.m. UTC 
  The ITE IT6505 display bridge can take one I2S input and transmit it
over the DisplayPort link.

Add #sound-dai-cells (= 0) to the binding for it.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
The driver side changes [1] are still being worked on, but given the
hardware is very simple, it would be nice if we could land the binding
first and be able to introduct device trees that have this.

[1] https://lore.kernel.org/linux-arm-kernel/20230730180803.22570-4-jiaxin.yu@mediatek.com/

 .../devicetree/bindings/display/bridge/ite,it6505.yaml         | 3 +++
 1 file changed, 3 insertions(+)

Comments

Krzysztof Kozlowski Jan. 26, 2024, 10:17 a.m. UTC | #1 
On 26/01/2024 08:35, Chen-Yu Tsai wrote:
> The ITE IT6505 display bridge can take one I2S input and transmit it
> over the DisplayPort link.
> 
> Add #sound-dai-cells (= 0) to the binding for it.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> The driver side changes [1] are still being worked on, but given the
> hardware is very simple, it would be nice if we could land the binding
> first and be able to introduct device trees that have this.
> 
> [1] https://lore.kernel.org/linux-arm-kernel/20230730180803.22570-4-jiaxin.yu@mediatek.com/
> 
>  .../devicetree/bindings/display/bridge/ite,it6505.yaml         | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> index 348b02f26041..7ec4decc9c21 100644
> --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> @@ -52,6 +52,9 @@ properties:
>      maxItems: 1
>      description: extcon specifier for the Power Delivery
>  
> +  "#sound-dai-cells":
> +    const: 0

In such case you also want to $ref /schemas/sound/dai-common.yaml.

Best regards,
Krzysztof
Chen-Yu Tsai Jan. 29, 2024, 7:16 a.m. UTC | #2 
On Fri, Jan 26, 2024 at 6:17 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 26/01/2024 08:35, Chen-Yu Tsai wrote:
> > The ITE IT6505 display bridge can take one I2S input and transmit it
> > over the DisplayPort link.
> >
> > Add #sound-dai-cells (= 0) to the binding for it.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> > The driver side changes [1] are still being worked on, but given the
> > hardware is very simple, it would be nice if we could land the binding
> > first and be able to introduct device trees that have this.
> >
> > [1] https://lore.kernel.org/linux-arm-kernel/20230730180803.22570-4-jiaxin.yu@mediatek.com/
> >
> >  .../devicetree/bindings/display/bridge/ite,it6505.yaml         | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> > index 348b02f26041..7ec4decc9c21 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> > +++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
> > @@ -52,6 +52,9 @@ properties:
> >      maxItems: 1
> >      description: extcon specifier for the Power Delivery
> >
> > +  "#sound-dai-cells":
> > +    const: 0
>
> In such case you also want to $ref /schemas/sound/dai-common.yaml.

Ack. I assume this also means I should change "additionalProperties: false"
to "unevaluatedProperties: false" in this file.

ChenYu

> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
index 348b02f26041..7ec4decc9c21 100644
--- a/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/ite,it6505.yaml
@@ -52,6 +52,9 @@  properties:
     maxItems: 1
     description: extcon specifier for the Power Delivery
 
+  "#sound-dai-cells":
+    const: 0
+
   ports:
     $ref: /schemas/graph.yaml#/properties/ports